From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: Use idr_init_base(1) when using id==0 for invalid Date: Mon, 12 Feb 2018 19:14:20 +0200 Message-ID: <20180212171420.GT5453@intel.com> References: <20180212145533.30046-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180212145533.30046-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Christian Konig , dri-devel@lists.freedesktop.org, Dave Airlie List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBGZWIgMTIsIDIwMTggYXQgMDI6NTU6MzNQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFVzZSB0aGUgbmV3IGlkcl9pbml0X2Jhc2UoKSBmdW5jdGlvbiB0byBjcmVhdGUgYW4g SURSIHRoYXQga25vd3MgaWQ9PTAKPiBpcyBuZXZlciBhbGxvY2F0ZWQgYXMgaXQgbWFwcyB0byBh biBpbnZhbGlkIGlkZW50aWZpZXIuIEJ5IGtub3dpbmcgdGhhdAo+IGlkPT0wIGlzIGludmFsaWQs IHRoZSBJRFIgY2FuIHN0YXJ0IGZyb20gaWQ9MSBpbnN0ZWFkIGF2b2lkaW5nIHRoZSBpc3N1ZQo+ IG9mIGhhdmluZyB0byBzdGFydCBlYWNoIGxvb2t1cCBmcm9tIHRoZSB6ZXJvdGggbGVhZiBhcyBp ZD09MCBpcyBhbHdheXMKPiB1bnVzZWQgKGFuZCB0aHVzIHRoZSB0cmVlLW9mLWJpdG1hcHMgaW5k aWNhdGUgdGhhdCBpcyB0aGUgZmlyc3QKPiBhdmFpbGFibGUpLgo+IAo+IFJlZmVyZW5jZXM6IDZj ZTcxMWYyNzUwMCAoImlkcjogTWFrZSAxLWJhc2VkIElEUnMgbW9yZSBlZmZpY2llbnQiKQo+IFNp Z25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENj OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IENjOiBDaHJpc3RpYW4g S29uaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KPiBDYzogRGF2ZSBBaXJsaWUgPGFpcmxp ZWRAcmVkaGF0LmNvbT4KClllcCwgbG9va3MgbGlrZSBhbGwgb2YgdGhlc2UgcGFzcyBzdGFydD09 MSB0byBpZHJfYWxsb2MoKS4KUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+CgpMb29rcyBsaWtlIGF0IGxlYXN0IHRpbGVfaWRyIGFuZCBj cnRjX2lkciBjb3VsZCB1c2UgdGhpcyBhcyB3ZWxsLAphbHRob3VnaCBJIHN1cHBvc2UgdGhleSdy ZSBub3QgaGl0IG5lYXJseSBhcyBoYXJkIGFzIHRoZSBnZW0gc3R1ZmYuCkFsc28gc29tZW9uZSBz aG91bGQgcmVhbGx5IHMvY3J0Y19pZHIvb2JqX2lkX2lkci8gb3Igc29tZXRoaW5nCmFsb25nIHRo b3NlIGxpbmVzLgoKPiAtLS0KPiBOb3RlIHRoaXMgcmVxdWlyZXMgNC4xNi1yYzEuCj4gLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMgICAgIHwgNCArKy0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9kcm1fc3luY29iai5jIHwgMiArLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygr KSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9n ZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMKPiBpbmRleCAwMWY4ZDk0ODEyMTEuLjQ5 NzViYTlhN2JjOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbS5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2RybV9nZW0uYwo+IEBAIC05OCw3ICs5OCw3IEBAIGRybV9nZW1f aW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJc3RydWN0IGRybV92bWFfb2Zmc2V0X21h bmFnZXIgKnZtYV9vZmZzZXRfbWFuYWdlcjsKPiAgCj4gIAltdXRleF9pbml0KCZkZXYtPm9iamVj dF9uYW1lX2xvY2spOwo+IC0JaWRyX2luaXQoJmRldi0+b2JqZWN0X25hbWVfaWRyKTsKPiArCWlk cl9pbml0X2Jhc2UoJmRldi0+b2JqZWN0X25hbWVfaWRyLCAxKTsKPiAgCj4gIAl2bWFfb2Zmc2V0 X21hbmFnZXIgPSBremFsbG9jKHNpemVvZigqdm1hX29mZnNldF9tYW5hZ2VyKSwgR0ZQX0tFUk5F TCk7Cj4gIAlpZiAoIXZtYV9vZmZzZXRfbWFuYWdlcikgewo+IEBAIC03NzYsNyArNzc2LDcgQEAg ZHJtX2dlbV9vcGVuX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4g IHZvaWQKPiAgZHJtX2dlbV9vcGVuKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1f ZmlsZSAqZmlsZV9wcml2YXRlKQo+ICB7Cj4gLQlpZHJfaW5pdCgmZmlsZV9wcml2YXRlLT5vYmpl Y3RfaWRyKTsKPiArCWlkcl9pbml0X2Jhc2UoJmZpbGVfcHJpdmF0ZS0+b2JqZWN0X2lkciwgMSk7 Cj4gIAlzcGluX2xvY2tfaW5pdCgmZmlsZV9wcml2YXRlLT50YWJsZV9sb2NrKTsKPiAgfQo+ICAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9zeW5jb2JqLmMgYi9kcml2ZXJzL2dw dS9kcm0vZHJtX3N5bmNvYmouYwo+IGluZGV4IDBiN2IwZDFhZDJkNS4uZDRmNGNlNDg0NTI5IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fc3luY29iai5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2RybV9zeW5jb2JqLmMKPiBAQCAtNTQ2LDcgKzU0Niw3IEBAIHN0YXRpYyBpbnQg ZHJtX3N5bmNvYmpfZXhwb3J0X3N5bmNfZmlsZShzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdmF0 ZSwKPiAgdm9pZAo+ICBkcm1fc3luY29ial9vcGVuKHN0cnVjdCBkcm1fZmlsZSAqZmlsZV9wcml2 YXRlKQo+ICB7Cj4gLQlpZHJfaW5pdCgmZmlsZV9wcml2YXRlLT5zeW5jb2JqX2lkcik7Cj4gKwlp ZHJfaW5pdF9iYXNlKCZmaWxlX3ByaXZhdGUtPnN5bmNvYmpfaWRyLCAxKTsKPiAgCXNwaW5fbG9j a19pbml0KCZmaWxlX3ByaXZhdGUtPnN5bmNvYmpfdGFibGVfbG9jayk7Cj4gIH0KPiAgCj4gLS0g Cj4gMi4xNi4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK