From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2] RFC drm/i915: Only acquire vblank-irq when waiting for vblank evade Date: Tue, 13 Feb 2018 15:01:23 +0200 Message-ID: <20180213130123.GB5453@intel.com> References: <20180212213727.549-1-chris@chris-wilson.co.uk> <20180212222111.6780-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF56389FC9 for ; Tue, 13 Feb 2018 13:01:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180212222111.6780-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBGZWIgMTIsIDIwMTggYXQgMTA6MjE6MTFQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t Pgo+IENjOiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwu Y29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyB8IDY1ICsr KysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDM4 IGluc2VydGlvbnMoKyksIDI3IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3Nwcml0ZS5jCj4gaW5kZXggZTA5OGU0YjJjODVjLi5hZDcwN2M5N2E5ZDkgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IEBAIC03NCw2ICs3NCwxNCBAQCBpbnQgaW50ZWxf dXNlY3NfdG9fc2NhbmxpbmVzKGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICphZGp1c3Rl ZF9tb2RlLAo+ICAjZGVmaW5lIFZCTEFOS19FVkFTSU9OX1RJTUVfVVMgMTAwCj4gICNlbmRpZgo+ ICAKPiArc3RhdGljIGlubGluZSBib29sIHNjYW5saW5lX2luX3ZibGFuayhzdHJ1Y3QgaW50ZWxf Y3J0YyAqY3J0YywKPiArCQkJCSAgICAgIGludCBtaW4sIGludCBtYXgsCj4gKwkJCQkgICAgICBp bnQgKnNjYW5saW5lKQoKVGhlIGZ1bmN0aW9uIG5hbWUgaXMgd3JvbmcuIE5vdCBzdXJlIHdoYXQg dG8gY2FsbCBpdCByZWFsbHkuCnNjYW5saW5lX29rKCksIG9yIHJldmVyc2UgdGhlIGNvbmRpdGlv biBhbmQgY2FsbCBpdApzY2FubGluZV9iYWQoKSBvciBzY2FubGluZV9pbl9kYW5nZXJfem9uZSgp IChjdWUgS2VubnkgTG9nZ2lucyk/Cgo+ICt7Cj4gKwkqc2NhbmxpbmUgPSBpbnRlbF9nZXRfY3J0 Y19zY2FubGluZShjcnRjKTsKPiArCXJldHVybiAqc2NhbmxpbmUgPCBtaW4gfHwgKnNjYW5saW5l ID4gbWF4Owo+ICt9Cj4gKwo+ICAvKioKPiAgICogaW50ZWxfcGlwZV91cGRhdGVfc3RhcnQoKSAt IHN0YXJ0IHVwZGF0ZSBvZiBhIHNldCBvZiBkaXNwbGF5IHJlZ2lzdGVycwo+ICAgKiBAbmV3X2Ny dGNfc3RhdGU6IHRoZSBuZXcgY3J0YyBzdGF0ZQo+IEBAIC05MSwxMiArOTksOSBAQCB2b2lkIGlu dGVsX3BpcGVfdXBkYXRlX3N0YXJ0KGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdf Y3J0Y19zdGF0ZSkKPiAgCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0gdG9faW50ZWxfY3J0Yyhu ZXdfY3J0Y19zdGF0ZS0+YmFzZS5jcnRjKTsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiA9IHRvX2k5MTUoY3J0Yy0+YmFzZS5kZXYpOwo+ICAJY29uc3Qgc3RydWN0IGRybV9k aXNwbGF5X21vZGUgKmFkanVzdGVkX21vZGUgPSAmbmV3X2NydGNfc3RhdGUtPmJhc2UuYWRqdXN0 ZWRfbW9kZTsKPiAtCWxvbmcgdGltZW91dCA9IG1zZWNzX3RvX2ppZmZpZXNfdGltZW91dCgxKTsK PiAgCWludCBzY2FubGluZSwgbWluLCBtYXgsIHZibGFua19zdGFydDsKPiAtCXdhaXRfcXVldWVf aGVhZF90ICp3cSA9IGRybV9jcnRjX3ZibGFua193YWl0cXVldWUoJmNydGMtPmJhc2UpOwo+ICAJ Ym9vbCBuZWVkX3Zsdl9kc2lfd2EgPSAoSVNfVkFMTEVZVklFVyhkZXZfcHJpdikgfHwgSVNfQ0hF UlJZVklFVyhkZXZfcHJpdikpICYmCj4gIAkJaW50ZWxfY3J0Y19oYXNfdHlwZShuZXdfY3J0Y19z dGF0ZSwgSU5URUxfT1VUUFVUX0RTSSk7Cj4gLQlERUZJTkVfV0FJVCh3YWl0KTsKPiAgCj4gIAl2 Ymxhbmtfc3RhcnQgPSBhZGp1c3RlZF9tb2RlLT5jcnRjX3ZibGFua19zdGFydDsKPiAgCWlmIChh ZGp1c3RlZF9tb2RlLT5mbGFncyAmIERSTV9NT0RFX0ZMQUdfSU5URVJMQUNFKQo+IEBAIC0xMTIs NDEgKzExNyw0NiBAQCB2b2lkIGludGVsX3BpcGVfdXBkYXRlX3N0YXJ0KGNvbnN0IHN0cnVjdCBp bnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZSkKPiAgCWlmIChtaW4gPD0gMCB8fCBtYXgg PD0gMCkKPiAgCQlyZXR1cm47Cj4gIAo+IC0JaWYgKFdBUk5fT04oZHJtX2NydGNfdmJsYW5rX2dl dCgmY3J0Yy0+YmFzZSkpKQo+IC0JCXJldHVybjsKPiAtCj4gIAljcnRjLT5kZWJ1Zy5taW5fdmJs ID0gbWluOwo+ICAJY3J0Yy0+ZGVidWcubWF4X3ZibCA9IG1heDsKPiAgCXRyYWNlX2k5MTVfcGlw ZV91cGRhdGVfc3RhcnQoY3J0Yyk7Cj4gIAo+IC0JZm9yICg7Oykgewo+IC0JCS8qCj4gLQkJICog cHJlcGFyZV90b193YWl0KCkgaGFzIGEgbWVtb3J5IGJhcnJpZXIsIHdoaWNoIGd1YXJhbnRlZXMK PiAtCQkgKiBvdGhlciBDUFVzIGNhbiBzZWUgdGhlIHRhc2sgc3RhdGUgdXBkYXRlIGJ5IHRoZSB0 aW1lIHdlCj4gLQkJICogcmVhZCB0aGUgc2NhbmxpbmUuCj4gLQkJICovCj4gLQkJcHJlcGFyZV90 b193YWl0KHdxLCAmd2FpdCwgVEFTS19VTklOVEVSUlVQVElCTEUpOwo+ICsJaWYgKCFzY2FubGlu ZV9pbl92YmxhbmsoY3J0YywgbWluLCBtYXgsICZzY2FubGluZSkpIHsKCidnb3RvIHNraXBfZXZh ZGUnIHRvIGF2b2lkIG1lc3Npbmcgd2l0aCB0aGUgbG9vcCBpbmRlbnRhdGlvbj8KCj4gKwkJd2Fp dF9xdWV1ZV9oZWFkX3QgKndxID0gZHJtX2NydGNfdmJsYW5rX3dhaXRxdWV1ZSgmY3J0Yy0+YmFz ZSk7Cj4gKwkJbG9uZyB0aW1lb3V0ID0gbXNlY3NfdG9famlmZmllc190aW1lb3V0KDEpOwo+ICsJ CURFRklORV9XQUlUKHdhaXQpOwo+ICAKPiAtCQlzY2FubGluZSA9IGludGVsX2dldF9jcnRjX3Nj YW5saW5lKGNydGMpOwo+IC0JCWlmIChzY2FubGluZSA8IG1pbiB8fCBzY2FubGluZSA+IG1heCkK PiAtCQkJYnJlYWs7Cj4gKwkJaWYgKFdBUk5fT04oZHJtX2NydGNfdmJsYW5rX2dldCgmY3J0Yy0+ YmFzZSkpKQo+ICsJCQlnb3RvIHNraXBfZXZhZGU7Cj4gIAo+IC0JCWlmICh0aW1lb3V0IDw9IDAp IHsKPiAtCQkJRFJNX0VSUk9SKCJQb3RlbnRpYWwgYXRvbWljIHVwZGF0ZSBmYWlsdXJlIG9uIHBp cGUgJWNcbiIsCj4gLQkJCQkgIHBpcGVfbmFtZShjcnRjLT5waXBlKSk7Cj4gLQkJCWJyZWFrOwo+ IC0JCX0KPiArCQlmb3IgKDs7KSB7Cj4gKwkJCS8qCj4gKwkJCSAqIHByZXBhcmVfdG9fd2FpdCgp IGhhcyBhIG1lbW9yeSBiYXJyaWVyLCB3aGljaAo+ICsJCQkgKiBndWFyYW50ZWVzIG90aGVyIENQ VXMgY2FuIHNlZSB0aGUgdGFzayBzdGF0ZSB1cGRhdGUKPiArCQkJICogYnkgdGhlIHRpbWUgd2Ug cmVhZCB0aGUgc2NhbmxpbmUuCj4gKwkJCSAqLwo+ICsJCQlwcmVwYXJlX3RvX3dhaXQod3EsICZ3 YWl0LCBUQVNLX1VOSU5URVJSVVBUSUJMRSk7Cj4gIAo+IC0JCWxvY2FsX2lycV9lbmFibGUoKTsK PiArCQkJaWYgKHNjYW5saW5lX2luX3ZibGFuayhjcnRjLCBtaW4sIG1heCwgJnNjYW5saW5lKSkK PiArCQkJCWJyZWFrOwo+ICAKPiAtCQl0aW1lb3V0ID0gc2NoZWR1bGVfdGltZW91dCh0aW1lb3V0 KTsKPiArCQkJaWYgKHRpbWVvdXQgPD0gMCkgewo+ICsJCQkJRFJNX0VSUk9SKCJQb3RlbnRpYWwg YXRvbWljIHVwZGF0ZSBmYWlsdXJlIG9uIHBpcGUgJWNcbiIsCj4gKwkJCQkJICBwaXBlX25hbWUo Y3J0Yy0+cGlwZSkpOwo+ICsJCQkJYnJlYWs7Cj4gKwkJCX0KPiAgCj4gLQkJbG9jYWxfaXJxX2Rp c2FibGUoKTsKPiAtCX0KPiArCQkJbG9jYWxfaXJxX2VuYWJsZSgpOwo+ICAKPiAtCWZpbmlzaF93 YWl0KHdxLCAmd2FpdCk7Cj4gKwkJCXRpbWVvdXQgPSBzY2hlZHVsZV90aW1lb3V0KHRpbWVvdXQp Owo+ICAKPiAtCWRybV9jcnRjX3ZibGFua19wdXQoJmNydGMtPmJhc2UpOwo+ICsJCQlsb2NhbF9p cnFfZGlzYWJsZSgpOwo+ICsJCX0KPiArCj4gKwkJZmluaXNoX3dhaXQod3EsICZ3YWl0KTsKPiAr Cj4gKwkJZHJtX2NydGNfdmJsYW5rX3B1dCgmY3J0Yy0+YmFzZSk7Cj4gKwl9Cj4gIAo+ICAJLyoK PiAgCSAqIE9uIFZMVi9DSFYgRFNJIHRoZSBzY2FubGluZSBjb3VudGVyIHdvdWxkIGFwcGVhciB0 bwo+IEBAIC0xNjYsNiArMTc2LDcgQEAgdm9pZCBpbnRlbF9waXBlX3VwZGF0ZV9zdGFydChjb25z dCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3X2NydGNfc3RhdGUpCj4gIAl3aGlsZSAobmVl ZF92bHZfZHNpX3dhICYmIHNjYW5saW5lID09IHZibGFua19zdGFydCkKPiAgCQlzY2FubGluZSA9 IGludGVsX2dldF9jcnRjX3NjYW5saW5lKGNydGMpOwoKSSB0aGluayB3ZSdsbCBuZWVkIHRvIGRv IHRoZSBkc2kgdy9hIHJlZ2FyZGxlc3MsIHNvIHRoZSBsYWJlbCBzaG91bGQgYmUKYmVmb3JlIGl0 LgoKPiAgCj4gK3NraXBfZXZhZGU6Cj4gIAljcnRjLT5kZWJ1Zy5zY2FubGluZV9zdGFydCA9IHNj YW5saW5lOwo+ICAJY3J0Yy0+ZGVidWcuc3RhcnRfdmJsX3RpbWUgPSBrdGltZV9nZXQoKTsKPiAg CWNydGMtPmRlYnVnLnN0YXJ0X3ZibF9jb3VudCA9IGludGVsX2NydGNfZ2V0X3ZibGFua19jb3Vu dGVyKGNydGMpOwo+IC0tIAo+IDIuMTYuMQoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==