public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm: Add COLOR_ENCODING and COLOR_RANGE plane properties
Date: Wed, 14 Feb 2018 20:53:52 -0000	[thread overview]
Message-ID: <20180214205352.21135.54366@emeril.freedesktop.org> (raw)
In-Reply-To: <20180214192327.3250-1-ville.syrjala@linux.intel.com>

== Series Details ==

Series: drm: Add COLOR_ENCODING and COLOR_RANGE plane properties
URL   : https://patchwork.freedesktop.org/series/38286/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
fe775e9df8ef drm: Add optional COLOR_ENCODING and COLOR_RANGE properties to drm_plane
-:67: WARNING: please, no space before tabs
#67: FILE: drivers/gpu/drm/drm_color_mgmt.c:96:
+ * ^IOptional plane enum property to support different non RGB$

-:68: WARNING: please, no space before tabs
#68: FILE: drivers/gpu/drm/drm_color_mgmt.c:97:
+ * ^Icolor encodings. The driver can provide a subset of standard$

-:69: WARNING: please, no space before tabs
#69: FILE: drivers/gpu/drm/drm_color_mgmt.c:98:
+ * ^Ienum values supported by the DRM plane.$

-:72: WARNING: please, no space before tabs
#72: FILE: drivers/gpu/drm/drm_color_mgmt.c:101:
+ * ^IOptional plane enum property to support different non RGB$

-:73: WARNING: please, no space before tabs
#73: FILE: drivers/gpu/drm/drm_color_mgmt.c:102:
+ * ^Icolor parameter ranges. The driver can provide a subset of$

-:74: WARNING: please, no space before tabs
#74: FILE: drivers/gpu/drm/drm_color_mgmt.c:103:
+ * ^Istandard enum values supported by the DRM plane.$

total: 0 errors, 6 warnings, 0 checks, 175 lines checked
970627907fcd drm: Add BT.2020 constant luminance enum value for the COLOR_ENCODING property
-:34: WARNING: line over 80 characters
#34: FILE: drivers/gpu/drm/drm_color_mgmt.c:360:
+	[DRM_COLOR_YCBCR_BT2020_CONST] = "ITU-R BT.2020 YCbCr constant luminance",

total: 0 errors, 1 warnings, 0 checks, 16 lines checked
d286b7a4cbb9 drm/atomic: Include color encoding/range in plane state dump
c9445dd9d6eb drm/i915: Correctly handle limited range YCbCr data on VLV/CHV
-:81: WARNING: line over 80 characters
#81: FILE: drivers/gpu/drm/i915/i915_reg.h:6345:
+#define SPCLRC0(pipe, plane_id)		_MMIO_VLV_SPR((pipe), (plane_id), _SPACLRC0, _SPBCLRC0)

-:82: WARNING: line over 80 characters
#82: FILE: drivers/gpu/drm/i915/i915_reg.h:6346:
+#define SPCLRC1(pipe, plane_id)		_MMIO_VLV_SPR((pipe), (plane_id), _SPACLRC1, _SPBCLRC1)

-:142: WARNING: line over 80 characters
#142: FILE: drivers/gpu/drm/i915/intel_sprite.c:380:
+	I915_WRITE_FW(SPCSCYGICLAMP(plane_id), SPCSC_IMAX(1023) | SPCSC_IMIN(0));

-:143: WARNING: line over 80 characters
#143: FILE: drivers/gpu/drm/i915/intel_sprite.c:381:
+	I915_WRITE_FW(SPCSCCBICLAMP(plane_id), SPCSC_IMAX(512) | SPCSC_IMIN(-512));

-:144: WARNING: line over 80 characters
#144: FILE: drivers/gpu/drm/i915/intel_sprite.c:382:
+	I915_WRITE_FW(SPCSCCRICLAMP(plane_id), SPCSC_IMAX(512) | SPCSC_IMIN(-512));

total: 0 errors, 5 warnings, 0 checks, 143 lines checked
956e75f5dfb0 drm/i915: Fix plane YCbCr->RGB conversion for GLK
-:36: CHECK: Prefer using the BIT macro
#36: FILE: drivers/gpu/drm/i915/i915_reg.h:6467:
+#define   PLANE_COLOR_CSC_MODE_YUV601_TO_RGB709		(1 << 17)

total: 0 errors, 0 warnings, 1 checks, 74 lines checked
19bc29ea8f95 drm/i915: Add support for the YCbCr COLOR_ENCODING property
-:42: CHECK: spaces preferred around that '<<' (ctx:VxV)
#42: FILE: drivers/gpu/drm/i915/i915_reg.h:6143:
+#define   DVS_YUV_FORMAT_BT709	(1<<18)
                               	  ^

-:42: CHECK: Prefer using the BIT macro
#42: FILE: drivers/gpu/drm/i915/i915_reg.h:6143:
+#define   DVS_YUV_FORMAT_BT709	(1<<18)

-:51: CHECK: spaces preferred around that '<<' (ctx:VxV)
#51: FILE: drivers/gpu/drm/i915/i915_reg.h:6214:
+#define   SPRITE_YUV_TO_RGB_CSC_FORMAT_BT709	(1<<18) /* 0 is BT601 */
                                             	  ^

-:51: CHECK: Prefer using the BIT macro
#51: FILE: drivers/gpu/drm/i915/i915_reg.h:6214:
+#define   SPRITE_YUV_TO_RGB_CSC_FORMAT_BT709	(1<<18) /* 0 is BT601 */

-:59: CHECK: spaces preferred around that '<<' (ctx:VxV)
#59: FILE: drivers/gpu/drm/i915/i915_reg.h:6290:
+#define   SP_YUV_FORMAT_BT709		(1<<18)
                              		  ^

-:59: CHECK: Prefer using the BIT macro
#59: FILE: drivers/gpu/drm/i915/i915_reg.h:6290:
+#define   SP_YUV_FORMAT_BT709		(1<<18)

-:67: CHECK: Prefer using the BIT macro
#67: FILE: drivers/gpu/drm/i915/i915_reg.h:6415:
+#define   PLANE_CTL_YUV_TO_RGB_CSC_FORMAT_BT709	(1 << 18)

-:93: WARNING: line over 80 characters
#93: FILE: drivers/gpu/drm/i915/intel_display.c:3581:
+			plane_color_ctl |= PLANE_COLOR_CSC_MODE_YUV709_TO_RGB709;

-:95: WARNING: line over 80 characters
#95: FILE: drivers/gpu/drm/i915/intel_display.c:3583:
+			plane_color_ctl |= PLANE_COLOR_CSC_MODE_YUV601_TO_RGB709;

-:108: WARNING: line over 80 characters
#108: FILE: drivers/gpu/drm/i915/intel_display.c:13328:
+						  BIT(DRM_COLOR_YCBCR_LIMITED_RANGE),

-:110: WARNING: line over 80 characters
#110: FILE: drivers/gpu/drm/i915/intel_display.c:13330:
+						  DRM_COLOR_YCBCR_LIMITED_RANGE);

total: 0 errors, 4 warnings, 7 checks, 166 lines checked
e2c49a51ad72 drm/i915: Change the COLOR_ENCODING prop default value to BT.709
b9af44b33bda drm/i915: Add support for the YCbCr COLOR_RANGE property
-:39: CHECK: spaces preferred around that '<<' (ctx:VxV)
#39: FILE: drivers/gpu/drm/i915/i915_reg.h:6135:
+#define   DVS_YUV_RANGE_CORRECTION_DISABLE	(1<<27)
                                           	  ^

-:39: CHECK: Prefer using the BIT macro
#39: FILE: drivers/gpu/drm/i915/i915_reg.h:6135:
+#define   DVS_YUV_RANGE_CORRECTION_DISABLE	(1<<27)

-:47: CHECK: spaces preferred around that '<<' (ctx:VxV)
#47: FILE: drivers/gpu/drm/i915/i915_reg.h:6204:
+#define   SPRITE_YUV_RANGE_CORRECTION_DISABLE	(1<<28)
                                              	  ^

-:47: CHECK: Prefer using the BIT macro
#47: FILE: drivers/gpu/drm/i915/i915_reg.h:6204:
+#define   SPRITE_YUV_RANGE_CORRECTION_DISABLE	(1<<28)

-:55: CHECK: Prefer using the BIT macro
#55: FILE: drivers/gpu/drm/i915/i915_reg.h:6396:
+#define   PLANE_CTL_YUV_RANGE_CORRECTION_DISABLE	(1 << 28)

-:63: CHECK: Prefer using the BIT macro
#63: FILE: drivers/gpu/drm/i915/i915_reg.h:6471:
+#define   PLANE_COLOR_YUV_RANGE_CORRECTION_DISABLE	(1 << 28)

-:87: WARNING: line over 80 characters
#87: FILE: drivers/gpu/drm/i915/intel_display.c:3589:
+			plane_color_ctl |= PLANE_COLOR_YUV_RANGE_CORRECTION_DISABLE;

-:96: WARNING: line over 80 characters
#96: FILE: drivers/gpu/drm/i915/intel_display.c:13334:
+						  BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) |

-:97: WARNING: line over 80 characters
#97: FILE: drivers/gpu/drm/i915/intel_display.c:13335:
+						  BIT(DRM_COLOR_YCBCR_FULL_RANGE),

total: 0 errors, 3 warnings, 6 checks, 91 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-02-14 20:53 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14 19:23 [PATCH 0/8] drm: Add COLOR_ENCODING and COLOR_RANGE plane properties Ville Syrjala
2018-02-14 19:23 ` [PATCH 1/8] drm: Add optional COLOR_ENCODING and COLOR_RANGE properties to drm_plane Ville Syrjala
2018-02-19 15:04   ` Daniel Vetter
2018-02-19 20:19     ` Ville Syrjälä
2018-02-19 20:38       ` Jyri Sarha
2018-02-19 22:38         ` Daniel Vetter
2018-02-19 20:28   ` [PATCH v2 " Ville Syrjala
2018-02-20 11:24     ` Daniel Vetter
2018-11-30 13:08     ` [v2, " Christoph Manszewski
2018-11-30 13:25       ` Ville Syrjälä
2018-11-30 14:20         ` Andrzej Hajda
2018-11-30 14:29           ` Ville Syrjälä
2018-11-30 14:48             ` Hans Verkuil
2018-11-30 15:16               ` Ville Syrjälä
2018-11-30 15:34                 ` Hans Verkuil
2018-11-30 16:22                   ` Brian Starkey
2018-12-03 11:23               ` Andrzej Hajda
2018-12-03 11:52                 ` Hans Verkuil
2018-12-03 12:51                   ` Andrzej Hajda
2018-11-30 14:40           ` Hans Verkuil
2018-02-14 19:23 ` [PATCH 2/8] drm: Add BT.2020 constant luminance enum value for the COLOR_ENCODING property Ville Syrjala
2018-03-02 12:40   ` Ville Syrjälä
2018-02-14 19:23 ` [PATCH 3/8] drm/atomic: Include color encoding/range in plane state dump Ville Syrjala
2018-02-19 15:08   ` Daniel Vetter
2018-02-19 20:28   ` [PATCH v2 " Ville Syrjala
2018-02-20 11:25     ` Daniel Vetter
2018-02-20 15:57     ` Harry Wentland
2018-02-14 19:23 ` [PATCH 4/8] drm/i915: Correctly handle limited range YCbCr data on VLV/CHV Ville Syrjala
2018-02-14 19:23 ` [PATCH 5/8] drm/i915: Fix plane YCbCr->RGB conversion for GLK Ville Syrjala
2018-02-28 20:43   ` Imre Deak
2018-02-14 19:23 ` [PATCH 6/8] drm/i915: Add support for the YCbCr COLOR_ENCODING property Ville Syrjala
2018-02-14 19:23 ` [PATCH 7/8] drm/i915: Change the COLOR_ENCODING prop default value to BT.709 Ville Syrjala
2018-02-14 19:23 ` [PATCH 8/8] drm/i915: Add support for the YCbCr COLOR_RANGE property Ville Syrjala
2018-02-14 20:53 ` Patchwork [this message]
2018-02-14 20:56 ` ✗ Fi.CI.SPARSE: warning for drm: Add COLOR_ENCODING and COLOR_RANGE plane properties Patchwork
2018-02-14 21:09 ` ✓ Fi.CI.BAT: success " Patchwork
2018-02-15  5:34 ` ✓ Fi.CI.IGT: " Patchwork
2018-02-19 15:00 ` [PATCH 0/8] " Daniel Vetter
2018-02-19 15:09 ` Daniel Vetter
2018-02-19 15:52   ` Ville Syrjälä
2018-02-19 20:41 ` ✗ Fi.CI.CHECKPATCH: warning for drm: Add COLOR_ENCODING and COLOR_RANGE plane properties (rev3) Patchwork
2018-02-19 20:43 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-02-19 20:59 ` ✓ Fi.CI.BAT: success " Patchwork
2018-02-20  0:20 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-02-20 11:26 ` [PATCH 0/8] drm: Add COLOR_ENCODING and COLOR_RANGE plane properties Daniel Vetter
2018-02-20 13:42   ` Ville Syrjälä
2018-03-02 13:06 ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180214205352.21135.54366@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox