From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 06/10] drm/tegra: Handle 64-bit return from drm_crtc_vblank_count() Date: Thu, 15 Feb 2018 13:17:01 +0100 Message-ID: <20180215121701.GA29499@ulmo> References: <20180203051302.9974-1-dhinakaran.pandiyan@intel.com> <20180203051302.9974-6-dhinakaran.pandiyan@intel.com> <1517969059.11349.39.camel@dk-H97M-D3H> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1833800521==" Return-path: In-Reply-To: <1517969059.11349.39.camel@dk-H97M-D3H> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Pandiyan, Dhinakaran" Cc: "intel-gfx@lists.freedesktop.org" , "treding@nvidia.com" , "dri-devel@lists.freedesktop.org" , "Vivi, Rodrigo" List-Id: intel-gfx@lists.freedesktop.org --===============1833800521== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ew6BAiZeqk4r7MaW" Content-Disposition: inline --ew6BAiZeqk4r7MaW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 07, 2018 at 01:41:18AM +0000, Pandiyan, Dhinakaran wrote: > On Fri, 2018-02-02 at 21:12 -0800, Dhinakaran Pandiyan wrote: > > 570e86963a51 ("drm: Widen vblank count to 64-bits [v3]") changed the > > return type for drm_crtc_vblank_count() to u64. This could cause > > potential problems if the return value is used in arithmetic operations > > with a 32-bit reference HW vblank count. Explicitly typecasting this > > down to u32 either fixes a potential problem or serves to add clarity in > > case the implicit typecasting was already correct. > >=20 > > Cc: Keith Packard > > Cc: Thierry Reding >=20 >=20 > Thierry,=20 >=20 > Can I get an Ack on this please?=20 Acked-by: Thierry Reding --ew6BAiZeqk4r7MaW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlqFejgACgkQ3SOs138+ s6E3Ww//VpZmdV83jAEpuENCKKA7W2WyOUZ8vhAcEMqkV7r+6ySmTX2kKp3a3ORf RdVaZ/Lrcb4fOV2Yvy+4ZIsQ4Yb07V8JYt08H5AOJHeTPws5raaKuuDAXHikmAjq 3s55h7uYqWvihtexlrBE1LwNxrFSiajl5tbvVGXASvO5KLgZPu8XHgEdC0Je6uNv tSmnKHh7QjDEhUBcVTQKQ5y4PGNESwNv1XvVSgDob4+ogJX4UGFueafiHB7z2u86 B3DLDbgPREQURuedJoz2y4LAS9wV6daRky4j3GUxypCGNgDl7AR3OmuoLDFz0vW3 AAshelnO/pKaJo0MOcQa2005Y4tYLWegQqEGypfKfKwBivj8bzkGPaPkU35EEmCH jNs4U8+sqOBzpSP3ua5Oawkd6a0I0oCy393FZ/RHeHX0vzO6B7rSPDxMTpIcSdqk b4nC8OEbC0Wepy4QAgBugGaCLXIHRQLh6sNT+qeSLs+QbCNjir8FI/aUgTuJCCLL YidvzqK5U9W4PgHK+p3WrlzbjilHerBLrOGzzTOKprtu2R3JvWZXF1KlhVG5xo4F 0gY3UyESm98dBj2rEujhaASxKUC6cgViEaSf/BFKwqnx3eLk1sDy9p/ByGUoCzKe SH8UwRZFuUjZ22XqUajYyVSZNZoxwqNAiatgN2TrsQTNG81f1zo= =59WQ -----END PGP SIGNATURE----- --ew6BAiZeqk4r7MaW-- --===============1833800521== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============1833800521==--