From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/i915: Track GT interrupt handling using the master iir Date: Thu, 15 Feb 2018 20:35:22 +0200 Message-ID: <20180215183522.GT5453@intel.com> References: <20180215073713.26985-1-chris@chris-wilson.co.uk> <87zi4ath1e.fsf@gaia.fi.intel.com> <151871040461.11261.1982076111992938940@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id DB3F86E0F1 for ; Thu, 15 Feb 2018 18:35:26 +0000 (UTC) Content-Disposition: inline In-Reply-To: <151871040461.11261.1982076111992938940@mail.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBGZWIgMTUsIDIwMTggYXQgMDQ6MDA6MDRQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgTWlrYSBLdW9wcGFsYSAoMjAxOC0wMi0xNSAxNToyMTozMykKPiA+IENo cmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPiB3cml0ZXM6Cj4gPiAKPiA+ID4g S2VlcCB0aGUgbWFzdGVyIGlpciBhbmQgdXNlIGl0IHRvIHJlZHVjZSB0aGUgbnVtYmVyIG9mIHJl YWRzIGFuZCB3cml0ZXMKPiA+ID4gdG8gdGhlIEdUIGlpciBhcnJheSwgaS5lLiBvbmx5IHRoZSBi aXRzIG1hcmtlZCBhcyBzZXQgYnkgdGhlIG1hc3RlciBpaXIKPiA+ID4gYXJlIHZhbGlkIGluc2lk ZSBHVCBpaXIgYXJyYXkgYW5kIHdpbGwgYmUgaGFuZGxlZCBkdXJpbmcgdGhlIGludGVycnVwdC4K PiA+ID4KPiA+ID4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxz b24uY28udWs+Cj4gPiA+IENjOiBWaWxsZSBTeXJqYWxhIDx2aWxsZS5zeXJqYWxhQGxpbnV4Lmlu dGVsLmNvbT4KPiA+ID4gQ2M6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50 ZWwuY29tPgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMg fCA1MSArKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLQo+ID4gPiAgMSBm aWxlIGNoYW5nZWQsIDMxIGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQo+ID4gPgo+ID4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiA+ID4gaW5kZXggYjg4NmJkNDU5YWNjLi5iN2IzNzdi YTdiNmUgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMK PiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ID4gPiBAQCAtMTQx Niw2ICsxNDE2LDE0IEBAIGdlbjhfY3NfaXJxX2hhbmRsZXIoc3RydWN0IGludGVsX2VuZ2luZV9j cyAqZW5naW5lLCB1MzIgaWlyLCBpbnQgdGVzdF9zaGlmdCkKPiA+ID4gIHN0YXRpYyB2b2lkIGdl bjhfZ3RfaXJxX2FjayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiA+ICAg ICAgICAgICAgICAgICAgICAgICAgICAgdTMyIG1hc3Rlcl9jdGwsIHUzMiBndF9paXJbNF0pCj4g PiA+ICB7Cj4gPiA+ICsjZGVmaW5lIEdFTjhfR1RfSVJRUyAoR0VOOF9HVF9SQ1NfSVJRIHwgXAo+ ID4gPiArICAgICAgICAgICAgICAgICAgIEdFTjhfR1RfQkNTX0lSUSB8IFwKPiA+ID4gKyAgICAg ICAgICAgICAgICAgICBHRU44X0dUX1ZDUzFfSVJRIHwgXAo+ID4gPiArICAgICAgICAgICAgICAg ICAgIEdFTjhfR1RfVkNTMl9JUlEgfCBcCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgR0VOOF9H VF9WRUNTX0lSUSB8IFwKPiA+ID4gKyAgICAgICAgICAgICAgICAgICBHRU44X0dUX1BNX0lSUSB8 IFwKPiA+ID4gKyAgICAgICAgICAgICAgICAgICBHRU44X0dUX0dVQ19JUlEpCj4gPiA+ICsKPiA+ ID4gICAgICAgaWYgKG1hc3Rlcl9jdGwgJiAoR0VOOF9HVF9SQ1NfSVJRIHwgR0VOOF9HVF9CQ1Nf SVJRKSkgewo+ID4gPiAgICAgICAgICAgICAgIGd0X2lpclswXSA9IEk5MTVfUkVBRF9GVyhHRU44 X0dUX0lJUigwKSk7Cj4gPiA+ICAgICAgICAgICAgICAgaWYgKGd0X2lpclswXSkKPiA+ID4gQEAg LTE0NDYsMzEgKzE0NTQsMzQgQEAgc3RhdGljIHZvaWQgZ2VuOF9ndF9pcnFfYWNrKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ID4gIH0KPiA+ID4gIAo+ID4gPiAgc3RhdGlj IHZvaWQgZ2VuOF9ndF9pcnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYsCj4gPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIHUzMiBndF9paXJbNF0pCj4g PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHUzMiBtYXN0ZXJfY3RsLCB1MzIgZ3Rf aWlyWzRdKQo+ID4gPiAgewo+ID4gPiAtICAgICBpZiAoZ3RfaWlyWzBdKSB7Cj4gPiA+ICsgICAg IGlmIChtYXN0ZXJfY3RsICYgKEdFTjhfR1RfUkNTX0lSUSB8IEdFTjhfR1RfQkNTX0lSUSkpIHsK PiA+ID4gICAgICAgICAgICAgICBnZW44X2NzX2lycV9oYW5kbGVyKGRldl9wcml2LT5lbmdpbmVb UkNTXSwKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGd0X2lpclswXSwg R0VOOF9SQ1NfSVJRX1NISUZUKTsKPiA+ID4gICAgICAgICAgICAgICBnZW44X2NzX2lycV9oYW5k bGVyKGRldl9wcml2LT5lbmdpbmVbQkNTXSwKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGd0X2lpclswXSwgR0VOOF9CQ1NfSVJRX1NISUZUKTsKPiA+ID4gICAgICAgfQo+ ID4gPiAgCj4gPiA+IC0gICAgIGlmIChndF9paXJbMV0pIHsKPiA+ID4gKyAgICAgaWYgKG1hc3Rl cl9jdGwgJiAoR0VOOF9HVF9WQ1MxX0lSUSB8IEdFTjhfR1RfVkNTMl9JUlEpKSB7Cj4gPiA+ICAg ICAgICAgICAgICAgZ2VuOF9jc19pcnFfaGFuZGxlcihkZXZfcHJpdi0+ZW5naW5lW1ZDU10sCj4g PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBndF9paXJbMV0sIEdFTjhfVkNT MV9JUlFfU0hJRlQpOwo+ID4gPiAgICAgICAgICAgICAgIGdlbjhfY3NfaXJxX2hhbmRsZXIoZGV2 X3ByaXYtPmVuZ2luZVtWQ1MyXSwKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGd0X2lpclsxXSwgR0VOOF9WQ1MyX0lSUV9TSElGVCk7Cj4gPiA+ICAgICAgIH0KPiA+ID4g IAo+ID4gPiAtICAgICBpZiAoZ3RfaWlyWzNdKQo+ID4gPiArICAgICBpZiAobWFzdGVyX2N0bCAm IEdFTjhfR1RfVkVDU19JUlEpIHsKPiA+ID4gICAgICAgICAgICAgICBnZW44X2NzX2lycV9oYW5k bGVyKGRldl9wcml2LT5lbmdpbmVbVkVDU10sCj4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBndF9paXJbM10sIEdFTjhfVkVDU19JUlFfU0hJRlQpOwo+ID4gPiArICAgICB9 Cj4gPiA+ICAKPiA+ID4gLSAgICAgaWYgKGd0X2lpclsyXSAmIGRldl9wcml2LT5wbV9ycHNfZXZl bnRzKQo+ID4gPiAtICAgICAgICAgICAgIGdlbjZfcnBzX2lycV9oYW5kbGVyKGRldl9wcml2LCBn dF9paXJbMl0pOwo+ID4gPiArICAgICBpZiAobWFzdGVyX2N0bCAmIChHRU44X0dUX1BNX0lSUSB8 IEdFTjhfR1RfR1VDX0lSUSkpIHsKPiA+ID4gKyAgICAgICAgICAgICBpZiAoZ3RfaWlyWzJdICYg ZGV2X3ByaXYtPnBtX3Jwc19ldmVudHMpCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICBnZW42 X3Jwc19pcnFfaGFuZGxlcihkZXZfcHJpdiwgZ3RfaWlyWzJdKTsKPiA+ID4gIAo+ID4gPiAtICAg ICBpZiAoZ3RfaWlyWzJdICYgZGV2X3ByaXYtPnBtX2d1Y19ldmVudHMpCj4gPiA+IC0gICAgICAg ICAgICAgZ2VuOV9ndWNfaXJxX2hhbmRsZXIoZGV2X3ByaXYsIGd0X2lpclsyXSk7Cj4gPiA+ICsg ICAgICAgICAgICAgaWYgKGd0X2lpclsyXSAmIGRldl9wcml2LT5wbV9ndWNfZXZlbnRzKQo+ID4g PiArICAgICAgICAgICAgICAgICAgICAgZ2VuOV9ndWNfaXJxX2hhbmRsZXIoZGV2X3ByaXYsIGd0 X2lpclsyXSk7Cj4gPiA+ICsgICAgIH0KPiA+ID4gIH0KPiA+ID4gIAo+ID4gPiAgc3RhdGljIGJv b2wgYnh0X3BvcnRfaG90cGx1Z19sb25nX2RldGVjdChlbnVtIHBvcnQgcG9ydCwgdTMyIHZhbCkK PiA+ID4gQEAgLTIwODUsOSArMjA5Niw5IEBAIHN0YXRpYyBpcnFyZXR1cm5fdCBjaGVycnl2aWV3 X2lycV9oYW5kbGVyKGludCBpcnEsIHZvaWQgKmFyZykKPiA+ID4gIAo+ID4gPiAgICAgICBkbyB7 Cj4gPiA+ICAgICAgICAgICAgICAgdTMyIG1hc3Rlcl9jdGwsIGlpcjsKPiA+ID4gLSAgICAgICAg ICAgICB1MzIgZ3RfaWlyWzRdID0ge307Cj4gPiA+ICAgICAgICAgICAgICAgdTMyIHBpcGVfc3Rh dHNbSTkxNV9NQVhfUElQRVNdID0ge307Cj4gPiA+ICAgICAgICAgICAgICAgdTMyIGhvdHBsdWdf c3RhdHVzID0gMDsKPiA+ID4gKyAgICAgICAgICAgICB1MzIgZ3RfaWlyWzRdOwo+ID4gPiAgICAg ICAgICAgICAgIHUzMiBpZXIgPSAwOwo+ID4gPiAgCj4gPiA+ICAgICAgICAgICAgICAgbWFzdGVy X2N0bCA9IEk5MTVfUkVBRChHRU44X01BU1RFUl9JUlEpICYgfkdFTjhfTUFTVEVSX0lSUV9DT05U Uk9MOwo+ID4gPiBAQCAtMjE0MCw3ICsyMTUxLDcgQEAgc3RhdGljIGlycXJldHVybl90IGNoZXJy eXZpZXdfaXJxX2hhbmRsZXIoaW50IGlycSwgdm9pZCAqYXJnKQo+ID4gPiAgICAgICAgICAgICAg IEk5MTVfV1JJVEUoR0VOOF9NQVNURVJfSVJRLCBHRU44X01BU1RFUl9JUlFfQ09OVFJPTCk7Cj4g PiA+ICAgICAgICAgICAgICAgUE9TVElOR19SRUFEKEdFTjhfTUFTVEVSX0lSUSk7Cj4gPiA+ICAK PiA+ID4gLSAgICAgICAgICAgICBnZW44X2d0X2lycV9oYW5kbGVyKGRldl9wcml2LCBndF9paXIp Owo+ID4gPiArICAgICAgICAgICAgIGdlbjhfZ3RfaXJxX2hhbmRsZXIoZGV2X3ByaXYsIG1hc3Rl cl9jdGwsIGd0X2lpcik7Cj4gPiA+ICAKPiA+ID4gICAgICAgICAgICAgICBpZiAoaG90cGx1Z19z dGF0dXMpCj4gPiA+ICAgICAgICAgICAgICAgICAgICAgICBpOXh4X2hwZF9pcnFfaGFuZGxlcihk ZXZfcHJpdiwgaG90cGx1Z19zdGF0dXMpOwo+ID4gPiBAQCAtMjY3NSwxMCArMjY4Niw5IEBAIGdl bjhfZGVfaXJxX2hhbmRsZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzIg bWFzdGVyX2N0bCkKPiA+ID4gIAo+ID4gPiAgc3RhdGljIGlycXJldHVybl90IGdlbjhfaXJxX2hh bmRsZXIoaW50IGlycSwgdm9pZCAqYXJnKQo+ID4gPiAgewo+ID4gPiAtICAgICBzdHJ1Y3QgZHJt X2RldmljZSAqZGV2ID0gYXJnOwo+ID4gPiAtICAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4gPiA+ICsgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoYXJnKTsKPiA+ID4gICAgICAgdTMyIG1hc3Rlcl9jdGw7 Cj4gPiA+IC0gICAgIHUzMiBndF9paXJbNF0gPSB7fTsKPiA+ID4gKyAgICAgdTMyIGd0X2lpcls0 XTsKPiA+ID4gIAo+ID4gPiAgICAgICBpZiAoIWludGVsX2lycXNfZW5hYmxlZChkZXZfcHJpdikp Cj4gPiA+ICAgICAgICAgICAgICAgcmV0dXJuIElSUV9OT05FOwo+ID4gPiBAQCAtMjY5MCwxOCAr MjcwMCwxOSBAQCBzdGF0aWMgaXJxcmV0dXJuX3QgZ2VuOF9pcnFfaGFuZGxlcihpbnQgaXJxLCB2 b2lkICphcmcpCj4gPiA+ICAKPiA+ID4gICAgICAgSTkxNV9XUklURV9GVyhHRU44X01BU1RFUl9J UlEsIDApOwo+ID4gPiAgCj4gPiA+IC0gICAgIC8qIElSUXMgYXJlIHN5bmNlZCBkdXJpbmcgcnVu dGltZV9zdXNwZW5kLCB3ZSBkb24ndCByZXF1aXJlIGEgd2FrZXJlZiAqLwo+ID4gPiAtICAgICBk aXNhYmxlX3JwbV93YWtlcmVmX2Fzc2VydHMoZGV2X3ByaXYpOwo+ID4gPiAtCj4gPiA+ICAgICAg IC8qIEZpbmQsIGNsZWFyLCB0aGVuIHByb2Nlc3MgZWFjaCBzb3VyY2Ugb2YgaW50ZXJydXB0ICov Cj4gPiA+ICAgICAgIGdlbjhfZ3RfaXJxX2FjayhkZXZfcHJpdiwgbWFzdGVyX2N0bCwgZ3RfaWly KTsKPiA+ID4gLSAgICAgZ2VuOF9ndF9pcnFfaGFuZGxlcihkZXZfcHJpdiwgZ3RfaWlyKTsKPiA+ ID4gLSAgICAgZ2VuOF9kZV9pcnFfaGFuZGxlcihkZXZfcHJpdiwgbWFzdGVyX2N0bCk7Cj4gPiA+ ICsKPiA+ID4gKyAgICAgLyogSVJRcyBhcmUgc3luY2VkIGR1cmluZyBydW50aW1lX3N1c3BlbmQs IHdlIGRvbid0IHJlcXVpcmUgYSB3YWtlcmVmICovCj4gPiA+ICsgICAgIGlmIChtYXN0ZXJfY3Rs ICYgfkdFTjhfR1RfSVJRUykgewo+ID4gPiArICAgICAgICAgICAgIGRpc2FibGVfcnBtX3dha2Vy ZWZfYXNzZXJ0cyhkZXZfcHJpdik7Cj4gPiA+ICsgICAgICAgICAgICAgZ2VuOF9kZV9pcnFfaGFu ZGxlcihkZXZfcHJpdiwgbWFzdGVyX2N0bCk7Cj4gPiA+ICsgICAgICAgICAgICAgZW5hYmxlX3Jw bV93YWtlcmVmX2Fzc2VydHMoZGV2X3ByaXYpOwo+ID4gPiArICAgICB9Cj4gPiA+Cj4gPiA+ICAg ICAgIEk5MTVfV1JJVEVfRlcoR0VOOF9NQVNURVJfSVJRLCBHRU44X01BU1RFUl9JUlFfQ09OVFJP TCk7Cj4gPiA+IC0gICAgIFBPU1RJTkdfUkVBRF9GVyhHRU44X01BU1RFUl9JUlEpOwo+ID4gPiAg Cj4gPiA+IC0gICAgIGVuYWJsZV9ycG1fd2FrZXJlZl9hc3NlcnRzKGRldl9wcml2KTsKPiA+ID4g KyAgICAgZ2VuOF9ndF9pcnFfaGFuZGxlcihkZXZfcHJpdiwgbWFzdGVyX2N0bCwgZ3RfaWlyKTsK PiA+IAo+ID4gWW91IHdhbnQgdG8gc2VydmUgZGlzcGxheSBmaXJzdD8gRG8geW91IHJlY29tbWVu ZCB0aGUKPiA+IHNhbWUgYXBwcm9hY2ggdG8gZ2VuMTE/Cj4gCj4gVGhlIGlkZWEgaXMgdGhhdCBo YXZpbmcgc3F1aXJyZWwgdGhlIGlpciBhbmQgYWNrZWQgdGhlIHNlY29uZGFyeQo+IHNvdXJjZXMs IHdlIHJlLWVuYWJsZWQgdGhlIHByaW1hcnkgaW50ZXJydXB0IHNvIHRoYXQgd2Ugc2VydmljZSB0 aGUgbmV4dAo+IGludGVycnVwdCBxdWlja2VyOyB3aGlsc3Qgd2UgY29udGludWUgdG8gcHJvY2Vz cyB0aGUgcHJldmlvdXMgaXJxIG9uCj4gdGhpcyBjcHUuIE5vdCBzdXJlIGlmIGl0IG1ha2VzIGEg YmlnIGRpZmZlcmVuY2UgaW4gdGhlIGVuZCwgd2UgaGF2ZSBhCj4gbG90IG9mIHNlcmlhbGlzYXRp b24gdG8gb3ZlcmNvbWUsIGJ1dCBpdCdzIGEgbmljZSBjb25zZXF1ZW5jZSBvZiBWaWxsZSdzCj4g Y2xlYW51cCBvZiBzcGxpdHRpbmcgdGhlIGFjay9wcm9jZXNzaW5nIG9mIHRoZSBzb3VyY2VzLgoK SSd2ZSBvY2Nhc2lvbmFsbHkgcG9uZGVyZWQgYWJvdXQgbW92aW5nIHRoZSBwcm9jZXNzaW5nIHBh cnQgdG8gYSB0aHJlYWQsCndpdGggbWF5YmUgbGVhdmluZyBzb21lIHN1cGVyIGR1cGVyIGNyaXRp Y2FsIGV4ZWNsaXN0IHN0dWZmIGluIHRoZSBoYXJkCmlycSBwYXJ0LiBUaG91Z2ggSSdtIG5vdCBz dXJlIGlmIHRoYXQgd291bGQgYmUgc2lnaW5pZmljYW50bHkgZGlmZmVyZW50CnRvIGp1c3QgbW92 aW5nIHRoZSBlbnRpcmUgdGhpbmcgaW50byBhIHRocmVhZCwgb3IganVzdCBsZWF2aW5nIGl0IGFs bAp3aGVyZSBpdCBpcyBub3cuIFdvdWxkIG5lZWQgdG8gY29sbGVjdCBzb21lIGhhcmQgZGF0YSBJ IHN1cHBvc2UuCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK