From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 3/4] drm/i915/fbdev: Use the PLANE_HAS_FENCE flags from the time of pinning
Date: Tue, 20 Feb 2018 15:56:35 +0200 [thread overview]
Message-ID: <20180220135635.GD5453@intel.com> (raw)
In-Reply-To: <20180220134208.24988-3-chris@chris-wilson.co.uk>
On Tue, Feb 20, 2018 at 01:42:07PM +0000, Chris Wilson wrote:
> Use the information about the fence state from the time of pinning to
> determine if the fbdev writes are going through a fence. This avoids any
> confusion in cases where the fence may appear or disappear unconnected
> to the use by fbdev.
>
> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_fbdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c
> index 3d8ce3a62743..055f409f8b75 100644
> --- a/drivers/gpu/drm/i915/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/intel_fbdev.c
> @@ -48,7 +48,8 @@
> static void intel_fbdev_invalidate(struct intel_fbdev *ifbdev)
> {
> struct drm_i915_gem_object *obj = ifbdev->fb->obj;
> - unsigned int origin = ifbdev->vma->fence ? ORIGIN_GTT : ORIGIN_CPU;
> + unsigned int origin =
> + ifbdev->vma_flags & PLANE_HAS_FENCE ? ORIGIN_GTT : ORIGIN_CPU;
>
> intel_fb_obj_invalidate(obj, origin);
> }
> --
> 2.16.1
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-02-20 13:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 13:42 [PATCH v2 1/4] drm/i915: Also check view->type for a normal GGTT view Chris Wilson
2018-02-20 13:42 ` [PATCH v2 2/4] drm/i915: Move the policy for placement of the GGTT vma into the caller Chris Wilson
2018-02-20 13:42 ` [PATCH v2 3/4] drm/i915/fbdev: Use the PLANE_HAS_FENCE flags from the time of pinning Chris Wilson
2018-02-20 13:56 ` Ville Syrjälä [this message]
2018-02-20 13:42 ` [PATCH v2 4/4] drm/i915/fbc: Use PLANE_HAS_FENCE to determine if the plane is fenced Chris Wilson
2018-02-20 13:59 ` Ville Syrjälä
2018-02-20 14:02 ` Chris Wilson
2018-02-20 14:49 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/4] drm/i915: Also check view->type for a normal GGTT view Patchwork
2018-02-20 15:04 ` ✓ Fi.CI.BAT: success " Patchwork
2018-02-20 20:36 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-02-20 20:39 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220135635.GD5453@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox