From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 7/8] drm: Check that the plane supports the request format+modifier combo Date: Mon, 26 Feb 2018 16:43:47 +0200 Message-ID: <20180226144347.GS5453@intel.com> References: <20171222192231.17981-1-ville.syrjala@linux.intel.com> <20171222192231.17981-8-ville.syrjala@linux.intel.com> <20180110130457.GR13066@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180110130457.GR13066@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky , dri-devel@lists.freedesktop.org, Daniel Stone List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKYW4gMTAsIDIwMTggYXQgMDI6MDQ6NTdQTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBGcmksIERlYyAyMiwgMjAxNyBhdCAwOToyMjozMFBNICswMjAwLCBWaWxsZSBT eXJqYWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiA+IAo+ID4gQ3VycmVudGx5IHdlIG9ubHkgY2hlY2sgdGhhdCB0aGUg cGxhbmUgc3VwcG9ydHMgdGhlIHBpeGVsIGZvcm1hdCBvZiB0aGUKPiA+IGZiIHdlJ3JlIGFib3V0 IHRvIGZlZWQgdG8gaXQuIEV4dGVuZCBpdCB0byBjaGVjayBhbHNvIHRoZSBtb2RpZmllciwgYW5k Cj4gPiBtb3JlIHNwZWNpZmljYWxseSB0aGF0IHRoZSBjb21iaW5hdGlvbiBvZiB0aGUgZm9ybWF0 IGFuZCBtb2RpZmllciBpcwo+ID4gc3VwcG9ydGVkLgo+ID4gCj4gPiBDYzogZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gQ2M6IEJlbiBXaWRhd3NreSA8YmVuQGJ3aWRhd3NrLm5l dD4KPiA+IENjOiBKYXNvbiBFa3N0cmFuZCA8amFzb25Aamxla3N0cmFuZC5uZXQ+Cj4gPiBDYzog RGFuaWVsIFN0b25lIDxkYW5pZWxzQGNvbGxhYm9yYS5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBW aWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IAo+IFJldmll d2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKRmluYWxseSBw dXNoZWQgdGhpcyAoYW5kIHRoZSBmb2xsb3d1cCBpOTE1IHBhdGNoKSB0byBkcm0tbWlzYy1uZXh0 LgpUaGFua3MgZm9yIHRoZSByZXZpZXdzLgoKPiAKPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2Ry bS9kcm1fYXRvbWljLmMgICAgICAgIHwgMTAgKysrKysrLS0tLQo+ID4gIGRyaXZlcnMvZ3B1L2Ry bS9kcm1fY3J0Yy5jICAgICAgICAgIHwgMTAgKysrKysrLS0tLQo+ID4gIGRyaXZlcnMvZ3B1L2Ry bS9kcm1fY3J0Y19pbnRlcm5hbC5oIHwgIDQgKystLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1f cGxhbmUuYyAgICAgICAgIHwgMzMgKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tCj4g PiAgNCBmaWxlcyBjaGFuZ2VkLCA0MCBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKPiA+ IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gPiBpbmRleCBiNzZkNDkyMThjZjEuLjZlNWMzZWExZTQz YiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiA+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiA+IEBAIC04ODIsMTIgKzg4MiwxNCBAQCBz dGF0aWMgaW50IGRybV9hdG9taWNfcGxhbmVfY2hlY2soc3RydWN0IGRybV9wbGFuZSAqcGxhbmUs Cj4gPiAgCX0KPiA+ICAKPiA+ICAJLyogQ2hlY2sgd2hldGhlciB0aGlzIHBsYW5lIHN1cHBvcnRz IHRoZSBmYiBwaXhlbCBmb3JtYXQuICovCj4gPiAtCXJldCA9IGRybV9wbGFuZV9jaGVja19waXhl bF9mb3JtYXQocGxhbmUsIHN0YXRlLT5mYi0+Zm9ybWF0LT5mb3JtYXQpOwo+ID4gKwlyZXQgPSBk cm1fcGxhbmVfY2hlY2tfcGl4ZWxfZm9ybWF0KHBsYW5lLCBzdGF0ZS0+ZmItPmZvcm1hdC0+Zm9y bWF0LAo+ID4gKwkJCQkJICAgc3RhdGUtPmZiLT5tb2RpZmllcik7Cj4gPiAgCWlmIChyZXQpIHsK PiA+ICAJCXN0cnVjdCBkcm1fZm9ybWF0X25hbWVfYnVmIGZvcm1hdF9uYW1lOwo+ID4gLQkJRFJN X0RFQlVHX0FUT01JQygiSW52YWxpZCBwaXhlbCBmb3JtYXQgJXNcbiIsCj4gPiAtCQkgICAgICAg ICAgICAgICAgIGRybV9nZXRfZm9ybWF0X25hbWUoc3RhdGUtPmZiLT5mb3JtYXQtPmZvcm1hdCwK PiA+IC0JCSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmZm9ybWF0X25hbWUp KTsKPiA+ICsJCURSTV9ERUJVR19BVE9NSUMoIkludmFsaWQgcGl4ZWwgZm9ybWF0ICVzLCBtb2Rp ZmllciAweCVsbHhcbiIsCj4gPiArCQkJCSBkcm1fZ2V0X2Zvcm1hdF9uYW1lKHN0YXRlLT5mYi0+ Zm9ybWF0LT5mb3JtYXQsCj4gPiArCQkJCQkJICAgICAmZm9ybWF0X25hbWUpLAo+ID4gKwkJCQkg c3RhdGUtPmZiLT5tb2RpZmllcik7Cj4gPiAgCQlyZXR1cm4gcmV0Owo+ID4gIAl9Cj4gPiAgCj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMgYi9kcml2ZXJzL2dwdS9k cm0vZHJtX2NydGMuYwo+ID4gaW5kZXggZjA1NTZlNjU0MTE2Li44MTZjMzBhMGYwMzAgMTAwNjQ0 Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+ID4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2RybV9jcnRjLmMKPiA+IEBAIC02MjUsMTIgKzYyNSwxNCBAQCBpbnQgZHJtX21vZGVf c2V0Y3J0YyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ID4gIAkJICovCj4g PiAgCQlpZiAoIWNydGMtPnByaW1hcnktPmZvcm1hdF9kZWZhdWx0KSB7Cj4gPiAgCQkJcmV0ID0g ZHJtX3BsYW5lX2NoZWNrX3BpeGVsX2Zvcm1hdChjcnRjLT5wcmltYXJ5LAo+ID4gLQkJCQkJCQkg ICBmYi0+Zm9ybWF0LT5mb3JtYXQpOwo+ID4gKwkJCQkJCQkgICBmYi0+Zm9ybWF0LT5mb3JtYXQs Cj4gPiArCQkJCQkJCSAgIGZiLT5tb2RpZmllcik7Cj4gPiAgCQkJaWYgKHJldCkgewo+ID4gIAkJ CQlzdHJ1Y3QgZHJtX2Zvcm1hdF9uYW1lX2J1ZiBmb3JtYXRfbmFtZTsKPiA+IC0JCQkJRFJNX0RF QlVHX0tNUygiSW52YWxpZCBwaXhlbCBmb3JtYXQgJXNcbiIsCj4gPiAtCQkJCSAgICAgICAgICAg ICAgZHJtX2dldF9mb3JtYXRfbmFtZShmYi0+Zm9ybWF0LT5mb3JtYXQsCj4gPiAtCQkJCSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmZm9ybWF0X25hbWUpKTsKPiA+ICsJCQkJRFJN X0RFQlVHX0tNUygiSW52YWxpZCBwaXhlbCBmb3JtYXQgJXMsIG1vZGlmaWVyIDB4JWxseFxuIiwK PiA+ICsJCQkJCSAgICAgIGRybV9nZXRfZm9ybWF0X25hbWUoZmItPmZvcm1hdC0+Zm9ybWF0LAo+ ID4gKwkJCQkJCQkJICAmZm9ybWF0X25hbWUpLAo+ID4gKwkJCQkJICAgICAgZmItPm1vZGlmaWVy KTsKPiA+ICAJCQkJZ290byBvdXQ7Cj4gPiAgCQkJfQo+ID4gIAkJfQo+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Y19pbnRlcm5hbC5oIGIvZHJpdmVycy9ncHUvZHJtL2Ry bV9jcnRjX2ludGVybmFsLmgKPiA+IGluZGV4IGFmMDBmNDJiYTI2OS4uODYwOTY4YTY0YWU3IDEw MDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjX2ludGVybmFsLmgKPiA+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Y19pbnRlcm5hbC5oCj4gPiBAQCAtMTk2LDggKzE5 Niw4IEBAIGludCBkcm1fbW9kZV9hdG9taWNfaW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwK PiA+ICAvKiBkcm1fcGxhbmUuYyAqLwo+ID4gIGludCBkcm1fcGxhbmVfcmVnaXN0ZXJfYWxsKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ID4gIHZvaWQgZHJtX3BsYW5lX3VucmVnaXN0ZXJfYWxs KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ID4gLWludCBkcm1fcGxhbmVfY2hlY2tfcGl4ZWxf Zm9ybWF0KGNvbnN0IHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ID4gLQkJCQkgdTMyIGZvcm1h dCk7Cj4gPiAraW50IGRybV9wbGFuZV9jaGVja19waXhlbF9mb3JtYXQoc3RydWN0IGRybV9wbGFu ZSAqcGxhbmUsCj4gPiArCQkJCSB1MzIgZm9ybWF0LCB1NjQgbW9kaWZpZXIpOwo+ID4gIAo+ID4g IC8qIGRybV9icmlkZ2UuYyAqLwo+ID4gIHZvaWQgZHJtX2JyaWRnZV9kZXRhY2goc3RydWN0IGRy bV9icmlkZ2UgKmJyaWRnZSk7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9w bGFuZS5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZS5jCj4gPiBpbmRleCAyYzkwNTE5NTc2 YTMuLjhhYzE5Mzc5ZmU5OSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcGxh bmUuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZS5jCj4gPiBAQCAtNTQ1LDE2 ICs1NDUsMzMgQEAgaW50IGRybV9tb2RlX2dldHBsYW5lKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs IHZvaWQgKmRhdGEsCj4gPiAgCXJldHVybiAwOwo+ID4gIH0KPiA+ICAKPiA+IC1pbnQgZHJtX3Bs YW5lX2NoZWNrX3BpeGVsX2Zvcm1hdChjb25zdCBzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwgdTMy IGZvcm1hdCkKPiA+ICtpbnQgZHJtX3BsYW5lX2NoZWNrX3BpeGVsX2Zvcm1hdChzdHJ1Y3QgZHJt X3BsYW5lICpwbGFuZSwKPiA+ICsJCQkJIHUzMiBmb3JtYXQsIHU2NCBtb2RpZmllcikKPiA+ICB7 Cj4gPiAgCXVuc2lnbmVkIGludCBpOwo+ID4gIAo+ID4gIAlmb3IgKGkgPSAwOyBpIDwgcGxhbmUt PmZvcm1hdF9jb3VudDsgaSsrKSB7Cj4gPiAgCQlpZiAoZm9ybWF0ID09IHBsYW5lLT5mb3JtYXRf dHlwZXNbaV0pCj4gPiAtCQkJcmV0dXJuIDA7Cj4gPiArCQkJYnJlYWs7Cj4gPiArCX0KPiA+ICsJ aWYgKGkgPT0gcGxhbmUtPmZvcm1hdF9jb3VudCkKPiA+ICsJCXJldHVybiAtRUlOVkFMOwo+ID4g Kwo+ID4gKwlpZiAoIXBsYW5lLT5tb2RpZmllcl9jb3VudCkKPiA+ICsJCXJldHVybiAwOwo+ID4g Kwo+ID4gKwlmb3IgKGkgPSAwOyBpIDwgcGxhbmUtPm1vZGlmaWVyX2NvdW50OyBpKyspIHsKPiA+ ICsJCWlmIChtb2RpZmllciA9PSBwbGFuZS0+bW9kaWZpZXJzW2ldKQo+ID4gKwkJCWJyZWFrOwo+ ID4gIAl9Cj4gPiArCWlmIChpID09IHBsYW5lLT5tb2RpZmllcl9jb3VudCkKPiA+ICsJCXJldHVy biAtRUlOVkFMOwo+ID4gIAo+ID4gLQlyZXR1cm4gLUVJTlZBTDsKPiA+ICsJaWYgKHBsYW5lLT5m dW5jcy0+Zm9ybWF0X21vZF9zdXBwb3J0ZWQgJiYKPiA+ICsJICAgICFwbGFuZS0+ZnVuY3MtPmZv cm1hdF9tb2Rfc3VwcG9ydGVkKHBsYW5lLCBmb3JtYXQsIG1vZGlmaWVyKSkKPiA+ICsJCXJldHVy biAtRUlOVkFMOwo+ID4gKwo+ID4gKwlyZXR1cm4gMDsKPiA+ICB9Cj4gPiAgCj4gPiAgLyoKPiA+ IEBAIC01OTgsMTIgKzYxNSwxNCBAQCBzdGF0aWMgaW50IF9fc2V0cGxhbmVfaW50ZXJuYWwoc3Ry dWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gPiAgCX0KPiA+ICAKPiA+ICAJLyogQ2hlY2sgd2hldGhl ciB0aGlzIHBsYW5lIHN1cHBvcnRzIHRoZSBmYiBwaXhlbCBmb3JtYXQuICovCj4gPiAtCXJldCA9 IGRybV9wbGFuZV9jaGVja19waXhlbF9mb3JtYXQocGxhbmUsIGZiLT5mb3JtYXQtPmZvcm1hdCk7 Cj4gPiArCXJldCA9IGRybV9wbGFuZV9jaGVja19waXhlbF9mb3JtYXQocGxhbmUsIGZiLT5mb3Jt YXQtPmZvcm1hdCwKPiA+ICsJCQkJCSAgIGZiLT5tb2RpZmllcik7Cj4gPiAgCWlmIChyZXQpIHsK PiA+ICAJCXN0cnVjdCBkcm1fZm9ybWF0X25hbWVfYnVmIGZvcm1hdF9uYW1lOwo+ID4gLQkJRFJN X0RFQlVHX0tNUygiSW52YWxpZCBwaXhlbCBmb3JtYXQgJXNcbiIsCj4gPiAtCQkgICAgICAgICAg ICAgIGRybV9nZXRfZm9ybWF0X25hbWUoZmItPmZvcm1hdC0+Zm9ybWF0LAo+ID4gLQkJICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICZmb3JtYXRfbmFtZSkpOwo+ID4gKwkJRFJNX0RF QlVHX0tNUygiSW52YWxpZCBwaXhlbCBmb3JtYXQgJXMsIG1vZGlmaWVyIDB4JWxseFxuIiwKPiA+ ICsJCQkgICAgICBkcm1fZ2V0X2Zvcm1hdF9uYW1lKGZiLT5mb3JtYXQtPmZvcm1hdCwKPiA+ICsJ CQkJCQkgICZmb3JtYXRfbmFtZSksCj4gPiArCQkJICAgICAgZmItPm1vZGlmaWVyKTsKPiA+ICAJ CWdvdG8gb3V0Owo+ID4gIAl9Cj4gPiAgCj4gPiAtLSAKPiA+IDIuMTMuNgo+ID4gCj4gPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPiAK PiAtLSAKPiBEYW5pZWwgVmV0dGVyCj4gU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0 aW9uCj4gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RD Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=