From: Manasi Navare <manasi.d.navare@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
Subject: Re: [RFC] drm/i915/dp: move link rate arrays where they're used
Date: Tue, 27 Feb 2018 13:10:29 -0800 [thread overview]
Message-ID: <20180227211028.GA14764@intel.com> (raw)
In-Reply-To: <87woyygt8e.fsf@intel.com>
On Tue, Feb 27, 2018 at 08:52:49PM +0200, Jani Nikula wrote:
> On Tue, 27 Feb 2018, "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com> wrote:
> > On Tue, 2018-02-27 at 12:59 +0200, Jani Nikula wrote:
> >> Localize link rate arrays by moving them to the functions where they're
> >> used.
> >
> > I feel this array expresses platform capability concisely and it's easy
> > to quickly check what rates a platform supports when the array is at the
> > top. But,that's probably just me.
>
> I could argue both ways myself, hence RFC. :)
>
> BR,
> Jani.
>
I prefer the localized array of these per platform rates since its better if
this information is abstracted from the user and user only sees an array source_rates[].
Per platform rates will still be part of separate arrays for debug purposes and to check
them within code, but since the rest of the driver only uses source_rates, sink_rates,
common_rates arrays, having these per platform arrays local to the function make more sense.
Regards
Manasi
>
> --
> Jani Nikula, Intel Open Source Technology Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-02-27 21:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 10:59 [RFC] drm/i915/dp: move link rate arrays where they're used Jani Nikula
2018-02-27 13:27 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-02-27 18:05 ` [RFC] " Pandiyan, Dhinakaran
2018-02-27 18:52 ` Jani Nikula
2018-02-27 21:10 ` Manasi Navare [this message]
2018-02-27 18:22 ` Manasi Navare
2018-02-27 18:51 ` Jani Nikula
2018-02-27 20:05 ` ✗ Fi.CI.IGT: failure for " Patchwork
2018-02-28 9:51 ` ✓ Fi.CI.BAT: success " Patchwork
2018-02-28 10:53 ` ✗ Fi.CI.IGT: warning " Patchwork
2018-02-28 21:02 ` [RFC] " Ville Syrjälä
2018-02-28 21:17 ` Manasi Navare
2018-02-28 21:23 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227211028.GA14764@intel.com \
--to=manasi.d.navare@intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).