From: Manasi Navare <manasi.d.navare@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/i915: Nuke intel_dp->channel_eq_status
Date: Wed, 28 Feb 2018 12:12:19 -0800 [thread overview]
Message-ID: <20180228201218.GD11481@intel.com> (raw)
In-Reply-To: <20180119065904.sknwiuvd5ckt4but@intel.com>
On Thu, Jan 18, 2018 at 10:59:04PM -0800, Rodrigo Vivi wrote:
> On Wed, Jan 17, 2018 at 07:21:48PM +0000, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > intel_dp->channel_eq_status is used in exactly one function, and we
> > don't need it to persist between calls. So just go back to using a
> > local variable instead.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> > ---
> > drivers/gpu/drm/i915/intel_dp_link_training.c | 6 +++---
> > drivers/gpu/drm/i915/intel_drv.h | 1 -
> > 2 files changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c
> > index 05907fa8a553..1314f5d87d7d 100644
> > --- a/drivers/gpu/drm/i915/intel_dp_link_training.c
> > +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c
> > @@ -248,6 +248,7 @@ intel_dp_link_training_channel_equalization(struct intel_dp *intel_dp)
> > int tries;
> > u32 training_pattern;
> > uint8_t link_status[DP_LINK_STATUS_SIZE];
> > + bool channel_eq = false;
> >
> > training_pattern = intel_dp_training_pattern(intel_dp);
> >
> > @@ -259,7 +260,6 @@ intel_dp_link_training_channel_equalization(struct intel_dp *intel_dp)
> > return false;
> > }
> >
> > - intel_dp->channel_eq_status = false;
> > for (tries = 0; tries < 5; tries++) {
> >
> > drm_dp_link_train_channel_eq_delay(intel_dp->dpcd);
> > @@ -279,7 +279,7 @@ intel_dp_link_training_channel_equalization(struct intel_dp *intel_dp)
> >
> > if (drm_dp_channel_eq_ok(link_status,
> > intel_dp->lane_count)) {
> > - intel_dp->channel_eq_status = true;
> > + channel_eq = true;
> > DRM_DEBUG_KMS("Channel EQ done. DP Training "
> > "successful\n");
> > break;
> > @@ -301,7 +301,7 @@ intel_dp_link_training_channel_equalization(struct intel_dp *intel_dp)
> >
> > intel_dp_set_idle_link_train(intel_dp);
> >
> > - return intel_dp->channel_eq_status;
> > + return channel_eq;
> >
> > }
> >
> > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> > index ddf28a442cd7..1d018869ad02 100644
> > --- a/drivers/gpu/drm/i915/intel_drv.h
> > +++ b/drivers/gpu/drm/i915/intel_drv.h
> > @@ -1045,7 +1045,6 @@ struct intel_dp {
> > bool link_mst;
> > bool has_audio;
> > bool detect_done;
> > - bool channel_eq_status;
> > bool reset_link_params;
> > uint8_t dpcd[DP_RECEIVER_CAP_SIZE];
> > uint8_t psr_dpcd[EDP_PSR_RECEIVER_CAP_SIZE];
> > --
> > 2.13.6
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-02-28 20:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 19:21 [PATCH 1/5] drm/i915: Convert intel_hpd_irq_event() into an encoder hotplug hook Ville Syrjala
2018-01-17 19:21 ` [PATCH v2 2/5] drm/i915: Reinitialize sink scrambling/TMDS clock ratio on HPD Ville Syrjala
2018-01-30 22:45 ` Lyude Paul
2018-01-17 19:21 ` [PATCH v2 3/5] drm/i915: Move SST DP link retraining into the ->post_hotplug() hook Ville Syrjala
2018-01-30 23:16 ` Lyude Paul
2018-01-31 13:27 ` Ville Syrjälä
2018-02-28 7:17 ` Manasi Navare
2018-02-28 19:07 ` Lyude Paul
2018-02-28 19:27 ` Manasi Navare
2018-02-28 19:41 ` Lyude Paul
2018-02-28 19:57 ` Manasi Navare
2018-02-28 20:10 ` Lyude Paul
2018-03-05 23:41 ` Manasi Navare
2018-01-17 19:21 ` [PATCH 4/5] drm/i915: Nuke intel_dp->channel_eq_status Ville Syrjala
2018-01-19 6:59 ` Rodrigo Vivi
2018-02-28 20:12 ` Manasi Navare [this message]
2018-01-30 23:17 ` Lyude Paul
2018-01-17 19:21 ` [PATCH 5/5] drm/i915: Track whether the DP link is trained or not Ville Syrjala
2018-01-30 23:19 ` Lyude Paul
2018-02-28 20:08 ` Manasi Navare
2018-01-18 11:21 ` ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Convert intel_hpd_irq_event() into an encoder hotplug hook Patchwork
2018-01-18 13:04 ` ✓ Fi.CI.IGT: " Patchwork
2018-01-30 23:22 ` [PATCH 1/5] " Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228201218.GD11481@intel.com \
--to=manasi.d.navare@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).