From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH] drm/i915: Handle changing enable_fbc parameter at runtime better. Date: Mon, 5 Mar 2018 10:50:14 -0800 Message-ID: <20180305185014.GE15113@intel.com> References: <20180305123608.20665-1-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD4686E46A for ; Mon, 5 Mar 2018 18:50:16 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180305123608.20665-1-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMDUsIDIwMTggYXQgMDE6MzY6MDhQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gSWYgaTkxNS5lbmFibGVfZmJjIGlzIGNsZWFyZWQgYXQgcnVudGltZSwgYnV0 IEZCQyB3YXMgcHJldmlvdXNseSBlbmFibGVkCj4gdGhlbiB3ZSBkb24ndCBkaXNhYmxlIEZCQyB1 bnRpbCB0aGUgbmV4dCB0aW1lIHRoZSBjcnRjIGlzIGRpc2FibGVkLgo+IAo+IE1ha2Ugc3VyZSB0 aGF0IGlmIHRoZSBtb2R1bGUgcGFyYW0gaXMgY2hhbmdlZCwgd2UgZGlzYWJsZSBGQkMgaW4KPiBp bnRlbF9mYmNfcG9zdF91cGRhdGUgc28gd2UgbmV2ZXIgaGF2ZSB0byB3b3JyeSBhYm91dCBkaXNh YmxpbmcuCgpXaGF0IGFib3V0IHN3aXRjaGluZyB0aGlzIGZyb20gYSBwYXJhbWV0ZXIgdG8gZGVi dWdmcyB0b2dnbGUgbGlrZSBkcnJzPwoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmto b3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMuYyB8IDYyICsrKysrKysrKysrKysrKysrKysrKysrLS0t LS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDM2IGluc2VydGlvbnMoKyksIDI2IGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9m YmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiYy5jCj4gaW5kZXggZWFhYTU5YjQ1 NzA3Li41MzI1YjU5YzJmOWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZmJjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMuYwo+IEBAIC05 NDksNiArOTQ5LDMwIEBAIHZvaWQgaW50ZWxfZmJjX3ByZV91cGRhdGUoc3RydWN0IGludGVsX2Ny dGMgKmNydGMsCj4gIAltdXRleF91bmxvY2soJmZiYy0+bG9jayk7Cj4gIH0KPiAgCj4gKy8qKgo+ ICsgKiBfX2ludGVsX2ZiY19kaXNhYmxlIC0gZGlzYWJsZSBGQkMKPiArICogQGRldl9wcml2OiBp OTE1IGRldmljZSBpbnN0YW5jZQo+ICsgKgo+ICsgKiBUaGlzIGlzIHRoZSBsb3cgbGV2ZWwgZnVu Y3Rpb24gdGhhdCBhY3R1YWxseSBkaXNhYmxlcyBGQkMuIENhbGxlcnMgc2hvdWxkCj4gKyAqIGdy YWIgdGhlIEZCQyBsb2NrLgo+ICsgKi8KPiArc3RhdGljIHZvaWQgX19pbnRlbF9mYmNfZGlzYWJs ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gK3sKPiArCXN0cnVjdCBpbnRl bF9mYmMgKmZiYyA9ICZkZXZfcHJpdi0+ZmJjOwo+ICsJc3RydWN0IGludGVsX2NydGMgKmNydGMg PSBmYmMtPmNydGM7Cj4gKwo+ICsJV0FSTl9PTighbXV0ZXhfaXNfbG9ja2VkKCZmYmMtPmxvY2sp KTsKPiArCVdBUk5fT04oIWZiYy0+ZW5hYmxlZCk7Cj4gKwlXQVJOX09OKGZiYy0+YWN0aXZlKTsK PiArCj4gKwlEUk1fREVCVUdfS01TKCJEaXNhYmxpbmcgRkJDIG9uIHBpcGUgJWNcbiIsIHBpcGVf bmFtZShjcnRjLT5waXBlKSk7Cj4gKwo+ICsJX19pbnRlbF9mYmNfY2xlYW51cF9jZmIoZGV2X3By aXYpOwo+ICsKPiArCWZiYy0+ZW5hYmxlZCA9IGZhbHNlOwo+ICsJZmJjLT5jcnRjID0gTlVMTDsK PiArfQo+ICsKPiAgc3RhdGljIHZvaWQgX19pbnRlbF9mYmNfcG9zdF91cGRhdGUoc3RydWN0IGlu dGVsX2NydGMgKmNydGMpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diA9IHRvX2k5MTUoY3J0Yy0+YmFzZS5kZXYpOwo+IEBAIC05NjAsNiArOTg0LDEzIEBAIHN0YXRp YyB2b2lkIF9faW50ZWxfZmJjX3Bvc3RfdXBkYXRlKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ ICAJaWYgKCFmYmMtPmVuYWJsZWQgfHwgZmJjLT5jcnRjICE9IGNydGMpCj4gIAkJcmV0dXJuOwo+ ICAKPiArCWlmICghaTkxNV9tb2RwYXJhbXMuZW5hYmxlX2ZiYykgewo+ICsJCWludGVsX2ZiY19k ZWFjdGl2YXRlKGRldl9wcml2LCAiZGlzYWJsZWQgYXQgcnVudGltZSBwZXIgbW9kdWxlIHBhcmFt Iik7Cj4gKwkJX19pbnRlbF9mYmNfZGlzYWJsZShkZXZfcHJpdik7Cj4gKwo+ICsJCXJldHVybjsK PiArCX0KPiArCj4gIAlpZiAoIWludGVsX2ZiY19jYW5fYWN0aXZhdGUoY3J0YykpIHsKPiAgCQlX QVJOX09OKGZiYy0+YWN0aXZlKTsKPiAgCQlyZXR1cm47Cj4gQEAgLTExNjMsMzEgKzExOTQsNiBA QCB2b2lkIGludGVsX2ZiY19lbmFibGUoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gIAltdXRl eF91bmxvY2soJmZiYy0+bG9jayk7Cj4gIH0KPiAgCj4gLS8qKgo+IC0gKiBfX2ludGVsX2ZiY19k aXNhYmxlIC0gZGlzYWJsZSBGQkMKPiAtICogQGRldl9wcml2OiBpOTE1IGRldmljZSBpbnN0YW5j ZQo+IC0gKgo+IC0gKiBUaGlzIGlzIHRoZSBsb3cgbGV2ZWwgZnVuY3Rpb24gdGhhdCBhY3R1YWxs eSBkaXNhYmxlcyBGQkMuIENhbGxlcnMgc2hvdWxkCj4gLSAqIGdyYWIgdGhlIEZCQyBsb2NrLgo+ IC0gKi8KPiAtc3RhdGljIHZvaWQgX19pbnRlbF9mYmNfZGlzYWJsZShzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpCj4gLXsKPiAtCXN0cnVjdCBpbnRlbF9mYmMgKmZiYyA9ICZkZXZf cHJpdi0+ZmJjOwo+IC0Jc3RydWN0IGludGVsX2NydGMgKmNydGMgPSBmYmMtPmNydGM7Cj4gLQo+ IC0JV0FSTl9PTighbXV0ZXhfaXNfbG9ja2VkKCZmYmMtPmxvY2spKTsKPiAtCVdBUk5fT04oIWZi Yy0+ZW5hYmxlZCk7Cj4gLQlXQVJOX09OKGZiYy0+YWN0aXZlKTsKPiAtCVdBUk5fT04oY3J0Yy0+ YWN0aXZlKTsKPiAtCj4gLQlEUk1fREVCVUdfS01TKCJEaXNhYmxpbmcgRkJDIG9uIHBpcGUgJWNc biIsIHBpcGVfbmFtZShjcnRjLT5waXBlKSk7Cj4gLQo+IC0JX19pbnRlbF9mYmNfY2xlYW51cF9j ZmIoZGV2X3ByaXYpOwo+IC0KPiAtCWZiYy0+ZW5hYmxlZCA9IGZhbHNlOwo+IC0JZmJjLT5jcnRj ID0gTlVMTDsKPiAtfQo+IC0KPiAgLyoqCj4gICAqIGludGVsX2ZiY19kaXNhYmxlIC0gZGlzYWJs ZSBGQkMgaWYgaXQncyBhc3NvY2lhdGVkIHdpdGggY3J0Ywo+ICAgKiBAY3J0YzogdGhlIENSVEMK PiBAQCAtMTIwMiw2ICsxMjA4LDggQEAgdm9pZCBpbnRlbF9mYmNfZGlzYWJsZShzdHJ1Y3QgaW50 ZWxfY3J0YyAqY3J0YykKPiAgCWlmICghZmJjX3N1cHBvcnRlZChkZXZfcHJpdikpCj4gIAkJcmV0 dXJuOwo+ICAKPiArCVdBUk5fT04oY3J0Yy0+YWN0aXZlKTsKPiArCj4gIAltdXRleF9sb2NrKCZm YmMtPmxvY2spOwo+ICAJaWYgKGZiYy0+Y3J0YyA9PSBjcnRjKQo+ICAJCV9faW50ZWxfZmJjX2Rp c2FibGUoZGV2X3ByaXYpOwo+IEBAIC0xMjI0LDggKzEyMzIsMTAgQEAgdm9pZCBpbnRlbF9mYmNf Z2xvYmFsX2Rpc2FibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJCXJl dHVybjsKPiAgCj4gIAltdXRleF9sb2NrKCZmYmMtPmxvY2spOwo+IC0JaWYgKGZiYy0+ZW5hYmxl ZCkKPiArCWlmIChmYmMtPmVuYWJsZWQpIHsKPiArCQlXQVJOX09OKGZiYy0+Y3J0Yy0+YWN0aXZl KTsKPiAgCQlfX2ludGVsX2ZiY19kaXNhYmxlKGRldl9wcml2KTsKPiArCX0KPiAgCW11dGV4X3Vu bG9jaygmZmJjLT5sb2NrKTsKPiAgCj4gIAljYW5jZWxfd29ya19zeW5jKCZmYmMtPndvcmsud29y ayk7Cj4gLS0gCj4gMi4xNi4yCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=