From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC][PATCH 06/11] drm/edid: Don't call drm_add_display_info() with an invalid EDID Date: Tue, 6 Mar 2018 10:45:22 +0100 Message-ID: <20180306094522.GU22212@phenom.ffwll.local> References: <20180227125700.6527-1-ville.syrjala@linux.intel.com> <20180227125700.6527-7-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA9E06E5FD for ; Tue, 6 Mar 2018 09:45:26 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id w128so21525001wmw.0 for ; Tue, 06 Mar 2018 01:45:26 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180227125700.6527-7-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBGZWIgMjcsIDIwMTggYXQgMDI6NTY6NTVQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IGRybV9tb2RlX2Nvbm5lY3Rvcl91cGRhdGVfZWRpZF9wcm9wZXJ0eSgpIHdpbGwg Y2FsbAo+IGRybV9hZGRfZGlzcGxheV9pbmZvKCkgaWYgYW4gaW52YWxpZCBlZGlkIGlzIHBhc3Nl ZCBpbi4KPiBUaGlzIGRpZmZlcnMgZnJvbSB0aGUgYmVoYXZpb3VyIG9mIGRybV9hZGRfZWRpZF9t b2RlcygpIHdoaWNoCj4gZG9lc24ndCB0cnkgdG8gcG9wdWxhdGUgdGhlIGRpc3BsYXkgaW5mbyBm cm9tIGFuIGludmFsaWQgZWRpZC4KPiBBZGp1c3QgZHJtX21vZGVfY29ubmVjdG9yX3VwZGF0ZV9l ZGlkX3Byb3BlcnR5KCkgdG8gbWF0Y2ggdGhhdAo+IGJlaGF2aW91ci4KPiAKPiBVbmZvcnR1bmF0 ZWx5IHdlIGhhdmUgdG8gcGFzcyB0aGUgZWRpZCBhcyBub24tY29uc3QgdG8KPiBkcm1fbW9kZV9j b25uZWN0b3JfdXBkYXRlX2VkaWRfcHJvcGVydHkoKSBiZWNhdXNlIGRybV9lZGlkX2lzX3ZhbGlk KCkKPiBtYXkgbmVlZCB0byBtb2RpZnkgaXQgOiggV291bGQgYmUgbmljZSB0byBvbmUgZGF5IGZp eCB1cCB0aGUgRURJRCBjb2RlCj4gdG8gbm90IGRvIGNyYXp5IHRoaW5ncyBsaWtlIHRoYXQuCgpJ IGd1ZXNzIHdlIGNvdWxkIHB1dCB0aGUgRURJRCB2YWxpZGF0aW9uIGludG8gdGhlIEVESUQgcmVh ZGluZyBoZWxwZXJzIGFuZApqdXN0IHByYXkgdGhhdCBhbnkgZml4ZWQgRURJRCAoZnJvbSB2YnQg b3Igd2hlcmV2ZXIpIGlzIGFjdHVhbGx5IHZhbGlkPwoKTWVhbndoaWxlIHRoaXMgbWFrZXMgc2Vu c2UgdG8gbWUuCgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZnds bC5jaD4KCj4gCj4gQ2M6IEtlaXRoIFBhY2thcmQgPGtlaXRocEBrZWl0aHAuY29tPgo+IENjOiBE YW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IFNpZ25lZC1vZmYtYnk6IFZp bGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9kcm1fY29ubmVjdG9yLmMgfCA0ICsrLS0KPiAgaW5jbHVkZS9kcm0vZHJt X2Nvbm5lY3Rvci5oICAgICB8IDIgKy0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAzIGluc2VydGlvbnMo KyksIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f Y29ubmVjdG9yLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jCj4gaW5kZXggZGRk N2Q5NzhmNDYyLi5kOGMzZWY0ZjE3ZGEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9jb25uZWN0b3IuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY29ubmVjdG9yLmMKPiBA QCAtMTM2OCw3ICsxMzY4LDcgQEAgRVhQT1JUX1NZTUJPTChkcm1fbW9kZV9jb25uZWN0b3Jfc2V0 X3RpbGVfcHJvcGVydHkpOwo+ICAgKiBaZXJvIG9uIHN1Y2Nlc3MsIG5lZ2F0aXZlIGVycm5vIG9u IGZhaWx1cmUuCj4gICAqLwo+ICBpbnQgZHJtX21vZGVfY29ubmVjdG9yX3VwZGF0ZV9lZGlkX3By b3BlcnR5KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gLQkJCQkJICAgIGNvbnN0 IHN0cnVjdCBlZGlkICplZGlkKQo+ICsJCQkJCSAgICBzdHJ1Y3QgZWRpZCAqZWRpZCkKPiAgewo+ ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNvbm5lY3Rvci0+ZGV2Owo+ICAJc2l6ZV90IHNp emUgPSAwOwo+IEBAIC0xMzkwLDcgKzEzOTAsNyBAQCBpbnQgZHJtX21vZGVfY29ubmVjdG9yX3Vw ZGF0ZV9lZGlkX3Byb3BlcnR5KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gIAkg KiBvcmRlcmluZyBvZiBjYWxscy4KPiAgCSAqLwo+ICAJZHJtX3Jlc2V0X2Rpc3BsYXlfaW5mbyhj b25uZWN0b3IpOwo+IC0JaWYgKGVkaWQpCj4gKwlpZiAoZWRpZCAmJiBkcm1fZWRpZF9pc192YWxp ZChlZGlkKSkKPiAgCQlkcm1fYWRkX2Rpc3BsYXlfaW5mbyhjb25uZWN0b3IsIGVkaWQpOwo+ICAK PiAgCWRybV9vYmplY3RfcHJvcGVydHlfc2V0X3ZhbHVlKCZjb25uZWN0b3ItPmJhc2UsCj4gZGlm ZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9jb25uZWN0b3IuaCBiL2luY2x1ZGUvZHJtL2RybV9j b25uZWN0b3IuaAo+IGluZGV4IGFhZDMyNThmYWNmMi4uODgxNWVmMWNlNDI5IDEwMDY0NAo+IC0t LSBhL2luY2x1ZGUvZHJtL2RybV9jb25uZWN0b3IuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9j b25uZWN0b3IuaAo+IEBAIC0xMTE5LDcgKzExMTksNyBAQCBpbnQgZHJtX21vZGVfY29ubmVjdG9y X3NldF9wYXRoX3Byb3BlcnR5KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gIAkJ CQkJIGNvbnN0IGNoYXIgKnBhdGgpOwo+ICBpbnQgZHJtX21vZGVfY29ubmVjdG9yX3NldF90aWxl X3Byb3BlcnR5KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IpOwo+ICBpbnQgZHJtX21v ZGVfY29ubmVjdG9yX3VwZGF0ZV9lZGlkX3Byb3BlcnR5KHN0cnVjdCBkcm1fY29ubmVjdG9yICpj b25uZWN0b3IsCj4gLQkJCQkJICAgIGNvbnN0IHN0cnVjdCBlZGlkICplZGlkKTsKPiArCQkJCQkg ICAgc3RydWN0IGVkaWQgKmVkaWQpOwo+ICB2b2lkIGRybV9tb2RlX2Nvbm5lY3Rvcl9zZXRfbGlu a19zdGF0dXNfcHJvcGVydHkoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAgCQkJ CQkJIHVpbnQ2NF90IGxpbmtfc3RhdHVzKTsKPiAgaW50IGRybV9jb25uZWN0b3JfaW5pdF9wYW5l bF9vcmllbnRhdGlvbl9wcm9wZXJ0eSgKPiAtLSAKPiAyLjEzLjYKPiAKCi0tIApEYW5pZWwgVmV0 dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZnds bC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK