From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [Intel-gfx] [PATCH v2 1/3] drm: Make sure at least one plane supports the fb format Date: Tue, 6 Mar 2018 13:57:26 +0200 Message-ID: <20180306115726.GD5453@intel.com> References: <20180305144919.2881-1-ville.syrjala@linux.intel.com> <20180305214102.8220-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180305214102.8220-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMDUsIDIwMTggYXQgMTE6NDE6MDJQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IFRvIG1ha2UgbGlmZSBlYXNpZXIgZm9yIGRyaXZlcnMsIGxldCdzIGhhdmUgdGhl IGNvcmUgY2hlY2sgdGhhdCB0aGUKPiByZXF1ZXN0ZWQgcGl4ZWwgZm9ybWF0IGlzIHN1cHBvcnRl ZCBieSBhdCBsZWFzdCBvbmUgcGxhbmUgd2hlbiBjcmVhdGluZwo+IGEgbmV3IGZyYW1lYnVmZmVy Lgo+IAo+IHYyOiBBY2NlcHQgYW55Zm9ybWF0IGlmIHRoZSBkcml2ZXIgZG9lc24ndCBkbyBwbGFu ZXMgKEVyaWMpCj4gICAgIHMvcGxhbmVzX2hhdmVfZm9ybWF0L2FueV9wbGFuZV9oYXNfZm9ybWF0 LyAoRXJpYykKPiAgICAgQ2hlY2sgdGhlIG1vZGlmaWVyIGFzIHdlbGwgc2luY2Ugd2UgYWxyZWFk eSBoYXZlIGEgZnVuY3Rpb24KPiAgICAgdGhhdCBkb2VzIGJvdGgKPiAKPiBDYzogRXJpYyBBbmhv bHQgPGVyaWNAYW5ob2x0Lm5ldD4KPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJt X2ZyYW1lYnVmZmVyLmMgfCA0MyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0t LS0KPiAgMSBmaWxlIGNoYW5nZWQsIDM1IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYwo+IGluZGV4IGMwNTMwYTFhZjVlMy4uYjlhMzNl M2YxM2U5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYwo+IEBAIC0xNTIsMTIgKzE1 MiwzNyBAQCBzdGF0aWMgaW50IGZiX3BsYW5lX2hlaWdodChpbnQgaGVpZ2h0LAo+ICAJcmV0dXJu IERJVl9ST1VORF9VUChoZWlnaHQsIGZvcm1hdC0+dnN1Yik7Cj4gIH0KPiAgCj4gK3N0YXRpYyBi b29sIGFueV9wbGFuZV9oYXNfZm9ybWF0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gKwkJCQkg dTMyIGZvcm1hdCwgdTY0IG1vZGlmaWVyKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFu ZTsKPiArCj4gKwkvKiBUT0RPOiBtYXliZSBtYWludGFpbiBhIGRldmljZSBsZXZlbCBmb3JtYXQg bGlzdD8gKi8KPiArCWRybV9mb3JfZWFjaF9wbGFuZShwbGFuZSwgZGV2KSB7Cj4gKwkJLyoKPiAr CQkgKiBJbiBjYXNlIHRoZSBkcml2ZXIgZG9lc24ndCByZWFsbHkgZG8KPiArCQkgKiBwbGFuZXMg d2UgaGF2ZSB0byBhY2NlcHQgYW55IGZvcm1hdCBoZXJlLgo+ICsJCSAqLwo+ICsJCWlmIChwbGFu ZS0+Zm9ybWF0X2RlZmF1bHQpCj4gKwkJCXJldHVybiB0cnVlOwo+ICsKPiArCQlpZiAoZHJtX3Bs YW5lX2NoZWNrX3BpeGVsX2Zvcm1hdChwbGFuZSwgZm9ybWF0LCBtb2RpZmllcikgPT0gMCkKPiAr CQkJcmV0dXJuIHRydWU7Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIGZhbHNlOwo+ICt9Cj4gKwo+ICBz dGF0aWMgaW50IGZyYW1lYnVmZmVyX2NoZWNrKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJ CSAgICAgY29uc3Qgc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgKnIpCj4gIHsKPiAgCWNvbnN0IHN0 cnVjdCBkcm1fZm9ybWF0X2luZm8gKmluZm87Cj4gKwl1NjQgbW9kaWZpZXIgPSAwOwo+ICAJaW50 IGk7Cj4gIAo+ICsJaWYgKHItPmZsYWdzICYgRFJNX01PREVfRkJfTU9ESUZJRVJTKQo+ICsJCW1v ZGlmaWVyID0gci0+bW9kaWZpZXJbMF07CgpBbmQgb2YgY291cnNlIHRoaXMgaXNuJ3QgcXVpdGUg Y29ycmVjdC4gRm9yIHRoZSAhbW9kaWZpZXJzIGNhc2Ugd2UncmUKbm93IGNoZWNraW5nIGlmIGFu eSBwbGFuZSBzdXBwb3J0cyB0aGUgZm9ybWF0IHdpdGggdGhlIGxpbmVhciBtb2RpZmllciwKYnV0 IHRoZSBhY3R1YWwgbW9kaWZpZXIgd2lsbCBvbmx5IGJlIHBpY2tlZCBieSB0aGUgZHJpdmVyIGxh dGVyLgoKTm90IHF1aXRlIHN1cmUgaG93IEkgd291bGQgd3JpdGUgdGhpcyBpbiBhIHdheSB0aGF0 IHJlYWxseSBtYWtlcwpzZW5zZS4gTWlnaHQgaGF2ZSB0byBtYWtlIGl0IHRoZSBkcml2ZXIncyBy ZXNwb25zaWJpbGl0eSB0byBjYWxsCmFueV9wbGFuZV9oYXNfZm9ybWF0KCkgaW5zdGVhZC4uLgoK PiArCj4gIAkvKiBjaGVjayBpZiB0aGUgZm9ybWF0IGlzIHN1cHBvcnRlZCBhdCBhbGwgKi8KPiAg CWluZm8gPSBfX2RybV9mb3JtYXRfaW5mbyhyLT5waXhlbF9mb3JtYXQgJiB+RFJNX0ZPUk1BVF9C SUdfRU5ESUFOKTsKPiAgCWlmICghaW5mbykgewo+IEBAIC0xNjgsNiArMTkzLDE1IEBAIHN0YXRp YyBpbnQgZnJhbWVidWZmZXJfY2hlY2soc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQlyZXR1 cm4gLUVJTlZBTDsKPiAgCX0KPiAgCj4gKwlpZiAoIWFueV9wbGFuZV9oYXNfZm9ybWF0KGRldiwg ci0+cGl4ZWxfZm9ybWF0LCBtb2RpZmllcikpIHsKPiArCQlzdHJ1Y3QgZHJtX2Zvcm1hdF9uYW1l X2J1ZiBmb3JtYXRfbmFtZTsKPiArCj4gKwkJRFJNX0RFQlVHX0tNUygidW5zdXBwb3J0ZWQgcGl4 ZWwgZm9ybWF0ICVzLCBtb2RpZmllciAweCVsbHhcbiIsCj4gKwkJCSAgICAgIGRybV9nZXRfZm9y bWF0X25hbWUoci0+cGl4ZWxfZm9ybWF0LCAmZm9ybWF0X25hbWUpLAo+ICsJCQkgICAgICBtb2Rp Zmllcik7Cj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gKwl9Cj4gKwo+ICAJLyogbm93IGxldCB0aGUg ZHJpdmVyIHBpY2sgaXRzIG93biBmb3JtYXQgaW5mbyAqLwo+ICAJaW5mbyA9IGRybV9nZXRfZm9y bWF0X2luZm8oZGV2LCByKTsKPiAgCj4gQEAgLTIwMiwxNCArMjM2LDcgQEAgc3RhdGljIGludCBm cmFtZWJ1ZmZlcl9jaGVjayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJCQlyZXR1cm4gLUVJ TlZBTDsKPiAgCQl9Cj4gIAo+IC0JCWlmIChyLT5tb2RpZmllcltpXSAmJiAhKHItPmZsYWdzICYg RFJNX01PREVfRkJfTU9ESUZJRVJTKSkgewo+IC0JCQlEUk1fREVCVUdfS01TKCJiYWQgZmIgbW9k aWZpZXIgJWxsdSBmb3IgcGxhbmUgJWRcbiIsCj4gLQkJCQkgICAgICByLT5tb2RpZmllcltpXSwg aSk7Cj4gLQkJCXJldHVybiAtRUlOVkFMOwo+IC0JCX0KPiAtCj4gLQkJaWYgKHItPmZsYWdzICYg RFJNX01PREVfRkJfTU9ESUZJRVJTICYmCj4gLQkJICAgIHItPm1vZGlmaWVyW2ldICE9IHItPm1v ZGlmaWVyWzBdKSB7Cj4gKwkJaWYgKHItPm1vZGlmaWVyW2ldICE9IG1vZGlmaWVyKSB7Cj4gIAkJ CURSTV9ERUJVR19LTVMoImJhZCBmYiBtb2RpZmllciAlbGx1IGZvciBwbGFuZSAlZFxuIiwKPiAg CQkJCSAgICAgIHItPm1vZGlmaWVyW2ldLCBpKTsKPiAgCQkJcmV0dXJuIC1FSU5WQUw7Cj4gLS0g Cj4gMi4xNi4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK