From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [Intel-gfx] [PATCH v2 1/3] drm: Make sure at least one plane supports the fb format Date: Tue, 6 Mar 2018 14:54:50 +0200 Message-ID: <20180306125450.GG5453@intel.com> References: <20180305144919.2881-1-ville.syrjala@linux.intel.com> <20180305214102.8220-1-ville.syrjala@linux.intel.com> <20180306115726.GD5453@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180306115726.GD5453@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXIgMDYsIDIwMTggYXQgMDE6NTc6MjZQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIE1vbiwgTWFyIDA1LCAyMDE4IGF0IDExOjQxOjAyUE0gKzAyMDAsIFZpbGxl IFN5cmphbGEgd3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFA bGludXguaW50ZWwuY29tPgo+ID4gCj4gPiBUbyBtYWtlIGxpZmUgZWFzaWVyIGZvciBkcml2ZXJz LCBsZXQncyBoYXZlIHRoZSBjb3JlIGNoZWNrIHRoYXQgdGhlCj4gPiByZXF1ZXN0ZWQgcGl4ZWwg Zm9ybWF0IGlzIHN1cHBvcnRlZCBieSBhdCBsZWFzdCBvbmUgcGxhbmUgd2hlbiBjcmVhdGluZwo+ ID4gYSBuZXcgZnJhbWVidWZmZXIuCj4gPiAKPiA+IHYyOiBBY2NlcHQgYW55Zm9ybWF0IGlmIHRo ZSBkcml2ZXIgZG9lc24ndCBkbyBwbGFuZXMgKEVyaWMpCj4gPiAgICAgcy9wbGFuZXNfaGF2ZV9m b3JtYXQvYW55X3BsYW5lX2hhc19mb3JtYXQvIChFcmljKQo+ID4gICAgIENoZWNrIHRoZSBtb2Rp ZmllciBhcyB3ZWxsIHNpbmNlIHdlIGFscmVhZHkgaGF2ZSBhIGZ1bmN0aW9uCj4gPiAgICAgdGhh dCBkb2VzIGJvdGgKPiA+IAo+ID4gQ2M6IEVyaWMgQW5ob2x0IDxlcmljQGFuaG9sdC5uZXQ+Cj4g PiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9mcmFtZWJ1ZmZlci5jIHwg NDMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tCj4gPiAgMSBmaWxlIGNo YW5nZWQsIDM1IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0v ZHJtX2ZyYW1lYnVmZmVyLmMKPiA+IGluZGV4IGMwNTMwYTFhZjVlMy4uYjlhMzNlM2YxM2U5IDEw MDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9mcmFtZWJ1ZmZlci5jCj4gPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMKPiA+IEBAIC0xNTIsMTIgKzE1Miwz NyBAQCBzdGF0aWMgaW50IGZiX3BsYW5lX2hlaWdodChpbnQgaGVpZ2h0LAo+ID4gIAlyZXR1cm4g RElWX1JPVU5EX1VQKGhlaWdodCwgZm9ybWF0LT52c3ViKTsKPiA+ICB9Cj4gPiAgCj4gPiArc3Rh dGljIGJvb2wgYW55X3BsYW5lX2hhc19mb3JtYXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ ICsJCQkJIHUzMiBmb3JtYXQsIHU2NCBtb2RpZmllcikKPiA+ICt7Cj4gPiArCXN0cnVjdCBkcm1f cGxhbmUgKnBsYW5lOwo+ID4gKwo+ID4gKwkvKiBUT0RPOiBtYXliZSBtYWludGFpbiBhIGRldmlj ZSBsZXZlbCBmb3JtYXQgbGlzdD8gKi8KPiA+ICsJZHJtX2Zvcl9lYWNoX3BsYW5lKHBsYW5lLCBk ZXYpIHsKPiA+ICsJCS8qCj4gPiArCQkgKiBJbiBjYXNlIHRoZSBkcml2ZXIgZG9lc24ndCByZWFs bHkgZG8KPiA+ICsJCSAqIHBsYW5lcyB3ZSBoYXZlIHRvIGFjY2VwdCBhbnkgZm9ybWF0IGhlcmUu Cj4gPiArCQkgKi8KPiA+ICsJCWlmIChwbGFuZS0+Zm9ybWF0X2RlZmF1bHQpCj4gPiArCQkJcmV0 dXJuIHRydWU7Cj4gPiArCj4gPiArCQlpZiAoZHJtX3BsYW5lX2NoZWNrX3BpeGVsX2Zvcm1hdChw bGFuZSwgZm9ybWF0LCBtb2RpZmllcikgPT0gMCkKPiA+ICsJCQlyZXR1cm4gdHJ1ZTsKPiA+ICsJ fQo+ID4gKwo+ID4gKwlyZXR1cm4gZmFsc2U7Cj4gPiArfQo+ID4gKwo+ID4gIHN0YXRpYyBpbnQg ZnJhbWVidWZmZXJfY2hlY2soc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ICAJCQkgICAgIGNv bnN0IHN0cnVjdCBkcm1fbW9kZV9mYl9jbWQyICpyKQo+ID4gIHsKPiA+ICAJY29uc3Qgc3RydWN0 IGRybV9mb3JtYXRfaW5mbyAqaW5mbzsKPiA+ICsJdTY0IG1vZGlmaWVyID0gMDsKPiA+ICAJaW50 IGk7Cj4gPiAgCj4gPiArCWlmIChyLT5mbGFncyAmIERSTV9NT0RFX0ZCX01PRElGSUVSUykKPiA+ ICsJCW1vZGlmaWVyID0gci0+bW9kaWZpZXJbMF07Cj4gCj4gQW5kIG9mIGNvdXJzZSB0aGlzIGlz bid0IHF1aXRlIGNvcnJlY3QuIEZvciB0aGUgIW1vZGlmaWVycyBjYXNlIHdlJ3JlCj4gbm93IGNo ZWNraW5nIGlmIGFueSBwbGFuZSBzdXBwb3J0cyB0aGUgZm9ybWF0IHdpdGggdGhlIGxpbmVhciBt b2RpZmllciwKPiBidXQgdGhlIGFjdHVhbCBtb2RpZmllciB3aWxsIG9ubHkgYmUgcGlja2VkIGJ5 IHRoZSBkcml2ZXIgbGF0ZXIuCj4gCj4gTm90IHF1aXRlIHN1cmUgaG93IEkgd291bGQgd3JpdGUg dGhpcyBpbiBhIHdheSB0aGF0IHJlYWxseSBtYWtlcwo+IHNlbnNlLiBNaWdodCBoYXZlIHRvIG1h a2UgaXQgdGhlIGRyaXZlcidzIHJlc3BvbnNpYmlsaXR5IHRvIGNhbGwKPiBhbnlfcGxhbmVfaGFz X2Zvcm1hdCgpIGluc3RlYWQuLi4KCkhtbS4gT25lIGlkZWEgd291bGQgYmUgdG8gc3RpY2sgdGhl IGNoZWNrIGludG8gZHJtX2ZyYW1lYnVmZmVyX2luaXQoKSwKYnV0IEknbSBub3QgY29tZm9ydGFi bGUgd2l0aCB0aGF0IHNpbmNlIHRoZSBkcml2ZXIgbWF5IHdlbGwgYmUgZG9pbmcKdGhpbmdzIGlu IGl0cyAuZmJfY3JlYXRlKCkgaG9vayB0aGF0IGV4cGVjdHMgdGhlIGZvcm1hdCttb2RpZmllciB0 bwpoYXZlIGJlZW4gdmFsaWRhdGVkIGFscmVhZHksIGFuZCBkcm1fZnJhbWVidWZmZXJfaW5pdCgp IHNob3VsZCBvbmx5IGJlCmNhbGxlZCBvbmNlIGV2ZXJ5dGhpbmcgaXMgcmVhZHkuCgpJIGd1ZXNz IEknbGwganVzdCBleHBvcnQgZHJtX2FueV9wbGFuZV9oYXNfZm9ybWF0KCkgYW5kIGFkZCBzb21l Cmtlcm5lbGRvYyBmb3IgLmZiX2NyZWF0ZSgpIHRvIGxldCBwZW9wbGUga25vdyBhYm91dCBpdC4g QmV0dGVyIGlkZWFzCmFyZSB3ZWxjb21lIG9mIGNvdXJzZS4KCj4gCj4gPiArCj4gPiAgCS8qIGNo ZWNrIGlmIHRoZSBmb3JtYXQgaXMgc3VwcG9ydGVkIGF0IGFsbCAqLwo+ID4gIAlpbmZvID0gX19k cm1fZm9ybWF0X2luZm8oci0+cGl4ZWxfZm9ybWF0ICYgfkRSTV9GT1JNQVRfQklHX0VORElBTik7 Cj4gPiAgCWlmICghaW5mbykgewo+ID4gQEAgLTE2OCw2ICsxOTMsMTUgQEAgc3RhdGljIGludCBm cmFtZWJ1ZmZlcl9jaGVjayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4gIAkJcmV0dXJuIC1F SU5WQUw7Cj4gPiAgCX0KPiA+ICAKPiA+ICsJaWYgKCFhbnlfcGxhbmVfaGFzX2Zvcm1hdChkZXYs IHItPnBpeGVsX2Zvcm1hdCwgbW9kaWZpZXIpKSB7Cj4gPiArCQlzdHJ1Y3QgZHJtX2Zvcm1hdF9u YW1lX2J1ZiBmb3JtYXRfbmFtZTsKPiA+ICsKPiA+ICsJCURSTV9ERUJVR19LTVMoInVuc3VwcG9y dGVkIHBpeGVsIGZvcm1hdCAlcywgbW9kaWZpZXIgMHglbGx4XG4iLAo+ID4gKwkJCSAgICAgIGRy bV9nZXRfZm9ybWF0X25hbWUoci0+cGl4ZWxfZm9ybWF0LCAmZm9ybWF0X25hbWUpLAo+ID4gKwkJ CSAgICAgIG1vZGlmaWVyKTsKPiA+ICsJCXJldHVybiAtRUlOVkFMOwo+ID4gKwl9Cj4gPiArCj4g PiAgCS8qIG5vdyBsZXQgdGhlIGRyaXZlciBwaWNrIGl0cyBvd24gZm9ybWF0IGluZm8gKi8KPiA+ ICAJaW5mbyA9IGRybV9nZXRfZm9ybWF0X2luZm8oZGV2LCByKTsKPiA+ICAKPiA+IEBAIC0yMDIs MTQgKzIzNiw3IEBAIHN0YXRpYyBpbnQgZnJhbWVidWZmZXJfY2hlY2soc3RydWN0IGRybV9kZXZp Y2UgKmRldiwKPiA+ICAJCQlyZXR1cm4gLUVJTlZBTDsKPiA+ICAJCX0KPiA+ICAKPiA+IC0JCWlm IChyLT5tb2RpZmllcltpXSAmJiAhKHItPmZsYWdzICYgRFJNX01PREVfRkJfTU9ESUZJRVJTKSkg ewo+ID4gLQkJCURSTV9ERUJVR19LTVMoImJhZCBmYiBtb2RpZmllciAlbGx1IGZvciBwbGFuZSAl ZFxuIiwKPiA+IC0JCQkJICAgICAgci0+bW9kaWZpZXJbaV0sIGkpOwo+ID4gLQkJCXJldHVybiAt RUlOVkFMOwo+ID4gLQkJfQo+ID4gLQo+ID4gLQkJaWYgKHItPmZsYWdzICYgRFJNX01PREVfRkJf TU9ESUZJRVJTICYmCj4gPiAtCQkgICAgci0+bW9kaWZpZXJbaV0gIT0gci0+bW9kaWZpZXJbMF0p IHsKPiA+ICsJCWlmIChyLT5tb2RpZmllcltpXSAhPSBtb2RpZmllcikgewo+ID4gIAkJCURSTV9E RUJVR19LTVMoImJhZCBmYiBtb2RpZmllciAlbGx1IGZvciBwbGFuZSAlZFxuIiwKPiA+ICAJCQkJ ICAgICAgci0+bW9kaWZpZXJbaV0sIGkpOwo+ID4gIAkJCXJldHVybiAtRUlOVkFMOwo+ID4gLS0g Cj4gPiAyLjE2LjEKPiA+IAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gCj4gLS0gCj4gVmlsbGUgU3lyasOkbMOkCj4gSW50ZWwg T1RDCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK