From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 6/6] drm: Reject bad property flag combinations Date: Tue, 6 Mar 2018 19:22:51 +0100 Message-ID: <20180306182251.GX22212@phenom.ffwll.local> References: <20180306164849.2862-1-ville.syrjala@linux.intel.com> <20180306164849.2862-6-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 608F76E262 for ; Tue, 6 Mar 2018 18:22:59 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id h21so21792wmd.1 for ; Tue, 06 Mar 2018 10:22:59 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180306164849.2862-6-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXIgMDYsIDIwMTggYXQgMDY6NDg6NDlQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IFBpbXAgZHJtX3Byb3BlcnR5X3R5cGVfdmFsaWQoKSB0byBjaGVjayBmb3IgbW9y ZSBmYWlscyB3aXRoIHRoZQo+IHByb3BlcnR5IGZsYWdzLiBBbHNvIG1ha2UgdGhlIGNoZWNrIGJl Zm9yZSBhZGRpbmcgdGhlIHByb3BlcnR5LAo+IGFuZCBiYWlsIG91dCBpZiB0aGluZ3MgbG9vayBi YWQuCj4gCj4gU2luY2Ugd2UncmUgbm93IGNoZWtjaW5nIGZvciBtb3JlIHRoYW4gdGhlIHR5cGUg bGV0J3MgYWxzbwo+IGNoYW5nZSB0aGUgZnVuY3Rpb24gbmFtZSB0byBkcm1fcHJvcGVydHlfZmxh Z3NfdmFsaWQoKS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX3Byb3Bl cnR5LmMgfCAyOSArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLQo+ICAxIGZpbGUgY2hhbmdl ZCwgMjMgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2RybV9wcm9wZXJ0eS5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9wZXJ0 eS5jCj4gaW5kZXggMDI3YTUwZTU1ZTk2Li42YWM2ZWU0MWE2YTMgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2RybV9wcm9wZXJ0eS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9w cm9wZXJ0eS5jCj4gQEAgLTUwLDExICs1MCwyNyBAQAo+ICAgKiBJT0NUTCBhbmQgaW4gdGhlIGdl dC9zZXQgcHJvcGVydHkgSU9DVEwuCj4gICAqLwo+ICAKPiAtc3RhdGljIGJvb2wgZHJtX3Byb3Bl cnR5X3R5cGVfdmFsaWQoc3RydWN0IGRybV9wcm9wZXJ0eSAqcHJvcGVydHkpCj4gK3N0YXRpYyBi b29sIGRybV9wcm9wZXJ0eV9mbGFnc192YWxpZCh1MzIgZmxhZ3MpCj4gIHsKPiAtCWlmIChwcm9w ZXJ0eS0+ZmxhZ3MgJiBEUk1fTU9ERV9QUk9QX0VYVEVOREVEX1RZUEUpCj4gLQkJcmV0dXJuICEo cHJvcGVydHktPmZsYWdzICYgRFJNX01PREVfUFJPUF9MRUdBQ1lfVFlQRSk7Cj4gLQlyZXR1cm4g ISEocHJvcGVydHktPmZsYWdzICYgRFJNX01PREVfUFJPUF9MRUdBQ1lfVFlQRSk7Cj4gKwl1MzIg bGVnYWN5X3R5cGUgPSBmbGFncyAmIERSTV9NT0RFX1BST1BfTEVHQUNZX1RZUEU7Cj4gKwl1MzIg ZXh0X3R5cGUgPSBmbGFncyAmIERSTV9NT0RFX1BST1BfRVhURU5ERURfVFlQRTsKPiArCj4gKwkv KiBSZWplY3QgdW5kZWZpbmVkL2RlcHJlY2F0ZWQgZmxhZ3MgKi8KPiArCWlmIChmbGFncyAmIH4o RFJNX01PREVfUFJPUF9MRUdBQ1lfVFlQRSB8Cj4gKwkJICAgICAgRFJNX01PREVfUFJPUF9FWFRF TkRFRF9UWVBFIHwKPiArCQkgICAgICBEUk1fTU9ERV9QUk9QX0lNTVVUQUJMRSB8Cj4gKwkJICAg ICAgRFJNX01PREVfUFJPUF9BVE9NSUMpKQo+ICsJCXJldHVybiBmYWxzZTsKPiArCj4gKwkvKiBX ZSB3YW50IGVpdGhlciBhIGxlZ2FjeSB0eXBlIG9yIGFuIGV4dGVuZGVkIHR5cGUsIGJ1dCBub3Qg Ym90aCAqLwo+ICsJaWYgKCFsZWdhY3lfdHlwZSA9PSAhZXh0X3R5cGUpCj4gKwkJcmV0dXJuIGZh bHNlOwo+ICsKPiArCS8qIE9ubHkgb25lIGxlZ2FjeSB0eXBlIGF0IGEgdGltZSBwbGVhc2UgKi8K PiArCWlmIChsZWdhY3lfdHlwZSAmJiAhaXNfcG93ZXJfb2ZfMihsZWdhY3lfdHlwZSkpCj4gKwkJ cmV0dXJuIGZhbHNlOwo+ICsKPiArCXJldHVybiB0cnVlOwo+ICB9CgpJIHRoaW5rIHRoaXMgY2F0 Y2hlcyBldmVyeXRoaW5nLiBXZWxsIGV4Y2VwdCBub3QteWV0LWFzc2lnbmVkCkVYVEVOREVEX1RZ UEUgZGVmaW5lcywgYnV0IHJlYWxseSB3ZSBjYW4gb3ZlcmRvIHRoaXMgOi0pCgpSZXZpZXdlZC1i eTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiAgCj4gIC8qKgo+IEBA IC03OSw2ICs5NSw5IEBAIHN0cnVjdCBkcm1fcHJvcGVydHkgKmRybV9wcm9wZXJ0eV9jcmVhdGUo c3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCXN0cnVjdCBkcm1fcHJvcGVydHkgKnByb3BlcnR5 ID0gTlVMTDsKPiAgCWludCByZXQ7Cj4gIAo+ICsJaWYgKFdBUk5fT04oIWRybV9wcm9wZXJ0eV9m bGFnc192YWxpZChmbGFncykpKQo+ICsJCXJldHVybiBOVUxMOwo+ICsKPiAgCWlmIChXQVJOX09O KHN0cmxlbihuYW1lKSA+PSBEUk1fUFJPUF9OQU1FX0xFTikpCj4gIAkJcmV0dXJuIE5VTEw7Cj4g IAo+IEBAIC0xMDgsOCArMTI3LDYgQEAgc3RydWN0IGRybV9wcm9wZXJ0eSAqZHJtX3Byb3BlcnR5 X2NyZWF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAKPiAgCWxpc3RfYWRkX3RhaWwoJnBy b3BlcnR5LT5oZWFkLCAmZGV2LT5tb2RlX2NvbmZpZy5wcm9wZXJ0eV9saXN0KTsKPiAgCj4gLQlX QVJOX09OKCFkcm1fcHJvcGVydHlfdHlwZV92YWxpZChwcm9wZXJ0eSkpOwo+IC0KPiAgCXJldHVy biBwcm9wZXJ0eTsKPiAgZmFpbDoKPiAgCWtmcmVlKHByb3BlcnR5LT52YWx1ZXMpOwo+IC0tIAo+ IDIuMTYuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBv cmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=