From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/3] drm: Nuke the useless 'ret' variable from drm_mode_convert_umode() Date: Tue, 13 Mar 2018 17:17:14 +0100 Message-ID: <20180313161714.GA25297@phenom.ffwll.local> References: <20180313150759.27620-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 262206E2B4 for ; Tue, 13 Mar 2018 16:17:23 +0000 (UTC) Received: by mail-wr0-x243.google.com with SMTP id k3so455298wrg.6 for ; Tue, 13 Mar 2018 09:17:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180313150759.27620-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXIgMTMsIDIwMTggYXQgMDU6MDc6NTdQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IE5vIG5lZWQgdG8gc3RvcmUgdGhlIHJldHVybiB2YWx1ZSBpbiBhIHZhcmlhYmxl IHNpbmNlIHdlIGRvbid0IGhhdmUgdG8KPiBkbyBhbnkgdW53aW5kaW5nLgo+IAo+IFNpZ25lZC1v ZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpS ZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiAtLS0K PiAgZHJpdmVycy9ncHUvZHJtL2RybV9tb2Rlcy5jIHwgMTUgKysrKy0tLS0tLS0tLS0tCj4gIDEg ZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX21vZGVzLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X21vZGVzLmMKPiBpbmRleCA1YTgwMzNmZGE0ZTMuLjQxNTcyNTAxNDBiMCAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vZHJtX21vZGVzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X21vZGVzLmMKPiBAQCAtMTU5NiwxMiArMTU5Niw4IEBAIGludCBkcm1fbW9kZV9jb252ZXJ0X3Vt b2RlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJCSAgIHN0cnVjdCBkcm1fZGlzcGxheV9t b2RlICpvdXQsCj4gIAkJCSAgIGNvbnN0IHN0cnVjdCBkcm1fbW9kZV9tb2RlaW5mbyAqaW4pCj4g IHsKPiAtCWludCByZXQgPSAtRUlOVkFMOwo+IC0KPiAtCWlmIChpbi0+Y2xvY2sgPiBJTlRfTUFY IHx8IGluLT52cmVmcmVzaCA+IElOVF9NQVgpIHsKPiAtCQlyZXQgPSAtRVJBTkdFOwo+IC0JCWdv dG8gb3V0Owo+IC0JfQo+ICsJaWYgKGluLT5jbG9jayA+IElOVF9NQVggfHwgaW4tPnZyZWZyZXNo ID4gSU5UX01BWCkKPiArCQlyZXR1cm4gLUVSQU5HRTsKPiAgCj4gIAlvdXQtPmNsb2NrID0gaW4t PmNsb2NrOwo+ICAJb3V0LT5oZGlzcGxheSA9IGluLT5oZGlzcGxheTsKPiBAQCAtMTYyMiwxNCAr MTYxOCwxMSBAQCBpbnQgZHJtX21vZGVfY29udmVydF91bW9kZShzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2LAo+ICAKPiAgCW91dC0+c3RhdHVzID0gZHJtX21vZGVfdmFsaWRhdGVfZHJpdmVyKGRldiwg b3V0KTsKPiAgCWlmIChvdXQtPnN0YXR1cyAhPSBNT0RFX09LKQo+IC0JCWdvdG8gb3V0Owo+ICsJ CXJldHVybiAtRUlOVkFMOwo+ICAKPiAgCWRybV9tb2RlX3NldF9jcnRjaW5mbyhvdXQsIENSVENf SU5URVJMQUNFX0hBTFZFX1YpOwo+ICAKPiAtCXJldCA9IDA7Cj4gLQo+IC1vdXQ6Cj4gLQlyZXR1 cm4gcmV0Owo+ICsJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gIC8qKgo+IC0tIAo+IDIuMTYuMQo+IAo+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRl dmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0g CkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6 Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=