From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 2/6] drm/i915/psr: Tie PSR2 support to Y
 coordinate requirement in intel_psr_init_dpcd()
Date: Thu, 15 Mar 2018 17:35:57 -0700
Message-ID: <20180316003557.GR3945@intel.com>
References: <20180314223617.20122-1-jose.souza@intel.com>
 <20180314223617.20122-2-jose.souza@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id E8DDD6E128
 for <intel-gfx@lists.freedesktop.org>; Fri, 16 Mar 2018 00:36:02 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20180314223617.20122-2-jose.souza@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCBNYXIgMTQsIDIwMTggYXQgMDM6MzY6MTNQTSAtMDcwMCwgSm9zw6kgUm9iZXJ0byBk
ZSBTb3V6YSB3cm90ZToKPiBNb3ZlIHRvIG9ubHkgb25lIHBsYWNlIHRoZSBzaW5rIHJlcXVpcmVt
ZW50cyB0aGF0IHRoZSBhY3R1YWwgZHJpdmVyCj4gbmVlZHMgdG8gZW5hYmxlIFBTUjIuCj4gCj4g
QWxzbyBpbnRlbF9wc3IyX2NvbmZpZ192YWxpZCgpIGlzIGNhbGxlZCBldmVyeSB0aW1lIHRoZSBj
cnRjIGNvbmZpZwo+IGlzIGNvbXB1dGVkLCB3YXN0aW5nIHNvbWUgdGltZSBldmVyeSB0aW1lIGl0
IHdhcyBjaGVja2luZyBmb3IKPiBZIGNvb3JkaW5hdGUgcmVxdWlyZW1lbnQuCj4gCj4gVGhpcyBh
bGxvdyB1cyB0byBudWtlIHlfY29yZF9zdXBwb3J0IGFuZCBzb21lIG9mIFZTQyBzZXR1cCBjb2Rl
IHRoYXQKPiB3YXMgaGFuZGxpbmcgYSBzY2VuYXJpbyB0aGF0IHdvdWxkIG5ldmVyIGhhcHBlbihQ
U1IyIHdpdGhvdXQgWQo+IGNvb3JkaW5hdGUpLgo+IAo+IENjOiBEaGluYWthcmFuIFBhbmRpeWFu
IDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KPiBDYzogUm9kcmlnbyBWaXZpIDxyb2Ry
aWdvLnZpdmlAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEpvc8OpIFJvYmVydG8gZGUgU291
emEgPGpvc2Uuc291emFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p
OTE1X2Rydi5oICB8ICAxIC0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMgfCA1
NSArKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDIgZmlsZXMgY2hh
bmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgMjggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
OTE1X2Rydi5oCj4gaW5kZXggOGE1ODQyNzNmODk3Li5kNGJjOGQxOGY1NmMgMTAwNjQ0Cj4gLS0t
IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtNjAzLDcgKzYwMyw2IEBAIHN0cnVjdCBpOTE1X3BzciB7
Cj4gIAl1bnNpZ25lZCBidXN5X2Zyb250YnVmZmVyX2JpdHM7Cj4gIAlib29sIHBzcjJfc3VwcG9y
dDsKPiAgCWJvb2wgbGlua19zdGFuZGJ5Owo+IC0JYm9vbCB5X2NvcmRfc3VwcG9ydDsKPiAgCWJv
b2wgY29sb3JpbWV0cnlfc3VwcG9ydDsKPiAgCWJvb2wgYWxwbTsKPiAgCWJvb2wgaGFzX2h3X3Ry
YWNraW5nOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gaW5kZXggOTgxMWY1ZjBiYzc1Li42
MmQ5N2Q1NTc2ZDEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNy
LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+IEBAIC05Myw3ICs5
Myw3IEBAIHN0YXRpYyB2b2lkIHBzcl9hdXhfaW9fcG93ZXJfcHV0KHN0cnVjdCBpbnRlbF9kcCAq
aW50ZWxfZHApCj4gIAlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJpdiwgcHNyX2F1eF9k
b21haW4oaW50ZWxfZHApKTsKPiAgfQo+ICAKPiAtc3RhdGljIGJvb2wgaW50ZWxfZHBfZ2V0X3lf
Y29yZF9zdGF0dXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiArc3RhdGljIGJvb2wgaW50
ZWxfZHBfZ2V0X3lfY29vcmRfcmVxdWlyZWQoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAg
ewo+ICAJdWludDhfdCBwc3JfY2FwcyA9IDA7Cj4gIAo+IEBAIC0xMzcsMjIgKzEzNywzOCBAQCB2
b2lkIGludGVsX3Bzcl9pbml0X2RwY2Qoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgCj4g
IAlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5ICYmCj4gIAkgICAgKGludGVsX2RwLT5wc3Jf
ZHBjZFswXSAmIERQX1BTUjJfSVNfU1VQUE9SVEVEKSkgewo+IC0JCXVpbnQ4X3QgZnJhbWVfc3lu
Y19jYXA7Cj4gKwkJdWludDhfdCBmcmFtZV9zeW5jX2NhcCwgeV9jb29yZF9yZXE7Cj4gIAo+ICAJ
CWRldl9wcml2LT5wc3Iuc2lua19zdXBwb3J0ID0gdHJ1ZTsKPiArCj4gKwkJLyogUFNSMiBuZWVk
cyBmcmFtZSBzeW5jIHRvIGRvIHNlbGVjdGl2ZSB1cGRhdGVzICovCj4gIAkJaWYgKGRybV9kcF9k
cGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LAo+ICAJCQkJICAgICAgRFBfU0lOS19ERVZJQ0VfQVVY
X0ZSQU1FX1NZTkNfQ0FQLAo+ICAJCQkJICAgICAgJmZyYW1lX3N5bmNfY2FwKSAhPSAxKQo+ICAJ
CQlmcmFtZV9zeW5jX2NhcCA9IDA7Cj4gIAkJZnJhbWVfc3luY19jYXAgPSAoZnJhbWVfc3luY19j
YXAgJiBEUF9BVVhfRlJBTUVfU1lOQ19DQVApOwo+IC0JCS8qIFBTUjIgbmVlZHMgZnJhbWUgc3lu
YyBhcyB3ZWxsICovCj4gLQkJZGV2X3ByaXYtPnBzci5wc3IyX3N1cHBvcnQgPSBmcmFtZV9zeW5j
X2NhcDsKPiAtCQlEUk1fREVCVUdfS01TKCJQU1IyICVzIG9uIHNpbmsiLAo+IC0JCQkgICAgICBk
ZXZfcHJpdi0+cHNyLnBzcjJfc3VwcG9ydCA/ICJzdXBwb3J0ZWQiIDogIm5vdCBzdXBwb3J0ZWQi
KTsKPiArCj4gKwkJLyoKPiArCQkgKiBGSVhNRTogRW5hYmxlIFBTUjIgb25seSBmb3IgeS1jb29y
ZGluYXRlIFBTUjIgcGFuZWxzCj4gKwkJICogQWZ0ZXIgR1RDIGltcGxlbWVudGF0aW9uLCByZW1v
dmUgdGhpcyByZXN0cmljdGlvbi4KCkkgYmVsaWV2ZSB3ZSBzaG91bGQgcmVtb3ZlIHRoZSBGSVhN
RSBhbmQganVzdCBjb21tZW50IG91dCB0aGF0IG5vbiB5LWNvb3JkaW5hdGUKd291bGQgbmVlZCBH
VEMgdGhhdCB3ZSBjdXJyZW50bHkgZG9uJ3QgaW1wbGVtZW50LgoKbGF0ZXIgaWYgd2UgY2hhbmdl
IG91ciBtaW5kcyBhbmQgZGVjaWRlZCB0byBhZGQgdGhhdCBzdXBwb3J0IHdlIHJldmlzaXQgaGVy
ZQpidXQgd2l0aG91dCBhIEZJWE1FIHBvbHV0aW5nIGNvZGUgZm9yIHNvbWV0aGluZyB3ZSBkb24n
dCBwbGFuIHRvIHN1cHBvcnQgZm9yIG5vdy4KCj4gKwkJICoKPiArCQkgKiBBbGwgcGFuZWxzIHRo
YXQgc3VwcG9ydHMgUFNSIHZlcnNpb24gMyB0aGF0IGlzCgpQU1J2Mz8gaXMgdGhlcmUgcmVhbGx5
IHNvbWV0aGluZyBmb3JtYWwgYWJvdXQgdGhhdD8KCj4gKwkJICogUFNSMiArIFktY29vcmRpbmF0
ZSBzdXBwb3J0IGNhbiBoYW5kbGUgWSBjb29yZGluYXRlcyBpbiBWU0MKPiArCQkgKiBidXQgd2Ug
YXJlIG9ubHkgc3VyZSB0aGF0IGl0IGlzIGdvaW5nIHRvIGJlIHVzZWQgd2hlbgo+ICsJCSAqIHJl
cXVpcmVkIGJ5IHRoZSBwYW5lbC4gVGhpcyB3YXkgcGFuZWwgaXMgY2FwYWJsZSB0byBkbwo+ICsJ
CSAqIHNlbGVjdGl2ZSB1cGRhdGUgZXZlbiB3aXRob3V0IGEgdmFsaWQgYXV4IGZyYW1lIHN5bmMu
Cj4gKwkJICovCj4gKwkJeV9jb29yZF9yZXEgPSBpbnRlbF9kcF9nZXRfeV9jb29yZF9yZXF1aXJl
ZChpbnRlbF9kcCk7Cj4gKwo+ICsJCWRldl9wcml2LT5wc3IucHNyMl9zdXBwb3J0ID0gZnJhbWVf
c3luY19jYXAgJiYgeV9jb29yZF9yZXE7Cj4gKwkJaWYgKGRldl9wcml2LT5wc3IucHNyMl9zdXBw
b3J0KQo+ICsJCQlEUk1fREVCVUdfS01TKCJQU1IyIHN1cHBvcnRlZCBvbiBzaW5rXG4iKTsKPiAr
CQllbHNlCj4gKwkJCURSTV9ERUJVR19LTVMoIlBTUjIgbm90IHN1cHBvcnRlZCBvbiBzaW5rIgo+
ICsJCQkJICAgICAgIihmcmFtZSBzeW5jOiAlZCBZLWNvb3JkIHJlcXVpcmVkOiAlZClcbiIsCj4g
KwkJCQkgICAgICBmcmFtZV9zeW5jX2NhcCwgeV9jb29yZF9yZXEpOwo+ICAKPiAgCQlpZiAoZGV2
X3ByaXYtPnBzci5wc3IyX3N1cHBvcnQpIHsKPiAtCQkJZGV2X3ByaXYtPnBzci55X2NvcmRfc3Vw
cG9ydCA9Cj4gLQkJCQlpbnRlbF9kcF9nZXRfeV9jb3JkX3N0YXR1cyhpbnRlbF9kcCk7Cj4gIAkJ
CWRldl9wcml2LT5wc3IuY29sb3JpbWV0cnlfc3VwcG9ydCA9Cj4gIAkJCQlpbnRlbF9kcF9nZXRf
Y29sb3JpbWV0cnlfc3RhdHVzKGludGVsX2RwKTsKPiAgCQkJZGV2X3ByaXYtPnBzci5hbHBtID0K
PiBAQCAtMTk4LDE2ICsyMTQsMTIgQEAgc3RhdGljIHZvaWQgaHN3X3Bzcl9zZXR1cF92c2Moc3Ry
dWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAgCQltZW1zZXQoJnBzcl92c2MsIDAsIHNpemVvZihw
c3JfdnNjKSk7Cj4gIAkJcHNyX3ZzYy5zZHBfaGVhZGVyLkhCMCA9IDA7Cj4gIAkJcHNyX3ZzYy5z
ZHBfaGVhZGVyLkhCMSA9IDB4NzsKPiAtCQlpZiAoZGV2X3ByaXYtPnBzci5jb2xvcmltZXRyeV9z
dXBwb3J0ICYmCj4gLQkJICAgIGRldl9wcml2LT5wc3IueV9jb3JkX3N1cHBvcnQpIHsKPiArCQlp
ZiAoZGV2X3ByaXYtPnBzci5jb2xvcmltZXRyeV9zdXBwb3J0KSB7Cj4gIAkJCXBzcl92c2Muc2Rw
X2hlYWRlci5IQjIgPSAweDU7Cj4gIAkJCXBzcl92c2Muc2RwX2hlYWRlci5IQjMgPSAweDEzOwo+
IC0JCX0gZWxzZSBpZiAoZGV2X3ByaXYtPnBzci55X2NvcmRfc3VwcG9ydCkgewo+ICsJCX0gZWxz
ZSB7Cj4gIAkJCXBzcl92c2Muc2RwX2hlYWRlci5IQjIgPSAweDQ7Cj4gIAkJCXBzcl92c2Muc2Rw
X2hlYWRlci5IQjMgPSAweGU7Cj4gLQkJfSBlbHNlIHsKPiAtCQkJcHNyX3ZzYy5zZHBfaGVhZGVy
LkhCMiA9IDB4MzsKPiAtCQkJcHNyX3ZzYy5zZHBfaGVhZGVyLkhCMyA9IDB4YzsKPiAgCQl9Cj4g
IAl9IGVsc2Ugewo+ICAJCS8qIFByZXBhcmUgVlNDIHBhY2tldCBhcyBwZXIgRURQIDEuMyBzcGVj
LCBUYWJsZSAzLjEwICovCj4gQEAgLTQ3OCwxNSArNDkwLDYgQEAgc3RhdGljIGJvb2wgaW50ZWxf
cHNyMl9jb25maWdfdmFsaWQoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAgCQlyZXR1cm4g
ZmFsc2U7Cj4gIAl9Cj4gIAo+IC0JLyoKPiAtCSAqIEZJWE1FOmVuYWJsZSBwc3IyIG9ubHkgZm9y
IHktY29yZGluYXRlIHBzcjIgcGFuZWxzCj4gLQkgKiBBZnRlciBndGMgaW1wbGVtZW50YXRpb24g
LCByZW1vdmUgdGhpcyByZXN0cmljdGlvbi4KPiAtCSAqLwo+IC0JaWYgKCFkZXZfcHJpdi0+cHNy
LnlfY29yZF9zdXBwb3J0KSB7Cj4gLQkJRFJNX0RFQlVHX0tNUygiUFNSMiBub3QgZW5hYmxlZCwg
cGFuZWwgZG9lcyBub3Qgc3VwcG9ydCBZIGNvb3JkaW5hdGVcbiIpOwo+IC0JCXJldHVybiBmYWxz
ZTsKPiAtCX0KPiAtCj4gIAlyZXR1cm4gdHJ1ZTsKPiAgfQo+ICAKPiBAQCAtNTg2LDE0ICs1ODks
MTIgQEAgc3RhdGljIHZvaWQgaHN3X3Bzcl9lbmFibGVfc291cmNlKHN0cnVjdCBpbnRlbF9kcCAq
aW50ZWxfZHAsCj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gZGlnX3BvcnQtPmJhc2UuYmFz
ZS5kZXY7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRl
dik7Cj4gIAllbnVtIHRyYW5zY29kZXIgY3B1X3RyYW5zY29kZXIgPSBjcnRjX3N0YXRlLT5jcHVf
dHJhbnNjb2RlcjsKPiAtCXUzMiBjaGlja2VuOwo+ICAKPiAgCXBzcl9hdXhfaW9fcG93ZXJfZ2V0
KGludGVsX2RwKTsKPiAgCj4gIAlpZiAoZGV2X3ByaXYtPnBzci5wc3IyX3N1cHBvcnQpIHsKPiAt
CQljaGlja2VuID0gUFNSMl9WU0NfRU5BQkxFX1BST0dfSEVBREVSOwo+IC0JCWlmIChkZXZfcHJp
di0+cHNyLnlfY29yZF9zdXBwb3J0KQo+IC0JCQljaGlja2VuIHw9IFBTUjJfQUREX1ZFUlRJQ0FM
X0xJTkVfQ09VTlQ7Cj4gKwkJdTMyIGNoaWNrZW4gPSBQU1IyX1ZTQ19FTkFCTEVfUFJPR19IRUFE
RVIKPiArCQkJICAgICAgfCBQU1IyX0FERF9WRVJUSUNBTF9MSU5FX0NPVU5UOwo+ICAJCUk5MTVf
V1JJVEUoQ0hJQ0tFTl9UUkFOUyhjcHVfdHJhbnNjb2RlciksIGNoaWNrZW4pOwo+ICAKPiAgCQlJ
OTE1X1dSSVRFKEVEUF9QU1JfREVCVUcsCj4gLS0gCj4gMi4xNi4yCj4gCl9fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK
SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w
Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=