From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 2/2] drm/i915/psr: Remove open-coded PSR AUX
 transactions for SKL+
Date: Wed, 21 Mar 2018 13:24:36 -0700
Message-ID: <20180321202436.GY4616@intel.com>
References: <20180313034646.3721-1-dhinakaran.pandiyan@intel.com>
 <20180313034646.3721-2-dhinakaran.pandiyan@intel.com>
 <1520973843.1640.4.camel@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 23D0E6EACB
 for <intel-gfx@lists.freedesktop.org>; Wed, 21 Mar 2018 20:24:39 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <1520973843.1640.4.camel@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: "Souza, Jose" <jose.souza@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCBNYXIgMTMsIDIwMTggYXQgMDg6NDY6NTZQTSArMDAwMCwgU291emEsIEpvc2Ugd3Jv
dGU6Cj4gT24gTW9uLCAyMDE4LTAzLTEyIGF0IDIwOjQ2IC0wNzAwLCBEaGluYWthcmFuIFBhbmRp
eWFuIHdyb3RlOgo+ID4gSFNXIGFuZCBCRFcgaGF2ZSBTUkRfQVVYX3tDVEwsIFNUQVRVU30gcmVn
aXN0ZXJzIHRoYXQgdGhlIGRyaXZlcgo+ID4gbmVlZHMgdG8KPiA+IHNldHVwIGZvciB0aGUgSFcg
dG8gdXNlIHdoZW5ldmVyIGV4aXRpbmcgUFNSLiBTS0wrIGhhcmR3YXJlIHVzZQo+ID4gaGFyZGNv
ZGVkCj4gPiB2YWx1ZXMgZm9yIHRoZSBzYW1lIGFuZCBkbyBub3QgbmVlZCBhbnkgcmVnaXN0ZXJz
IHRvIGJlIHNldHVwLiBTbywKPiA+IHVzZQo+ID4gZHJtX2RwX2RwY2Rfd3JpdGViKCkgZm9yIGEg
b25lLXRpbWUgd3JpdGUgZHVyaW5nIFBTUiBlbmFibGUgYW5kIHNldHVwCj4gPiB0aGUKPiA+IFBT
UiBhdXggcmVnaXN0ZXJzIG9uIEhTVyBhbmQgQkRXIGZvciBsYXRlciB1c2UgYnkgSFcuCj4gPiAK
PiA+IFdlIGFsc28gZW5kIHVwIHdyaXRpbmcgdG8gcmVzZXJ2ZWQgYml0cyBpbiBTUkRfQVVYX0NU
TCBieSByZXVzaW5nCj4gPiBpbnRlbF9kcC0+Z2V0X2F1eF9zZW5kX2N0bCgpIGZvciBIU1cgYW5k
IEJEVywgZml4IHRoaXMuCj4gPiAKPiA+IFNpbmNlIHRoZSBBVVggcmVnaXN0ZXIgc2V0dXAgaXMg
c291cmNlIHNpZGUgcHJvZ3JhbW1pbmcsIG1vdmUgdGhlCj4gPiBjYWxsCj4gPiB0byBlbmFibGVf
c291cmNlKCkgZnJvbSBlbmFibGVfc2luaygpLgo+ID4gCj4gPiBDYzogSm9zw6kgUm9iZXJ0byBk
ZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+Cj4gCj4gUmV2aWV3ZWQtYnk6IEpvc2UgUm9i
ZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+CgpwdXNoZWQgdG8gZGlucS4gdGhh
bmtzIGZvciBwYXRjaCBhbmQgcmV2aWV3LgoKPiAKPiA+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJp
Z28udml2aUBpbnRlbC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBEaGluYWthcmFuIFBhbmRpeWFu
IDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1
L2RybS9pOTE1L2k5MTVfcmVnLmggIHwgIDYgKysrKysKPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9wc3IuYyB8IDU1ICsrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0KPiA+IC0tLS0t
LS0tLS0tLQo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgMzMgZGVsZXRp
b25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jl
Zy5oCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiA+IGluZGV4IGFiZGM1
MTNhOWVkZC4uMjNjMGY5YmRmNTkxIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaTkxNV9yZWcuaAo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+
ID4gQEAgLTQxNTEsNiArNDE1MSwxMiBAQCBlbnVtIHsKPiA+ICAjZGVmaW5lICAgRURQX1BTUl9J
RExFX0ZSQU1FX1NISUZUCQkwCj4gPiAgCj4gPiAgI2RlZmluZSBFRFBfUFNSX0FVWF9DVEwJCQkJ
X01NSU8oZGV2X3ByaQo+ID4gdi0+cHNyX21taW9fYmFzZSArIDB4MTApCj4gPiArI2RlZmluZSAg
IEVEUF9QU1JfQVVYX0NUTF9USU1FX09VVF9NQVNLCQkoMyA8PCAyNikKPiA+ICsjZGVmaW5lICAg
RURQX1BTUl9BVVhfQ1RMX01FU1NBR0VfU0laRV9NQVNLCSgweDFmIDw8IDIwKQo+ID4gKyNkZWZp
bmUgICBFRFBfUFNSX0FVWF9DVExfUFJFQ0hBUkdFXzJVU19NQVNLCSgweGYgPDwgMTYpCj4gPiAr
I2RlZmluZSAgIEVEUF9QU1JfQVVYX0NUTF9FUlJPUl9JTlRFUlJVUFQJKDEgPDwgMTEpCj4gPiAr
I2RlZmluZSAgIEVEUF9QU1JfQVVYX0NUTF9CSVRfQ0xPQ0tfMlhfTUFTSwkoMHg3ZmYpCj4gPiAr
Cj4gPiAgI2RlZmluZSBFRFBfUFNSX0FVWF9EQVRBKGkpCQkJX01NSU8oZGV2X3ByaXYtCj4gPiA+
cHNyX21taW9fYmFzZSArIDB4MTQgKyAoaSkgKiA0KSAvKiA1IHJlZ2lzdGVycyAqLwo+ID4gIAo+
ID4gICNkZWZpbmUgRURQX1BTUl9TVEFUVVMJCQkJX01NSU8oZGV2X3ByaXYKPiA+IC0+cHNyX21t
aW9fYmFzZSArIDB4NDApCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfcHNyLmMKPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiA+IGluZGV4
IDg2ZDZjMTljOWFlNi4uMjkzYTk4N2ExYmZkIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs
X3Bzci5jCj4gPiBAQCAtMjI4LDMxICsyMjgsMTIgQEAgc3RhdGljIHZvaWQgdmx2X3Bzcl9lbmFi
bGVfc2luayhzdHJ1Y3QgaW50ZWxfZHAKPiA+ICppbnRlbF9kcCkKPiA+ICAJCQkgICBEUF9QU1Jf
RU5BQkxFIHwgRFBfUFNSX01BSU5fTElOS19BQ1RJVkUpOwo+ID4gIH0KPiA+ICAKPiA+IC1zdGF0
aWMgaTkxNV9yZWdfdCBwc3JfYXV4X2N0bF9yZWcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl
dl9wcml2LAo+ID4gLQkJCQkgICAgICAgZW51bSBwb3J0IHBvcnQpCj4gPiAtewo+ID4gLQlpZiAo
SU5URUxfR0VOKGRldl9wcml2KSA+PSA5KQo+ID4gLQkJcmV0dXJuIERQX0FVWF9DSF9DVEwocG9y
dCk7Cj4gPiAtCWVsc2UKPiA+IC0JCXJldHVybiBFRFBfUFNSX0FVWF9DVEw7Cj4gPiAtfQo+ID4g
LQo+ID4gLXN0YXRpYyBpOTE1X3JlZ190IHBzcl9hdXhfZGF0YV9yZWcoc3RydWN0IGRybV9pOTE1
X3ByaXZhdGUKPiA+ICpkZXZfcHJpdiwKPiA+IC0JCQkJCWVudW0gcG9ydCBwb3J0LCBpbnQgaW5k
ZXgpCj4gPiAtewo+ID4gLQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KQo+ID4gLQkJcmV0
dXJuIERQX0FVWF9DSF9EQVRBKHBvcnQsIGluZGV4KTsKPiA+IC0JZWxzZQo+ID4gLQkJcmV0dXJu
IEVEUF9QU1JfQVVYX0RBVEEoaW5kZXgpOwo+ID4gLX0KPiA+IC0KPiA+ICBzdGF0aWMgdm9pZCBo
c3dfcHNyX3NldHVwX2F1eChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ID4gIHsKPiA+ICAJ
c3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQgPQo+ID4gZHBfdG9fZGlnX3BvcnQo
aW50ZWxfZHApOwo+ID4gLQlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gZGlnX3BvcnQtPmJhc2Uu
YmFzZS5kZXY7Cj4gPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5
MTUoZGV2KTsKPiA+IC0JdWludDMyX3QgYXV4X2Nsb2NrX2RpdmlkZXI7Cj4gPiAtCWk5MTVfcmVn
X3QgYXV4X2N0bF9yZWc7Cj4gPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9
IHRvX2k5MTUoZGlnX3BvcnQtCj4gPiA+YmFzZS5iYXNlLmRldik7Cj4gPiArCXUzMiBhdXhfY2xv
Y2tfZGl2aWRlciwgYXV4X2N0bDsKPiA+ICsJaW50IGk7Cj4gPiAgCXN0YXRpYyBjb25zdCB1aW50
OF90IGF1eF9tc2dbXSA9IHsKPiA+ICAJCVswXSA9IERQX0FVWF9OQVRJVkVfV1JJVEUgPDwgNCwK
PiA+ICAJCVsxXSA9IERQX1NFVF9QT1dFUiA+PiA4LAo+ID4gQEAgLTI2MCwyMyArMjQxLDI1IEBA
IHN0YXRpYyB2b2lkIGhzd19wc3Jfc2V0dXBfYXV4KHN0cnVjdCBpbnRlbF9kcAo+ID4gKmludGVs
X2RwKQo+ID4gIAkJWzNdID0gMSAtIDEsCj4gPiAgCQlbNF0gPSBEUF9TRVRfUE9XRVJfRDAsCj4g
PiAgCX07Cj4gPiAtCWVudW0gcG9ydCBwb3J0ID0gZGlnX3BvcnQtPmJhc2UucG9ydDsKPiA+IC0J
dTMyIGF1eF9jdGw7Cj4gPiAtCWludCBpOwo+ID4gKwl1MzIgcHNyX2F1eF9tYXNrID0gRURQX1BT
Ul9BVVhfQ1RMX1RJTUVfT1VUX01BU0sgfAo+ID4gKwkJCSAgIEVEUF9QU1JfQVVYX0NUTF9NRVNT
QUdFX1NJWkVfTUFTSyB8Cj4gPiArCQkJICAgRURQX1BTUl9BVVhfQ1RMX1BSRUNIQVJHRV8yVVNf
TUFTSyB8Cj4gPiArCQkJICAgRURQX1BTUl9BVVhfQ1RMX0JJVF9DTE9DS18yWF9NQVNLOwo+ID4g
IAo+ID4gIAlCVUlMRF9CVUdfT04oc2l6ZW9mKGF1eF9tc2cpID4gMjApOwo+ID4gLQo+ID4gLQlh
dXhfY2xvY2tfZGl2aWRlciA9IGludGVsX2RwLQo+ID4gPmdldF9hdXhfY2xvY2tfZGl2aWRlcihp
bnRlbF9kcCwgMCk7Cj4gPiAtCWF1eF9jdGxfcmVnID0gcHNyX2F1eF9jdGxfcmVnKGRldl9wcml2
LCBwb3J0KTsKPiA+IC0KPiA+IC0JLyogU2V0dXAgQVVYIHJlZ2lzdGVycyAqLwo+ID4gIAlmb3Ig
KGkgPSAwOyBpIDwgc2l6ZW9mKGF1eF9tc2cpOyBpICs9IDQpCj4gPiAtCQlJOTE1X1dSSVRFKHBz
cl9hdXhfZGF0YV9yZWcoZGV2X3ByaXYsIHBvcnQsIGkgPj4gMiksCj4gPiArCQlJOTE1X1dSSVRF
KEVEUF9QU1JfQVVYX0RBVEEoaSA+PiAyKSwKPiA+ICAJCQkgICBpbnRlbF9kcF9wYWNrX2F1eCgm
YXV4X21zZ1tpXSwKPiA+IHNpemVvZihhdXhfbXNnKSAtIGkpKTsKPiA+ICAKPiA+ICsJYXV4X2Ns
b2NrX2RpdmlkZXIgPSBpbnRlbF9kcC0KPiA+ID5nZXRfYXV4X2Nsb2NrX2RpdmlkZXIoaW50ZWxf
ZHAsIDApOwo+ID4gKwo+ID4gKwkvKiBTdGFydCB3aXRoIGJpdHMgc2V0IGZvciBERElfQVVYX0NU
TCByZWdpc3RlciAqLwo+ID4gIAlhdXhfY3RsID0gaW50ZWxfZHAtPmdldF9hdXhfc2VuZF9jdGwo
aW50ZWxfZHAsIDAsCj4gPiBzaXplb2YoYXV4X21zZyksCj4gPiAgCQkJCQkgICAgIGF1eF9jbG9j
a19kaXZpZGVyKTsKPiA+IC0JSTkxNV9XUklURShhdXhfY3RsX3JlZywgYXV4X2N0bCk7Cj4gPiAr
Cj4gPiArCS8qIFNlbGVjdCBvbmx5IHZhbGlkIGJpdHMgZm9yIFNSRF9BVVhfQ1RMICovCj4gPiAr
CWF1eF9jdGwgJj0gcHNyX2F1eF9tYXNrOwo+ID4gKwlJOTE1X1dSSVRFKEVEUF9QU1JfQVVYX0NU
TCwgYXV4X2N0bCk7Cj4gPiAgfQo+ID4gIAo+ID4gIHN0YXRpYyB2b2lkIGhzd19wc3JfZW5hYmxl
X3Npbmsoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiA+IEBAIC0zMDMsNyArMjg2LDcgQEAg
c3RhdGljIHZvaWQgaHN3X3Bzcl9lbmFibGVfc2luayhzdHJ1Y3QgaW50ZWxfZHAKPiA+ICppbnRl
bF9kcCkKPiA+ICAJCWRybV9kcF9kcGNkX3dyaXRlYigmaW50ZWxfZHAtPmF1eCwgRFBfUFNSX0VO
X0NGRywKPiA+ICAJCQkJICAgRFBfUFNSX0VOQUJMRSk7Cj4gPiAgCj4gPiAtCWhzd19wc3Jfc2V0
dXBfYXV4KGludGVsX2RwKTsKPiA+ICsJZHJtX2RwX2RwY2Rfd3JpdGViKCZpbnRlbF9kcC0+YXV4
LCBEUF9TRVRfUE9XRVIsCj4gPiBEUF9TRVRfUE9XRVJfRDApOwo+ID4gIH0KPiA+ICAKPiA+ICBz
dGF0aWMgdm9pZCB2bHZfcHNyX2VuYWJsZV9zb3VyY2Uoc3RydWN0IGludGVsX2RwICppbnRlbF9k
cCwKPiA+IEBAIC01OTksNiArNTgyLDEyIEBAIHN0YXRpYyB2b2lkIGhzd19wc3JfZW5hYmxlX3Nv
dXJjZShzdHJ1Y3QKPiA+IGludGVsX2RwICppbnRlbF9kcCwKPiA+ICAKPiA+ICAJcHNyX2F1eF9p
b19wb3dlcl9nZXQoaW50ZWxfZHApOwo+ID4gIAo+ID4gKwkvKiBPbmx5IEhTVyBhbmQgQkRXIGhh
dmUgUFNSIEFVWCByZWdpc3RlcnMgdGhhdCBuZWVkIHRvIGJlCj4gPiBzZXR1cC4gU0tMKwo+ID4g
KwkgKiB1c2UgaGFyZGNvZGVkIHZhbHVlcyBQU1IgQVVYIHRyYW5zYWN0aW9ucwo+ID4gKwkgKi8K
PiA+ICsJaWYgKElTX0hBU1dFTEwoZGV2X3ByaXYpIHx8IElTX0JST0FEV0VMTChkZXZfcHJpdikp
Cj4gPiArCQloc3dfcHNyX3NldHVwX2F1eChpbnRlbF9kcCk7Cj4gPiArCj4gPiAgCWlmIChkZXZf
cHJpdi0+cHNyLnBzcjJfc3VwcG9ydCkgewo+ID4gIAkJY2hpY2tlbiA9IFBTUjJfVlNDX0VOQUJM
RV9QUk9HX0hFQURFUjsKPiA+ICAJCWlmIChkZXZfcHJpdi0+cHNyLnlfY29yZF9zdXBwb3J0KQo+
IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwt
Z2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRw
czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp
bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m
cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK