From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH 02/11] drm/i915/psr: Move PSR exit specific code to hardware specific function Date: Mon, 2 Apr 2018 11:09:17 -0700 Message-ID: <20180402180917.GO2338@intel.com> References: <20180330222336.5262-1-jose.souza@intel.com> <20180330222336.5262-2-jose.souza@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 59E986E082 for ; Mon, 2 Apr 2018 18:09:18 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180330222336.5262-2-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXIgMzAsIDIwMTggYXQgMDM6MjM6MjdQTSAtMDcwMCwgSm9zw6kgUm9iZXJ0byBk ZSBTb3V6YSB3cm90ZToKPiBUbyBwcm9wZXIgZXhlY3V0ZSBQU1IgZXhpdCBpdCB3YXMgdXNpbmcg J2lmIChIQVNfRERJKGRldl9wcml2KSknIHRvCj4gZGlmZmVyZW50aWF0ZSBiZXR3ZWVuIFZMVi9D SFYgYW5kIEhTVysgaGFyZHdhcmUsIHNvIGhlcmUgbW92aW5nIGVhY2gKPiBoYXJkd2FyZSBoYW5k bGluZyB0byBoaXMgb3duIGZ1bmN0aW9uLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEpvc8OpIFJvYmVy dG8gZGUgU291emEgPGpvc2Uuc291emFAaW50ZWwuY29tPgo+IENjOiBEaGluYWthcmFuIFBhbmRp eWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KPiBDYzogUm9kcmlnbyBWaXZpIDxy b2RyaWdvLnZpdmlAaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmln by52aXZpQGludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2 LmggIHwgIDEgKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyB8IDk0ICsrKysr KysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCA1 NiBpbnNlcnRpb25zKCspLCAzOSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2 LmgKPiBpbmRleCA1MzczYjE3MWJiOTYuLmE4ZDMwMDI4MGEyYyAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9kcnYuaAo+IEBAIC02MTcsNiArNjE3LDcgQEAgc3RydWN0IGk5MTVfcHNyIHsKPiAgCXZv aWQgKCplbmFibGVfc2luaykoc3RydWN0IGludGVsX2RwICopOwo+ICAJdm9pZCAoKmFjdGl2YXRl KShzdHJ1Y3QgaW50ZWxfZHAgKik7Cj4gIAl2b2lkICgqc2V0dXBfdnNjKShzdHJ1Y3QgaW50ZWxf ZHAgKiwgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKik7Cj4gKwl2b2lkICgqZXhpdCko c3RydWN0IGludGVsX2RwICppbnRlbF9kcCk7Cj4gIH07Cj4gIAo+ICBlbnVtIGludGVsX3BjaCB7 Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiBpbmRleCBmYzdjMzZlZmQ0MDEuLmJjYWFjOWU2 OWY4YyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gQEAgLTgzOCw1MyArODM4LDY3 IEBAIHN0YXRpYyB2b2lkIGludGVsX3Bzcl93b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykK PiAgCW11dGV4X3VubG9jaygmZGV2X3ByaXYtPnBzci5sb2NrKTsKPiAgfQo+ICAKPiAtc3RhdGlj IHZvaWQgaW50ZWxfcHNyX2V4aXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ ICtzdGF0aWMgdm9pZCBoc3dfcHNyX2V4aXQoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAg ewo+IC0Jc3RydWN0IGludGVsX2RwICppbnRlbF9kcCA9IGRldl9wcml2LT5wc3IuZW5hYmxlZDsK PiAtCXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9IGRwX3RvX2RpZ19wb3J0KGludGVsX2RwKS0+YmFz ZS5iYXNlLmNydGM7Cj4gKwlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpkaWdfcG9ydCA9IGRw X3RvX2RpZ19wb3J0KGludGVsX2RwKTsKPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBkaWdf cG9ydC0+YmFzZS5iYXNlLmRldjsKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diA9IHRvX2k5MTUoZGV2KTsKPiArCXUzMiB2YWw7Cj4gKwo+ICsJaWYgKGRldl9wcml2LT5wc3Iu cHNyMl9lbmFibGVkKSB7Cj4gKwkJdmFsID0gSTkxNV9SRUFEKEVEUF9QU1IyX0NUTCk7Cj4gKwkJ V0FSTl9PTighKHZhbCAmIEVEUF9QU1IyX0VOQUJMRSkpOwo+ICsJCUk5MTVfV1JJVEUoRURQX1BT UjJfQ1RMLCB2YWwgJiB+RURQX1BTUjJfRU5BQkxFKTsKPiArCX0gZWxzZSB7Cj4gKwkJdmFsID0g STkxNV9SRUFEKEVEUF9QU1JfQ1RMKTsKPiArCQlXQVJOX09OKCEodmFsICYgRURQX1BTUl9FTkFC TEUpKTsKPiArCQlJOTE1X1dSSVRFKEVEUF9QU1JfQ1RMLCB2YWwgJiB+RURQX1BTUl9FTkFCTEUp Owo+ICsJfQo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCB2bHZfcHNyX2V4aXQoc3RydWN0IGludGVs X2RwICppbnRlbF9kcCkKPiArewo+ICsJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3Bv cnQgPSBkcF90b19kaWdfcG9ydChpbnRlbF9kcCk7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 ID0gZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXY7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4gKwlzdHJ1Y3QgZHJtX2NydGMgKmNydGMgPSBkaWdf cG9ydC0+YmFzZS5iYXNlLmNydGM7Cj4gIAllbnVtIHBpcGUgcGlwZSA9IHRvX2ludGVsX2NydGMo Y3J0YyktPnBpcGU7Cj4gIAl1MzIgdmFsOwo+ICAKPiAtCWlmICghZGV2X3ByaXYtPnBzci5hY3Rp dmUpCj4gLQkJcmV0dXJuOwo+ICsJdmFsID0gSTkxNV9SRUFEKFZMVl9QU1JDVEwocGlwZSkpOwo+ ICAKPiAtCWlmIChIQVNfRERJKGRldl9wcml2KSkgewo+IC0JCWlmIChkZXZfcHJpdi0+cHNyLnBz cjJfZW5hYmxlZCkgewo+IC0JCQl2YWwgPSBJOTE1X1JFQUQoRURQX1BTUjJfQ1RMKTsKPiAtCQkJ V0FSTl9PTighKHZhbCAmIEVEUF9QU1IyX0VOQUJMRSkpOwo+IC0JCQlJOTE1X1dSSVRFKEVEUF9Q U1IyX0NUTCwgdmFsICYgfkVEUF9QU1IyX0VOQUJMRSk7Cj4gLQkJfSBlbHNlIHsKPiAtCQkJdmFs ID0gSTkxNV9SRUFEKEVEUF9QU1JfQ1RMKTsKPiAtCQkJV0FSTl9PTighKHZhbCAmIEVEUF9QU1Jf RU5BQkxFKSk7Cj4gLQkJCUk5MTVfV1JJVEUoRURQX1BTUl9DVEwsIHZhbCAmIH5FRFBfUFNSX0VO QUJMRSk7Cj4gLQkJfQo+IC0JfSBlbHNlIHsKPiAtCQl2YWwgPSBJOTE1X1JFQUQoVkxWX1BTUkNU TChwaXBlKSk7Cj4gKwkvKgo+ICsJICogSGVyZSB3ZSBkbyB0aGUgdHJhbnNpdGlvbiBkcmlyZWN0 bHkgZnJvbQo+ICsJICogUFNSX3N0YXRlIDMgKGFjdGl2ZSAtIG5vIFJlbW90ZSBGcmFtZSBCdWZm ZXIgKFJGQikgdXBkYXRlKSB0bwo+ICsJICogUFNSX3N0YXRlIDUgKGV4aXQpLgo+ICsJICogUFNS IFN0YXRlIDQgKGFjdGl2ZSB3aXRoIHNpbmdsZSBmcmFtZSB1cGRhdGUpIGNhbiBiZSBza2lwcGVk Lgo+ICsJICogT24gUFNSX3N0YXRlIDUgKGV4aXQpIEhhcmR3YXJlIGlzIHJlc3BvbnNpYmxlIHRv IHRyYW5zaXRpb24KPiArCSAqIGJhY2sgdG8gUFNSX3N0YXRlIDEgKGluYWN0aXZlKS4KPiArCSAq IE5vdyB3ZSBhcmUgYXQgU2FtZSBzdGF0ZSBhZnRlciB2bHZfcHNyX2VuYWJsZV9zb3VyY2UuCj4g KwkgKi8KPiArCXZhbCAmPSB+VkxWX0VEUF9QU1JfQUNUSVZFX0VOVFJZOwo+ICsJSTkxNV9XUklU RShWTFZfUFNSQ1RMKHBpcGUpLCB2YWwpOwo+ICAKPiAtCQkvKgo+IC0JCSAqIEhlcmUgd2UgZG8g dGhlIHRyYW5zaXRpb24gZHJpcmVjdGx5IGZyb20KPiAtCQkgKiBQU1Jfc3RhdGUgMyAoYWN0aXZl IC0gbm8gUmVtb3RlIEZyYW1lIEJ1ZmZlciAoUkZCKSB1cGRhdGUpIHRvCj4gLQkJICogUFNSX3N0 YXRlIDUgKGV4aXQpLgo+IC0JCSAqIFBTUiBTdGF0ZSA0IChhY3RpdmUgd2l0aCBzaW5nbGUgZnJh bWUgdXBkYXRlKSBjYW4gYmUgc2tpcHBlZC4KPiAtCQkgKiBPbiBQU1Jfc3RhdGUgNSAoZXhpdCkg SGFyZHdhcmUgaXMgcmVzcG9uc2libGUgdG8gdHJhbnNpdGlvbgo+IC0JCSAqIGJhY2sgdG8gUFNS X3N0YXRlIDEgKGluYWN0aXZlKS4KPiAtCQkgKiBOb3cgd2UgYXJlIGF0IFNhbWUgc3RhdGUgYWZ0 ZXIgdmx2X3Bzcl9lbmFibGVfc291cmNlLgo+IC0JCSAqLwo+IC0JCXZhbCAmPSB+VkxWX0VEUF9Q U1JfQUNUSVZFX0VOVFJZOwo+IC0JCUk5MTVfV1JJVEUoVkxWX1BTUkNUTChwaXBlKSwgdmFsKTsK PiArCS8qCj4gKwkgKiBTZW5kIEFVWCB3YWtlIHVwIC0gU3BlYyBzYXlzIGFmdGVyIHRyYW5zaXRp b25pbmcgdG8gUFNSCj4gKwkgKiBhY3RpdmUgd2UgaGF2ZSB0byBzZW5kIEFVWCB3YWtlIHVwIGJ5 IHdyaXRpbmcgMDFoIGluIERQQ0QKPiArCSAqIDYwMGggb2Ygc2luayBkZXZpY2UuCj4gKwkgKiBY WFg6IFRoaXMgbWlnaHQgc2xvdyBkb3duIHRoZSB0cmFuc2l0aW9uLCBidXQgd2l0aG91dCB0aGlz Cj4gKwkgKiBIVyBkb2Vzbid0IGNvbXBsZXRlIHRoZSB0cmFuc2l0aW9uIHRvIFBTUl9zdGF0ZSAx IGFuZCB3ZQo+ICsJICogbmV2ZXIgZ2V0IHRoZSBzY3JlZW4gdXBkYXRlZC4KPiArCSAqLwo+ICsJ ZHJtX2RwX2RwY2Rfd3JpdGViKCZpbnRlbF9kcC0+YXV4LCBEUF9TRVRfUE9XRVIsCj4gKwkJCSAg IERQX1NFVF9QT1dFUl9EMCk7Cj4gK30KPiAgCj4gLQkJLyoKPiAtCQkgKiBTZW5kIEFVWCB3YWtl IHVwIC0gU3BlYyBzYXlzIGFmdGVyIHRyYW5zaXRpb25pbmcgdG8gUFNSCj4gLQkJICogYWN0aXZl IHdlIGhhdmUgdG8gc2VuZCBBVVggd2FrZSB1cCBieSB3cml0aW5nIDAxaCBpbiBEUENECj4gLQkJ ICogNjAwaCBvZiBzaW5rIGRldmljZS4KPiAtCQkgKiBYWFg6IFRoaXMgbWlnaHQgc2xvdyBkb3du IHRoZSB0cmFuc2l0aW9uLCBidXQgd2l0aG91dCB0aGlzCj4gLQkJICogSFcgZG9lc24ndCBjb21w bGV0ZSB0aGUgdHJhbnNpdGlvbiB0byBQU1Jfc3RhdGUgMSBhbmQgd2UKPiAtCQkgKiBuZXZlciBn ZXQgdGhlIHNjcmVlbiB1cGRhdGVkLgo+IC0JCSAqLwo+IC0JCWRybV9kcF9kcGNkX3dyaXRlYigm aW50ZWxfZHAtPmF1eCwgRFBfU0VUX1BPV0VSLAo+IC0JCQkJICAgRFBfU0VUX1BPV0VSX0QwKTsK PiAtCX0KPiArc3RhdGljIHZvaWQgaW50ZWxfcHNyX2V4aXQoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2KQo+ICt7Cj4gKwlzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwID0gZGV2X3By aXYtPnBzci5lbmFibGVkOwo+ICsKPiArCWlmICghZGV2X3ByaXYtPnBzci5hY3RpdmUpCj4gKwkJ cmV0dXJuOwo+ICAKPiArCWRldl9wcml2LT5wc3IuZXhpdChpbnRlbF9kcCk7Cj4gIAlkZXZfcHJp di0+cHNyLmFjdGl2ZSA9IGZhbHNlOwo+ICB9Cj4gIAo+IEBAIC0xMDk0LDYgKzExMDgsNyBAQCB2 b2lkIGludGVsX3Bzcl9pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAg CQlkZXZfcHJpdi0+cHNyLmVuYWJsZV9zaW5rID0gdmx2X3Bzcl9lbmFibGVfc2luazsKPiAgCQlk ZXZfcHJpdi0+cHNyLmFjdGl2YXRlID0gdmx2X3Bzcl9hY3RpdmF0ZTsKPiAgCQlkZXZfcHJpdi0+ cHNyLnNldHVwX3ZzYyA9IHZsdl9wc3Jfc2V0dXBfdnNjOwo+ICsJCWRldl9wcml2LT5wc3IuZXhp dCA9IHZsdl9wc3JfZXhpdDsKPiAgCX0gZWxzZSB7Cj4gIAkJZGV2X3ByaXYtPnBzci5oYXNfaHdf dHJhY2tpbmcgPSB0cnVlOwo+ICAJCWRldl9wcml2LT5wc3IuZW5hYmxlX3NvdXJjZSA9IGhzd19w c3JfZW5hYmxlX3NvdXJjZTsKPiBAQCAtMTEwMSw1ICsxMTE2LDYgQEAgdm9pZCBpbnRlbF9wc3Jf aW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAkJZGV2X3ByaXYtPnBz ci5lbmFibGVfc2luayA9IGhzd19wc3JfZW5hYmxlX3Npbms7Cj4gIAkJZGV2X3ByaXYtPnBzci5h Y3RpdmF0ZSA9IGhzd19wc3JfYWN0aXZhdGU7Cj4gIAkJZGV2X3ByaXYtPnBzci5zZXR1cF92c2Mg PSBoc3dfcHNyX3NldHVwX3ZzYzsKPiArCQlkZXZfcHJpdi0+cHNyLmV4aXQgPSBoc3dfcHNyX2V4 aXQ7Cj4gIAl9Cj4gIH0KPiAtLSAKPiAyLjE2LjMKPiAKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==