From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 03/11] drm/i915/psr: Share code between
 disable and exit
Date: Mon, 2 Apr 2018 11:11:13 -0700
Message-ID: <20180402181113.GP2338@intel.com>
References: <20180330222336.5262-1-jose.souza@intel.com>
 <20180330222336.5262-3-jose.souza@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 7EAD56E082
 for <intel-gfx@lists.freedesktop.org>; Mon,  2 Apr 2018 18:11:14 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20180330222336.5262-3-jose.souza@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBNYXIgMzAsIDIwMTggYXQgMDM6MjM6MjhQTSAtMDcwMCwgSm9zw6kgUm9iZXJ0byBk
ZSBTb3V6YSB3cm90ZToKPiBUaGUgZGlzYWJsZSBhbmQgZXhpdCBzZXF1ZW5jZSBhcmUgdmVyeSBz
aW1pbGFyIHdpdGggYSBsb3QgY29tbW9uCj4gY29kZSBiZXR3ZWVuIGJvdGgsIHNvIGhlcmUgc2hh
cmluZyB0aGUgY29kZS4KCkkgZG9uJ3QgYmVsaWV2ZSB0aGF0IHdlIHNob3VsZCBkbyB0aGlzLgpE
aXNhYmxlIGFzIGlzIGhhcyBzb21lIGV4dHJhIHdhaXQvdGltZW91dHMgdGhhdCBjb3VsZCBzbG93
IHRoaW5ncyBkb3duLgoKT3IgYXQgbGVhc3Qgbm90IGRvIHRoaXMgd2hpbGUgd2UgZG9uJ3QgaGF2
ZSBhIHByb3BlciByb2J1dHMgdGVzdCBpbiBwbGFjZQphbmQgdG8gdGVzdCBhbHNvIHBlcmZvcm1h
bmNlIGltcGFjdHMuLi4KCj4gCj4gU2lnbmVkLW9mZi1ieTogSm9zw6kgUm9iZXJ0byBkZSBTb3V6
YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+Cj4gQ2M6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5h
a2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgo+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2
aUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggIHwg
IDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMgfCA4NCArKysrKysrKysr
KysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgMzggaW5z
ZXJ0aW9ucygrKSwgNDggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4g
aW5kZXggYThkMzAwMjgwYTJjLi5jYjcyZWUyNzQyMmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf
ZHJ2LmgKPiBAQCAtNjE3LDcgKzYxNyw3IEBAIHN0cnVjdCBpOTE1X3BzciB7Cj4gIAl2b2lkICgq
ZW5hYmxlX3NpbmspKHN0cnVjdCBpbnRlbF9kcCAqKTsKPiAgCXZvaWQgKCphY3RpdmF0ZSkoc3Ry
dWN0IGludGVsX2RwICopOwo+ICAJdm9pZCAoKnNldHVwX3ZzYykoc3RydWN0IGludGVsX2RwICos
IGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICopOwo+IC0Jdm9pZCAoKmV4aXQpKHN0cnVj
dCBpbnRlbF9kcCAqaW50ZWxfZHApOwo+ICsJdm9pZCAoKmV4aXQpKHN0cnVjdCBpbnRlbF9kcCAq
aW50ZWxfZHAsIGJvb2wgZGlzYWJsaW5nKTsKPiAgfTsKPiAgCj4gIGVudW0gaW50ZWxfcGNoIHsK
PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMgYi9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+IGluZGV4IGJjYWFjOWU2OWY4Yy4uZDM0NTFhZmVi
OGJiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gKysr
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiBAQCAtNjcyLDIzICs2NzIsOSBA
QCBzdGF0aWMgdm9pZCB2bHZfcHNyX2Rpc2FibGUoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwK
PiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9kaWdfcG9ydC0+YmFzZS5iYXNlLmRl
djsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsK
PiAgCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0gdG9faW50ZWxfY3J0YyhvbGRfY3J0Y19zdGF0
ZS0+YmFzZS5jcnRjKTsKPiAtCXVpbnQzMl90IHZhbDsKPiAgCj4gIAlpZiAoZGV2X3ByaXYtPnBz
ci5hY3RpdmUpIHsKPiAtCQkvKiBQdXQgVkxWIFBTUiBiYWNrIHRvIFBTUl9zdGF0ZSAwIChkaXNh
YmxlZCkuICovCj4gLQkJaWYgKGludGVsX3dhaXRfZm9yX3JlZ2lzdGVyKGRldl9wcml2LAo+IC0J
CQkJCSAgICBWTFZfUFNSU1RBVChjcnRjLT5waXBlKSwKPiAtCQkJCQkgICAgVkxWX0VEUF9QU1Jf
SU5fVFJBTlMsCj4gLQkJCQkJICAgIDAsCj4gLQkJCQkJICAgIDEpKQo+IC0JCQlXQVJOKDEsICJQ
U1IgdHJhbnNpdGlvbiB0b29rIGxvbmdlciB0aGFuIGV4cGVjdGVkXG4iKTsKPiAtCj4gLQkJdmFs
ID0gSTkxNV9SRUFEKFZMVl9QU1JDVEwoY3J0Yy0+cGlwZSkpOwo+IC0JCXZhbCAmPSB+VkxWX0VE
UF9QU1JfQUNUSVZFX0VOVFJZOwo+IC0JCXZhbCAmPSB+VkxWX0VEUF9QU1JfRU5BQkxFOwo+IC0J
CXZhbCAmPSB+VkxWX0VEUF9QU1JfTU9ERV9NQVNLOwo+IC0JCUk5MTVfV1JJVEUoVkxWX1BTUkNU
TChjcnRjLT5waXBlKSwgdmFsKTsKPiAtCj4gKwkJZGV2X3ByaXYtPnBzci5leGl0KGludGVsX2Rw
LCB0cnVlKTsKPiAgCQlkZXZfcHJpdi0+cHNyLmFjdGl2ZSA9IGZhbHNlOwo+ICAJfSBlbHNlIHsK
PiAgCQlXQVJOX09OKHZsdl9pc19wc3JfYWN0aXZlX29uX3BpcGUoZGV2LCBjcnRjLT5waXBlKSk7
Cj4gQEAgLTcwMywzMSArNjg5LDcgQEAgc3RhdGljIHZvaWQgaHN3X3Bzcl9kaXNhYmxlKHN0cnVj
dCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By
aXYgPSB0b19pOTE1KGRldik7Cj4gIAo+ICAJaWYgKGRldl9wcml2LT5wc3IuYWN0aXZlKSB7Cj4g
LQkJaTkxNV9yZWdfdCBwc3Jfc3RhdHVzOwo+IC0JCXUzMiBwc3Jfc3RhdHVzX21hc2s7Cj4gLQo+
IC0JCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfZW5hYmxlZCkgewo+IC0JCQlwc3Jfc3RhdHVzID0g
RURQX1BTUjJfU1RBVFVTOwo+IC0JCQlwc3Jfc3RhdHVzX21hc2sgPSBFRFBfUFNSMl9TVEFUVVNf
U1RBVEVfTUFTSzsKPiAtCj4gLQkJCUk5MTVfV1JJVEUoRURQX1BTUjJfQ1RMLAo+IC0JCQkJICAg
STkxNV9SRUFEKEVEUF9QU1IyX0NUTCkgJgo+IC0JCQkJICAgfihFRFBfUFNSMl9FTkFCTEUgfCBF
RFBfU1VfVFJBQ0tfRU5BQkxFKSk7Cj4gLQo+IC0JCX0gZWxzZSB7Cj4gLQkJCXBzcl9zdGF0dXMg
PSBFRFBfUFNSX1NUQVRVUzsKPiAtCQkJcHNyX3N0YXR1c19tYXNrID0gRURQX1BTUl9TVEFUVVNf
U1RBVEVfTUFTSzsKPiAtCj4gLQkJCUk5MTVfV1JJVEUoRURQX1BTUl9DVEwsCj4gLQkJCQkgICBJ
OTE1X1JFQUQoRURQX1BTUl9DVEwpICYgfkVEUF9QU1JfRU5BQkxFKTsKPiAtCQl9Cj4gLQo+IC0J
CS8qIFdhaXQgdGlsbCBQU1IgaXMgaWRsZSAqLwo+IC0JCWlmIChpbnRlbF93YWl0X2Zvcl9yZWdp
c3RlcihkZXZfcHJpdiwKPiAtCQkJCQkgICAgcHNyX3N0YXR1cywgcHNyX3N0YXR1c19tYXNrLCAw
LAo+IC0JCQkJCSAgICAyMDAwKSkKPiAtCQkJRFJNX0VSUk9SKCJUaW1lZCBvdXQgd2FpdGluZyBm
b3IgUFNSIElkbGUgU3RhdGVcbiIpOwo+IC0KPiArCQlkZXZfcHJpdi0+cHNyLmV4aXQoaW50ZWxf
ZHAsIHRydWUpOwo+ICAJCWRldl9wcml2LT5wc3IuYWN0aXZlID0gZmFsc2U7Cj4gIAl9IGVsc2Ug
ewo+ICAJCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfZW5hYmxlZCkKPiBAQCAtODM4LDI1ICs4MDAs
NDEgQEAgc3RhdGljIHZvaWQgaW50ZWxfcHNyX3dvcmsoc3RydWN0IHdvcmtfc3RydWN0ICp3b3Jr
KQo+ICAJbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+cHNyLmxvY2spOwo+ICB9Cj4gIAo+IC1zdGF0
aWMgdm9pZCBoc3dfcHNyX2V4aXQoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiArc3RhdGlj
IHZvaWQgaHN3X3Bzcl9leGl0KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIGJvb2wgZGlzYWJs
aW5nKQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpkaWdfcG9ydCA9IGRwX3Rv
X2RpZ19wb3J0KGludGVsX2RwKTsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBkaWdfcG9y
dC0+YmFzZS5iYXNlLmRldjsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9
IHRvX2k5MTUoZGV2KTsKPiArCWk5MTVfcmVnX3QgcHNyX3N0YXR1czsKPiArCXUzMiBwc3Jfc3Rh
dHVzX21hc2s7Cj4gIAl1MzIgdmFsOwo+ICAKPiAgCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfZW5h
YmxlZCkgewo+ICsJCXBzcl9zdGF0dXMgPSBFRFBfUFNSMl9TVEFUVVM7Cj4gKwkJcHNyX3N0YXR1
c19tYXNrID0gRURQX1BTUjJfU1RBVFVTX1NUQVRFX01BU0s7Cj4gKwo+ICAJCXZhbCA9IEk5MTVf
UkVBRChFRFBfUFNSMl9DVEwpOwo+IC0JCVdBUk5fT04oISh2YWwgJiBFRFBfUFNSMl9FTkFCTEUp
KTsKPiAtCQlJOTE1X1dSSVRFKEVEUF9QU1IyX0NUTCwgdmFsICYgfkVEUF9QU1IyX0VOQUJMRSk7
Cj4gKwkJV0FSTl9PTighZGlzYWJsaW5nICYmICEodmFsICYgRURQX1BTUjJfRU5BQkxFKSk7Cj4g
KwkJdmFsICY9IH5FRFBfUFNSMl9FTkFCTEU7Cj4gKwkJaWYgKGRpc2FibGluZykKPiArCQkJdmFs
ICY9IH5FRFBfU1VfVFJBQ0tfRU5BQkxFOwo+ICsJCUk5MTVfV1JJVEUoRURQX1BTUjJfQ1RMLCB2
YWwpOwo+ICAJfSBlbHNlIHsKPiArCQlwc3Jfc3RhdHVzID0gRURQX1BTUl9TVEFUVVM7Cj4gKwkJ
cHNyX3N0YXR1c19tYXNrID0gRURQX1BTUl9TVEFUVVNfU1RBVEVfTUFTSzsKPiArCj4gIAkJdmFs
ID0gSTkxNV9SRUFEKEVEUF9QU1JfQ1RMKTsKPiAtCQlXQVJOX09OKCEodmFsICYgRURQX1BTUl9F
TkFCTEUpKTsKPiArCQlXQVJOX09OKCFkaXNhYmxpbmcgJiYgISh2YWwgJiBFRFBfUFNSX0VOQUJM
RSkpOwo+ICAJCUk5MTVfV1JJVEUoRURQX1BTUl9DVEwsIHZhbCAmIH5FRFBfUFNSX0VOQUJMRSk7
Cj4gIAl9Cj4gKwo+ICsJLyogV2hlbiBkaXNhYmxpbmcgd2FpdCB0aWxsIFBTUiBpcyBpZGxlICov
Cj4gKwlpZiAoZGlzYWJsaW5nICYmIGludGVsX3dhaXRfZm9yX3JlZ2lzdGVyKGRldl9wcml2LCBw
c3Jfc3RhdHVzLAo+ICsJCQkJCQkgcHNyX3N0YXR1c19tYXNrLCAwLCAyMDAwKSkKPiArCQlEUk1f
RVJST1IoIlRpbWVkIG91dCB3YWl0aW5nIGZvciBQU1IgSWRsZSBTdGF0ZVxuIik7Cj4gIH0KPiAg
Cj4gLXN0YXRpYyB2b2lkIHZsdl9wc3JfZXhpdChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+
ICtzdGF0aWMgdm9pZCB2bHZfcHNyX2V4aXQoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgYm9v
bCBkaXNhYmxpbmcpCj4gIHsKPiAgCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0
ID0gZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApOwo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9
IGRpZ19wb3J0LT5iYXNlLmJhc2UuZGV2Owo+IEBAIC04NjUsMTAgKzg0MywxNCBAQCBzdGF0aWMg
dm9pZCB2bHZfcHNyX2V4aXQoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgCWVudW0gcGlw
ZSBwaXBlID0gdG9faW50ZWxfY3J0YyhjcnRjKS0+cGlwZTsKPiAgCXUzMiB2YWw7Cj4gIAo+ICsJ
aWYgKGRpc2FibGluZyAmJiBpbnRlbF93YWl0X2Zvcl9yZWdpc3RlcihkZXZfcHJpdiwgVkxWX1BT
UlNUQVQocGlwZSksCj4gKwkJCQkJCSBWTFZfRURQX1BTUl9JTl9UUkFOUywgMCwgMSkpCj4gKwkJ
RFJNX1dBUk4oIlBTUiB0cmFuc2l0aW9uIHRvb2sgbG9uZ2VyIHRoYW4gZXhwZWN0ZWRcbiIpOwo+
ICsKPiAgCXZhbCA9IEk5MTVfUkVBRChWTFZfUFNSQ1RMKHBpcGUpKTsKPiAgCj4gIAkvKgo+IC0J
ICogSGVyZSB3ZSBkbyB0aGUgdHJhbnNpdGlvbiBkcmlyZWN0bHkgZnJvbQo+ICsJICogSGVyZSB3
ZSBkbyB0aGUgdHJhbnNpdGlvbiBkaXJlY3RseSBmcm9tCj4gIAkgKiBQU1Jfc3RhdGUgMyAoYWN0
aXZlIC0gbm8gUmVtb3RlIEZyYW1lIEJ1ZmZlciAoUkZCKSB1cGRhdGUpIHRvCj4gIAkgKiBQU1Jf
c3RhdGUgNSAoZXhpdCkuCj4gIAkgKiBQU1IgU3RhdGUgNCAoYWN0aXZlIHdpdGggc2luZ2xlIGZy
YW1lIHVwZGF0ZSkgY2FuIGJlIHNraXBwZWQuCj4gQEAgLTg3Nyw4ICs4NTksMTYgQEAgc3RhdGlj
IHZvaWQgdmx2X3Bzcl9leGl0KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIAkgKiBOb3cg
d2UgYXJlIGF0IFNhbWUgc3RhdGUgYWZ0ZXIgdmx2X3Bzcl9lbmFibGVfc291cmNlLgo+ICAJICov
Cj4gIAl2YWwgJj0gflZMVl9FRFBfUFNSX0FDVElWRV9FTlRSWTsKPiArCWlmIChkaXNhYmxpbmcp
IHsKPiArCQkvKiBQdXQgVkxWIFBTUiBiYWNrIHRvIFBTUl9zdGF0ZSAwIChkaXNhYmxlZCkuICov
Cj4gKwkJdmFsICY9IH5WTFZfRURQX1BTUl9FTkFCTEU7Cj4gKwkJdmFsICY9IH5WTFZfRURQX1BT
Ul9NT0RFX01BU0s7Cj4gKwl9Cj4gIAlJOTE1X1dSSVRFKFZMVl9QU1JDVEwocGlwZSksIHZhbCk7
Cj4gIAo+ICsJaWYgKGRpc2FibGluZykKPiArCQlyZXR1cm47Cj4gKwo+ICAJLyoKPiAgCSAqIFNl
bmQgQVVYIHdha2UgdXAgLSBTcGVjIHNheXMgYWZ0ZXIgdHJhbnNpdGlvbmluZyB0byBQU1IKPiAg
CSAqIGFjdGl2ZSB3ZSBoYXZlIHRvIHNlbmQgQVVYIHdha2UgdXAgYnkgd3JpdGluZyAwMWggaW4g
RFBDRAo+IEBAIC04OTgsNyArODg4LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfcHNyX2V4aXQoc3Ry
dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJaWYgKCFkZXZfcHJpdi0+cHNyLmFj
dGl2ZSkKPiAgCQlyZXR1cm47Cj4gIAo+IC0JZGV2X3ByaXYtPnBzci5leGl0KGludGVsX2RwKTsK
PiArCWRldl9wcml2LT5wc3IuZXhpdChpbnRlbF9kcCwgZmFsc2UpOwo+ICAJZGV2X3ByaXYtPnBz
ci5hY3RpdmUgPSBmYWxzZTsKPiAgfQo+ICAKPiAtLSAKPiAyLjE2LjMKPiAKX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz
dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0
b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==