From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915/psr: Chase psr.enabled only under
 the psr.lock
Date: Fri, 6 Apr 2018 15:18:16 -0700
Message-ID: <20180406221816.GG8964@intel.com>
References: <20180405114915.29609-1-chris@chris-wilson.co.uk>
 <7e7b4336aefd6e6cf993150c1a83d214c161a210.camel@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id E30316EAE1
 for <intel-gfx@lists.freedesktop.org>; Fri,  6 Apr 2018 22:18:17 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <7e7b4336aefd6e6cf993150c1a83d214c161a210.camel@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: "Souza, Jose" <jose.souza@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "R,
 Durgadoss" <durgadoss.r@intel.com>, "stable@vger.kernel.org" <stable@vger.kernel.org>
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBBcHIgMDYsIDIwMTggYXQgMTE6MTI6MjdBTSAtMDcwMCwgU291emEsIEpvc2Ugd3Jv
dGU6Cj4gT24gVGh1LCAyMDE4LTA0LTA1IGF0IDEyOjQ5ICswMTAwLCBDaHJpcyBXaWxzb24gd3Jv
dGU6Cj4gPiBJbnNpZGUgdGhlIHBzciB3b3JrIGZ1bmN0aW9uLCB3ZSB3YW50IHRvIHdhaXQgZm9y
IFBTUiB0byBpZGxlIGZpcnN0Cj4gPiBhbmQKPiA+IHdpc2ggdG8gZG8gc28gd2l0aG91dCBibG9j
a2luZyB0aGUgbm9ybWFsIG1vZGVzZXQgcGF0aCwgc28gd2UgZG8gc28KPiA+IHdpdGhvdXQgaG9s
ZGluZyB0aGUgUFNSIGxvY2suIEhvd2V2ZXIsIHdlIGZpcnN0IGhhdmUgdG8gZmluZCB3aGljaAo+
ID4gcGlwZQo+ID4gUFNSIHdhcyBlbmFibGVkIG9uLCB3aGljaCByZXF1aXJlcyBjaGFzaW5nIGlu
dG8gdGhlIFBTUiBzdHJ1Y3QgYW5kCj4gPiByZXF1aXJlcyBsb2NraW5nIHRvIHByZXZlbnQgaW50
ZWxfcHNyX2Rpc2FibGUoKSBmcm9tIGNvbmN1cnJlbnRseQo+ID4gc2V0dGluZyBvdXIgcG9pbnRl
ciB0byBOVUxMLgo+ID4gCj4gPiBGaXhlczogOTk1ZDMwNDc3NDk2ICgiZHJtL2k5MTU6IFZMVi9D
SFYgUFNSIFNvZnR3YXJlIHRpbWVyIG1vZGUiKQo+ID4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2ls
c29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gPiBDYzogRHVyZ2Fkb3NzIFIgPGR1cmdh
ZG9zcy5yQGludGVsLmNvbT4KPiA+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRl
bC5jb20+Cj4gPiBDYzogPHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+ICMgdjQuMCsKPiAKPiBGZWVs
IGZyZWUgdG8gYWRkOgo+IFJldmlld2VkLWJ5OiBKb3NlIFJvYmVydG8gZGUgU291emEgPGpvc2Uu
c291emFAaW50ZWwuY29tPgo+IAo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfcHNyLmMgfCA4MiArKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0KPiA+IC0tLS0tLS0t
LS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKSwgMzggZGVsZXRpb25zKC0p
Cj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+
ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+ID4gaW5kZXggMmQ1M2Y3Mzk4
YTZkLi42OWE1YjI3NmY0ZDggMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9wc3IuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiA+
IEBAIC03NzUsNTMgKzc3NSw1OSBAQCB2b2lkIGludGVsX3Bzcl9kaXNhYmxlKHN0cnVjdCBpbnRl
bF9kcAo+ID4gKmludGVsX2RwLAo+ID4gIAljYW5jZWxfZGVsYXllZF93b3JrX3N5bmMoJmRldl9w
cml2LT5wc3Iud29yayk7Cj4gPiAgfQo+ID4gIAo+ID4gLXN0YXRpYyB2b2lkIGludGVsX3Bzcl93
b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKPiA+ICtzdGF0aWMgYm9vbCBwc3Jfd2FpdF9m
b3JfaWRsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAgewo+ID4gLQlz
dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPQo+ID4gLQkJY29udGFpbmVyX29mKHdv
cmssIHR5cGVvZigqZGV2X3ByaXYpLAo+ID4gcHNyLndvcmsud29yayk7Cj4gPiAtCXN0cnVjdCBp
bnRlbF9kcCAqaW50ZWxfZHAgPSBkZXZfcHJpdi0+cHNyLmVuYWJsZWQ7Cj4gPiAtCXN0cnVjdCBk
cm1fY3J0YyAqY3J0YyA9IGRwX3RvX2RpZ19wb3J0KGludGVsX2RwKS0KPiA+ID5iYXNlLmJhc2Uu
Y3J0YzsKPiA+IC0JZW51bSBwaXBlIHBpcGUgPSB0b19pbnRlbF9jcnRjKGNydGMpLT5waXBlOwo+
ID4gKwlzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwOwo+IAo+IG5pdHBpY2s6IFdoeSBub3QgYWxy
ZWFkeSBzZXQgaXQ/Cj4gc3RydWN0IGludGVsX2RwICppbnRlbF9kcCA9IGRldl9wcml2LT5wc3Iu
ZW5hYmxlZDsKPiAKPiAKPiA+ICsJaTkxNV9yZWdfdCByZWc7Cj4gPiArCXUzMiBtYXNrOwo+ID4g
KwlpbnQgZXJyOwo+ID4gKwo+ID4gKwlpbnRlbF9kcCA9IGRldl9wcml2LT5wc3IuZW5hYmxlZDsK
PiA+ICsJaWYgKCFpbnRlbF9kcCkKPiA+ICsJCXJldHVybiBmYWxzZTsKPiA+ICAKPiA+IC0JLyog
V2UgaGF2ZSB0byBtYWtlIHN1cmUgUFNSIGlzIHJlYWR5IGZvciByZS1lbmFibGUKPiA+IC0JICog
b3RoZXJ3aXNlIGl0IGtlZXBzIGRpc2FibGVkIHVudGlsIG5leHQgZnVsbAo+ID4gZW5hYmxlL2Rp
c2FibGUgY3ljbGUuCj4gPiAtCSAqIFBTUiBtaWdodCB0YWtlIHNvbWUgdGltZSB0byBnZXQgZnVs
bHkgZGlzYWJsZWQKPiA+IC0JICogYW5kIGJlIHJlYWR5IGZvciByZS1lbmFibGUuCj4gPiAtCSAq
Lwo+ID4gIAlpZiAoSEFTX0RESShkZXZfcHJpdikpIHsKPiAKPiAKPiBuaXRwaWNrOiBXaGlsZSBv
biB0aGF0IHlvdSBjb3VsZCByZXBsYWNlIHRoaXMgZm9yOgo+IAo+IGlmICghKElTX1ZBTExFWVZJ
RVcoZGV2X3ByaXYpIHx8IElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKSkgewo+IAo+ID4gIAkJaWYg
KGRldl9wcml2LT5wc3IucHNyMl9lbmFibGVkKSB7Cj4gPiAtCQkJaWYgKGludGVsX3dhaXRfZm9y
X3JlZ2lzdGVyKGRldl9wcml2LAo+ID4gLQkJCQkJCSAgICBFRFBfUFNSMl9TVEFUVVMsCj4gPiAt
CQkJCQkJICAgIEVEUF9QU1IyX1NUQVRVU18KPiA+IFNUQVRFX01BU0ssCj4gPiAtCQkJCQkJICAg
IDAsCj4gPiAtCQkJCQkJICAgIDUwKSkgewo+ID4gLQkJCQlEUk1fRVJST1IoIlRpbWVkIG91dCB3
YWl0aW5nIGZvcgo+ID4gUFNSMiBJZGxlIGZvciByZS1lbmFibGVcbiIpOwo+ID4gLQkJCQlyZXR1
cm47Cj4gPiAtCQkJfQo+ID4gKwkJCXJlZyA9IEVEUF9QU1IyX1NUQVRVUzsKPiA+ICsJCQltYXNr
ID0gRURQX1BTUjJfU1RBVFVTX1NUQVRFX01BU0s7Cj4gPiAgCQl9IGVsc2Ugewo+ID4gLQkJCWlm
IChpbnRlbF93YWl0X2Zvcl9yZWdpc3RlcihkZXZfcHJpdiwKPiA+IC0JCQkJCQkgICAgRURQX1BT
Ul9TVEFUVVMsCj4gPiAtCQkJCQkJICAgIEVEUF9QU1JfU1RBVFVTX1MKPiA+IFRBVEVfTUFTSywK
PiA+IC0JCQkJCQkgICAgMCwKPiA+IC0JCQkJCQkgICAgNTApKSB7Cj4gPiAtCQkJCURSTV9FUlJP
UigiVGltZWQgb3V0IHdhaXRpbmcgZm9yIFBTUgo+ID4gSWRsZSBmb3IgcmUtZW5hYmxlXG4iKTsK
PiA+IC0JCQkJcmV0dXJuOwo+ID4gLQkJCX0KPiA+ICsJCQlyZWcgPSBFRFBfUFNSX1NUQVRVUzsK
PiA+ICsJCQltYXNrID0gRURQX1BTUl9TVEFUVVNfU1RBVEVfTUFTSzsKPiA+ICAJCX0KPiA+ICAJ
fSBlbHNlIHsKPiA+IC0JCWlmIChpbnRlbF93YWl0X2Zvcl9yZWdpc3RlcihkZXZfcHJpdiwKPiA+
IC0JCQkJCSAgICBWTFZfUFNSU1RBVChwaXBlKSwKPiA+IC0JCQkJCSAgICBWTFZfRURQX1BTUl9J
Tl9UUkFOUywKPiA+IC0JCQkJCSAgICAwLAo+ID4gLQkJCQkJICAgIDEpKSB7Cj4gPiAtCQkJRFJN
X0VSUk9SKCJUaW1lZCBvdXQgd2FpdGluZyBmb3IgUFNSIElkbGUKPiA+IGZvciByZS1lbmFibGVc
biIpOwo+ID4gLQkJCXJldHVybjsKPiA+IC0JCX0KPiA+ICsJCXN0cnVjdCBkcm1fY3J0YyAqY3J0
YyA9Cj4gPiArCQkJZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApLT5iYXNlLmJhc2UuY3J0YzsKCkkn
bSBhZnJhaWQgdGhhdCB0aGUgaXNzdWUgaXMgdGhpcyBwb2ludGVyIGhlcmUuIFNvIHRoaXMgd2ls
bCBvbmx5IG1hc2sKdGhlIGlzc3VlLgoKU2hvdWxkIHdlIG1heWJlIHN0YXNoIHRoZSBwaXBlPyA6
LwoKPiA+ICsJCWVudW0gcGlwZSBwaXBlID0gdG9faW50ZWxfY3J0YyhjcnRjKS0+cGlwZTsKPiA+
ICsKPiA+ICsJCXJlZyA9IFZMVl9QU1JTVEFUKHBpcGUpOwo+ID4gKwkJbWFzayA9IFZMVl9FRFBf
UFNSX0lOX1RSQU5TOwo+ID4gIAl9Cj4gPiArCj4gPiArCW11dGV4X3VubG9jaygmZGV2X3ByaXYt
PnBzci5sb2NrKTsKPiA+ICsKPiA+ICsJZXJyID0gaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2
X3ByaXYsIHJlZywgbWFzaywgMCwgNTApOwo+ID4gKwlpZiAoZXJyKQo+ID4gKwkJRFJNX0VSUk9S
KCJUaW1lZCBvdXQgd2FpdGluZyBmb3IgUFNSIElkbGUgZm9yIHJlLQo+ID4gZW5hYmxlXG4iKTsK
PiA+ICsKPiA+ICsJLyogQWZ0ZXIgdGhlIHVubG9ja2VkIHdhaXQsIHZlcmlmeSB0aGF0IFBTUiBp
cyBzdGlsbCB3YW50ZWQhCj4gPiAqLwo+ID4gIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+cHNyLmxv
Y2spOwo+ID4gLQlpbnRlbF9kcCA9IGRldl9wcml2LT5wc3IuZW5hYmxlZDsKPiA+ICsJcmV0dXJu
IGVyciA9PSAwICYmIGRldl9wcml2LT5wc3IuZW5hYmxlZDsKPiA+ICt9Cj4gPiAgCj4gPiAtCWlm
ICghaW50ZWxfZHApCj4gPiArc3RhdGljIHZvaWQgaW50ZWxfcHNyX3dvcmsoc3RydWN0IHdvcmtf
c3RydWN0ICp3b3JrKQo+ID4gK3sKPiA+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w
cml2ID0KPiA+ICsJCWNvbnRhaW5lcl9vZih3b3JrLCB0eXBlb2YoKmRldl9wcml2KSwKPiA+IHBz
ci53b3JrLndvcmspOwo+ID4gKwo+ID4gKwltdXRleF9sb2NrKCZkZXZfcHJpdi0+cHNyLmxvY2sp
Owo+ID4gKwo+ID4gKwkvKgo+ID4gKwkgKiBXZSBoYXZlIHRvIG1ha2Ugc3VyZSBQU1IgaXMgcmVh
ZHkgZm9yIHJlLWVuYWJsZQo+ID4gKwkgKiBvdGhlcndpc2UgaXQga2VlcHMgZGlzYWJsZWQgdW50
aWwgbmV4dCBmdWxsCj4gPiBlbmFibGUvZGlzYWJsZSBjeWNsZS4KPiA+ICsJICogUFNSIG1pZ2h0
IHRha2Ugc29tZSB0aW1lIHRvIGdldCBmdWxseSBkaXNhYmxlZAo+ID4gKwkgKiBhbmQgYmUgcmVh
ZHkgZm9yIHJlLWVuYWJsZS4KPiA+ICsJICovCj4gPiArCWlmICghcHNyX3dhaXRfZm9yX2lkbGUo
ZGV2X3ByaXYpKQo+ID4gIAkJZ290byB1bmxvY2s7Cj4gPiAgCj4gPiAgCS8qCj4gPiBAQCAtODMy
LDcgKzgzOCw3IEBAIHN0YXRpYyB2b2lkIGludGVsX3Bzcl93b3JrKHN0cnVjdCB3b3JrX3N0cnVj
dAo+ID4gKndvcmspCj4gPiAgCWlmIChkZXZfcHJpdi0+cHNyLmJ1c3lfZnJvbnRidWZmZXJfYml0
cykKPiA+ICAJCWdvdG8gdW5sb2NrOwo+ID4gIAo+ID4gLQlpbnRlbF9wc3JfYWN0aXZhdGUoaW50
ZWxfZHApOwo+ID4gKwlpbnRlbF9wc3JfYWN0aXZhdGUoZGV2X3ByaXYtPnBzci5lbmFibGVkKTsK
PiA+ICB1bmxvY2s6Cj4gPiAgCW11dGV4X3VubG9jaygmZGV2X3ByaXYtPnBzci5sb2NrKTsKPiA+
ICB9Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs
LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov
L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=