From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v11 09/11] drm: Expose modes with aspect ratio, only if requested Date: Fri, 20 Apr 2018 17:22:39 +0300 Message-ID: <20180420142239.GD13908@intel.com> References: <1524231111-17440-1-git-send-email-ankit.k.nautiyal@intel.com> <1524231111-17440-10-git-send-email-ankit.k.nautiyal@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1524231111-17440-10-git-send-email-ankit.k.nautiyal@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Nautiyal, Ankit K" Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBBcHIgMjAsIDIwMTggYXQgMDc6MDE6NDlQTSArMDUzMCwgTmF1dGl5YWwsIEFua2l0 IEsgd3JvdGU6Cj4gRnJvbTogQW5raXQgTmF1dGl5YWwgPGFua2l0LmsubmF1dGl5YWxAaW50ZWwu Y29tPgo+IAo+IFdlIHBhcnNlIHRoZSBFRElEIGFuZCBhZGQgYWxsIHRoZSBtb2RlcyBpbiB0aGUg Y29ubmVjdG9yJ3MgbW9kZWxpc3QuCj4gVGhpcyBhZGRzIENFQSBtb2RlcyB3aXRoIGFzcGVjdCBy YXRpbyBpbmZvcm1hdGlvbiB0b28sIHJlZ2FyZGxlc3Mgb2YKPiB3aGV0aGVyIHVzZXIgc3BhY2Ug cmVxdWVzdGVkIHRoaXMgaW5mb3JtYXRpb24gb3Igbm90Lgo+IAo+IFRoaXMgcGF0Y2ggcHJ1bmVz IHRoZSBtb2RlcyB3aXRoIGFzcGVjdC1yYXRpbyBpbmZvcm1hdGlvbiwgZnJvbSBhCj4gY29ubmVj dG9yJ3MgbW9kZWxpc3QsIGlmIHRoZSB1c2VyLXNwYWNlIGhhcyBub3Qgc2V0IHRoZSBhc3BlY3Qg cmF0aW8KPiBEUk0gY2xpZW50IGNhcC4gSG93ZXZlciBpZiBzdWNoIGEgbW9kZSBpcyB1bmlxdWUg aW4gdGhlIGxpc3QsIGl0IGlzCj4ga2VwdCBpbiB0aGUgbGlzdCwgd2l0aCBhc3BlY3QtcmF0aW8g ZmxhZ3MgcmVzZXQuCj4gCj4gQ2M6IFZpbGxlIFN5cmphbGEgPHZpbGxlLnN5cmphbGFAbGludXgu aW50ZWwuY29tPgo+IENjOiBTaGFzaGFuayBTaGFybWEgPHNoYXNoYW5rLnNoYXJtYUBpbnRlbC5j b20+Cj4gQ2M6IEpvc2UgQWJyZXUgPGpvc2UuYWJyZXVAc3lub3BzeXMuY29tPgo+IAo+IFNpZ25l ZC1vZmYtYnk6IEFua2l0IE5hdXRpeWFsIDxhbmtpdC5rLm5hdXRpeWFsQGludGVsLmNvbT4KPiAK PiBWMzogQXMgc3VnZ2VzdGVkIGJ5IFZpbGxlLCBtb2RpZmllZCB0aGUgbWVjaGFuaXNtIG9mIHBy dW5pbmcgb2YgbW9kZXMKPiAgICAgd2l0aCBhc3BlY3QtcmF0aW8sIGlmIHRoZSBhc3BlY3QtcmF0 aW8gaXMgbm90IHN1cHBvcnRlZC4gSW5zdGVhZAo+ICAgICBvZiBzdHJhaWdodCBhd2F5IHBydW5p bmcgc3VjaCBhIG1vZGUsIHRoZSBtb2RlIGlzIHJldGFpbmVkIHdpdGgKPiAgICAgYXNwZWN0IHJh dGlvIGJpdHMgc2V0IHRvIHplcm8sIHByb3ZpZGVkIGl0IGlzIHVuaXF1ZS4KPiBWNDogcmViYXNl Cj4gVjU6IEFkZHJlc3NlZCByZXZpZXcgY29tbWVudHMgZnJvbSBWaWxsZToKPiAgICAgLXVzZWQg YSBwb2ludGVyIHRvIHN0b3JlIGxhc3QgdmFsaWQgbW9kZS4KPiAgICAgLWF2b2lkZWQsIG1vZGlm eWluZyBvZiBwaWN0dXJlX2FzcGVjdF9yYXRpbyBpbiBrZXJuZWwgbW9kZSwKPiAgICAgIGluc3Rl YWQgb25seSBmbGFncyBiaXRzIG9mIHVzZXIgbW9kZSBhcmUgcmVzZXQgKGlmIGFzcGVjdC1yYXRp bwo+ICAgICAgaXMgbm90IHN1cHBvcnRlZCkuCj4gVjY6IEFzIHN1Z2dlc3RlZCBieSBWaWxsZSwg Y29ycmVjdGVkIHRoZSBtb2RlIHBydW5pbmcgbG9naWMgYW5kCj4gICAgIGVsYWJvcmF0ZWQgdGhl IG1vZGUgcHJ1bmluZyBsb2dpYyBhbmQgdGhlIGFzc3VtcHRpb25zIHRha2VuLgo+IFY3OiByZWJh c2UKPiBWODogcmViYXNlCj4gVjk6IHJlYmFzZQo+IFYxMDogcmViYXNlCj4gVjExOiBGaXhlZCB0 aGUgaXNzdWUgY2F1c2VkIGluIGttc18zZCB0ZXN0LCBhbmQgZW5oYW5jZWQgdGhlIHBydW5pbmcK PiAgICAgIGxvZ2ljIHRvIGNvcnJlY3RseSBpZGVudGlmeSBhbmQgcHJ1bmUgbW9kZXMgd2l0aCBh c3BlY3QtcmF0aW8sCj4gICAgICBpZiBhc3BlY3QtcmF0aW8gY2FwIGlzIG5vdCBzZXQuCj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fY29ubmVjdG9yLmMgfCA1NiArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKy0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNDggaW5zZXJ0aW9u cygrKSwgOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9jb25uZWN0b3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY29ubmVjdG9yLmMKPiBpbmRleCBi M2NkZTg5Li44NjVlZTM1NCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Nvbm5l Y3Rvci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jb25uZWN0b3IuYwo+IEBAIC0xNTMx LDE1ICsxNTMxLDM1IEBAIHN0YXRpYyBzdHJ1Y3QgZHJtX2VuY29kZXIgKmRybV9jb25uZWN0b3Jf Z2V0X2VuY29kZXIoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lCj4gIAlyZXR1cm4gY29ubmVj dG9yLT5lbmNvZGVyOwo+ICB9Cj4gIAo+IC1zdGF0aWMgYm9vbCBkcm1fbW9kZV9leHBvc2VfdG9f dXNlcnNwYWNlKGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlLAo+IC0JCQkJCSBj b25zdCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdikKPiArc3RhdGljIGJvb2wKPiArZHJtX21v ZGVfZXhwb3NlX3RvX3VzZXJzcGFjZShjb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9k ZSwKPiArCQkJICAgICBjb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZWxpc3QsCj4g KwkJCSAgICAgY29uc3Qgc3RydWN0IGRybV9maWxlICpmaWxlX3ByaXYpCj4gIHsKPiAgCS8qCj4g IAkgKiBJZiB1c2VyLXNwYWNlIGhhc24ndCBjb25maWd1cmVkIHRoZSBkcml2ZXIgdG8gZXhwb3Nl IHRoZSBzdGVyZW8gM0QKPiAgCSAqIG1vZGVzLCBkb24ndCBleHBvc2UgdGhlbS4KPiAgCSAqLwo+ ICsJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGVfaXRyOwo+ICsKPiAgCWlmICghZmlsZV9w cml2LT5zdGVyZW9fYWxsb3dlZCAmJiBkcm1fbW9kZV9pc19zdGVyZW8obW9kZSkpCj4gIAkJcmV0 dXJuIGZhbHNlOwo+ICsJLyoKPiArCSAqIElmIHVzZXItc3BhY2UgaGFzbid0IGNvbmZpZ3VyZWQg dGhlIGRyaXZlciB0byBleHBvc2UgdGhlIG1vZGVzCj4gKwkgKiB3aXRoIGFzcGVjdC1yYXRpbywg ZG9uJ3QgZXhwb3NlIHRoZW0uIEhvd2V2ZXIgaWYgc3VjaCBhIG1vZGUKPiArCSAqIGlzIHVuaXF1 ZSwgbGV0IGl0IGJlIGV4cG9zZWQsIGJ1dCByZXNldCB0aGUgYXNwZWN0LXJhdGlvIGZsYWdzCj4g KwkgKiB3aGlsZSBwcmVwYXJpbmcgdGhlIGxpc3Qgb2YgdXNlci1tb2Rlcy4KPiArCSAqLwo+ICsJ aWYgKCFmaWxlX3ByaXYtPmFzcGVjdF9yYXRpb19hbGxvd2VkICYmCj4gKwkgICAgbW9kZS0+cGlj dHVyZV9hc3BlY3RfcmF0aW8gIT0gSERNSV9QSUNUVVJFX0FTUEVDVF9OT05FKSB7Cj4gKwkJbGlz dF9mb3JfZWFjaF9lbnRyeShtb2RlX2l0ciwgJm1vZGVsaXN0LT5oZWFkLCBoZWFkKQo+ICsJCQlp ZiAoZHJtX21vZGVfbWF0Y2gobW9kZV9pdHIsIG1vZGUsCj4gKwkJCQkJICAgRFJNX01PREVfTUFU Q0hfVElNSU5HUyB8Cj4gKwkJCQkJICAgRFJNX01PREVfTUFUQ0hfQ0xPQ0sgfAo+ICsJCQkJCSAg IERSTV9NT0RFX01BVENIX0ZMQUdTIHwKPiArCQkJCQkgICBEUk1fTU9ERV9NQVRDSF8zRF9GTEFH UykpCj4gKwkJCQlyZXR1cm4gZmFsc2U7Cj4gKwl9Cj4gIAo+ICAJcmV0dXJuIHRydWU7Cj4gIH0K PiBAQCAtMTU1MCw3ICsxNTcwLDcgQEAgaW50IGRybV9tb2RlX2dldGNvbm5lY3RvcihzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ICAJc3RydWN0IGRybV9tb2RlX2dldF9jb25u ZWN0b3IgKm91dF9yZXNwID0gZGF0YTsKPiAgCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0 b3I7Cj4gIAlzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXI7Cj4gLQlzdHJ1Y3QgZHJtX2Rpc3Bs YXlfbW9kZSAqbW9kZTsKPiArCXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlLCAqdG1wLCBt b2RlbGlzdDsKPiAgCWludCBtb2RlX2NvdW50ID0gMDsKPiAgCWludCBlbmNvZGVyc19jb3VudCA9 IDA7Cj4gIAlpbnQgcmV0ID0gMDsKPiBAQCAtMTYwNSwyMyArMTYyNSwzNyBAQCBpbnQgZHJtX21v ZGVfZ2V0Y29ubmVjdG9yKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gIAlv dXRfcmVzcC0+c3VicGl4ZWwgPSBjb25uZWN0b3ItPmRpc3BsYXlfaW5mby5zdWJwaXhlbF9vcmRl cjsKPiAgCW91dF9yZXNwLT5jb25uZWN0aW9uID0gY29ubmVjdG9yLT5zdGF0dXM7Cj4gIAo+ICsJ SU5JVF9MSVNUX0hFQUQoJm1vZGVsaXN0LmhlYWQpOwoKV2h5IGFyZSB3ZSB1c2luZyBhIHN0cnVj dCBkcm1fZGlzcGxheV9tb2RlIHRvIGdldCBhIHNpbXBsZSBsaXN0X2hlYWQ/Cgo+ICsKPiAgCS8q IGRlbGF5ZWQgc28gd2UgZ2V0IG1vZGVzIHJlZ2FyZGxlc3Mgb2YgcHJlLWZpbGxfbW9kZXMgc3Rh dGUgKi8KPiAgCWxpc3RfZm9yX2VhY2hfZW50cnkobW9kZSwgJmNvbm5lY3Rvci0+bW9kZXMsIGhl YWQpCj4gLQkJaWYgKGRybV9tb2RlX2V4cG9zZV90b191c2Vyc3BhY2UobW9kZSwgZmlsZV9wcml2 KSkKPiArCQlpZiAoZHJtX21vZGVfZXhwb3NlX3RvX3VzZXJzcGFjZShtb2RlLCAmbW9kZWxpc3Qs Cj4gKwkJCQkJCSBmaWxlX3ByaXYpKSB7Cj4gKwkJCXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICp0 bXBfbW9kZTsKPiArCj4gKwkJCXRtcF9tb2RlID0gZHJtX21vZGVfZHVwbGljYXRlKGRldiwgbW9k ZSk7CgpEdXBsaWNhdGluZyBldmVyeSBtb2RlIHNlZW1zIHJhdGhlciB3YXN0ZWZ1bC4gSSBzdXBw b3NlIHdlIGNvdWxkCmp1c3QgYWRkIGFub3RoZXIgbGlzdF9oZWFkIHRvIHN0cnVjdCBkcm1fZGlz cGxheV9tb2RlIGZvciB0aGlzCnB1cnBvc2UuIEFuIGFsdGVybmF0aXZlIGNvdWxkIGJlIHRvIHNv bWVob3cgbWFyayBlYWNoIGV4cG9zZWQgbW9kZQphbmQganVzdCB3YWxrIHRoZSBvcmlnaW5hbCBj b25uZWN0b3IgbW9kZSBsaXN0LgoKPiArCQkJbGlzdF9hZGRfdGFpbCgmdG1wX21vZGUtPmhlYWQs ICZtb2RlbGlzdC5oZWFkKTsKPiAgCQkJbW9kZV9jb3VudCsrOwo+ICsJCX0KPiAgCj4gIAkvKgo+ ICAJICogVGhpcyBpb2N0bCBpcyBjYWxsZWQgdHdpY2UsIG9uY2UgdG8gZGV0ZXJtaW5lIGhvdyBt dWNoIHNwYWNlIGlzCj4gIAkgKiBuZWVkZWQsIGFuZCB0aGUgMm5kIHRpbWUgdG8gZmlsbCBpdC4K PiArCSAqIFRoZSBtb2RlcyB0aGF0IG5lZWQgdG8gYmUgZXhwb3NlZCB0byB0aGUgdXNlciBhcmUg bWFpbnRhaW5lZCBpbiB0aGUKPiArCSAqICdtb2RlbGlzdCcuIFdoZW4gdGhlIGlvY3RsIGlzIGNh bGxlZCBmaXJzdCB0aW1lIHRvIGRldGVybWluZSB0aGUsCj4gKwkgKiBzcGFjZSwgdGhlIG1vZGVs aXN0IGdldHMgZmlsbGVkLCB0byBmaW5kIHRoZSBuby4gb2YgbW9kZXMuIEluIHRoZQo+ICsJICog Mm5kIHRpbWUsIHRoZSB1c2VyIG1vZGVzIGFyZSBmaWxsZWQsIG9uZSBieSBvbmUgZnJvbSB0aGUg bW9kZWxpc3QuCj4gIAkgKi8KPiAgCWlmICgob3V0X3Jlc3AtPmNvdW50X21vZGVzID49IG1vZGVf Y291bnQpICYmIG1vZGVfY291bnQpIHsKPiAgCQljb3BpZWQgPSAwOwo+ICAJCW1vZGVfcHRyID0g KHN0cnVjdCBkcm1fbW9kZV9tb2RlaW5mbyBfX3VzZXIgKikodW5zaWduZWQgbG9uZylvdXRfcmVz cC0+bW9kZXNfcHRyOwo+IC0JCWxpc3RfZm9yX2VhY2hfZW50cnkobW9kZSwgJmNvbm5lY3Rvci0+ bW9kZXMsIGhlYWQpIHsKPiAtCQkJaWYgKCFkcm1fbW9kZV9leHBvc2VfdG9fdXNlcnNwYWNlKG1v ZGUsIGZpbGVfcHJpdikpCj4gLQkJCQljb250aW51ZTsKPiAtCj4gKwkJbGlzdF9mb3JfZWFjaF9l bnRyeShtb2RlLCAmbW9kZWxpc3QuaGVhZCwgaGVhZCkgewo+ICAJCQlkcm1fbW9kZV9jb252ZXJ0 X3RvX3Vtb2RlKCZ1X21vZGUsIG1vZGUpOwo+ICsJCQkvKgo+ICsJCQkgKiBSZXNldCBhc3BlY3Qg cmF0aW8gZmxhZ3Mgb2YgdXNlci1tb2RlLCBpZiBtb2RlcyB3aXRoCj4gKwkJCSAqIGFzcGVjdC1y YXRpbyBhcmUgbm90IHN1cHBvcnRlZC4KPiArCQkJICovCj4gKwkJCWRybV9tb2RlX2ZpbHRlcl9h c3BlY3RfcmF0aW9fZmxhZ3MoZmlsZV9wcml2LCAmdV9tb2RlKTsKPiAgCQkJaWYgKGNvcHlfdG9f dXNlcihtb2RlX3B0ciArIGNvcGllZCwKPiAgCQkJCQkgJnVfbW9kZSwgc2l6ZW9mKHVfbW9kZSkp KSB7Cj4gIAkJCQlyZXQgPSAtRUZBVUxUOwo+IEBAIC0xNjUxLDYgKzE2ODUsMTIgQEAgaW50IGRy bV9tb2RlX2dldGNvbm5lY3RvcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ ICAJZHJtX21vZGVzZXRfdW5sb2NrKCZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgp Owo+ICAKPiAgb3V0Ogo+ICsJbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKG1vZGUsIHRtcCwgJm1v ZGVsaXN0LmhlYWQsIGhlYWQpIHsKPiArCQlsaXN0X2RlbCgmbW9kZS0+aGVhZCk7Cj4gKwkJZHJt X21vZGVfZGVzdHJveShkZXYsIG1vZGUpOwo+ICsJfQo+ICsJbGlzdF9kZWwoJm1vZGVsaXN0Lmhl YWQpOwo+ICsKPiAgCWRybV9jb25uZWN0b3JfcHV0KGNvbm5lY3Rvcik7Cj4gIAo+ICAJcmV0dXJu IHJldDsKPiAtLSAKPiAyLjcuNAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK