✗ Fi.CI.CHECKPATCH: warning for drm/i915: per context slice/subslice powergating

[Patchwork <patchwork@emeril.freedesktop.org>]

== Series Details ==

Series: drm/i915: per context slice/subslice powergating
URL   : https://patchwork.freedesktop.org/series/42285/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
aad432b4239c drm/i915: expose helper mapping exec flag engine to intel_engine_cs
f01ac5929e4d drm/i915: Program RPCS for Broadwell
1b1c9aba0ce7 drm/i915: don't specify pinned size for wa_bb pin/allocation
418f679dd16e drm/i915: extract per-ctx/indirect bb programming
-:44: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#44: FILE: drivers/gpu/drm/i915/intel_lrc.c:2421:
+	if (wa_ctx->per_ctx.size) {
+

total: 0 errors, 0 warnings, 1 checks, 71 lines checked
46f6a90557d5 drm/i915: pass wa_ctx as argument
02aac22145e0 drm/i915: reprogram NOA muxes on context switch when using perf
-:233: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#233: FILE: drivers/gpu/drm/i915/intel_lrc.c:1697:
+	BUG_ON(batch_ptr - batch > wa_ctx->vma->obj->base.size);

total: 0 errors, 1 warnings, 0 checks, 258 lines checked
c67130ef4bd9 drm/i915: Record the sseu configuration per-context & engine
-:57: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#57: FILE: drivers/gpu/drm/i915/i915_gem_context.c:335:
+			i915_gem_context_sseu_from_device_sseu(

-:133: ERROR:CODE_INDENT: code indent should use tabs where possible
#133: FILE: drivers/gpu/drm/i915/intel_lrc.c:2410:
+^I^I        GEN8_RPCS_SS_CNT_SHIFT;$

total: 1 errors, 0 warnings, 1 checks, 118 lines checked
59ec862256e6 drm/i915: Expose RPCS (SSEU) configuration to userspace
-:25: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#25: 
	struct drm_i915_gem_context_param_sseu sseu = { .flags = I915_EXEC_RENDER };

-:135: CHECK:BRACES: braces {} should be used on all arms of this statement
#135: FILE: drivers/gpu/drm/i915/i915_gem_context.c:905:
+		if (args->size)
[...]
+		else if (!HAS_EXECLISTS(ctx->i915))
[...]
+		else {
[...]

-:139: CHECK:BRACES: Unbalanced braces around else statement
#139: FILE: drivers/gpu/drm/i915/i915_gem_context.c:909:
+		else {

total: 0 errors, 1 warnings, 2 checks, 213 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx