From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 02/13] drm/i915: Fix tabs vs. spaces
Date: Fri, 1 Jun 2018 18:54:46 +0300 [thread overview]
Message-ID: <20180601155446.GA23723@intel.com> (raw)
In-Reply-To: <87d0xc73pj.fsf@intel.com>
On Thu, May 31, 2018 at 09:13:12AM +0300, Jani Nikula wrote:
> On Wed, 30 May 2018, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > The sprite code has a bunch of spaces where tabs should be used. Fix it
> > up.
>
> I guess the subject could be a little more specific; you aren't fixing
> the whole driver after all. With that,
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Patch subject amanded and pushed to dinq. Alas I forgot that I had
already pushed something to drm-misc-next which made this patch
redundant. So in hindsight I should have just dropped this one and
avoided the merge conflicts. Thanks for the review anyway.
>
>
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_sprite.c | 20 ++++++++++----------
> > 1 file changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> > index ee23613f9fd4..b056a74300c8 100644
> > --- a/drivers/gpu/drm/i915/intel_sprite.c
> > +++ b/drivers/gpu/drm/i915/intel_sprite.c
> > @@ -1303,8 +1303,8 @@ static bool skl_mod_supported(uint32_t format, uint64_t modifier)
> > }
> >
> > static bool intel_sprite_plane_format_mod_supported(struct drm_plane *plane,
> > - uint32_t format,
> > - uint64_t modifier)
> > + uint32_t format,
> > + uint64_t modifier)
> > {
> > struct drm_i915_private *dev_priv = to_i915(plane->dev);
> >
> > @@ -1326,14 +1326,14 @@ static bool intel_sprite_plane_format_mod_supported(struct drm_plane *plane,
> > }
> >
> > static const struct drm_plane_funcs intel_sprite_plane_funcs = {
> > - .update_plane = drm_atomic_helper_update_plane,
> > - .disable_plane = drm_atomic_helper_disable_plane,
> > - .destroy = intel_plane_destroy,
> > - .atomic_get_property = intel_plane_atomic_get_property,
> > - .atomic_set_property = intel_plane_atomic_set_property,
> > - .atomic_duplicate_state = intel_plane_duplicate_state,
> > - .atomic_destroy_state = intel_plane_destroy_state,
> > - .format_mod_supported = intel_sprite_plane_format_mod_supported,
> > + .update_plane = drm_atomic_helper_update_plane,
> > + .disable_plane = drm_atomic_helper_disable_plane,
> > + .destroy = intel_plane_destroy,
> > + .atomic_get_property = intel_plane_atomic_get_property,
> > + .atomic_set_property = intel_plane_atomic_set_property,
> > + .atomic_duplicate_state = intel_plane_duplicate_state,
> > + .atomic_destroy_state = intel_plane_destroy_state,
> > + .format_mod_supported = intel_sprite_plane_format_mod_supported,
> > };
> >
> > bool skl_plane_has_ccs(struct drm_i915_private *dev_priv,
>
> --
> Jani Nikula, Intel Open Source Graphics Center
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-06-01 15:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 16:59 [PATCH v2 00/13] drm/i915: Some plane init cleanups Ville Syrjala
2018-05-30 16:59 ` [PATCH v2 01/13] drm/i915: Constify intel_plane_funcs Ville Syrjala
2018-05-30 21:45 ` Kristian Høgsberg
2018-05-30 16:59 ` [PATCH v2 02/13] drm/i915: Fix tabs vs. spaces Ville Syrjala
2018-05-31 6:13 ` Jani Nikula
2018-06-01 15:54 ` Ville Syrjälä [this message]
2018-05-30 16:59 ` [PATCH v2 03/13] drm/i915: Populate possible_crtcs for primary/cursor planes Ville Syrjala
2018-05-30 16:59 ` [PATCH v2 04/13] drm/i915: Don't populate plane->i9xx_plane for sprites Ville Syrjala
2018-05-30 16:59 ` [PATCH v2 05/13] drm/i915: Allow horizontal mirroring for cnl+ "sprite" planes Ville Syrjala
2018-05-30 16:59 ` [PATCH v2 06/13] drm/i915: Disallow plane scaling with specific pixel formats Ville Syrjala
2018-05-30 16:59 ` [PATCH v2 07/13] drm/i915: Add missing pixel formats for skl+ "sprites" Ville Syrjala
2018-05-30 16:59 ` [PATCH v2 08/13] drm/i915: Move plane_state->scaler_id initialization into intel_create_plane_state() Ville Syrjala
2018-05-30 16:59 ` [PATCH v2 09/13] drm/i915: Introduce intel_plane_alloc() Ville Syrjala
2018-05-30 17:15 ` [PATCH v2 10/13] drm/i915: Extract skl_universal_plane_init() Ville Syrjala
2018-05-30 17:15 ` [PATCH v2 11/13] drm/i915: Simplify skl_plane_has_planar() Ville Syrjala
2018-05-30 17:16 ` [PATCH v2 12/13] drm/i915: s/intel_plane/plane/ in sprite init Ville Syrjala
2018-05-30 17:16 ` [PATCH v2 13/13] drm/i915: Rename variables in intel_primary_plane_create() Ville Syrjala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601155446.GA23723@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox