From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: [PATCH v2 2/2] drm/i915/icl: Do read-modify-write as needed during MG PLL programming Date: Tue, 19 Jun 2018 18:44:55 +0300 Message-ID: <20180619154455.302-1-imre.deak@intel.com> References: <20180615143911.31082-2-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A2B789227 for ; Tue, 19 Jun 2018 15:45:52 +0000 (UTC) In-Reply-To: <20180615143911.31082-2-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Vandita Kulkarni , Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org U29tZSBNRyBQTEwgcmVnaXN0ZXJzIGhhdmUgZmllbGRzIHRoYXQgbmVlZCB0byBiZSBwcmVzZXJ2 ZWQgYXQgdGhlaXIgSFcKZGVmYXVsdCBvciBCSU9TIHByb2dyYW1tZWQgdmFsdWVzLiBTbyBtYWtl IHN1cmUgd2UgcHJlc2VydmUgdGhlbS4KCnYyOgotIEFkZCBjb21tZW50IHRvIGljbF9tZ19wbGxf d3JpdGUoKSBleHBsYWluaW5nIHRoZSBuZWVkIGZvciByZWdpc3RlcgogIG1hc2tzLiAoVmFuZGl0 YSkKLSBGaXggcGF0Y2h3b3JrIGNoZWNrcGF0Y2ggd2FybmluZy4KCkNjOiBWYW5kaXRhIEt1bGth cm5pIDx2YW5kaXRhLmt1bGthcm5pQGludGVsLmNvbT4KQ2M6IFBhdWxvIFphbm9uaSA8cGF1bG8u ci56YW5vbmlAaW50ZWwuY29tPgpDYzogSmFtZXMgQXVzbXVzIDxqYW1lcy5hdXNtdXNAaW50ZWwu Y29tPgpTaWduZWQtb2ZmLWJ5OiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+ClJldmll d2VkLWJ5OiBKYW1lcyBBdXNtdXMgPGphbWVzLmF1c211c0BpbnRlbC5jb20+ICh2MSkKLS0tCiBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oICAgICAgIHwgMTMgKysrKysrKysrKysrCiBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jIHwgMzkgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKy0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgNDggaW5zZXJ0aW9ucygrKSwg NCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jl Zy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAppbmRleCBjNmM5ZTRmOWE3MTgu LjZlNTg3ZDQ5YjkzNiAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcu aAorKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCkBAIC05NDA1LDYgKzk0MDUs NyBAQCBlbnVtIHNrbF9wb3dlcl9nYXRlIHsKICNkZWZpbmUgX01HX1JFRkNMS0lOX0NUTF9QT1JU MwkJCQkweDE2QTkyQwogI2RlZmluZSBfTUdfUkVGQ0xLSU5fQ1RMX1BPUlQ0CQkJCTB4MTZCOTJD CiAjZGVmaW5lICAgTUdfUkVGQ0xLSU5fQ1RMX09EXzJfTVVYKHgpCQkJKCh4KSA8PCA4KQorI2Rl ZmluZSAgIE1HX1JFRkNMS0lOX0NUTF9PRF8yX01VWF9NQVNLCQkJKDB4NyA8PCA4KQogI2RlZmlu ZSBNR19SRUZDTEtJTl9DVEwocG9ydCkgX01NSU9fUE9SVCgocG9ydCkgLSBQT1JUX0MsIFwKIAkJ CQkJIF9NR19SRUZDTEtJTl9DVExfUE9SVDEsIFwKIAkJCQkJIF9NR19SRUZDTEtJTl9DVExfUE9S VDIpCkBAIC05NDE0LDcgKzk0MTUsOSBAQCBlbnVtIHNrbF9wb3dlcl9nYXRlIHsKICNkZWZpbmUg X01HX0NMS1RPUDJfQ09SRUNMS0NUTDFfUE9SVDMJCQkweDE2QThEOAogI2RlZmluZSBfTUdfQ0xL VE9QMl9DT1JFQ0xLQ1RMMV9QT1JUNAkJCTB4MTZCOEQ4CiAjZGVmaW5lICAgTUdfQ0xLVE9QMl9D T1JFQ0xLQ1RMMV9CX0RJVlJBVElPKHgpCQkoKHgpIDw8IDE2KQorI2RlZmluZSAgIE1HX0NMS1RP UDJfQ09SRUNMS0NUTDFfQl9ESVZSQVRJT19NQVNLCSgweGZmIDw8IDE2KQogI2RlZmluZSAgIE1H X0NMS1RPUDJfQ09SRUNMS0NUTDFfQV9ESVZSQVRJTyh4KQkJKCh4KSA8PCA4KQorI2RlZmluZSAg IE1HX0NMS1RPUDJfQ09SRUNMS0NUTDFfQV9ESVZSQVRJT19NQVNLCSgweGZmIDw8IDgpCiAjZGVm aW5lIE1HX0NMS1RPUDJfQ09SRUNMS0NUTDEocG9ydCkgX01NSU9fUE9SVCgocG9ydCkgLSBQT1JU X0MsIFwKIAkJCQkJCV9NR19DTEtUT1AyX0NPUkVDTEtDVEwxX1BPUlQxLCBcCiAJCQkJCQlfTUdf Q0xLVE9QMl9DT1JFQ0xLQ1RMMV9QT1JUMikKQEAgLTk0MjQsOSArOTQyNywxMyBAQCBlbnVtIHNr bF9wb3dlcl9nYXRlIHsKICNkZWZpbmUgX01HX0NMS1RPUDJfSFNDTEtDVExfUE9SVDMJCQkweDE2 QThENAogI2RlZmluZSBfTUdfQ0xLVE9QMl9IU0NMS0NUTF9QT1JUNAkJCTB4MTZCOEQ0CiAjZGVm aW5lICAgTUdfQ0xLVE9QMl9IU0NMS0NUTF9DT1JFX0lOUFVUU0VMKHgpCQkoKHgpIDw8IDE2KQor I2RlZmluZSAgIE1HX0NMS1RPUDJfSFNDTEtDVExfQ09SRV9JTlBVVFNFTF9NQVNLCSgweDEgPDwg MTYpCiAjZGVmaW5lICAgTUdfQ0xLVE9QMl9IU0NMS0NUTF9UTElORURSVl9DTEtTRUwoeCkJKCh4 KSA8PCAxNCkKKyNkZWZpbmUgICBNR19DTEtUT1AyX0hTQ0xLQ1RMX1RMSU5FRFJWX0NMS1NFTF9N QVNLCSgweDMgPDwgMTQpCiAjZGVmaW5lICAgTUdfQ0xLVE9QMl9IU0NMS0NUTF9IU0RJVl9SQVRJ Tyh4KQkJKCh4KSA8PCAxMikKKyNkZWZpbmUgICBNR19DTEtUT1AyX0hTQ0xLQ1RMX0hTRElWX1JB VElPX01BU0sJCSgweDMgPDwgMTIpCiAjZGVmaW5lICAgTUdfQ0xLVE9QMl9IU0NMS0NUTF9EU0RJ Vl9SQVRJTyh4KQkJKCh4KSA8PCA4KQorI2RlZmluZSAgIE1HX0NMS1RPUDJfSFNDTEtDVExfRFNE SVZfUkFUSU9fTUFTSwkJKDB4ZiA8PCA4KQogI2RlZmluZSBNR19DTEtUT1AyX0hTQ0xLQ1RMKHBv cnQpIF9NTUlPX1BPUlQoKHBvcnQpIC0gUE9SVF9DLCBcCiAJCQkJCSAgICAgX01HX0NMS1RPUDJf SFNDTEtDVExfUE9SVDEsIFwKIAkJCQkJICAgICBfTUdfQ0xLVE9QMl9IU0NMS0NUTF9QT1JUMikK QEAgLTk1MDAsMTIgKzk1MDcsMTggQEAgZW51bSBza2xfcG93ZXJfZ2F0ZSB7CiAjZGVmaW5lIF9N R19QTExfQklBU19QT1JUMwkJCQkweDE2QUExNAogI2RlZmluZSBfTUdfUExMX0JJQVNfUE9SVDQJ CQkJMHgxNkJBMTQKICNkZWZpbmUgICBNR19QTExfQklBU19CSUFTX0dCX1NFTCh4KQkJCSgoeCkg PDwgMzApCisjZGVmaW5lICAgTUdfUExMX0JJQVNfQklBU19HQl9TRUxfTUFTSwkJCSgweDMgPDwg MzApCiAjZGVmaW5lICAgTUdfUExMX0JJQVNfSU5JVF9EQ09BTVAoeCkJCQkoKHgpIDw8IDI0KQor I2RlZmluZSAgIE1HX1BMTF9CSUFTX0lOSVRfRENPQU1QX01BU0sJCQkoMHgzZiA8PCAyNCkKICNk ZWZpbmUgICBNR19QTExfQklBU19CSUFTX0JPTlVTKHgpCQkJKCh4KSA8PCAxNikKKyNkZWZpbmUg ICBNR19QTExfQklBU19CSUFTX0JPTlVTX01BU0sJCQkoMHhmZiA8PCAxNikKICNkZWZpbmUgICBN R19QTExfQklBU19CSUFTQ0FMX0VOCQkJKDEgPDwgMTUpCiAjZGVmaW5lICAgTUdfUExMX0JJQVNf Q1RSSU0oeCkJCQkJKCh4KSA8PCA4KQorI2RlZmluZSAgIE1HX1BMTF9CSUFTX0NUUklNX01BU0sJ CQkoMHgxZiA8PCA4KQogI2RlZmluZSAgIE1HX1BMTF9CSUFTX1ZSRUZfUkRBQyh4KQkJCSgoeCkg PDwgNSkKKyNkZWZpbmUgICBNR19QTExfQklBU19WUkVGX1JEQUNfTUFTSwkJCSgweDcgPDwgNSkK ICNkZWZpbmUgICBNR19QTExfQklBU19JUkVGVFJJTSh4KQkJCSgoeCkgPDwgMCkKKyNkZWZpbmUg ICBNR19QTExfQklBU19JUkVGVFJJTV9NQVNLCQkJKDB4MWYgPDwgMCkKICNkZWZpbmUgTUdfUExM X0JJQVMocG9ydCkgX01NSU9fUE9SVCgocG9ydCkgLSBQT1JUX0MsIF9NR19QTExfQklBU19QT1JU MSwgXAogCQkJCSAgICAgX01HX1BMTF9CSUFTX1BPUlQyKQogCmRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHBsbF9tZ3IuYwppbmRleCA4NTQzYTEwMTVlMjEuLmFlNDdjZGI4MGQ1NCAxMDA2NDQKLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYworKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCkBAIC0yOTkyLDEwICsyOTkyLDIxIEBAIHN0YXRp YyBib29sIGljbF9wbGxfZ2V0X2h3X3N0YXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiwKIAl9IGVsc2UgewogCQlwb3J0ID0gaWNsX21nX3BsbF9pZF90b19wb3J0KGRldl9wcml2 LCBpZCk7CiAJCWh3X3N0YXRlLT5tZ19yZWZjbGtpbl9jdGwgPSBJOTE1X1JFQUQoTUdfUkVGQ0xL SU5fQ1RMKHBvcnQpKTsKKwkJaHdfc3RhdGUtPm1nX3JlZmNsa2luX2N0bCAmPSBNR19SRUZDTEtJ Tl9DVExfT0RfMl9NVVhfTUFTSzsKKwogCQlod19zdGF0ZS0+bWdfY2xrdG9wMl9jb3JlY2xrY3Rs MSA9CiAJCQlJOTE1X1JFQUQoTUdfQ0xLVE9QMl9DT1JFQ0xLQ1RMMShwb3J0KSk7CisJCWh3X3N0 YXRlLT5tZ19jbGt0b3AyX2NvcmVjbGtjdGwxICY9CisJCQlNR19DTEtUT1AyX0NPUkVDTEtDVEwx X0FfRElWUkFUSU9fTUFTSzsKKwogCQlod19zdGF0ZS0+bWdfY2xrdG9wMl9oc2Nsa2N0bCA9CiAJ CQlJOTE1X1JFQUQoTUdfQ0xLVE9QMl9IU0NMS0NUTChwb3J0KSk7CisJCWh3X3N0YXRlLT5tZ19j bGt0b3AyX2hzY2xrY3RsICY9CisJCQlNR19DTEtUT1AyX0hTQ0xLQ1RMX1RMSU5FRFJWX0NMS1NF TF9NQVNLIHwKKwkJCU1HX0NMS1RPUDJfSFNDTEtDVExfQ09SRV9JTlBVVFNFTF9NQVNLIHwKKwkJ CU1HX0NMS1RPUDJfSFNDTEtDVExfSFNESVZfUkFUSU9fTUFTSyB8CisJCQlNR19DTEtUT1AyX0hT Q0xLQ1RMX0RTRElWX1JBVElPX01BU0s7CisKIAkJaHdfc3RhdGUtPm1nX3BsbF9kaXYwID0gSTkx NV9SRUFEKE1HX1BMTF9ESVYwKHBvcnQpKTsKIAkJaHdfc3RhdGUtPm1nX3BsbF9kaXYxID0gSTkx NV9SRUFEKE1HX1BMTF9ESVYxKHBvcnQpKTsKIAkJaHdfc3RhdGUtPm1nX3BsbF9sZiA9IEk5MTVf UkVBRChNR19QTExfTEYocG9ydCkpOwpAQCAtMzA1MSwxMCArMzA2MiwzMCBAQCBzdGF0aWMgdm9p ZCBpY2xfbWdfcGxsX3dyaXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKIAll bnVtIHBvcnQgcG9ydCA9IGljbF9tZ19wbGxfaWRfdG9fcG9ydChkZXZfcHJpdiwgcGxsLT5pbmZv LT5pZCk7CiAJdTMyIHZhbDsKIAotCUk5MTVfV1JJVEUoTUdfUkVGQ0xLSU5fQ1RMKHBvcnQpLCBo d19zdGF0ZS0+bWdfcmVmY2xraW5fY3RsKTsKLQlJOTE1X1dSSVRFKE1HX0NMS1RPUDJfQ09SRUNM S0NUTDEocG9ydCksCi0JCSAgIGh3X3N0YXRlLT5tZ19jbGt0b3AyX2NvcmVjbGtjdGwxKTsKLQlJ OTE1X1dSSVRFKE1HX0NMS1RPUDJfSFNDTEtDVEwocG9ydCksIGh3X3N0YXRlLT5tZ19jbGt0b3Ay X2hzY2xrY3RsKTsKKwkvKgorCSAqIFNvbWUgb2YgdGhlIGZvbGxvd2luZyByZWdpc3RlcnMgaGF2 ZSByZXNlcnZlZCBmaWVsZHMsIHNvIHByb2dyYW0KKwkgKiB0aGVzZSB3aXRoIFJNVyBiYXNlZCBv biBhIG1hc2suIFRoZSBtYXNrIGNhbiBiZSBmaXhlZCBvciBnZW5lcmF0ZWQKKwkgKiBkdXJpbmcg dGhlIGNhbGMvcmVhZG91dCBwaGFzZSBpZiB0aGUgbWFzayBkZXBlbmRzIG9uIHNvbWUgb3RoZXIg SFcKKwkgKiBzdGF0ZSBsaWtlIHJlZmNsaywgc2VlIGljbF9jYWxjX21nX3BsbF9zdGF0ZSgpLgor CSAqLworCXZhbCA9IEk5MTVfUkVBRChNR19SRUZDTEtJTl9DVEwocG9ydCkpOworCXZhbCAmPSB+ TUdfUkVGQ0xLSU5fQ1RMX09EXzJfTVVYX01BU0s7CisJdmFsIHw9IGh3X3N0YXRlLT5tZ19yZWZj bGtpbl9jdGw7CisJSTkxNV9XUklURShNR19SRUZDTEtJTl9DVEwocG9ydCksIHZhbCk7CisKKwl2 YWwgPSBJOTE1X1JFQUQoTUdfQ0xLVE9QMl9DT1JFQ0xLQ1RMMShwb3J0KSk7CisJdmFsICY9IH5N R19DTEtUT1AyX0NPUkVDTEtDVEwxX0FfRElWUkFUSU9fTUFTSzsKKwl2YWwgfD0gaHdfc3RhdGUt Pm1nX2Nsa3RvcDJfY29yZWNsa2N0bDE7CisJSTkxNV9XUklURShNR19DTEtUT1AyX0NPUkVDTEtD VEwxKHBvcnQpLCB2YWwpOworCisJdmFsID0gSTkxNV9SRUFEKE1HX0NMS1RPUDJfSFNDTEtDVEwo cG9ydCkpOworCXZhbCAmPSB+KE1HX0NMS1RPUDJfSFNDTEtDVExfVExJTkVEUlZfQ0xLU0VMX01B U0sgfAorCQkgTUdfQ0xLVE9QMl9IU0NMS0NUTF9DT1JFX0lOUFVUU0VMX01BU0sgfAorCQkgTUdf Q0xLVE9QMl9IU0NMS0NUTF9IU0RJVl9SQVRJT19NQVNLIHwKKwkJIE1HX0NMS1RPUDJfSFNDTEtD VExfRFNESVZfUkFUSU9fTUFTSyk7CisJdmFsIHw9IGh3X3N0YXRlLT5tZ19jbGt0b3AyX2hzY2xr Y3RsOworCUk5MTVfV1JJVEUoTUdfQ0xLVE9QMl9IU0NMS0NUTChwb3J0KSwgdmFsKTsKKwogCUk5 MTVfV1JJVEUoTUdfUExMX0RJVjAocG9ydCksIGh3X3N0YXRlLT5tZ19wbGxfZGl2MCk7CiAJSTkx NV9XUklURShNR19QTExfRElWMShwb3J0KSwgaHdfc3RhdGUtPm1nX3BsbF9kaXYxKTsKIAlJOTE1 X1dSSVRFKE1HX1BMTF9MRihwb3J0KSwgaHdfc3RhdGUtPm1nX3BsbF9sZik7Ci0tIAoyLjEzLjIK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=