From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/8] drm/fb-helper: Eliminate the .best_encoder() usage Date: Wed, 27 Jun 2018 15:03:09 +0300 Message-ID: <20180627120309.GC20518@intel.com> References: <20180626174714.32012-1-ville.syrjala@linux.intel.com> <20180626174714.32012-2-ville.syrjala@linux.intel.com> <20180627090331.GE13978@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180627090331.GE13978@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan , dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKdW4gMjcsIDIwMTggYXQgMTE6MDM6MzFBTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUdWUsIEp1biAyNiwgMjAxOCBhdCAwODo0NzowN1BNICswMzAwLCBWaWxsZSBT eXJqYWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiA+IAo+ID4gSW5zdGVhZCBvZiB1c2luZyB0aGUgLmJlc3RfZW5jb2Rl cigpIGhvb2sgdG8gZmlndXJlIG91dCB3aGV0aGVyIGEgZ2l2ZW4KPiA+IGNvbm5lY3RvcitjcnRj IGNvbWJvIHdpbGwgd29yaywgbGV0J3MgaW5zdGVhZCBkbyB3aGF0IHVzZXJzcGFjZSBkb2VzIGFu ZAo+ID4ganVzdCBpdGVyYXRlIG92ZXIgYWxsIHRoZSBlbmNvZGVycyBmb3IgdGhlIGNvbm5lY3Rv ciwgYW5kIHRoZW4gY2hlY2sKPiA+IGVhY2ggY3J0YyBhZ2FpbnN0IGVhY2ggZW5jb2RlcidzIHBv c3NpYmxlX2NydGNzIGJpdG1hc2suCj4gPiAKPiA+IENjOiBEaGluYWthcmFuIFBhbmRpeWFuIDxk aGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KPiA+IENjOiBIYXJyeSBXZW50bGFuZCA8aGFy cnkud2VudGxhbmRAYW1kLmNvbT4KPiA+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVy QGZmd2xsLmNoPgo+ID4gQWNrZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3 bGwuY2g+Cj4gPiBTdWdnZXN0ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3 bGwuY2g+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFA bGludXguaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxw ZXIuYyB8IDM2ICsrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLQo+ID4gIDEgZmls ZSBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9k cm0vZHJtX2ZiX2hlbHBlci5jCj4gPiBpbmRleCBjYWIxNGYyNTMzODQuLjYxYzM5Y2Q3NWEyNyAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiA+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiA+IEBAIC0yMzIzLDYgKzIzMjMsMjMg QEAgc3RhdGljIGJvb2wgZHJtX3RhcmdldF9wcmVmZXJyZWQoc3RydWN0IGRybV9mYl9oZWxwZXIg KmZiX2hlbHBlciwKPiA+ICAJcmV0dXJuIHRydWU7Cj4gPiAgfQo+ID4gIAo+ID4gK3N0YXRpYyBi b29sIGNvbm5lY3Rvcl9jcnRjX29rKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4g PiArCQkJICAgICAgc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ID4gK3sKPiA+ICsJaW50IGk7Cj4g PiArCj4gPiArCWZvciAoaSA9IDA7IGkgPCBEUk1fQ09OTkVDVE9SX01BWF9FTkNPREVSOyBpKysp IHsKPiA+ICsJCXN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlciA9Cj4gPiArCQkJZHJtX2VuY29k ZXJfZmluZChjb25uZWN0b3ItPmRldiwgTlVMTCwKPiA+ICsJCQkJCSBjb25uZWN0b3ItPmVuY29k ZXJfaWRzW2ldKTsKPiA+ICsKPiAKPiBTaG91bGRuJ3Qgd2UgYWxzbyBjaGVjayBmb3IgZW5jb2Rl ciAhPSBOVUxMIGhlcmU/IEp1c3QgZm9yIHRoZSBjYXNlIHdoZXJlCj4gYSBjb25uZWN0b3IgZG9l cyBub3Qgd29yayBvbiB0aGUgZ2l2ZW4gY3J0Yywgd2hlcmUgd2UgZG8gZXhwZWN0IHRvCj4gYWN0 dWFsbHkgcnVuIG9mZiB0aGUgZW5kIG9mIHRoZSB2YWxpZCBlbnRyaWVzIGluIHRoZSBhcnJheS4K ClllYWguIFRoaXMgb25lIGlzIG9idmlvdXNseSBjcmFwLiBPcmlnaW5hbGx5IEkgaGFkIGl0IGFm dGVyIHRoZQpmb3JfZWFjaF9lbmNvZGVyX2lkcygpIHRoaW5nIHNvIGRpZG4ndCBuZWVkIGFueSBj aGVja3MsIGJ1dCB0aGVuCnRob3VnaHQgSSBzaG91bGQgbW92ZSBpdCBiZWZvcmUganVzdCBpbiBj YXNlIHBlb3BsZSBkb24ndCBsaWtlCnRoYXQgcGFydGljdWxhciBtYWNyby4gQW5kIGFwcGFyZW50 bHkgZm9yZ290IHRvIHRoaW5rIHdoZW4gZG9pbmcKdGhhdC4KCj4gCj4gV2l0aCB0aGF0IGZpeGVk Ogo+IAo+IFJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNo Pgo+IAo+ID4gKwkJaWYgKGVuY29kZXItPnBvc3NpYmxlX2NydGNzICYgZHJtX2NydGNfbWFzayhj cnRjKSkKPiA+ICsJCQlyZXR1cm4gdHJ1ZTsKPiA+ICsJfQo+ID4gKwo+ID4gKwlyZXR1cm4gZmFs c2U7Cj4gPiArfQo+ID4gKwo+ID4gIHN0YXRpYyBpbnQgZHJtX3BpY2tfY3J0Y3Moc3RydWN0IGRy bV9mYl9oZWxwZXIgKmZiX2hlbHBlciwKPiA+ICAJCQkgIHN0cnVjdCBkcm1fZmJfaGVscGVyX2Ny dGMgKipiZXN0X2NydGNzLAo+ID4gIAkJCSAgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKiptb2Rl cywKPiA+IEBAIC0yMzMxLDcgKzIzNDgsNiBAQCBzdGF0aWMgaW50IGRybV9waWNrX2NydGNzKHN0 cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIsCj4gPiAgCWludCBjLCBvOwo+ID4gIAlzdHJ1 Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+ID4gIAljb25zdCBzdHJ1Y3QgZHJtX2Nvbm5l Y3Rvcl9oZWxwZXJfZnVuY3MgKmNvbm5lY3Rvcl9mdW5jczsKPiA+IC0Jc3RydWN0IGRybV9lbmNv ZGVyICplbmNvZGVyOwo+ID4gIAlpbnQgbXlfc2NvcmUsIGJlc3Rfc2NvcmUsIHNjb3JlOwo+ID4g IAlzdHJ1Y3QgZHJtX2ZiX2hlbHBlcl9jcnRjICoqY3J0Y3MsICpjcnRjOwo+ID4gIAlzdHJ1Y3Qg ZHJtX2ZiX2hlbHBlcl9jb25uZWN0b3IgKmZiX2hlbHBlcl9jb25uOwo+ID4gQEAgLTIzNjIsMjAg KzIzNzgsNiBAQCBzdGF0aWMgaW50IGRybV9waWNrX2NydGNzKHN0cnVjdCBkcm1fZmJfaGVscGVy ICpmYl9oZWxwZXIsCj4gPiAgCj4gPiAgCWNvbm5lY3Rvcl9mdW5jcyA9IGNvbm5lY3Rvci0+aGVs cGVyX3ByaXZhdGU7Cj4gPiAgCj4gPiAtCS8qCj4gPiAtCSAqIElmIHRoZSBEUk0gZGV2aWNlIGlt cGxlbWVudHMgYXRvbWljIGhvb2tzIGFuZCAtPmJlc3RfZW5jb2RlcigpIGlzCj4gPiAtCSAqIE5V TEwgd2UgZmFsbGJhY2sgdG8gdGhlIGRlZmF1bHQgZHJtX2F0b21pY19oZWxwZXJfYmVzdF9lbmNv ZGVyKCkKPiA+IC0JICogaGVscGVyLgo+ID4gLQkgKi8KPiA+IC0JaWYgKGRybV9kcnZfdXNlc19h dG9taWNfbW9kZXNldChmYl9oZWxwZXItPmRldikgJiYKPiA+IC0JICAgICFjb25uZWN0b3JfZnVu Y3MtPmJlc3RfZW5jb2RlcikKPiA+IC0JCWVuY29kZXIgPSBkcm1fYXRvbWljX2hlbHBlcl9iZXN0 X2VuY29kZXIoY29ubmVjdG9yKTsKPiA+IC0JZWxzZQo+ID4gLQkJZW5jb2RlciA9IGNvbm5lY3Rv cl9mdW5jcy0+YmVzdF9lbmNvZGVyKGNvbm5lY3Rvcik7Cj4gPiAtCj4gPiAtCWlmICghZW5jb2Rl cikKPiA+IC0JCWdvdG8gb3V0Owo+ID4gLQo+ID4gIAkvKgo+ID4gIAkgKiBzZWxlY3QgYSBjcnRj IGZvciB0aGlzIGNvbm5lY3RvciBhbmQgdGhlbiBhdHRlbXB0IHRvIGNvbmZpZ3VyZQo+ID4gIAkg KiByZW1haW5pbmcgY29ubmVjdG9ycwo+ID4gQEAgLTIzODMsNyArMjM4NSw3IEBAIHN0YXRpYyBp bnQgZHJtX3BpY2tfY3J0Y3Moc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlciwKPiA+ICAJ Zm9yIChjID0gMDsgYyA8IGZiX2hlbHBlci0+Y3J0Y19jb3VudDsgYysrKSB7Cj4gPiAgCQljcnRj ID0gJmZiX2hlbHBlci0+Y3J0Y19pbmZvW2NdOwo+ID4gIAo+ID4gLQkJaWYgKChlbmNvZGVyLT5w b3NzaWJsZV9jcnRjcyAmICgxIDw8IGMpKSA9PSAwKQo+ID4gKwkJaWYgKCFjb25uZWN0b3JfY3J0 Y19vayhjb25uZWN0b3IsIGNydGMtPm1vZGVfc2V0LmNydGMpKQo+ID4gIAkJCWNvbnRpbnVlOwo+ ID4gIAo+ID4gIAkJZm9yIChvID0gMDsgbyA8IG47IG8rKykKPiA+IEBAIC0yNDEwLDcgKzI0MTIs NyBAQCBzdGF0aWMgaW50IGRybV9waWNrX2NydGNzKHN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9o ZWxwZXIsCj4gPiAgCQkJICAgICAgIHNpemVvZihzdHJ1Y3QgZHJtX2ZiX2hlbHBlcl9jcnRjICop KTsKPiA+ICAJCX0KPiA+ICAJfQo+ID4gLW91dDoKPiA+ICsKPiA+ICAJa2ZyZWUoY3J0Y3MpOwo+ ID4gIAlyZXR1cm4gYmVzdF9zY29yZTsKPiA+ICB9Cj4gPiAtLSAKPiA+IDIuMTYuNAo+ID4gCj4g Cj4gLS0gCj4gRGFuaWVsIFZldHRlcgo+IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3Jh dGlvbgo+IGh0dHA6Ly9ibG9nLmZmd2xsLmNoCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=