From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/3] drm: Introduce __setplane_atomic() Date: Thu, 28 Jun 2018 20:36:49 +0300 Message-ID: <20180628173649.GP20518@intel.com> References: <20180628135457.14647-1-ville.syrjala@linux.intel.com> <20180628135457.14647-2-ville.syrjala@linux.intel.com> <20180628170510.GX13978@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180628170510.GX13978@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdW4gMjgsIDIwMTggYXQgMDc6MDU6MTBQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUaHUsIEp1biAyOCwgMjAxOCBhdCAwNDo1NDo1NlBNICswMzAwLCBWaWxsZSBT eXJqYWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiA+IAo+ID4gQWxsIHRoZSBwbGFuZS0+ZmIvb2xkX2ZiL2NydGMgZGFu Y2Ugb2YgX19zZXRwbGFuZV9pbnRlcm5hbCgpIGlzCj4gPiBwb2ludGxlc3Mgb24gYXRvbWljIGRy aXZlcnMuIFNvIGxldCdzIGp1c3QgaW50cm9kdWNlIGEgc2ltcGxlcgo+ID4gdmVyc2lvbiB0aGF0 IHNraXBzIGFsbCB0aGF0Lgo+ID4gCj4gPiBJZGVhbGx5IHdlIGNvdWxkIGFsc28gc2tpcCB0aGUg X19zZXRwbGFuZV9jaGVjaygpIGFzCj4gPiBkcm1fYXRvbWljX3BsYW5lX2NoZWNrKCkgYWxyZWFk eSBjaGVja3MgZm9yIGV2ZXJ5dGhpbmcsIGJ1dCB0aGUKPiA+IGxlZ2FjeSBjdXJzb3IvImFzeW5j IiAudXBkYXRlX3BsYW5lKCkgdHJpY2tzIGJ5cGFzcyB0aGF0IHNvCj4gPiB3ZSBzdGlsbCBuZWVk IHRvIGNhbGwgX19zZXRwbGFuZV9jaGVjaygpLiBUb3NzIGluIGEgRklYTUUgdG8KPiA+IHJlbWlu ZCBzb21lb25lIHRvIGNsZWFuIHRoaXMgdXAgbGF0ZXIuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6 IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAtLS0K PiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMgfCA2OCArKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrLS0tLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgNTcgaW5zZXJ0 aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vZHJtX3BsYW5lLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMKPiA+IGluZGV4 IDVjOTdhMDEzMTQ4NC4uNTg3MDIzNDA4MDhjIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2RybV9wbGFuZS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMKPiA+ IEBAIC02NDksNiArNjQ5LDggQEAgc3RhdGljIGludCBfX3NldHBsYW5lX2ludGVybmFsKHN0cnVj dCBkcm1fcGxhbmUgKnBsYW5lLAo+ID4gIHsKPiA+ICAJaW50IHJldCA9IDA7Cj4gPiAgCj4gPiAr CVdBUk5fT04ocGxhbmUtPnN0YXRlKTsKPiA+ICsKPiA+ICAJLyogTm8gZmIgbWVhbnMgc2h1dCBp dCBkb3duICovCj4gPiAgCWlmICghZmIpIHsKPiA+ICAJCXBsYW5lLT5vbGRfZmIgPSBwbGFuZS0+ ZmI7Cj4gPiBAQCAtNjczLDExICs2NzUsOSBAQCBzdGF0aWMgaW50IF9fc2V0cGxhbmVfaW50ZXJu YWwoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gPiAgCQkJCQkgY3J0Y194LCBjcnRjX3ksIGNy dGNfdywgY3J0Y19oLAo+ID4gIAkJCQkJIHNyY194LCBzcmNfeSwgc3JjX3csIHNyY19oLCBjdHgp Owo+ID4gIAlpZiAoIXJldCkgewo+ID4gLQkJaWYgKCFwbGFuZS0+c3RhdGUpIHsKPiA+IC0JCQlw bGFuZS0+Y3J0YyA9IGNydGM7Cj4gPiAtCQkJcGxhbmUtPmZiID0gZmI7Cj4gPiAtCQkJZHJtX2Zy YW1lYnVmZmVyX2dldChwbGFuZS0+ZmIpOwo+ID4gLQkJfQo+ID4gKwkJcGxhbmUtPmNydGMgPSBj cnRjOwo+ID4gKwkJcGxhbmUtPmZiID0gZmI7Cj4gPiArCQlkcm1fZnJhbWVidWZmZXJfZ2V0KHBs YW5lLT5mYik7Cj4gPiAgCX0gZWxzZSB7Cj4gPiAgCQlwbGFuZS0+b2xkX2ZiID0gTlVMTDsKPiA+ ICAJfQo+ID4gQEAgLTY5MCw2ICs2OTAsNDEgQEAgc3RhdGljIGludCBfX3NldHBsYW5lX2ludGVy bmFsKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ID4gIAlyZXR1cm4gcmV0Owo+ID4gIH0KPiA+ ICAKPiA+ICtzdGF0aWMgaW50IF9fc2V0cGxhbmVfYXRvbWljKHN0cnVjdCBkcm1fcGxhbmUgKnBs YW5lLAo+ID4gKwkJCSAgICAgc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ID4gKwkJCSAgICAgc3Ry dWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIsCj4gPiArCQkJICAgICBpbnQzMl90IGNydGNfeCwgaW50 MzJfdCBjcnRjX3ksCj4gPiArCQkJICAgICB1aW50MzJfdCBjcnRjX3csIHVpbnQzMl90IGNydGNf aCwKPiA+ICsJCQkgICAgIHVpbnQzMl90IHNyY194LCB1aW50MzJfdCBzcmNfeSwKPiA+ICsJCQkg ICAgIHVpbnQzMl90IHNyY193LCB1aW50MzJfdCBzcmNfaCwKPiA+ICsJCQkgICAgIHN0cnVjdCBk cm1fbW9kZXNldF9hY3F1aXJlX2N0eCAqY3R4KQo+ID4gK3sKPiA+ICsJaW50IHJldDsKPiA+ICsK PiA+ICsJV0FSTl9PTighcGxhbmUtPnN0YXRlKTsKPiA+ICsKPiA+ICsJLyogTm8gZmIgbWVhbnMg c2h1dCBpdCBkb3duICovCj4gPiArCWlmICghZmIpCj4gPiArCQlyZXR1cm4gcGxhbmUtPmZ1bmNz LT5kaXNhYmxlX3BsYW5lKHBsYW5lLCBjdHgpOwo+ID4gKwo+ID4gKwkvKgo+ID4gKwkgKiBGSVhN RTogVGhpcyBpcyByZWR1bmRhbnQgd2l0aCBkcm1fYXRvbWljX3BsYW5lX2NoZWNrKCksCj4gPiAr CSAqIGJ1dCB0aGUgbGVnYWN5IGN1cnNvci8iYXN5bmMiIC51cGRhdGVfcGxhbmUoKSB0cmlja3MK PiA+ICsJICogZG9uJ3QgY2FsbCB0aGF0IHNvIHdlIHN0aWxsIG5lZWQgdGhpcyBoZXJlLiBTaG91 bGQgcmVtb3ZlCj4gPiArCSAqIHRoaXMgd2hlbiBhbGwgLnVwZGF0ZV9wbGFuZSgpIGltcGxlbWVu dGF0aW9ucyBoYXZlIGJlZW4KPiA+ICsJICogZml4ZWQgdG8gY2FsbCBkcm1fYXRvbWljX3BsYW5l X2NoZWNrKCkuCj4gPiArCSAqLwo+ID4gKwlyZXQgPSBfX3NldHBsYW5lX2NoZWNrKHBsYW5lLCBj cnRjLCBmYiwKPiA+ICsJCQkgICAgICAgY3J0Y194LCBjcnRjX3ksIGNydGNfdywgY3J0Y19oLAo+ ID4gKwkJCSAgICAgICBzcmNfeCwgc3JjX3ksIHNyY193LCBzcmNfaCk7Cj4gPiArCWlmIChyZXQp Cj4gPiArCQlyZXR1cm4gcmV0Owo+ID4gKwo+ID4gKwlyZXR1cm4gcGxhbmUtPmZ1bmNzLT51cGRh dGVfcGxhbmUocGxhbmUsIGNydGMsIGZiLAo+ID4gKwkJCQkJICBjcnRjX3gsIGNydGNfeSwgY3J0 Y193LCBjcnRjX2gsCj4gPiArCQkJCQkgIHNyY194LCBzcmNfeSwgc3JjX3csIHNyY19oLCBjdHgp Owo+ID4gK30KPiA+ICsKPiA+ICBzdGF0aWMgaW50IHNldHBsYW5lX2ludGVybmFsKHN0cnVjdCBk cm1fcGxhbmUgKnBsYW5lLAo+ID4gIAkJCSAgICAgc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ID4g IAkJCSAgICAgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIsCj4gPiBAQCAtNzA3LDkgKzc0Miwx NSBAQCBzdGF0aWMgaW50IHNldHBsYW5lX2ludGVybmFsKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5l LAo+ID4gIAlyZXQgPSBkcm1fbW9kZXNldF9sb2NrX2FsbF9jdHgocGxhbmUtPmRldiwgJmN0eCk7 Cj4gPiAgCWlmIChyZXQpCj4gPiAgCQlnb3RvIGZhaWw7Cj4gPiAtCXJldCA9IF9fc2V0cGxhbmVf aW50ZXJuYWwocGxhbmUsIGNydGMsIGZiLAo+ID4gLQkJCQkgIGNydGNfeCwgY3J0Y195LCBjcnRj X3csIGNydGNfaCwKPiA+IC0JCQkJICBzcmNfeCwgc3JjX3ksIHNyY193LCBzcmNfaCwgJmN0eCk7 Cj4gPiArCj4gPiArCWlmIChwbGFuZS0+c3RhdGUpCj4gCj4gV2UncmUgbm90IDEwMCUgY29uc2lz dGVudCwgYnV0IEkgdGhpbmsgdGhpcyBoZXJlIHdpbGwgbWFrZSBsaWZlIGhhcmRlciBmb3IKPiBk cml2ZXJzIHRyYW5zaXRpb25pbmcgdG8gYXRvbWljLiBOb3QgbWFueSBsZWZ0LCBidXQgc3RpbGwg c29tZS4KPiAKPiBQbGVhc2UgdXNlIGRybV9kcnZfdXNlc19hdG9taWNfbW9kZXNldCgpIGluc3Rl YWQgYW5kIGNoZWNrIGluc3RlYWQgZm9yCj4gRFJJVkVSX0FUT01JQyBpbiB5b3VyIFdBUk5fT04g aW4gYWxsIHRoZSBwbGFjZXMgeW91J3JlIGNoZWNraW5nIGZvcgo+IC0+c3RhdGUgaW4gdGhpcyBw YXRjaCBhbmQgdGhlIG5leHQgb25lLgoKV2UncmUgYWxyZWFkeSB1c2luZyBvYmotPnN0YXRlIGFz IHRoZSBhdG9taWMgaW5kaWNhdG9yIGhlcmUsCnNvIHRoaXMgcGF0Y2ggaXRzZWxmIGlzbid0IGNo YW5naW5nIGFueXRoaW5nLgoKSSBndWVzcyB5b3UncmUgc3VnZ2VzdGluZyB0aGF0IHdlIGNoYW5n ZSBhbGwgdGhlIC0+c3RhdGUgY2hlY2tzCndlIGFscmVhZHkgaGF2ZSB0byB0aGUgdXNlc19hdG9t aWMoKSB0aGluZyBpbnN0ZWFkPyBBbmQgdGhlCmFpbSBpcyB0byBhbGxvdyBkcml2ZXMgdG8gYWRk IG9iai0+c3RhdGUgYmVmb3JlIGFjdHVhbGx5CmltcGxlbWVudGluZyBhdG9taWMgZnVsbHk/IFRv IG1lIHRoYXQgZmVlbHMgbGlrZSBhc2tpbmcgZm9yCnRyb3VibGUsIGJ1dCB3aG8ga25vd3MsIG1h eWJlIEknbSB3cm9uZy4KCj4gCj4gV2l0aCB0aGF0IGZpeGVkLCBvbiB0aGUgc2VyaWVzOgo+IAo+ IFJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IAo+ ID4gKwkJcmV0ID0gX19zZXRwbGFuZV9hdG9taWMocGxhbmUsIGNydGMsIGZiLAo+ID4gKwkJCQkJ Y3J0Y194LCBjcnRjX3ksIGNydGNfdywgY3J0Y19oLAo+ID4gKwkJCQkJc3JjX3gsIHNyY195LCBz cmNfdywgc3JjX2gsICZjdHgpOwo+ID4gKwllbHNlCj4gPiArCQlyZXQgPSBfX3NldHBsYW5lX2lu dGVybmFsKHBsYW5lLCBjcnRjLCBmYiwKPiA+ICsJCQkJCSAgY3J0Y194LCBjcnRjX3ksIGNydGNf dywgY3J0Y19oLAo+ID4gKwkJCQkJICBzcmNfeCwgc3JjX3ksIHNyY193LCBzcmNfaCwgJmN0eCk7 Cj4gPiAgCj4gPiAgZmFpbDoKPiA+ICAJaWYgKHJldCA9PSAtRURFQURMSykgewo+ID4gQEAgLTg0 MSw5ICs4ODIsMTQgQEAgc3RhdGljIGludCBkcm1fbW9kZV9jdXJzb3JfdW5pdmVyc2FsKHN0cnVj dCBkcm1fY3J0YyAqY3J0YywKPiA+ICAJCXNyY19oID0gZmItPmhlaWdodCA8PCAxNjsKPiA+ICAJ fQo+ID4gIAo+ID4gLQlyZXQgPSBfX3NldHBsYW5lX2ludGVybmFsKHBsYW5lLCBjcnRjLCBmYiwK PiA+IC0JCQkJICBjcnRjX3gsIGNydGNfeSwgY3J0Y193LCBjcnRjX2gsCj4gPiAtCQkJCSAgMCwg MCwgc3JjX3csIHNyY19oLCBjdHgpOwo+ID4gKwlpZiAocGxhbmUtPnN0YXRlKQo+ID4gKwkJcmV0 ID0gX19zZXRwbGFuZV9hdG9taWMocGxhbmUsIGNydGMsIGZiLAo+ID4gKwkJCQkJY3J0Y194LCBj cnRjX3ksIGNydGNfdywgY3J0Y19oLAo+ID4gKwkJCQkJMCwgMCwgc3JjX3csIHNyY19oLCBjdHgp Owo+ID4gKwllbHNlCj4gPiArCQlyZXQgPSBfX3NldHBsYW5lX2ludGVybmFsKHBsYW5lLCBjcnRj LCBmYiwKPiA+ICsJCQkJCSAgY3J0Y194LCBjcnRjX3ksIGNydGNfdywgY3J0Y19oLAo+ID4gKwkJ CQkJICAwLCAwLCBzcmNfdywgc3JjX2gsIGN0eCk7Cj4gPiAgCj4gPiAgCWlmIChmYikKPiA+ICAJ CWRybV9mcmFtZWJ1ZmZlcl9wdXQoZmIpOwo+ID4gLS0gCj4gPiAyLjE2LjQKPiA+IAo+ID4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IGRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKPiA+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCj4g Cj4gLS0gCj4gRGFuaWVsIFZldHRlcgo+IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3Jh dGlvbgo+IGh0dHA6Ly9ibG9nLmZmd2xsLmNoCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=