From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915: encourage BIT() macro usage in
 register definitions
Date: Thu, 28 Jun 2018 12:05:59 -0700
Message-ID: <20180628190559.GI20915@intel.com>
References: <20180627144113.6989-1-jani.nikula@intel.com>
 <op.zk9ycgfaxaggs7@mwajdecz-mobl1.ger.corp.intel.com>
 <153011517949.8693.5606799904077354457@mail.alporthouse.com>
 <87sh57rud8.fsf@intel.com> <1530207902.2636.11.camel@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 6EFF06EE4F
 for <intel-gfx@lists.freedesktop.org>; Thu, 28 Jun 2018 19:06:00 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <1530207902.2636.11.camel@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBKdW4gMjgsIDIwMTggYXQgMTA6NDU6MDJBTSAtMDcwMCwgUGF1bG8gWmFub25pIHdy
b3RlOgo+IEVtIFF1aSwgMjAxOC0wNi0yOCDDoHMgMTU6MDMgKzAzMDAsIEphbmkgTmlrdWxhIGVz
Y3JldmV1Ogo+ID4gT24gV2VkLCAyNyBKdW4gMjAxOCwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJp
cy13aWxzb24uY28udWs+IHdyb3RlOgo+ID4gPiBRdW90aW5nIE1pY2hhbCBXYWpkZWN6a28gKDIw
MTgtMDYtMjcgMTY6NTE6NDIpCj4gPiA+ID4gT24gV2VkLCAyNyBKdW4gMjAxOCAxNjo0MToxMyAr
MDIwMCwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGUKPiA+ID4gPiBsLmNvbT4gIAo+ID4g
PiA+IHdyb3RlOgo+ID4gPiA+IAo+ID4gPiA+ID4gVGhlcmUncyBhbHJlYWR5IHNvbWUgQklUKCkg
dXNhZ2UgaGVyZSBhbmQgdGhlcmUsIGVtYnJhY2UgaXQuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IENj
OiBQYXVsbyBaYW5vbmkgPHBhdWxvLnIuemFub25pQGludGVsLmNvbT4KPiAKPiBTaW5jZSBJJ20g
Q0MnZCBJIGd1ZXNzIG15IG9waW5pb24gY291bnRzIGhlcmUgOikKPiAKPiAKPiA+ID4gPiA+IFNp
Z25lZC1vZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gPiA+ID4g
PiAtLS0KPiA+ID4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oIHwgOSArKysr
Ky0tLS0KPiA+ID4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCA0IGRlbGV0
aW9ucygtKQo+ID4gPiA+ID4gCj4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaTkxNV9yZWcuaCAgCj4gPiA+ID4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf
cmVnLmgKPiA+ID4gPiA+IGluZGV4IDQ3NjExOGY0NmNmMy4uNjRiOWMyNzAwNDVkIDEwMDY0NAo+
ID4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4gPiA+ID4g
KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4gPiA+ID4gQEAgLTY1LDkg
KzY1LDEwIEBACj4gPiA+ID4gPiAgICogYnV0IGRvIG5vdGUgdGhhdCB0aGUgbWFjcm9zIG1heSBi
ZSBuZWVkZWQgdG8gcmVhZCBhcyB3ZWxsCj4gPiA+ID4gPiBhcyB3cml0ZSAgCj4gPiA+ID4gPiB0
aGUKPiA+ID4gPiA+ICAgKiByZWdpc3RlciBjb250ZW50cy4KPiA+ID4gPiA+ICAgKgo+ID4gPiA+
ID4gLSAqIERlZmluZSBiaXRzIHVzaW5nIGBgKDEgPDwgTilgYCBpbnN0ZWFkIG9mIGBgQklUKE4p
YGAuIFdlCj4gPiA+ID4gPiBtYXkgY2hhbmdlICAKPiA+ID4gPiA+IHRoaXMgaW4KPiA+ID4gPiA+
IC0gKiB0aGUgZnV0dXJlLCBidXQgdGhpcyBpcyB0aGUgcHJldmFpbGluZyBzdHlsZS4gRG8gKipu
b3QqKgo+ID4gPiA+ID4gYWRkICAKPiA+ID4gPiA+IGBgX0JJVGBgIHN1ZmZpeAo+ID4gPiA+ID4g
LSAqIHRvIHRoZSBuYW1lLgo+ID4gPiA+ID4gKyAqIERlZmluZSBiaXRzIHVzaW5nIGBgQklUKE4p
YGAgaW5zdGVhZCBvZiBgYCgxIDw8IE4pYGAuIERvCj4gPiA+ID4gPiAqKm5vdCoqIGFkZCAgCj4g
PiA+ID4gPiBgYF9CSVRgYAo+ID4gPiA+ID4gKyAqIHN1ZmZpeCB0byB0aGUgbmFtZS4gRXhjZXB0
aW9uIHRvIGBgQklUKClgYCB1c2FnZTogVmFsdWUgMQo+ID4gPiA+ID4gZm9yIGEgYml0ICAKPiA+
ID4gPiA+IGZpZWxkCj4gPiA+ID4gPiArICogc2hvdWxkIGJlIGRlZmluZWQgdXNpbmcgYGAoMSA8
PCBOKWBgIHRvIGJlIGluIGxpbmUgd2l0aAo+ID4gPiA+ID4gb3RoZXIgdmFsdWVzICAKPiA+ID4g
PiA+IHN1Y2ggYXMKPiA+ID4gPiA+ICsgKiBgYCgyIDw8IE4pYGAgZm9yIHRoZSBzYW1lIGZpZWxk
Lgo+ID4gPiA+ID4gICAqCj4gPiA+ID4gPiAgICogR3JvdXAgdGhlIHJlZ2lzdGVyIGFuZCBpdHMg
Y29udGVudHMgdG9nZXRoZXIgd2l0aG91dCBibGFuawo+ID4gPiA+ID4gbGluZXMsICAKPiA+ID4g
PiA+IHNlcGFyYXRlCj4gPiA+ID4gPiAgICogZnJvbSBvdGhlciByZWdpc3RlcnMgYW5kIHRoZWly
IGNvbnRlbnRzIHdpdGggb25lIGJsYW5rCj4gPiA+ID4gPiBsaW5lLgo+ID4gPiA+ID4gQEAgLTEw
NSw3ICsxMDYsNyBAQAo+ID4gPiA+ID4gICAqICAjZGVmaW5lIF9GT09fQSAgICAgICAgICAgICAg
ICAgICAgICAweGYwMDAKPiA+ID4gPiA+ICAgKiAgI2RlZmluZSBfRk9PX0IgICAgICAgICAgICAg
ICAgICAgICAgMHhmMDAxCj4gPiA+ID4gPiAgICogICNkZWZpbmUgRk9PKHBpcGUpICAgICAgICAg
ICAgICAgICAgIF9NTUlPX1BJUEUocGlwZSwKPiA+ID4gPiA+IF9GT09fQSwgX0ZPT19CKQo+ID4g
PiA+ID4gLSAqICAjZGVmaW5lICAgRk9PX0VOQUJMRSAgICAgICAgICAgICAgICAoMSA8PCAzMSkK
PiA+ID4gPiA+ICsgKiAgI2RlZmluZSAgIEZPT19FTkFCTEUgICAgICAgICAgICAgICAgQklUKDMx
KQo+ID4gPiA+IAo+ID4gPiA+IGhtbSwgdGhpcyBicmVha3MgbmljZSBjb25zaXN0ZW5jeSBiZXR3
ZWVuIG9uZS0gYW5kIG11bHRpLWJpdAo+ID4gPiA+IGZpZWxkcyAuLgo+IAo+IEknbGwgYWdyZWUg
d2l0aCBNaWNoYWwgYW5kIENocmlzIGhlcmU6IEknbSBub3QgYSBodWdlIGZhbiBvZiBtaXhpbmcK
PiBCSVQoKSBhbmQgKHggPDwgeSksIEkgd291bGQgcHJlZmVyIHRvIGtlZXAgdGhlIGN1cnJlbnQg
c3RhbmRhcmQsCj4gZXNwZWNpYWxseSBzaW5jZSBCSVQoKSBpcyBlYXNpbHkgYmxhY2tsaXN0YWJs
ZS4gT3IgZnVsbHkgZW1icmFjZSB0aGUKPiBoZWxwZXIgbWFjcm9zIGFuZCBhYm9saXNoIGFsbCBz
b3J0cyBvZiAoeCA8PCB5KS4gQ29uc2lzdGVuY3kgd2lucyBJTUhPLgoKKzEgZm9yIHRoZSBDb25z
aXN0ZW5jeS4KCj4gCj4gPiA+ID4gCj4gPiA+ID4gPiAgICogICNkZWZpbmUgICBGT09fTU9ERV9N
QVNLICAgICAgICAgICAgICgweGYgPDwgMTYpCj4gPiA+ID4gCj4gPiA+ID4gLi4gYnV0IGlmIHlv
dSB3YW50IHRvIHVzZSBtYWNybyBmb3Igc2luZ2xlIGJpdCwgdGhlbiBtYXliZSB5b3UKPiA+ID4g
PiBzaG91bGQKPiA+ID4gPiBhbHNvIGNvbnNpZGVyIG90aGVyIGV4aXN0aW5nIG1hY3JvIGZvciB0
aGUgbWFzayBkZWZpbml0aW9uOgo+ID4gPiA+IAo+ID4gPiA+ICAgICAgICAgI2RlZmluZSAgIEZP
T19NT0RFX01BU0sgICAgICAgICAgICAgR0VOTUFTSygxOSwgMTYpCj4gPiA+ID4gCj4gPiA+ID4g
PiAgICogICNkZWZpbmUgICBGT09fTU9ERV9TSElGVCAgICAgICAgICAgIDE2Cj4gPiA+ID4gPiAg
ICogICNkZWZpbmUgICBGT09fTU9ERV9CQVIgICAgICAgICAgICAgICgwIDw8IDE2KQo+ID4gPiA+
IAo+ID4gPiA+IC4uIGJ1dCB3ZSBzdGlsbCBkb24ndCBoYXZlIGFueSBtYWNybyBmb3IgZGVmaW5p
bmcgbXVsdGktYml0Cj4gPiA+ID4gdmFsdWVzCj4gPiA+ID4gc28gSSdtIG5vdCBzdXJlIGlmIHRo
aXMgY2hhbmdlIHdpbGwgbWFrZSBjb2RlIHJlYWxseSBlYXNpZXIgdG8KPiA+ID4gPiByZWFkCj4g
PiA+IAo+ID4gPiAjaW5jbHVkZSA8bGludXgvYml0ZmllbGQuaD4KPiA+ID4gCj4gPiA+IEknbSBu
b3Qgc3VyZSBpZiBJJ20gcmVhZHkgdG8gZW1icmFjZSB0aGF0IHlldCwgYnV0IGl0IGRvZXMgc2Vl
bSB0bwo+ID4gPiBiZQo+ID4gPiB0aGUgZGlyZWN0aW9uIHdlIHNob3VsZCBiZSBoZWFkaW5nIGlu
LiBQcmltYXJpbHkgdG8gY2hlY2sgdGhlCj4gPiA+IGludmFsaWQKPiA+ID4gcmFuZ2UgY2hlY2tp
bmcgJiB1c2FnZS4KPiA+IAo+ID4gSSBndWVzcyB0aGVyZSBhcmUgdHdvIHRoaW5ncyBoZXJlLiBV
c2luZyBiaXRmaWVsZC5oIG1hY3JvcyB0byBkZWZpbmUKPiA+IG91cgo+ID4gb3duIHN0dWZmIGlz
IG9uZSB0aGluZywgbGlrZSBzbzoKPiA+IAo+ID4gI2RlZmluZSAgIEZPT19FTkFCTEUgICAgICAg
ICAgICAgICAgQklUKDMxKQo+ID4gI2RlZmluZSAgIEZPT19NT0RFX01BU0sgICAgICAgICAgICAg
R0VOTUFTSygxOSwgMTYpCj4gPiAjZGVmaW5lICAgRk9PX01PREVfU0hJRlQgICAgICAgICAgICAx
Ngo+ID4gI2RlZmluZSAgIEZPT19NT0RFX0JBUiAgICAgICAgICAgICAgRklFTERfUFJFUChGT09f
TU9ERV9NQVNLLCAwKQo+ID4gI2RlZmluZSAgIEZPT19NT0RFX0JBWiAgICAgICAgICAgICAgRklF
TERfUFJFUChGT09fTU9ERV9NQVNLLCAxKQo+ID4gI2RlZmluZSAgIEZPT19NT0RFX1FVWF9TTkIg
ICAgICAgICAgRklFTERfUFJFUChGT09fTU9ERV9NQVNLLCAyKQo+ID4gCj4gPiBUaGUgcmFuZ2Ug
Y2hlY2tpbmcgaXMgaW5kZWVkIGFuIGFkdmFudGFnZS4KPiA+IAo+ID4gVXNpbmcgRklFTERfUFJF
UCgpIG9yIEZJRUxEX0dFVCgpIGluIGNvZGUgaXMgYW5vdGhlciwgYmVjYXVzZSB3ZQo+ID4gY3Vy
cmVudGx5IGRvbid0IGRlZmluZSB0aGUgKnVuc2hpZnRlZCogZmllbGQgdmFsdWVzLiBFdmVyeXRo
aW5nIGlzCj4gPiBkZWZpbmVkIHdpdGggdGhlIHNoaWZ0LiBEZWZpbmluZyBldmVyeXRoaW5nIHVu
c2hpZnRlZCBhbmQgdGhlbiBtb3ZpbmcKPiA+IHRoZSBGSUVMRF9QUkVQKCkgYW5kIEZJRUxEX0dF
VCgpIGluIGNvZGUgd291bGQgYmUgcXVpdGUgdGhlIGNoYW5nZS4KPiAKPiBDYW4ndCB3ZSBjcmVh
dGUgc2ltcGxlIG1hY3JvcyB0aGF0IGNvdmVyIG91ciBjYXNlcyB0aGVuPwo+IAo+ICh5ZXMsIHRo
YXQgd291bGQgcGVyaGFwcyBiZSBtb3JlIGRpdmVyZ2VuY2UgZnJvbSB0aGUgS2VybmVsIGNvZGlu
Zwo+IHN0YW5kYXJkcywgd2hpY2ggY291bGQgYmUgd29yc2UgdGhhbiB1c2luZyAoeCA8PCB5KSB0
aGF0IGFyZSBub3QgaGlkZGVuCj4gYnkgbm9uc3RhbmRhcmQgbWFjcm9zKQoKSSBmdWxseSBhZ3Jl
ZSB3aXRoIHRoZW0sIHNvIEknbSBhY3R1YWxseSBkcm9wcGluZyBteSBhY2sgd2hpbGUKd2UgZG9u
J3QgZmluZCByb3VnaCBhZ3JlZW1lbnQgb24gaG93IHRvIG1vdmUgZm9yd2FyZCB3aXRob3V0IG1v
cmUgY29uc2lzdGVuY3kuCgo+IAo+IAo+ID4gCj4gPiBCUiwKPiA+IEphbmkuCj4gPiAKPiBfX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBt
YWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9s
aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg
bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl
c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==