From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH xf86-video-intel 2/6] sna/gen6+: Split out wm_kernel from the sna_composite_op flags
Date: Wed, 4 Jul 2018 22:20:26 +0300 [thread overview]
Message-ID: <20180704192026.GV5565@intel.com> (raw)
In-Reply-To: <153073132921.15734.2650838874617052077@skylake.alporthouse.com>
On Wed, Jul 04, 2018 at 08:08:49PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjala (2018-07-04 19:59:15)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > With the extra video kernels we already ran out of bits in
> > the flags. To tackle that let's just split out the
> > wm_kernel to its own thing.
>
> Does make one wish we had used push constants or loading them from a
> constant surface. Oh well, stick to the path of least resistance. Looks
> fine, but I should double check the asm at the end.
Yeah. I should really rewrite these things to use the brw thing, at
which point I imagine it would be feasible to pass in some constants
as well. So far the motivation has escaped me.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-07-04 19:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 18:59 [PATCH xf86-video-intel 1/6] sna: Add SAMPLER_OFFSET() compile time asserts for gen6/7 Ville Syrjala
2018-07-04 18:59 ` [PATCH xf86-video-intel 2/6] sna/gen6+: Split out wm_kernel from the sna_composite_op flags Ville Syrjala
2018-07-04 19:08 ` Chris Wilson
2018-07-04 19:20 ` Ville Syrjälä [this message]
2018-07-04 18:59 ` [PATCH xf86-video-intel 3/6] sna/vide/textured: Rename yuv shaders to indicate they handle limited range data Ville Syrjala
2018-07-04 18:59 ` [PATCH xf86-video-intel 4/6] sna/video/textured: Add shaders to deal with full range yuv data Ville Syrjala
2018-07-04 18:59 ` [PATCH xf86-video-intel 5/6] sna/video/textured: Add XV_COLOR_RANGE port attribute Ville Syrjala
[not found] ` <20180704185919.30946-5-ville.syrjala-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-07-04 20:09 ` Ville Syrjälä
[not found] ` <20180704185919.30946-1-ville.syrjala-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-07-04 18:59 ` [PATCH xf86-video-intel 6/6] sna/video/sprite: " Ville Syrjala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704192026.GV5565@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).