From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/ddi: Simplify get_encoder_power_domains() Date: Thu, 5 Jul 2018 15:44:59 +0300 Message-ID: <20180705124459.GY5565@intel.com> References: <20180705122654.17072-1-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 264AA6ED45 for ; Thu, 5 Jul 2018 12:45:03 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180705122654.17072-1-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdWwgMDUsIDIwMTggYXQgMDM6MjY6NTRQTSArMDMwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IFdlIGNhbiBzaW1wbGlmeSB0aGUgZW5jb2RlcidzIGdldF9wb3dlcl9kb21haW5zKCkgaG9v ayBieSBjYWxsaW5nIGl0Cj4gb25seSBpZiB0aGUgZW5jb2RlciBpcyBhY3RpdmUuIFRoYXQgd2F5 IHRoZSBob29rIGNhbiByZXR1cm4gaXRzIHBvd2VyCj4gZG9tYWlucyB1bmNvbmRpdGlvbmFsbHkg d2l0aG91dCBjaGVja2luZyB0aGUgYWN0aXZlIHN0YXRlIGJ5IGNhbGxpbmcKPiBlbmNvZGVyOjpn ZXRfaHdfc3RhdGUoKS4gVGhpcyBnZXRfaHdfc3RhdGUoKSBxdWVyeSBpcyBpbiBmYWN0Cj4gcmVk dW5kYW50IHNpbmNlIGl0J3MgYWxyZWFkeSBkb25lIGJ5IGludGVsX21vZGVzZXRfcmVhZG91dF9o d19zdGF0ZSgpCj4gc2V0dGluZyB0aGUgZW5jb2RlcidzIGNydGMgb3IgbGVhdmluZyBpdCBOVUxM IGFjY29yZGluZ2x5LiBMZXQncyB1c2UKPiB0aGlzIGZhY3QgdG8gZGVjaWRlIGlmIHRoZSBlbmNv ZGVyIGlzIGFjdGl2ZS4KPiAKPiBXaGlsZSBhdCBpdCBjbGFyaWZ5IHRoZSBjb21tZW50IGluIGlu dGVsX2RkaV9nZXRfcG93ZXJfZG9tYWlucygpIGFib3V0Cj4gcHJpbWFyeSB2cy4gZmFrZSBNU1Qg ZW5jb2RlcnMgYW5kIG1ha2Ugc3VyZSB3ZSBuZXZlciBkbyBhbiBpbmNvcnJlY3QKPiBlbmNvZGVy LT5kaWdfcG9ydCBjYXN0IGZvciBmYWtlIE1TVCBlbmNvZGVycy4KPiAKPiBTdWdnZXN0ZWQtYnk6 IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IFZp bGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9m Zi1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IFZpbGxl IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyAgICAgfCAxOSArKysrKysrLS0tLS0tLS0tLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDExICsrKysrLS0tLS0t Cj4gIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBpbmRleCAwMzE5ODI1YjcyNWIuLjZiNzRlZWU1 YTNhYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gQEAgLTIwMDUsMjQgKzIwMDUs MTkgQEAgaW50ZWxfZGRpX21haW5fbGlua19hdXhfZG9tYWluKHN0cnVjdCBpbnRlbF9kcCAqaW50 ZWxfZHApCj4gIHN0YXRpYyB1NjQgaW50ZWxfZGRpX2dldF9wb3dlcl9kb21haW5zKHN0cnVjdCBp bnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJCQkJICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0 YXRlICpjcnRjX3N0YXRlKQo+ICB7Cj4gLQlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpkaWdf cG9ydCA9IGVuY190b19kaWdfcG9ydCgmZW5jb2Rlci0+YmFzZSk7Cj4gLQllbnVtIHBpcGUgcGlw ZTsKPiArCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0Owo+ICAJdTY0IGRvbWFp bnM7Cj4gIAo+IC0JaWYgKCFpbnRlbF9kZGlfZ2V0X2h3X3N0YXRlKGVuY29kZXIsICZwaXBlKSkK PiAtCQlyZXR1cm4gMDsKPiAtCj4gLQlkb21haW5zID0gQklUX1VMTChkaWdfcG9ydC0+ZGRpX2lv X3Bvd2VyX2RvbWFpbik7Cj4gLQlpZiAoIWNydGNfc3RhdGUpCj4gLQkJcmV0dXJuIGRvbWFpbnM7 Cj4gLQo+ICAJLyoKPiAgCSAqIFRPRE86IEFkZCBzdXBwb3J0IGZvciBNU1QgZW5jb2RlcnMuIEF0 bSwgdGhlIGZvbGxvd2luZyBzaG91bGQgbmV2ZXIKPiAtCSAqIGhhcHBlbiBzaW5jZSB0aGlzIGZ1 bmN0aW9uIHdpbGwgYmUgY2FsbGVkIG9ubHkgZm9yIHRoZSBwcmltYXJ5Cj4gLQkgKiBlbmNvZGVy IHdoaWNoIGRvZXNuJ3QgaGF2ZSBpdHMgb3duIHBpcGUvY3J0Y19zdGF0ZS4KPiArCSAqIGhhcHBl biBzaW5jZSBmYWtlLU1TVCBlbmNvZGVycyBkb24ndCBzZXQgdGhlaXIgZ2V0X3Bvd2VyX2RvbWFp bnMoKQo+ICsJICogaG9vay4KPiAgCSAqLwo+ICAJaWYgKFdBUk5fT04oaW50ZWxfY3J0Y19oYXNf dHlwZShjcnRjX3N0YXRlLCBJTlRFTF9PVVRQVVRfRFBfTVNUKSkpCj4gLQkJcmV0dXJuIGRvbWFp bnM7Cj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICsJZGlnX3BvcnQgPSBlbmNfdG9fZGlnX3BvcnQoJmVu Y29kZXItPmJhc2UpOwo+ICsJZG9tYWlucyA9IEJJVF9VTEwoZGlnX3BvcnQtPmRkaV9pb19wb3dl cl9kb21haW4pOwo+ICAKPiAgCS8qIEFVWCBwb3dlciBpcyBvbmx5IG5lZWRlZCBmb3IgKGUpRFAg bW9kZSwgbm90IGZvciBIRE1JLiAqLwo+ICAJaWYgKGludGVsX2NydGNfaGFzX2RwX2VuY29kZXIo Y3J0Y19zdGF0ZSkpIHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXgg NjgxZTA3MTBhNDY3Li5hNjFkYmRmMmY2MTIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jCj4gQEAgLTE1NzA1LDE0ICsxNTcwNSwxMyBAQCBnZXRfZW5jb2Rlcl9wb3dlcl9k b21haW5zKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCQkJY29udGludWU7 Cj4gIAo+ICAJCS8qCj4gLQkJICogRm9yIE1TVCBhbmQgaW5hY3RpdmUgZW5jb2RlcnMgd2UgZG9u J3QgaGF2ZSBhIGNydGMgc3RhdGUuCj4gLQkJICogRklYTUU6IG5vIG5lZWQgdG8gY2FsbCBnZXRf cG93ZXJfZG9tYWlucyBpbiBzdWNoIGNhc2VzLCBpdAo+IC0JCSAqIHdpbGwgYWx3YXlzIHJldHVy biAwLgo+ICsJCSAqIE1TVC1wcmltYXJ5IGFuZCBpbmFjdGl2ZSBlbmNvZGVycyBkb24ndCBoYXZl IGEgY3J0YyBzdGF0ZQo+ICsJCSAqIGFuZCBuZWl0aGVyIG9mIHRoZXNlIHJlcXVpcmUgYW55IHBv d2VyIGRvbWFpbiByZWZlcmVuY2VzLgo+ICAJCSAqLwo+IC0JCWNydGNfc3RhdGUgPSBlbmNvZGVy LT5iYXNlLmNydGMgPwo+IC0JCQkgICAgIHRvX2ludGVsX2NydGNfc3RhdGUoZW5jb2Rlci0+YmFz ZS5jcnRjLT5zdGF0ZSkgOgo+IC0JCQkgICAgIE5VTEw7Cj4gKwkJaWYgKCFlbmNvZGVyLT5iYXNl LmNydGMpCj4gKwkJCWNvbnRpbnVlOwo+ICAKPiArCQljcnRjX3N0YXRlID0gdG9faW50ZWxfY3J0 Y19zdGF0ZShlbmNvZGVyLT5iYXNlLmNydGMtPnN0YXRlKTsKPiAgCQlnZXRfZG9tYWlucyA9IGVu Y29kZXItPmdldF9wb3dlcl9kb21haW5zKGVuY29kZXIsIGNydGNfc3RhdGUpOwo+ICAJCWZvcl9l YWNoX3Bvd2VyX2RvbWFpbihkb21haW4sIGdldF9kb21haW5zKQo+ICAJCQlpbnRlbF9kaXNwbGF5 X3Bvd2VyX2dldChkZXZfcHJpdiwgZG9tYWluKTsKPiAtLSAKPiAyLjEzLjIKCi0tIApWaWxsZSBT eXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==