From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v2 1/9] drm/fb-helper: Eliminate the
 .best_encoder() usage
Date: Thu, 5 Jul 2018 16:59:39 +0300
Message-ID: <20180705135939.GA5565@intel.com>
References: <20180628131315.14156-1-ville.syrjala@linux.intel.com>
 <20180628131315.14156-2-ville.syrjala@linux.intel.com>
 <CADnq5_NnO82a55TMk0fA-5mbahJMRJRY6JZZg3_BO+gJYujSjw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <CADnq5_NnO82a55TMk0fA-5mbahJMRJRY6JZZg3_BO+gJYujSjw@mail.gmail.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>, Maling list - DRI developers <dri-devel@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBKdW4gMjgsIDIwMTggYXQgMTE6Mjc6MDdBTSAtMDQwMCwgQWxleCBEZXVjaGVyIHdy
b3RlOgo+IE9uIFRodSwgSnVuIDI4LCAyMDE4IGF0IDk6MTMgQU0sIFZpbGxlIFN5cmphbGEKPiA8
dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3ly
asOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+Cj4gPiBJbnN0ZWFkIG9m
IHVzaW5nIHRoZSAuYmVzdF9lbmNvZGVyKCkgaG9vayB0byBmaWd1cmUgb3V0IHdoZXRoZXIgYSBn
aXZlbgo+ID4gY29ubmVjdG9yK2NydGMgY29tYm8gd2lsbCB3b3JrLCBsZXQncyBpbnN0ZWFkIGRv
IHdoYXQgdXNlcnNwYWNlIGRvZXMgYW5kCj4gPiBqdXN0IGl0ZXJhdGUgb3ZlciBhbGwgdGhlIGVu
Y29kZXJzIGZvciB0aGUgY29ubmVjdG9yLCBhbmQgdGhlbiBjaGVjawo+ID4gZWFjaCBjcnRjIGFn
YWluc3QgZWFjaCBlbmNvZGVyJ3MgcG9zc2libGVfY3J0Y3MgYml0bWFzay4KPiA+Cj4gPiB2Mjog
QXZvaWQgb29wc2luZyBvbiBOVUxMIGVuY29kZXJzIChEYW5pZWwpCj4gPiAgICAgcy9jb25uZWN0
b3JfY3J0Y19vay9jb25uZWN0b3JfaGFzX3Bvc3NpYmxlX2NydGMvCj4gPgo+ID4gQ2M6IERoaW5h
a2FyYW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgo+ID4gQ2M6IEhh
cnJ5IFdlbnRsYW5kIDxoYXJyeS53ZW50bGFuZEBhbWQuY29tPgo+ID4gQ2M6IERhbmllbCBWZXR0
ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRl
ciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiA+IFJldmlld2VkLWJ5OiBBbGV4IERldWNoZXIg
PGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+ICN2MQo+ID4gU3VnZ2VzdGVkLWJ5OiBEYW5pZWwg
VmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUg
U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBTZXJpZXMgaXM6
Cj4gUmV2aWV3ZWQtYnk6IEFsZXggRGV1Y2hlciA8YWxleGFuZGVyLmRldWNoZXJAYW1kLmNvbT4K
ClRoYW5rcyBmb3IgdGhlIHJldmlldy4gU2VyaWVzIHB1c2hlZCB0byBkcm0tbWlzYy1uZXh0LgoK
PiAKPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMgfCA0MSArKysr
KysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2Vk
LCAyNCBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEv
ZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJf
aGVscGVyLmMKPiA+IGluZGV4IGNhYjE0ZjI1MzM4NC4uYjM3ZjA2MzE3ZDUxIDEwMDY0NAo+ID4g
LS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+ID4gKysrIGIvZHJpdmVycy9n
cHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+ID4gQEAgLTIzMjMsNiArMjMyMywyNyBAQCBzdGF0aWMg
Ym9vbCBkcm1fdGFyZ2V0X3ByZWZlcnJlZChzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVy
LAo+ID4gICAgICAgICByZXR1cm4gdHJ1ZTsKPiA+ICB9Cj4gPgo+ID4gK3N0YXRpYyBib29sIGNv
bm5lY3Rvcl9oYXNfcG9zc2libGVfY3J0YyhzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9y
LAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBkcm1f
Y3J0YyAqY3J0YykKPiA+ICt7Cj4gPiArICAgICAgIGludCBpOwo+ID4gKwo+ID4gKyAgICAgICBm
b3IgKGkgPSAwOyBpIDwgRFJNX0NPTk5FQ1RPUl9NQVhfRU5DT0RFUjsgaSsrKSB7Cj4gPiArICAg
ICAgICAgICAgICAgc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyOwo+ID4gKwo+ID4gKyAgICAg
ICAgICAgICAgIGlmIChjb25uZWN0b3ItPmVuY29kZXJfaWRzW2ldID09IDApCj4gPiArICAgICAg
ICAgICAgICAgICAgICAgICBicmVhazsKPiA+ICsKPiA+ICsgICAgICAgICAgICAgICBlbmNvZGVy
ID0gZHJtX2VuY29kZXJfZmluZChjb25uZWN0b3ItPmRldiwgTlVMTCwKPiA+ICsgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25uZWN0b3ItPmVuY29kZXJfaWRzW2ld
KTsKPiA+ICsKPiA+ICsgICAgICAgICAgICAgICBpZiAoZW5jb2Rlci0+cG9zc2libGVfY3J0Y3Mg
JiBkcm1fY3J0Y19tYXNrKGNydGMpKQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJu
IHRydWU7Cj4gPiArICAgICAgIH0KPiA+ICsKPiA+ICsgICAgICAgcmV0dXJuIGZhbHNlOwo+ID4g
K30KPiA+ICsKPiA+ICBzdGF0aWMgaW50IGRybV9waWNrX2NydGNzKHN0cnVjdCBkcm1fZmJfaGVs
cGVyICpmYl9oZWxwZXIsCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBkcm1f
ZmJfaGVscGVyX2NydGMgKipiZXN0X2NydGNzLAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAg
ICBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqKm1vZGVzLAo+ID4gQEAgLTIzMzEsNyArMjM1Miw2
IEBAIHN0YXRpYyBpbnQgZHJtX3BpY2tfY3J0Y3Moc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hl
bHBlciwKPiA+ICAgICAgICAgaW50IGMsIG87Cj4gPiAgICAgICAgIHN0cnVjdCBkcm1fY29ubmVj
dG9yICpjb25uZWN0b3I7Cj4gPiAgICAgICAgIGNvbnN0IHN0cnVjdCBkcm1fY29ubmVjdG9yX2hl
bHBlcl9mdW5jcyAqY29ubmVjdG9yX2Z1bmNzOwo+ID4gLSAgICAgICBzdHJ1Y3QgZHJtX2VuY29k
ZXIgKmVuY29kZXI7Cj4gPiAgICAgICAgIGludCBteV9zY29yZSwgYmVzdF9zY29yZSwgc2NvcmU7
Cj4gPiAgICAgICAgIHN0cnVjdCBkcm1fZmJfaGVscGVyX2NydGMgKipjcnRjcywgKmNydGM7Cj4g
PiAgICAgICAgIHN0cnVjdCBkcm1fZmJfaGVscGVyX2Nvbm5lY3RvciAqZmJfaGVscGVyX2Nvbm47
Cj4gPiBAQCAtMjM2MiwyMCArMjM4Miw2IEBAIHN0YXRpYyBpbnQgZHJtX3BpY2tfY3J0Y3Moc3Ry
dWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlciwKPiA+Cj4gPiAgICAgICAgIGNvbm5lY3Rvcl9m
dW5jcyA9IGNvbm5lY3Rvci0+aGVscGVyX3ByaXZhdGU7Cj4gPgo+ID4gLSAgICAgICAvKgo+ID4g
LSAgICAgICAgKiBJZiB0aGUgRFJNIGRldmljZSBpbXBsZW1lbnRzIGF0b21pYyBob29rcyBhbmQg
LT5iZXN0X2VuY29kZXIoKSBpcwo+ID4gLSAgICAgICAgKiBOVUxMIHdlIGZhbGxiYWNrIHRvIHRo
ZSBkZWZhdWx0IGRybV9hdG9taWNfaGVscGVyX2Jlc3RfZW5jb2RlcigpCj4gPiAtICAgICAgICAq
IGhlbHBlci4KPiA+IC0gICAgICAgICovCj4gPiAtICAgICAgIGlmIChkcm1fZHJ2X3VzZXNfYXRv
bWljX21vZGVzZXQoZmJfaGVscGVyLT5kZXYpICYmCj4gPiAtICAgICAgICAgICAhY29ubmVjdG9y
X2Z1bmNzLT5iZXN0X2VuY29kZXIpCj4gPiAtICAgICAgICAgICAgICAgZW5jb2RlciA9IGRybV9h
dG9taWNfaGVscGVyX2Jlc3RfZW5jb2Rlcihjb25uZWN0b3IpOwo+ID4gLSAgICAgICBlbHNlCj4g
PiAtICAgICAgICAgICAgICAgZW5jb2RlciA9IGNvbm5lY3Rvcl9mdW5jcy0+YmVzdF9lbmNvZGVy
KGNvbm5lY3Rvcik7Cj4gPiAtCj4gPiAtICAgICAgIGlmICghZW5jb2RlcikKPiA+IC0gICAgICAg
ICAgICAgICBnb3RvIG91dDsKPiA+IC0KPiA+ICAgICAgICAgLyoKPiA+ICAgICAgICAgICogc2Vs
ZWN0IGEgY3J0YyBmb3IgdGhpcyBjb25uZWN0b3IgYW5kIHRoZW4gYXR0ZW1wdCB0byBjb25maWd1
cmUKPiA+ICAgICAgICAgICogcmVtYWluaW5nIGNvbm5lY3RvcnMKPiA+IEBAIC0yMzgzLDcgKzIz
ODksOCBAQCBzdGF0aWMgaW50IGRybV9waWNrX2NydGNzKHN0cnVjdCBkcm1fZmJfaGVscGVyICpm
Yl9oZWxwZXIsCj4gPiAgICAgICAgIGZvciAoYyA9IDA7IGMgPCBmYl9oZWxwZXItPmNydGNfY291
bnQ7IGMrKykgewo+ID4gICAgICAgICAgICAgICAgIGNydGMgPSAmZmJfaGVscGVyLT5jcnRjX2lu
Zm9bY107Cj4gPgo+ID4gLSAgICAgICAgICAgICAgIGlmICgoZW5jb2Rlci0+cG9zc2libGVfY3J0
Y3MgJiAoMSA8PCBjKSkgPT0gMCkKPiA+ICsgICAgICAgICAgICAgICBpZiAoIWNvbm5lY3Rvcl9o
YXNfcG9zc2libGVfY3J0Yyhjb25uZWN0b3IsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgY3J0Yy0+bW9kZV9zZXQuY3J0YykpCj4gPiAgICAgICAg
ICAgICAgICAgICAgICAgICBjb250aW51ZTsKPiA+Cj4gPiAgICAgICAgICAgICAgICAgZm9yIChv
ID0gMDsgbyA8IG47IG8rKykKPiA+IEBAIC0yNDEwLDcgKzI0MTcsNyBAQCBzdGF0aWMgaW50IGRy
bV9waWNrX2NydGNzKHN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIsCj4gPiAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgc2l6ZW9mKHN0cnVjdCBkcm1fZmJfaGVscGVyX2NydGMg
KikpOwo+ID4gICAgICAgICAgICAgICAgIH0KPiA+ICAgICAgICAgfQo+ID4gLW91dDoKPiA+ICsK
PiA+ICAgICAgICAga2ZyZWUoY3J0Y3MpOwo+ID4gICAgICAgICByZXR1cm4gYmVzdF9zY29yZTsK
PiA+ICB9Cj4gPiAtLQo+ID4gMi4xNi40Cj4gPgo+ID4gX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX18KPiA+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiA+IGRy
aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0
b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKVmlsbGUgU3lyasOkbMOkCklu
dGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs
LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov
L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=