* [PATCH] drm/i915: Squelch very verbose error logging
@ 2018-07-05 18:24 Chris Wilson
2018-07-05 22:46 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2018-07-05 18:24 UTC (permalink / raw)
To: intel-gfx
Having found the error causing the IGT test to fail, downgrade the
verbose logging so that we stop flooding the syslogs as we deliberately
provoke it many thousands of time during selftests.
References: 10195b1e4411 ("drm/i915: Show vma allocator stack when in doubt")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/Kconfig.debug | 12 ++++++++++++
drivers/gpu/drm/i915/i915_vma.c | 2 +-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
index 9de8b1c51a5c..459f8f88a34c 100644
--- a/drivers/gpu/drm/i915/Kconfig.debug
+++ b/drivers/gpu/drm/i915/Kconfig.debug
@@ -51,6 +51,18 @@ config DRM_I915_DEBUG_GEM
If in doubt, say "N".
+config DRM_I915_ERRLOG_GEM
+ bool "Insert extra logging (very verbose) for common GEM errors"
+ default n
+ depends on DRM_I915_DEBUG_GEM
+ help
+ Enable additional logging that may help track down the cause of
+ principally userspace errors.
+
+ Recommended for driver developers only.
+
+ If in doubt, say "N".
+
config DRM_I915_TRACE_GEM
bool "Insert extra ftrace output from the GEM internals"
depends on DRM_I915_DEBUG_GEM
diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index de2b6d65e865..518de47111ff 100644
--- a/drivers/gpu/drm/i915/i915_vma.c
+++ b/drivers/gpu/drm/i915/i915_vma.c
@@ -30,7 +30,7 @@
#include <drm/drm_gem.h>
-#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM) && IS_ENABLED(CONFIG_DRM_DEBUG_MM)
+#if IS_ENABLED(CONFIG_DRM_I915_ERRLOG_GEM) && IS_ENABLED(CONFIG_DRM_DEBUG_MM)
#include <linux/stackdepot.h>
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Squelch very verbose error logging 2018-07-05 18:24 [PATCH] drm/i915: Squelch very verbose error logging Chris Wilson @ 2018-07-05 22:46 ` Patchwork 2018-07-05 22:46 ` ✗ Fi.CI.SPARSE: " Patchwork 2018-07-05 23:02 ` ✓ Fi.CI.BAT: success " Patchwork 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2018-07-05 22:46 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915: Squelch very verbose error logging URL : https://patchwork.freedesktop.org/series/46032/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2465d597588b drm/i915: Squelch very verbose error logging -:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #10: References: 10195b1e4411 ("drm/i915: Show vma allocator stack when in doubt") -:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 10195b1e4411 ("drm/i915: Show vma allocator stack when in doubt")' #10: References: 10195b1e4411 ("drm/i915: Show vma allocator stack when in doubt") total: 1 errors, 1 warnings, 0 checks, 26 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* ✗ Fi.CI.SPARSE: warning for drm/i915: Squelch very verbose error logging 2018-07-05 18:24 [PATCH] drm/i915: Squelch very verbose error logging Chris Wilson 2018-07-05 22:46 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork @ 2018-07-05 22:46 ` Patchwork 2018-07-05 23:02 ` ✓ Fi.CI.BAT: success " Patchwork 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2018-07-05 22:46 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915: Squelch very verbose error logging URL : https://patchwork.freedesktop.org/series/46032/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Squelch very verbose error logging + +Error in reading or end of file. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Squelch very verbose error logging 2018-07-05 18:24 [PATCH] drm/i915: Squelch very verbose error logging Chris Wilson 2018-07-05 22:46 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2018-07-05 22:46 ` ✗ Fi.CI.SPARSE: " Patchwork @ 2018-07-05 23:02 ` Patchwork 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2018-07-05 23:02 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915: Squelch very verbose error logging URL : https://patchwork.freedesktop.org/series/46032/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4438 -> Patchwork_9556 = == Summary - SUCCESS == No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/46032/revisions/1/mbox/ == Known issues == Here are the changes found in Patchwork_9556 that come from known issues: === IGT changes === ==== Issues hit ==== igt@kms_chamelium@hdmi-hpd-fast: fi-kbl-7500u: SKIP -> FAIL (fdo#102672, fdo#103841) ==== Possible fixes ==== igt@kms_frontbuffer_tracking@basic: fi-hsw-peppy: DMESG-FAIL (fdo#102614, fdo#106103) -> PASS igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b: fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614 fdo#102672 https://bugs.freedesktop.org/show_bug.cgi?id=102672 fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713 fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841 fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103 == Participating hosts (47 -> 42) == Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u == Build changes == * Linux: CI_DRM_4438 -> Patchwork_9556 CI_DRM_4438: b689733af687b4b8072fb62a6bfe267c4e888f5f @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4539: 8b3cc74c6911e9b2835fe6e160f84bae463a70ef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_9556: 2465d597588b38b7552dc0664a9d9082a1285314 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 2465d597588b drm/i915: Squelch very verbose error logging == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9556/issues.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-05 23:02 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-07-05 18:24 [PATCH] drm/i915: Squelch very verbose error logging Chris Wilson 2018-07-05 22:46 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2018-07-05 22:46 ` ✗ Fi.CI.SPARSE: " Patchwork 2018-07-05 23:02 ` ✓ Fi.CI.BAT: success " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).