From: Patchwork <patchwork@emeril.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Introduce BITS_PER_TYPE
Date: Fri, 06 Jul 2018 08:54:41 -0000 [thread overview]
Message-ID: <20180706085441.22157.5403@emeril.freedesktop.org> (raw)
In-Reply-To: <20180706084455.23601-1-chris@chris-wilson.co.uk>
== Series Details ==
Series: drm/i915: Introduce BITS_PER_TYPE
URL : https://patchwork.freedesktop.org/series/46055/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
c827b8e3ce5f drm/i915: Introduce BITS_PER_TYPE
-:30: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#30: FILE: drivers/gpu/drm/i915/i915_drv.c:891:
+ BUG_ON(device_info->gen > BITS_PER_TYPE(device_info->gen_mask));
-:77: WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#77: FILE: drivers/gpu/drm/i915/i915_syncmap.c:96:
+ BUILD_BUG_ON(KSYNCMAP > BITS_PER_TYPE((*root)->bitmap));
-:113: WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#113: FILE: drivers/gpu/drm/i915/intel_device_info.c:753:
+ BUILD_BUG_ON(I915_NUM_ENGINES > BITS_PER_TYPE(intel_ring_mask_t));
total: 0 errors, 3 warnings, 0 checks, 74 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-07-06 8:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 8:44 [PATCH] drm/i915: Introduce BITS_PER_TYPE Chris Wilson
2018-07-06 8:54 ` Patchwork [this message]
2018-07-06 8:59 ` Tvrtko Ursulin
2018-07-06 9:07 ` Jani Nikula
2018-07-06 9:10 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-07-07 0:59 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706085441.22157.5403@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).