* [PATCH 1/2] drm/i915/gtt: Suppress warnings for dma_map_page
@ 2018-07-06 12:26 Chris Wilson
2018-07-06 12:26 ` [PATCH 2/2] drm/i915/gtt: Control cache domain of dma_map_page() directly Chris Wilson
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Chris Wilson @ 2018-07-06 12:26 UTC (permalink / raw)
To: intel-gfx; +Cc: Matthew Auld
As we propagate back the error to the caller for them to handle, we do
not need the lowest level spitting out a redundant warning upon an
allocation failure inside dma_map_page().
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 2f10f5580230..ee881998a7d3 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -561,8 +561,10 @@ static int __setup_page_dma(struct i915_address_space *vm,
if (unlikely(!p->page))
return -ENOMEM;
- p->daddr = dma_map_page(vm->dma, p->page, 0, PAGE_SIZE,
- PCI_DMA_BIDIRECTIONAL);
+ p->daddr = dma_map_page_attrs(vm->dma,
+ p->page, 0, PAGE_SIZE,
+ PCI_DMA_BIDIRECTIONAL,
+ DMA_ATTR_NO_WARN);
if (unlikely(dma_mapping_error(vm->dma, p->daddr))) {
vm_free_page(vm, p->page);
return -ENOMEM;
@@ -643,8 +645,10 @@ setup_scratch_page(struct i915_address_space *vm, gfp_t gfp)
if (unlikely(!page))
goto skip;
- addr = dma_map_page(vm->dma, page, 0, size,
- PCI_DMA_BIDIRECTIONAL);
+ addr = dma_map_page_attrs(vm->dma,
+ page, 0, size,
+ PCI_DMA_BIDIRECTIONAL,
+ DMA_ATTR_NO_WARN);
if (unlikely(dma_mapping_error(vm->dma, addr)))
goto free_page;
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] drm/i915/gtt: Control cache domain of dma_map_page() directly
2018-07-06 12:26 [PATCH 1/2] drm/i915/gtt: Suppress warnings for dma_map_page Chris Wilson
@ 2018-07-06 12:26 ` Chris Wilson
2018-07-06 12:55 ` Matthew Auld
2018-07-06 12:32 ` [PATCH 1/2] drm/i915/gtt: Suppress warnings for dma_map_page Matthew Auld
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2018-07-06 12:26 UTC (permalink / raw)
To: intel-gfx; +Cc: Matthew Auld
We already maually control the CPU cache for our page table directories,
so we can tell the dma mapper to skip doing it as well.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index ee881998a7d3..3b7a1437bfbf 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -564,6 +564,7 @@ static int __setup_page_dma(struct i915_address_space *vm,
p->daddr = dma_map_page_attrs(vm->dma,
p->page, 0, PAGE_SIZE,
PCI_DMA_BIDIRECTIONAL,
+ DMA_ATTR_SKIP_CPU_SYNC |
DMA_ATTR_NO_WARN);
if (unlikely(dma_mapping_error(vm->dma, p->daddr))) {
vm_free_page(vm, p->page);
@@ -648,6 +649,7 @@ setup_scratch_page(struct i915_address_space *vm, gfp_t gfp)
addr = dma_map_page_attrs(vm->dma,
page, 0, size,
PCI_DMA_BIDIRECTIONAL,
+ DMA_ATTR_SKIP_CPU_SYNC |
DMA_ATTR_NO_WARN);
if (unlikely(dma_mapping_error(vm->dma, addr)))
goto free_page;
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] drm/i915/gtt: Suppress warnings for dma_map_page
2018-07-06 12:26 [PATCH 1/2] drm/i915/gtt: Suppress warnings for dma_map_page Chris Wilson
2018-07-06 12:26 ` [PATCH 2/2] drm/i915/gtt: Control cache domain of dma_map_page() directly Chris Wilson
@ 2018-07-06 12:32 ` Matthew Auld
2018-07-06 15:01 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2018-07-07 10:35 ` ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Matthew Auld @ 2018-07-06 12:32 UTC (permalink / raw)
To: Chris Wilson; +Cc: Intel Graphics Development, Matthew Auld
On 6 July 2018 at 13:26, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> As we propagate back the error to the caller for them to handle, we do
> not need the lowest level spitting out a redundant warning upon an
> allocation failure inside dma_map_page().
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gtt: Suppress warnings for dma_map_page
2018-07-06 12:26 [PATCH 1/2] drm/i915/gtt: Suppress warnings for dma_map_page Chris Wilson
2018-07-06 12:26 ` [PATCH 2/2] drm/i915/gtt: Control cache domain of dma_map_page() directly Chris Wilson
2018-07-06 12:32 ` [PATCH 1/2] drm/i915/gtt: Suppress warnings for dma_map_page Matthew Auld
@ 2018-07-06 15:01 ` Patchwork
2018-07-07 10:35 ` ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-07-06 15:01 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915/gtt: Suppress warnings for dma_map_page
URL : https://patchwork.freedesktop.org/series/46072/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4446 -> Patchwork_9567 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/46072/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9567:
=== IGT changes ===
==== Possible regressions ====
igt@kms_flip@basic-flip-vs-dpms:
{fi-cfl-8109u}: PASS -> INCOMPLETE
== Known issues ==
Here are the changes found in Patchwork_9567 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_flip@basic-flip-vs-dpms:
fi-skl-6700hq: PASS -> DMESG-WARN (fdo#105998)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
== Participating hosts (47 -> 41) ==
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* Linux: CI_DRM_4446 -> Patchwork_9567
CI_DRM_4446: 95944426a9ffda186843c78f2f925494e1bc53c5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9567: c8a26b94b94b3e9077ee998a8bd9085e79b75cb6 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
c8a26b94b94b drm/i915/gtt: Control cache domain of dma_map_page() directly
944065137401 drm/i915/gtt: Suppress warnings for dma_map_page
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9567/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/gtt: Suppress warnings for dma_map_page
2018-07-06 12:26 [PATCH 1/2] drm/i915/gtt: Suppress warnings for dma_map_page Chris Wilson
` (2 preceding siblings ...)
2018-07-06 15:01 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
@ 2018-07-07 10:35 ` Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-07-07 10:35 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915/gtt: Suppress warnings for dma_map_page
URL : https://patchwork.freedesktop.org/series/46072/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4446_full -> Patchwork_9567_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9567_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9567_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9567_full:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_schedule@deep-bsd1:
shard-kbl: SKIP -> PASS
== Known issues ==
Here are the changes found in Patchwork_9567_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_gtt:
shard-glk: PASS -> FAIL (fdo#107127, fdo#105347)
igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
shard-glk: PASS -> FAIL (fdo#106509)
igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
shard-glk: PASS -> FAIL (fdo#103060)
igt@kms_flip_tiling@flip-x-tiled:
shard-glk: PASS -> FAIL (fdo#103822)
==== Possible fixes ====
igt@drv_selftest@live_gtt:
shard-kbl: FAIL (fdo#107127, fdo#105347) -> PASS
igt@gem_workarounds@suspend-resume-context:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@kms_flip_tiling@flip-to-y-tiled:
shard-glk: FAIL (fdo#103822) -> PASS
igt@kms_flip_tiling@flip-y-tiled:
shard-glk: FAIL -> PASS
igt@kms_setmode@basic:
shard-kbl: FAIL (fdo#99912) -> PASS
igt@kms_universal_plane@cursor-fb-leak-pipe-c:
shard-apl: FAIL -> PASS
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#107127 https://bugs.freedesktop.org/show_bug.cgi?id=107127
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4446 -> Patchwork_9567
CI_DRM_4446: 95944426a9ffda186843c78f2f925494e1bc53c5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9567: c8a26b94b94b3e9077ee998a8bd9085e79b75cb6 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9567/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-07 10:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-06 12:26 [PATCH 1/2] drm/i915/gtt: Suppress warnings for dma_map_page Chris Wilson
2018-07-06 12:26 ` [PATCH 2/2] drm/i915/gtt: Control cache domain of dma_map_page() directly Chris Wilson
2018-07-06 12:55 ` Matthew Auld
2018-07-06 12:32 ` [PATCH 1/2] drm/i915/gtt: Suppress warnings for dma_map_page Matthew Auld
2018-07-06 15:01 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2018-07-07 10:35 ` ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).