[PATCH] drm/i915/selftests: Skip over live context testing when wedged

[PATCH] drm/i915/selftests: Skip over live context testing when wedged

[Chris Wilson]

If the GPU is terminally wedged we cannot submit any requests into a
context, completely unfulfilling our purpose of doing so. As this
expectedly fails, skip over the test.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/selftests/i915_gem_context.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/selftests/i915_gem_context.c
index cc848ceeb3c3..0b36265a0f96 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_context.c
@@ -599,6 +599,9 @@ int i915_gem_context_live_selftests(struct drm_i915_private *dev_priv)
 	bool fake_alias = false;
 	int err;
 
+	if (i915_terminally_wedged(&dev_priv->gpu_error))
+		return 0;
+
 	/* Install a fake aliasing gtt for exercise */
 	if (USES_PPGTT(dev_priv) && !dev_priv->mm.aliasing_ppgtt) {
 		mutex_lock(&dev_priv->drm.struct_mutex);
-- 
2.18.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915/selftests: Skip over live context testing when wedged

[Patchwork]

== Series Details ==

Series: drm/i915/selftests: Skip over live context testing when wedged
URL   : https://patchwork.freedesktop.org/series/46009/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4435 -> Patchwork_9547 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46009/revisions/1/mbox/

== Known issues ==

  Here are the changes found in Patchwork_9547 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         PASS -> INCOMPLETE (fdo#103927)

    
    ==== Possible fixes ====

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         FAIL (fdo#104008) -> PASS

    
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008


== Participating hosts (47 -> 42) ==

  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * Linux: CI_DRM_4435 -> Patchwork_9547

  CI_DRM_4435: 8acff624cc6754eb6c1d8cefbff8ec592022ffab @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4539: 8b3cc74c6911e9b2835fe6e160f84bae463a70ef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9547: 8dda85d85ae821dec55739a85b70e0e748134355 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

8dda85d85ae8 drm/i915/selftests: Skip over live context testing when wedged

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9547/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/selftests: Skip over live context testing when wedged

[Rodrigo Vivi]

On Thu, Jul 05, 2018 at 03:58:45PM +0100, Chris Wilson wrote:
> If the GPU is terminally wedged we cannot submit any requests into a
> context, completely unfulfilling our purpose of doing so. As this
> expectedly fails, skip over the test.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/selftests/i915_gem_context.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/selftests/i915_gem_context.c
> index cc848ceeb3c3..0b36265a0f96 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_gem_context.c
> @@ -599,6 +599,9 @@ int i915_gem_context_live_selftests(struct drm_i915_private *dev_priv)
>  	bool fake_alias = false;
>  	int err;
>  
> +	if (i915_terminally_wedged(&dev_priv->gpu_error))
> +		return 0;
> +

I wonder if this could mask a real failure under the skips?

but if actual error is already captured somewhere else than probably better to avoid the noise
of a ENOTRECOVERABLE or whatever...

>  	/* Install a fake aliasing gtt for exercise */
>  	if (USES_PPGTT(dev_priv) && !dev_priv->mm.aliasing_ppgtt) {
>  		mutex_lock(&dev_priv->drm.struct_mutex);
> -- 
> 2.18.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.IGT: failure for drm/i915/selftests: Skip over live context testing when wedged

[Patchwork]

== Series Details ==

Series: drm/i915/selftests: Skip over live context testing when wedged
URL   : https://patchwork.freedesktop.org/series/46009/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4435_full -> Patchwork_9547_full =

== Summary - FAILURE ==

  Serious unknown changes coming with Patchwork_9547_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_9547_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_9547_full:

  === IGT changes ===

    ==== Possible regressions ====

    igt@kms_vblank@pipe-b-ts-continuation-modeset-hang:
      shard-snb:          PASS -> DMESG-WARN

    
    ==== Warnings ====

    igt@gem_mocs_settings@mocs-rc6-vebox:
      shard-kbl:          PASS -> SKIP +2

    
== Known issues ==

  Here are the changes found in Patchwork_9547_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_flip@2x-plain-flip-ts-check:
      shard-glk:          PASS -> FAIL (fdo#100368)

    igt@kms_flip_tiling@flip-to-y-tiled:
      shard-glk:          PASS -> FAIL (fdo#103822)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_gtt:
      shard-glk:          INCOMPLETE (fdo#107127, k.org#198133, fdo#103359) -> PASS

    igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          FAIL (fdo#106509, fdo#105454) -> PASS

    igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
      shard-glk:          FAIL (fdo#105363) -> PASS

    igt@kms_flip@plain-flip-ts-check-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS +1

    igt@kms_flip_tiling@flip-x-tiled:
      shard-glk:          FAIL -> PASS +1

    igt@kms_plane_lowres@pipe-c-tiling-none:
      shard-kbl:          DMESG-WARN (fdo#106247) -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
  fdo#106247 https://bugs.freedesktop.org/show_bug.cgi?id=106247
  fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
  fdo#107127 https://bugs.freedesktop.org/show_bug.cgi?id=107127
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_4435 -> Patchwork_9547

  CI_DRM_4435: 8acff624cc6754eb6c1d8cefbff8ec592022ffab @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4539: 8b3cc74c6911e9b2835fe6e160f84bae463a70ef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9547: 8dda85d85ae821dec55739a85b70e0e748134355 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9547/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/selftests: Skip over live context testing when wedged

[Chris Wilson]

Quoting Rodrigo Vivi (2018-07-05 21:52:10)
> On Thu, Jul 05, 2018 at 03:58:45PM +0100, Chris Wilson wrote:
> > If the GPU is terminally wedged we cannot submit any requests into a
> > context, completely unfulfilling our purpose of doing so. As this
> > expectedly fails, skip over the test.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> >  drivers/gpu/drm/i915/selftests/i915_gem_context.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/selftests/i915_gem_context.c
> > index cc848ceeb3c3..0b36265a0f96 100644
> > --- a/drivers/gpu/drm/i915/selftests/i915_gem_context.c
> > +++ b/drivers/gpu/drm/i915/selftests/i915_gem_context.c
> > @@ -599,6 +599,9 @@ int i915_gem_context_live_selftests(struct drm_i915_private *dev_priv)
> >       bool fake_alias = false;
> >       int err;
> >  
> > +     if (i915_terminally_wedged(&dev_priv->gpu_error))
> > +             return 0;
> > +
> 
> I wonder if this could mask a real failure under the skips?

The *test* can't be run, so what failure relevant to this *test* can be
shown?

As you notice, when we get to the reset test, we do proclaim failure as
we've already demonstrated reset is bust.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/selftests: Skip over live context testing when wedged

[Rodrigo Vivi]

On Fri, Jul 06, 2018 at 07:42:00AM +0100, Chris Wilson wrote:
> Quoting Rodrigo Vivi (2018-07-05 21:52:10)
> > On Thu, Jul 05, 2018 at 03:58:45PM +0100, Chris Wilson wrote:
> > > If the GPU is terminally wedged we cannot submit any requests into a
> > > context, completely unfulfilling our purpose of doing so. As this
> > > expectedly fails, skip over the test.
> > > 
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > ---
> > >  drivers/gpu/drm/i915/selftests/i915_gem_context.c | 3 +++
> > >  1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/selftests/i915_gem_context.c
> > > index cc848ceeb3c3..0b36265a0f96 100644
> > > --- a/drivers/gpu/drm/i915/selftests/i915_gem_context.c
> > > +++ b/drivers/gpu/drm/i915/selftests/i915_gem_context.c
> > > @@ -599,6 +599,9 @@ int i915_gem_context_live_selftests(struct drm_i915_private *dev_priv)
> > >       bool fake_alias = false;
> > >       int err;
> > >  
> > > +     if (i915_terminally_wedged(&dev_priv->gpu_error))
> > > +             return 0;
> > > +
> > 
> > I wonder if this could mask a real failure under the skips?
> 
> The *test* can't be run, so what failure relevant to this *test* can be
> shown?
> 
> As you notice, when we get to the reset test, we do proclaim failure as
> we've already demonstrated reset is bust.

Makes sense...

I was going to add rv-b here for this and others, but
I saw you already got hem and is already pushing ;)

Also thanks for the explanation on -ENOTRECOVERABLE one..
that also makes sense.

> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx