From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/selftests: Provide full mb() around clflush
Date: Fri, 6 Jul 2018 13:23:00 -0700 [thread overview]
Message-ID: <20180706202259.GA23473@intel.com> (raw)
In-Reply-To: <20180706174926.4712-1-chris@chris-wilson.co.uk>
On Fri, Jul 06, 2018 at 06:49:26PM +0100, Chris Wilson wrote:
> clflush is an unserialised instruction and the IA manual strongly advises
> you to serialise it with a mb. To be cautious, apply one before and one
> after,
my understanding is that we need one before and one after anyways,
not just a matter of being cautious for being cautious..
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> so that it is serialised with both writes and reads without
> worrying too much about the required direction.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> .../drm/i915/selftests/i915_gem_coherency.c | 21 ++++++++++++++++---
> 1 file changed, 18 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_coherency.c b/drivers/gpu/drm/i915/selftests/i915_gem_coherency.c
> index 294c58aba2c1..df44c302a9fe 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_gem_coherency.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_gem_coherency.c
> @@ -42,11 +42,21 @@ static int cpu_set(struct drm_i915_gem_object *obj,
>
> page = i915_gem_object_get_page(obj, offset >> PAGE_SHIFT);
> map = kmap_atomic(page);
> - if (needs_clflush & CLFLUSH_BEFORE)
> +
> + if (needs_clflush & CLFLUSH_BEFORE) {
> + mb();
> clflush(map+offset_in_page(offset) / sizeof(*map));
> + mb();
> + }
> +
> map[offset_in_page(offset) / sizeof(*map)] = v;
> - if (needs_clflush & CLFLUSH_AFTER)
> +
> + if (needs_clflush & CLFLUSH_AFTER) {
> + mb();
> clflush(map+offset_in_page(offset) / sizeof(*map));
> + mb();
> + }
> +
> kunmap_atomic(map);
>
> i915_gem_obj_finish_shmem_access(obj);
> @@ -68,8 +78,13 @@ static int cpu_get(struct drm_i915_gem_object *obj,
>
> page = i915_gem_object_get_page(obj, offset >> PAGE_SHIFT);
> map = kmap_atomic(page);
> - if (needs_clflush & CLFLUSH_BEFORE)
> +
> + if (needs_clflush & CLFLUSH_BEFORE) {
> + mb();
> clflush(map+offset_in_page(offset) / sizeof(*map));
> + mb();
> + }
> +
> *v = map[offset_in_page(offset) / sizeof(*map)];
> kunmap_atomic(map);
>
> --
> 2.18.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-07-06 20:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 17:49 [PATCH] drm/i915/selftests: Provide full mb() around clflush Chris Wilson
2018-07-06 17:56 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-07-06 18:14 ` ✓ Fi.CI.BAT: success " Patchwork
2018-07-06 20:23 ` Rodrigo Vivi [this message]
2018-07-06 20:27 ` [PATCH] " Chris Wilson
2018-07-06 20:31 ` Rodrigo Vivi
2018-07-07 18:32 ` ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706202259.GA23473@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).