From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH] Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE() Date: Fri, 6 Jul 2018 13:30:15 -0700 Message-ID: <20180706203015.GC23473@intel.com> References: <20180706190424.29194-1-pjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180706190424.29194-1-pjones@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Peter Jones Cc: Jani Nikula , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jul 06, 2018 at 03:04:24PM -0400, Peter Jones wrote: > This was sort of annoying me: > > random:~$ dmesg | tail -1 > [523884.039227] [drm] Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS. > random:~$ dmesg | grep -c "Reducing the compressed" > 47 > > This patch makes it DRM_INFO_ONCE() just like the similar message > farther down in that function is pr_info_once(). > > Signed-off-by: Peter Jones > --- > drivers/gpu/drm/i915/intel_fbc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c > index b431b6733cc..88b013758da 100644 > --- a/drivers/gpu/drm/i915/intel_fbc.c > +++ b/drivers/gpu/drm/i915/intel_fbc.c > @@ -585,7 +585,7 @@ static int intel_fbc_alloc_cfb(struct intel_crtc *crtc) > if (!ret) > goto err_llb; > else if (ret > 1) { > - DRM_INFO("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n"); > + DRM_INFO_ONCE("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n"); I know the feeling of seeing a message over and over again when you are already aware of that. Specially something that tells you to change BIOS configuration... for this reason I think it makes sense, so: Acked-by: Rodrigo Vivi I will just wait for CI and give a couple days to someone else to challenge. If I end up forgetting to push it please ping me... > > } > > -- > 2.17.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel