intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Guang Bai <guang.bai@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [BUG] i915 HDMI connector status is connected after disconnection
Date: Fri, 6 Jul 2018 13:38:06 -0700	[thread overview]
Message-ID: <20180706203803.GE23473@intel.com> (raw)
In-Reply-To: <20180706104118.7e36c435@gbai-ub1604-LTS>

On Fri, Jul 06, 2018 at 10:41:18AM -0700, Guang Bai wrote:
> On Fri, 6 Jul 2018 14:44:58 +0800
> Chris Chiu <chiu@endlessm.com> wrote:
> 
> > On Thu, Jul 5, 2018 at 10:40 PM, Ville Syrjälä
> > <ville.syrjala@linux.intel.com> wrote:
> > > On Thu, Jul 05, 2018 at 03:58:36PM +0800, Chris Chiu wrote:  
> > >> Hi,
> > >>     We have few ASUS laptops X705FD (The new WiskyLake), X560UD
> > >> (intel i5-8250U), X530UN (intel i7-8550U) share the same problem,
> > >> which is the HDMI connector status stays connected even the HDMI
> > >> cable has been unplugged. Look into the
> > >> "/sys/class/drm/card0-HDMI-A-1/status" for checking the status
> > >> while plug/unplug the HDMI, it shows "disconnected" before plug in
> > >> HDMI cable, then switch to "connected" after plugin, and still
> > >> stay "connected" after unplug. This would cause the audio output
> > >> path cannot correctly switch from HDMI to internal speaker after
> > >> unplugging the HDMI.
> > >>
> > >> I then try to verify with the latest kernel 4.18.0-rc3+, the bug
> > >> still present. The full "dmesg" log is here.
> > >> https://gist.github.com/mschiu77/d761d7c5cf191b7868d4d7788ae087f1
> > >>
> > >> The HDMI cable is plugged in at ~26th second.
> > >> "[ 26.214371] [drm:drm_detect_monitor_audio [drm]] Monitor has
> > >> basic audio support"
> > >> then unplug the HDMI at ~73th second.
> > >> "[ 73.328361] [drm:drm_detect_monitor_audio [drm]] Monitor has
> > >> basic audio support"
> > >>
> > >> Please advise what I can do to fix this. Thanks  
> > >
> > > Pull the cable out faster?
> > >
> > > I presume this is the same old case of hpd disconnecting slightly
> > > before ddc and we still manage to read the EDID when processing
> > > the hpd irq. We kinda tried to fix that with the live status
> > > check but that thing failed spectacularly.
> > >
> > > --
> > > Ville Syrjälä
> > > Intel  
> > 
> > Thanks for the suggestion. I tried pulling the cable out faster, the
> > status shows correctly. I also tried branch drm-tip of
> > https://cgit.freedesktop.org/drm/drm-tip
> > but the symptom persists.
> > 
> > Anything I can help here? Or any old commit/patch I can try to do some
> > experiments?
> > 
> > Chris
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> I'm working on a same issue with HP KBL ThinPro laptop where both
> 
> kernel 4.9.79 & 4.15.7 are failing the same way:
> - Unplug the HDMI cable slowly the connector status is still
>   "connected"
> 
> Debugging shows from kernel 4.9 and up to 4.18 drim/i915 behaves the
> same way:
> - When the HDMI calbe is unplugged, there is a transition time when
>   the DDC lines are still connected and i915 can read back the EDID
>   and honors "connected" state
> 
> This problem does not happen on Windows7 & Windows 10 on the same
> failing platform - Windows KMD does *not* read the DDC when seeing the
> corresponding PCH/HPD pins indicating "disconnected" within 300ms-400ms
> period - This checking is done during bottom-half interrupt routines
> 
> I worked patches with both 4.15.7 and 4.17.1 intercepting this Windows
> KMD logics; It seems these patches work for HP KBL ThinPro laptop - My
> patches are being tested by HP team - I was just about to post the open
> discussion on this topic to collect inputs from our community

please send them out anyways ;)

> - Do we have to refactor the HDMI hot-plug handling codes to cope with
>   this long standing issue?

What is your proposal for re-work?

> - Is that OK to add 300ms-500ms delay "msleep(100)" in a loop in the
>   bottom half of interrupt routines?

Well, We fight to add the delays only when they are required by specs,
rather than experimental on single display/configuration...
but/however/nevertheless we have cases that we retry aux communications
32 times because a specific monitor...

please show your patch and we discuss on top of it...

> 
> Regards,
> -Guang
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-07-06 20:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05  7:58 [BUG] i915 HDMI connector status is connected after disconnection Chris Chiu
2018-07-05  8:58 ` Jani Nikula
2018-07-05  9:04   ` Chris Wilson
2018-07-05  9:37     ` Jani Nikula
2018-07-05 13:02       ` Chris Chiu
2018-07-05 13:18         ` Jani Nikula
2018-07-05 13:30           ` Chris Chiu
2018-07-05 14:40 ` Ville Syrjälä
2018-07-06  6:44   ` Chris Chiu
2018-07-06 17:41     ` Guang Bai
2018-07-06 20:38       ` Rodrigo Vivi [this message]
2018-07-07  0:03         ` Guang Bai
2018-08-22  6:30     ` Chris Chiu
2018-08-24 15:04       ` Jani Nikula
2018-09-11 10:25         ` Chris Chiu
2018-09-19 11:20           ` Chris Chiu
2018-09-19 12:08             ` Jani Nikula
2018-09-20  7:32               ` Chris Chiu
2018-07-07  0:13 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-09-19 12:22 ` ✗ Fi.CI.CHECKPATCH: warning for i915 HDMI connector status is connected after disconnection (rev2) Patchwork
2018-09-19 12:40 ` ✓ Fi.CI.BAT: success " Patchwork
2018-09-19 14:50 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180706203803.GE23473@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=guang.bai@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).