* [PATCH] drm/i915/selftests: Magic numbers for old Y-tiling
@ 2018-07-07 10:04 Chris Wilson
2018-07-07 10:29 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chris Wilson @ 2018-07-07 10:04 UTC (permalink / raw)
To: intel-gfx
i915g has a slightly different tiling layout, and so requires a
different reference swizzle pattern.
Testcase: igt/drv_selftests/live_objects #gdg
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/selftests/i915_gem_object.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_object.c b/drivers/gpu/drm/i915/selftests/i915_gem_object.c
index 25c2b2d433bd..f4a5099c75b5 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_object.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_object.c
@@ -169,9 +169,16 @@ static u64 tiled_offset(const struct tile *tile, u64 v)
v += y * tile->width;
v += div64_u64_rem(x, tile->width, &x) << tile->size;
v += x;
- } else {
+ } else if (tile->width == 128) {
const unsigned int ytile_span = 16;
- const unsigned int ytile_height = 32 * ytile_span;
+ const unsigned int ytile_height = 512;
+
+ v += y * ytile_span;
+ v += div64_u64_rem(x, ytile_span, &x) * ytile_height;
+ v += x;
+ } else {
+ const unsigned int ytile_span = 32;
+ const unsigned int ytile_height = 256;
v += y * ytile_span;
v += div64_u64_rem(x, ytile_span, &x) * ytile_height;
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/selftests: Magic numbers for old Y-tiling
2018-07-07 10:04 [PATCH] drm/i915/selftests: Magic numbers for old Y-tiling Chris Wilson
@ 2018-07-07 10:29 ` Patchwork
2018-07-08 6:04 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-07-09 9:57 ` [PATCH] " Mika Kuoppala
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-07-07 10:29 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Magic numbers for old Y-tiling
URL : https://patchwork.freedesktop.org/series/46114/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4451 -> Patchwork_9582 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/46114/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_9582 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: PASS -> FAIL (fdo#104008)
==== Possible fixes ====
igt@drv_module_reload@basic-reload:
fi-kbl-7560u: INCOMPLETE -> PASS
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
== Participating hosts (46 -> 41) ==
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4451 -> Patchwork_9582
CI_DRM_4451: 7ae7763aa2be33d723ed891f0803f08a11f85633 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9582: f23ff15282b42dae2f1cfe4d6ad4f6a419acbd2a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f23ff15282b4 drm/i915/selftests: Magic numbers for old Y-tiling
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9582/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* ✗ Fi.CI.IGT: failure for drm/i915/selftests: Magic numbers for old Y-tiling
2018-07-07 10:04 [PATCH] drm/i915/selftests: Magic numbers for old Y-tiling Chris Wilson
2018-07-07 10:29 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-07-08 6:04 ` Patchwork
2018-07-09 9:57 ` [PATCH] " Mika Kuoppala
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-07-08 6:04 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Magic numbers for old Y-tiling
URL : https://patchwork.freedesktop.org/series/46114/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4451_full -> Patchwork_9582_full =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_9582_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9582_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9582_full:
=== IGT changes ===
==== Possible regressions ====
igt@drv_suspend@fence-restore-untiled:
shard-snb: PASS -> DMESG-WARN
==== Warnings ====
igt@gem_exec_schedule@deep-bsd1:
shard-kbl: SKIP -> PASS +3
igt@gem_exec_schedule@deep-render:
shard-kbl: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_9582_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled:
shard-glk: PASS -> FAIL (fdo#103184)
igt@kms_flip@2x-flip-vs-blocking-wf-vblank:
shard-glk: PASS -> FAIL (fdo#100368)
==== Possible fixes ====
igt@drv_suspend@shrink:
shard-snb: INCOMPLETE (fdo#105411) -> PASS
igt@gem_workarounds@suspend-resume-context:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@kms_setmode@basic:
shard-apl: FAIL (fdo#99912) -> PASS
shard-kbl: FAIL (fdo#99912) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4451 -> Patchwork_9582
CI_DRM_4451: 7ae7763aa2be33d723ed891f0803f08a11f85633 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9582: f23ff15282b42dae2f1cfe4d6ad4f6a419acbd2a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9582/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/selftests: Magic numbers for old Y-tiling
2018-07-07 10:04 [PATCH] drm/i915/selftests: Magic numbers for old Y-tiling Chris Wilson
2018-07-07 10:29 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-07-08 6:04 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-07-09 9:57 ` Mika Kuoppala
2018-07-09 10:03 ` Chris Wilson
2 siblings, 1 reply; 5+ messages in thread
From: Mika Kuoppala @ 2018-07-09 9:57 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> i915g has a slightly different tiling layout, and so requires a
> different reference swizzle pattern.
>
> Testcase: igt/drv_selftests/live_objects #gdg
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/selftests/i915_gem_object.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_object.c b/drivers/gpu/drm/i915/selftests/i915_gem_object.c
> index 25c2b2d433bd..f4a5099c75b5 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_gem_object.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_gem_object.c
> @@ -169,9 +169,16 @@ static u64 tiled_offset(const struct tile *tile, u64 v)
> v += y * tile->width;
> v += div64_u64_rem(x, tile->width, &x) << tile->size;
> v += x;
> - } else {
> + } else if (tile->width == 128) {
> const unsigned int ytile_span = 16;
> - const unsigned int ytile_height = 32 * ytile_span;
> + const unsigned int ytile_height = 512;
> +
> + v += y * ytile_span;
> + v += div64_u64_rem(x, ytile_span, &x) * ytile_height;
> + v += x;
> + } else {
> + const unsigned int ytile_span = 32;
> + const unsigned int ytile_height = 256;
>
> v += y * ytile_span;
> v += div64_u64_rem(x, ytile_span, &x) * ytile_height;
> --
> 2.18.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/selftests: Magic numbers for old Y-tiling
2018-07-09 9:57 ` [PATCH] " Mika Kuoppala
@ 2018-07-09 10:03 ` Chris Wilson
0 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2018-07-09 10:03 UTC (permalink / raw)
To: Mika Kuoppala, intel-gfx
Quoting Mika Kuoppala (2018-07-09 10:57:19)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > i915g has a slightly different tiling layout, and so requires a
> > different reference swizzle pattern.
> >
> > Testcase: igt/drv_selftests/live_objects #gdg
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Acked-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Ta, and welcome back \o/
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-09 10:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-07 10:04 [PATCH] drm/i915/selftests: Magic numbers for old Y-tiling Chris Wilson
2018-07-07 10:29 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-07-08 6:04 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-07-09 9:57 ` [PATCH] " Mika Kuoppala
2018-07-09 10:03 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).