From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tarun Vyas Subject: Re: [PATCH v2] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update Date: Mon, 9 Jul 2018 13:24:28 -0700 Message-ID: <20180709202428.GA82862@otc-chromeosbuild-5> References: <20180709014636.29607-1-tarun.vyas@intel.com> <1531161000.26763.7.camel@intel.com> <20180709181630.GA81522@otc-chromeosbuild-5> <1531162732.26763.17.camel@intel.com> <20180709195251.GA82530@otc-chromeosbuild-5> <1531168312.4283.5.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id D66FA6E617 for ; Mon, 9 Jul 2018 20:24:28 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1531168312.4283.5.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan Cc: intel-gfx@lists.freedesktop.org, rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKdWwgMDksIDIwMTggYXQgMDE6MzE6NTJQTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiBPbiBNb24sIDIwMTgtMDctMDkgYXQgMTI6NTIgLTA3MDAsIFRhcnVuIFZ5 YXMgd3JvdGU6Cj4gPiBPbiBNb24sIEp1bCAwOSwgMjAxOCBhdCAxMTo1ODo1MkFNIC0wNzAwLCBE aGluYWthcmFuIFBhbmRpeWFuIHdyb3RlOgo+ID4gPiAKPiA+ID4gT24gTW9uLCAyMDE4LTA3LTA5 IGF0IDExOjE2IC0wNzAwLCBUYXJ1biBWeWFzIHdyb3RlOgo+ID4gPiA+IAo+ID4gPiA+IE9uIE1v biwgSnVsIDA5LCAyMDE4IGF0IDExOjMwOjAwQU0gLTA3MDAsIERoaW5ha2FyYW4gUGFuZGl5YW4K PiA+ID4gPiB3cm90ZToKPiA+ID4gPiA+IAo+ID4gPiA+ID4gCj4gPiA+ID4gPiBPbiBTdW4sIDIw MTgtMDctMDggYXQgMTg6NDYgLTA3MDAsIFRhcnVuIFZ5YXMgd3JvdGU6Cj4gPiA+ID4gPiA+IAo+ ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gSW4gY29tbWl0ICJkcm0vaTkxNTogV2FpdCBmb3IgUFNS IGV4aXQgYmVmb3JlIGNoZWNraW5nIGZvcgo+ID4gPiA+ID4gPiB2YmxhbmsKPiA+ID4gPiA+ID4g ZXZhc2lvbiIsIHRoZSBpZGVhIHdhcyB0byBsaW1pdCB0aGUgUFNSIElETEUgY2hlY2tzIHdoZW4g UFNSCj4gPiA+ID4gPiA+IGlzCj4gPiA+ID4gPiA+IGFjdHVhbGx5IHN1cHBvcnRlZC4gV2hpbGUg Q0FOX1BTUiBkb2VzIGRvIHRoYXQgY2hlY2ssIGl0Cj4gPiA+ID4gPiA+IGRvZXNuJ3QKPiA+ID4g PiA+ID4gYXBwbGllcyBvbiBhIHBlci1jcnRjIGJhc2lzLiBjcnRjX3N0YXRlLT5oYXNfcHNyIGlz IGEgbW9yZQo+ID4gPiA+ID4gPiBncmFudWxhcgo+ID4gPiA+ID4gPiBjaGVjayB0aGF0IGF2b2lk cyBldmVyeXRoaW5nIGJ1dCBwaXBlIEEsIGZvciB0aGUgUFNSIElETEUKPiA+ID4gPiA+ID4gY2hl Y2suCj4gCj4gSSBsb29rZWQgYXQgdGhlIGNvZGUgYW5kIHNwZWMgYWdhaW4sIFBTUiBpc24ndCB0 aWVkIHRvICJwaXBlIEEiIFRoZQo+IGRyaXZlciBhbGxvd3MgUFNSIG9ubHkgb24gInBvcnQgQSIg KyAidHJhbnNjb2RlciBlRFAiLCBidXQgdGhlIHBpcGUKPiBpdHNlbGYgY2FuIGJlIGFueSBvbmUg b2YgdGhlIHBvc3NpYmxlIG9wdGlvbnMuCj4KSSdsbCByZW1vdmUgdGhlIHBpcGUgQSBwYXJ0IGZy b20gdGhlIG1lc3NhZ2UgYW5kIHNwZWNpZnkgdGhhdCBhdCB0aGUgbW9tZW50IHdlIGFzc3VtZSBw b3J0IEEgKyBlRFAsIGIvYyBhdCBsZWFzdCBpbiB0aGUgY29kZSB3ZSBwb3B1bGF0ZSB0aGUgcmVn aXN0ZXJzIHdpdGggRURQX1BTUiBiYXNlIGRpcmVjdGx5LiAKPiA+ID4gPiA+ID4gCj4gPiA+ID4g PiA+IFdpdGggdGhpcywgdGhlIFBTUiBJRExFIGNoZWNrIHNob3VsZCBiZSBhICpuby1vcCogZm9y IGFsbCBidXQKPiA+ID4gPiA+ID4gcGlwZSBBCj4gPiA+ID4gPiA+IHdoaWNoIGlzIHdoYXQgd2Fz IGludGVuZGVkIG9yaWdpbmFsbHkuCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gU28sIHRoZSBwcm9i bGVtIGlzIHdoZW4gd2UgdXBkYXRlIGEgbm9uLVBTUiBwaXBlIChCIG9yIEMpIGFuZAo+ID4gPiA+ ID4gUFNSCj4gPiA+ID4gPiBpcwo+ID4gPiA+ID4gYWN0aXZlIG9uIGFub3RoZXIgcGlwZShBLCBz cGVjaWZpY2FsbHkpLCB3ZSBlbmQgdXAgd2FpdGluZyBmb3IKPiA+ID4gPiA+IHRoZQo+ID4gPiA+ ID4gcGlwZQo+ID4gPiA+ID4gQSBNTUlPIHRvIGJlY29tZSBpZGxlLgo+ID4gPiA+ID4gCj4gPiA+ ID4gPiBDYW4geW91IHBsZWFzZSB1cGRhdGUgdGhlIGNvbW1pdCBtZXNzYWdlIGFzIHRoZSBjb21t aXQgbWVzc2FnZQo+ID4gPiA+ID4gbWFrZXMKPiA+ID4gPiA+IHRoZSBwZXItcGlwZSBjaGVjayBz b3VuZCBsaWtlIGFuIG9wdGltaXphdGlvbj/CoAo+ID4gPiA+ID4gCj4gPiA+ID4gPiBUaGlzIGFs c28gcG9pbnRzIHRvIGEgZ2FwIGluIG91ciB0ZXN0aW5nLCBJIGRvbid0IHNlZSBhIHR3bwo+ID4g PiA+ID4gcGlwZQo+ID4gPiA+ID4gUFNSCj4gPiA+ID4gPiByZWxhdGVkIElHVC4KPiA+ID4gPiA+ IAo+ID4gPiA+IFRoYXQncyByaWdodC4gT24gbXkgS0JMIGNocm9tZWJvb2sgdGhhdCdzIHJ1bm5p bmcgdGhlIGRybS10aXAsCj4gPiA+ID4gd2hlbiBJCj4gPiA+ID4gcGx1Zy1pbiBhbiBleHRlcm5h bCBkaXNwbGF5LCBzbyBwaXBlIEIsCj4gPiA+ID4gSSBzZWUgIltkcm06aW50ZWxfcGlwZV91cGRh dGVfc3RhcnRdICpFUlJPUiogUFNSIGlkbGUgdGltZWQgb3V0LAo+ID4gPiA+IGF0b21pYyB1cGRh dGUgbWF5IGZhaWwgb24gcGlwZSBCIiwgSWFkZGVkIHRoZSBwaXBlCj4gPiA+ID4gbmFtZSBpbiB0 aGUgRFJNX0VSUk9SLCBtYXkgYmUgSSBzaG91bGQgbWFrZSB0aGF0IGNoYW5nZSBpbiB0aGUgdjMK PiA+ID4gPiBvZgo+ID4gPiA+IHRoaXMgcGF0Y2ggYWxvbmcgd2l0aCB1cGRhdGluZyB0aGUgY29t bWl0IG1lc3NhZ2UuCj4gPiA+ID4gCj4gPiA+ID4gQnV0LCB5ZWEsIHRoaXMgcHJvdmVzIHRoYXQg d2l0aCB0aGUgQ0FOX1BTUiBjaGVjaywgdGhlIG5vbi1QU1IKPiA+ID4gPiBwaXBlcwo+ID4gPiA+ IChCL0MpIHdhaXQgb24gcGlwZS1BIHRvIGV4aXQgUFNSIHdoaWNoIGRvZXNuJ3QgaGF2ZQo+ID4g PiA+IGFueSByZWFzb24gdG8gZG8gc28gYXQgdGhhdCBtb21lbnQsIGhlbmNlIHRoZSBlcnJvci4K PiA+ID4gPiAKPiA+ID4gPiBJJ2xsIG1ha2UgdGhlIGNvbW1pdCBtZXNzYWdlIGNoYW5nZXMgYW5k IGFkZCB0aGUgcGlwZSBuYW1lIGluIHRoZQo+ID4gPiA+IERSTV9FUlJPUiBhcyB3ZWxsID8KPiA+ ID4gSSBhbSB0aGlua2luZyB5b3UgY291bGQgcGFzcyBjcnRjX3N0YXRlCj4gPiA+IHRvwqBpbnRl bF9wc3Jfd2FpdF9mb3JfaWRsZSgpCj4gPiA+IGFuZCB0aGVuIGNoZWNrIGluc2lkZSB0aGUgaW1w bGVtZW50YXRpb24gaWYgdGhlIGFyZ3VtZW50IGlzIHRoZQo+ID4gPiBzYW1lIGFzCj4gPiA+IHRo ZSBwaXBlIFBTUiB3YXMgZW5hYmxlZCBvbiBhbmQgdGhlbiB3YWl0Lgo+ID4gPiAKPiA+ID4gaW50 ZWxfcHNyX3dhaXRfZm9yX2lkbGUoY3J0Y19zdGF0ZSkgewo+ID4gPiAJaWYgKCFDQU5fUFNSKCkg fHwgIWNydGNfc3RhdGUtPmhhc19wc3IpCj4gPiA+IAkJcmV0dXJuOwo+ID4gPiAJLi4uCj4gPiA+ IH0KPiA+IEhtbSwgYnV0IHRoZSBDQU5fUFNSIGNoZWNrIGlzIGFscmVhZHkgdGFrZW4gY2FyZSBv ZiBieQo+ID4gaW50ZWxfcHNyX2NvbXB1dGVfY29uZmlnKCkgd2hpY2ggdGhlbiBzZXRzIGhhc19w c3IsIHNvIGp1c3QKPiA+IAlpZiAoIWNydGNfc3RhdGUtPmhhc19wc3IpCj4gPiAJCXJldHVybjsK PiA+IHNob3VsZCBzdWZmaWNlLCByaWdodCA/Cj4gPiAKPiBZZWFoLCB3ZSBjYW4gYXNzdW1lIGF0 IHRoaXMgcG9pbnQgc3RhdGUtPmhhc19wc3IgaXMgc2V0IGNvcnJlY3RseS4KPiAKPiA+IEJ1dCB0 aGVuLCB3ZSBpbmN1ciBhIGZ1bmN0aW9uIGNhbGwgZm9yIG5vbi1QU1IgcGlwZXMsIHdoaWNoIHdp bGwKPiA+IHJldHVybiByaWdodCBhd2F5Lgo+IAo+IFRoYXQgc2hvdWxkIGJlIG9rYXksIGhhdmlu ZyB0aGUgUFNSIHJlbGF0ZWQgY2hlY2sgaW5zaWRlIHRoZSBmdW5jdGlvbgo+IGxvb2tzIGNsZWFu ZXIgSU1PLsKgClNvdW5kcyBnb29kLgo+IAo+ID4gPiAKPiA+ID4gCj4gPiA+IEkgZG9uJ3QgbGlr ZSBob3cgaW50ZWxfcHNyX3dhaXRfZm9yX2lkbGUoKSBkb2Vzbid0IGNhcmUgd2hpY2ggcGlwZQo+ ID4gPiAodHJhbnNjb2RlciBhY3R1YWxseSkgTU1JTyBpdCBzaG91bGQgd2FpdCBvbi4KPiA+ID4g CQkKPiA+ID4gCj4gPiA+ID4gCj4gPiA+ID4gPiAKPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiAKPiA+ ID4gPiA+ID4gCj4gPiA+ID4gPiA+IEZpeGVzOiBhNjA4OTg3OTcwYjkgKCJkcm0vaTkxNTogV2Fp dCBmb3IgUFNSIGV4aXQgYmVmb3JlCj4gPiA+ID4gPiA+IGNoZWNraW5nCj4gPiA+ID4gPiA+IGZv cgo+ID4gPiA+ID4gPiB2YmxhbmsgZXZhc2lvbiIpCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiB2 MjogUmVtb3ZlIHVubmVjZXNzYXJ5IHBhcmFudGhlc2VzLCBtYWtlIGNoZWNrcGF0Y2ggaGFwcHku Cj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBSZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2Ry aWdvLnZpdmlAaW50ZWwuY29tPgo+ID4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBUYXJ1biBWeWFz IDx0YXJ1bi52eWFzQGludGVsLmNvbT4KPiA+ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiA+IMKgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgfCAyICstCj4gPiA+ID4gPiA+IMKgMSBm aWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+ID4gPiA+IAo+ ID4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRl LmMKPiA+ID4gPiA+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+ID4g PiA+ID4gPiBpbmRleCA0OTkwZDZlODRkZGYuLjgzODgwZTNhNWYzZCAxMDA2NDQKPiA+ID4gPiA+ ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiA+ID4gPiA+ID4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiA+ID4gPiA+ID4gQEAg LTExOCw3ICsxMTgsNyBAQCB2b2lkIGludGVsX3BpcGVfdXBkYXRlX3N0YXJ0KGNvbnN0IHN0cnVj dAo+ID4gPiA+ID4gPiBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZSkKPiA+ID4gPiA+ ID4gwqAJwqAqIFZCTCBpbnRlcnJ1cHRzIHdpbGwgc3RhcnQgdGhlIFBTUiBleGl0IGFuZAo+ID4g PiA+ID4gPiBwcmV2ZW50IGEKPiA+ID4gPiA+ID4gUFNSCj4gPiA+ID4gPiA+IMKgCcKgKiByZS1l bnRyeSBhcyB3ZWxsLgo+ID4gPiA+ID4gPiDCoAnCoCovCj4gPiA+ID4gPiA+IC0JaWYgKENBTl9Q U1IoZGV2X3ByaXYpICYmCj4gPiA+ID4gPiA+IGludGVsX3Bzcl93YWl0X2Zvcl9pZGxlKGRldl9w cml2KSkKPiA+ID4gPiA+ID4gKwlpZiAobmV3X2NydGNfc3RhdGUtPmhhc19wc3IgJiYKPiA+ID4g PiA+ID4gaW50ZWxfcHNyX3dhaXRfZm9yX2lkbGUoZGV2X3ByaXYpKQo+ID4gPiA+ID4gPiDCoAkJ RFJNX0VSUk9SKCJQU1IgaWRsZSB0aW1lZCBvdXQsIGF0b21pYyB1cGRhdGUKPiA+ID4gPiA+ID4g bWF5Cj4gPiA+ID4gPiA+IGZhaWxcbiIpOwo+ID4gPiA+ID4gPiDCoAo+ID4gPiA+ID4gPiDCoAls b2NhbF9pcnFfZGlzYWJsZSgpOwo+ID4gPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCj4gPiA+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gPiA+ IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+ID4gPiBodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK