From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 3/7] drm/i915: Convert fences to use a GGTT lock rather than struct_mutex Date: Thu, 12 Jul 2018 09:12:43 +0200 Message-ID: <20180712071243.GF3008@phenom.ffwll.local> References: <20180711073608.20286-1-chris@chris-wilson.co.uk> <20180711073608.20286-4-chris@chris-wilson.co.uk> <20180711090846.GV3008@phenom.ffwll.local> <153130664835.18500.14218544150315527790@skylake-alporthouse-com> <153130754940.18500.16846506196264433809@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id C732989A14 for ; Thu, 12 Jul 2018 07:12:47 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id x5-v6so17389090edr.0 for ; Thu, 12 Jul 2018 00:12:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <153130754940.18500.16846506196264433809@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKdWwgMTEsIDIwMTggYXQgMTI6MTI6MzlQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgQ2hyaXMgV2lsc29uICgyMDE4LTA3LTExIDExOjU3OjM4KQo+ID4gUXVv dGluZyBEYW5pZWwgVmV0dGVyICgyMDE4LTA3LTExIDEwOjA4OjQ2KQo+ID4gPiBJIHRoaW5rIHRo ZSBhYm92ZSBjaGFuZ2UgaXNuJ3QgY29ycmVjdCwgYXQgbGVhc3Qgbm90IHlldCBhdCB0aGlzIHN0 YWdlOgo+ID4gPiBBbGwgdXNlcnMgb2YgdGhlIHVzZXJmYXVsdF9saXN0IHN0aWxsIHVzZSBkZXYt PnN0cnVjdF9tdXRleCwgbm90IHZtLm11dGV4Lgo+ID4gPiBJIGd1ZXNzIHdlIGNvdWxkIG1vdmUg dGhhdCBvdmVyIHRvIHRoZSBnZ3R0LnZtLm11dGV4IGV2ZW50dWFsbHksIGJ1dCB0aGlzCj4gPiA+ IHBhdGNoIGRvZXNuJ3QgZG8gdGhhdC4KPiA+IAo+ID4gSXQgZG9lcywgYWxsIHRob3NlIG1pc3Bs YWNlZCBodW5rcyBhcmUgbm90IHNvIG1pc3BsYWNlZC4KPiAKPiBTaW5jZSB3ZSBoYXZlIGRpZmZl cmluZyBvcGluaW9ucyBvbiB3aGV0aGVyIHRoaXMgaXMgb3IgaXMgbm90Cj4gc3VmZmljaWVudGx5 IGd1YXJkaW5nIEdHVFQgdnMgcnBtLCB3aGF0IHRlc3QgYXJlIHdlIG1pc3NpbmcgaW4gQ0kgdG8K PiBjb25jbHVzaXZlbHkgaW5kaWNhdGUgd2hldGhlciBvciBub3QgdGhpcyBpcyBicm9rZW4uIEFz IGl0IHN0YW5kcywgQ0kgaXMKPiBoYXBweSwgYW5kIEkgZG9uJ3QgaGF2ZSBtYW55IG1hY2hpbmVz IHdoZXJlIHJwbSB3b3JrcyAoc2luY2UgaXQgcmVxdWlyZXMKPiBmdywgc291bmQgZHJpdmVycywg ZXRjKS4KClNvIHRoZSAibWlzcGxhY2VkIGh1bmsiIGNvbW1lbnQgSSB0eXBlZCBiZWZvcmUgSSBm dWxseSByZWFkIHRocm91Z2ggdGhlCnBhdGNoIGFuZCBzcG90dGVkIHRoZSByZXdvcmsgb2YgdGhl IHVzZXJmYXVsdCBsaXN0LiBNeSB1bmRlcnN0YW5kaW5nIGlzCnN0aWxsIHRoYXQgdGhlIHVzZXJm YXVsdF9saXN0IGlzIHByb3RlY3RlZCBieSBycG0gKHNlZSBzb21lIG9mIHRoZQphc3NlcnRfcnBt X3dha2Vsb2NrX2hlbGQgcmlnaHQgbmV4dCB0byB0aGVtKSwgb3IgbWF5YmUgYSBjb21iaW5hdGlv biBvZgpycG0gKyBkZXYtPnN0cnVjdF9tdXRleC4KCkFmYWljdCBpdCdzIGRlZmluaXRlbHkgbm90 IHByb3RlY3RlZCBieSB0aGUgbmV3IHZtLm11dGV4LCBldmVuIGFmdGVyIHRoaXMKcGF0Y2guIFRo YXQncyB3aHkgSSBjb21wbGFpbmVkIGFib3V0IHRoZSBjb21tZW50IGNoYW5nZSwgYW5kIGFsc28g d2h5IEkKZGlkbid0IHNlZSB3aHkgdGhpcyBwYXRjaCBoZXJlIG5lZWRzIHRoZSB1c2VyZmF1bHRf Y291bnQgY2hhbmdlcy4KCk5vdyBjb3VsZCB2ZXJ5IHdlbGwgYmUgdGhhdCBJJ20gbWlzc2luZyBz b21ldGhpbmcgYXJvdW5kIHVzZXJmYXVsdCAtIEkKZG9uJ3QgcmVtZW1iZXIgdGhlIGRldGFpbHMs IGV4Y2VwdCB0aGF0IGV2ZXJ5IHRpbWUgSSB0cnkgdG8gcmVjb25zdHJ1Y3QgYQptZW50YWwgbW9k ZWwgZm9yIHRoaXMgSSBnZXQgd3JvbmcgZm9yIGEgZmV3IGRheXMuIEJ1dCBpZiB0aGF0J3MgdGhl IGNhc2UKdGhlbiBJIHRoaW5rIHlvdSdyZSBwYXRjaCBpc24ndCBzdWZmaWNpZW50LgoKLSBKdXN0 IGZvciBjb2RlIG9yZ2FuaXphdGlvbiByZWFzb25zIEkgdGhpbmsgd2Ugc2hvdWxkIHRoZW4gbW92 ZQogIG1tLnVzZXJmYXVsdF9saXN0IHRvIHRoZSBnZ3R0LCBsaWtlIHlvdSd2ZSBkb25lIHdpdGgg dGhlIGZlbmNlIHN0dWZmLgogIFNlcGFyYXRlIHBhdGNoIHByb2JhYmx5LCBsaWtlIHRoZSBmZW5j ZSBwcmVwLgoKLSBBbGwgdGhlIG90aGVyIHBsYWNlcyB0aGF0IHRvdWNoIHVzZXJmYXVsdF8qIG5l ZWQgdG8gYmUgYXVkaXRlZC9maXhlZAogIHRvby4KClRoaXMgaXMgcHJvYmFibHkgc29tZXRoaW5n IHdlIG5lZWQvd2FudCB0byBkbywgYnV0IEkgZG9uJ3Qgc2VlIHRoZQpyZWxhdGlvbnNoaXAgd2l0 aCBmZW5jZXMuIEFuZCBhc3N1bWluZyB0aGUgY3VycmVudCBsb2NraW5nIHNjaGVtZSBpcyBzb3Vu ZAood2l0aCBpdCdzIGZ1bmt5IGNvbWJpbmF0aW9uIG9mIGRldi0+c3RydWN0X211dGV4ICsgcnBt KSBJIGRvbid0IHNlZSB3aHkKd2UgbmVlZCB0byBkbyBhbnl0aGluZyBpbiBhIHBhdGNoIHRoYXQg b25seSBtb3ZlcyB0aGUgZmVuY2Ugc3R1ZmYgb3ZlcgooYW5kIG5vdCBhbnl0aGluZyBvZiB0aGUg b3RoZXIgZ2d0dCBtbWFwIHRyaWNrZXJ5KSB0byB2bS5tdXRleC4KCldydCBDSSBjb3ZlcmFnZTog R2l2ZW4gdGhhdCBJIHRoaW5rIHRoZSBjdXJyZW50IGNvZGUgd2l0aG91dCB5b3VyIGNoYW5nZXMK d291bGQgYmUgZmluZSwgZXZlbiB3aXRoIGZlbmNlIHJlZyB0cmFja2luZyBwcm90ZWN0ZWQgYnkg dm0ubXV0ZXgsIHRoZXJlJ3MKbm90aGluZyBmb3IgQ0kgdG8gcHJvdmUuIEknbSBqdXN0IHNheWlu ZyB5b3UgY291bGQgZHJvcCBhbGwgdGhlCnVzZXJmYXVsdF8qIHJlbGF0ZWQgY2hhbmdlcyBmcm9t IHRoaXMgcGF0Y2gsIGFuZCBpdCBzaG91bGQgc3RpbGwgYWxsIHdvcmsuCgp0bGRyOyBJIHRoaW5r IHVzZXJmYXVsdF8qIGlzIHNhZmUgYXMgaXMgYW5kIHdpbGwgc3RheSBzYWZlIGV2ZW4gd2l0aApm ZW5jZXMgbW92ZWQgdG8gb3RoZXIgbG9ja3MuIFlvdSBjYW4ga2VlcCB0aGUgdmFyaW91cyBodW5r cyBJIGNvbXBsYWluZWQKYWJvdXQgZm9yIGZ1dHVyZSBwYXRjaGVzIHdoaWNoIHdpbGwgbW92ZSB1 c2VyZmF1bHRfKiBvdmVyIHRvCmdndHQudm0ubXV0ZXguCgpBbmQgb2ggZGVhciBkbyBJIG5vdCBs b29rIGZvcndhcmQgdG8gcmV2aWV3ZWluZyB1c2VyZmF1bHRfKiBsb2NraW5nCmNoYW5nZXMgOi0p CgpDaGVlcnMsIERhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50 ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==