From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915/guc: Protect against NULL client
 dereference in error path
Date: Thu, 12 Jul 2018 16:02:36 -0700
Message-ID: <20180712230236.GE2208@intel.com>
References: <20180712202027.19801-1-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 29FC76F14D
 for <intel-gfx@lists.freedesktop.org>; Thu, 12 Jul 2018 23:02:37 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20180712202027.19801-1-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBKdWwgMTIsIDIwMTggYXQgMDk6MjA6MjdQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IEFmdGVyIGFib3J0aW5nIGEgbW9kdWxlIGxvYWQsIHdlIG1heSB0cnkgYW5kIGRpc2Fi
bGUgZ3VjIGJlZm9yZSB3ZSBoYXZlCj4gZmluaXNoZWQgc2V0dGluZyBpdC4gTG9uZyB0ZXJtIHBs
YW4gaXMgdG8gZW5zdXJlIHBlcmZlY3Qgb25pb24gdW53aW5kLAo+IGJ1dCBpbiB0aGUgc2hvcnQg
dGVybSB3ZSB3YW50IHRvIGZpeCB0aGUgb29wcyB0byByZS1lbmFibGUKPiBkcnZfbW9kdWxlX3Jl
bG9hZC4KPiAKPiBbICAzMTcuNDAxMjM5XSBCVUc6IHVuYWJsZSB0byBoYW5kbGUga2VybmVsIE5V
TEwgcG9pbnRlciBkZXJlZmVyZW5jZSBhdCAwMDAwMDAwMDAwMDAwMDMwCj4gWyAgMzE3LjQwMTI3
OV0gT29wczogMDAwMCBbIzFdIFBSRUVNUFQgU01QIFBUSQo+IFsgIDMxNy40MDEyOTRdIENQVTog
NSBQSUQ6IDQyNzUgQ29tbTogZHJ2X21vZHVsZV9yZWxvIFRhaW50ZWQ6IEcgICAgIFUgICAgICAg
ICAgICA0LjE4LjAtcmM0LUNJLUNJX0RSTV80NDc2KyAjMQo+IFsgIDMxNy40MDEzMTddIEhhcmR3
YXJlIG5hbWU6IFN5c3RlbSBtYW51ZmFjdHVyZXIgU3lzdGVtIFByb2R1Y3QgTmFtZS9aMTcwTS1Q
TFVTLCBCSU9TIDM2MTAgMDMvMjkvMjAxOAo+IFsgIDMxNy40MDE0NDBdIFJJUDogMDAxMDp1bnJl
c2VydmVfZG9vcmJlbGwrMHgwLzB4ODAgW2k5MTVdCj4gWyAgMzE3LjQwMTQ1NF0gQ29kZTogYmIg
ZTAgNDggOGIgMzUgMjEgNGQgMTggMDAgNDkgYzcgYzAgYTggZTUgNjIgYTAgYjkgY2MgMDAgMDAg
MDAgNDggYzcgYzIgZDggNDEgNWYgYTAgNDggYzcgYzcgYzkgZjYgNTMgYTAgZTggYTIgM2QgYzIg
ZTAgMGYgMGIgPDBmPiBiNyA0NyAzMCA2NiAzZCAwMCAwMSA3NCAyMCA0OCA4YiA1NyAxOCA0OCAw
ZiBhMyA4MiA0MCAwNSAwMCAwMAo+IFsgIDMxNy40MDE2MDJdIFJTUDogMDAxODpmZmZmYzkwMDAw
M2QzZGEwIEVGTEFHUzogMDAwMTAyNDYKPiBbICAzMTcuNDAxNjE5XSBSQVg6IGZmZmZmZmZmODIy
M2IzMDAgUkJYOiAwMDAwMDAwMDAwMDAwMDAwIFJDWDogMDAwMDAwMDAwMDAwMDAwMAo+IFsgIDMx
Ny40MDE2MzZdIFJEWDogMDAwMDAwMWZmZmZmZmZjMCBSU0k6IGZmZmY4ODAyMTlmMTE1ZjAgUkRJ
OiAwMDAwMDAwMDAwMDAwMDAwCj4gWyAgMzE3LjQwMTY1NF0gUkJQOiBmZmZmODgwMjE5ZjExODM4
IFIwODogMDAwMDAwMDAwMDAwMDAwMCBSMDk6IDAwMDAwMDAwMDAwMDAwMDAKPiBbICAzMTcuNDAx
NjcxXSBSMTA6IDAwMDAwMDAwMDAwMDAwMDAgUjExOiAwMDAwMDAwMDAwMDAwMDAwIFIxMjogZmZm
Zjg4MDIxOWYxMTMwMAo+IFsgIDMxNy40MDE2ODldIFIxMzogZmZmZjg4MDIxOWYxNzc3MCBSMTQ6
IGZmZmY4ODAyMmMxZGFlZjggUjE1OiBmZmZmZmZmZmEwNmFlOTUwCj4gWyAgMzE3LjQwMTcwN10g
RlM6ICAwMDAwN2ZlYmY3N2E5OTgwKDAwMDApIEdTOmZmZmY4ODAyMzZkNDAwMDAoMDAwMCkga25s
R1M6MDAwMDAwMDAwMDAwMDAwMAo+IFsgIDMxNy40MDE3MjddIENTOiAgMDAxMCBEUzogMDAwMCBF
UzogMDAwMCBDUjA6IDAwMDAwMDAwODAwNTAwMzMKPiBbICAzMTcuNDAxNzQzXSBDUjI6IDAwMDAw
MDAwMDAwMDAwMzAgQ1IzOiAwMDAwMDAwMjIyMDcyMDAzIENSNDogMDAwMDAwMDAwMDM2MDZlMAo+
IFsgIDMxNy40MDE3NjFdIERSMDogMDAwMDAwMDAwMDAwMDAwMCBEUjE6IDAwMDAwMDAwMDAwMDAw
MDAgRFIyOiAwMDAwMDAwMDAwMDAwMDAwCj4gWyAgMzE3LjQwMTc3OV0gRFIzOiAwMDAwMDAwMDAw
MDAwMDAwIERSNjogMDAwMDAwMDBmZmZlMGZmMCBEUjc6IDAwMDAwMDAwMDAwMDA0MDAKPiBbICAz
MTcuNDAxNzk2XSBDYWxsIFRyYWNlOgo+IFsgIDMxNy40MDE4OTRdICBndWNfY2xpZW50X2ZyZWUr
MHg5LzB4MTMwIFtpOTE1XQo+IFsgIDMxNy40MDE5OTNdICBpbnRlbF9ndWNfc3VibWlzc2lvbl9m
aW5pKzB4NTAvMHg5MCBbaTkxNV0KPiBbICAzMTcuNDAyMDkyXSAgaW50ZWxfdWNfZmluaSsweDM0
LzB4ZDAgW2k5MTVdCj4gWyAgMzE3LjQwMjE3OV0gIGk5MTVfZ2VtX2ZpbmkrMHg1Yy8weDEwMCBb
aTkxNV0KPiBbICAzMTcuNDAyMjQ5XSAgaTkxNV9kcml2ZXJfdW5sb2FkKzB4ZDIvMHgxMTAgW2k5
MTVdCj4gWyAgMzE3LjQwMjMyMV0gIGk5MTVfcGNpX3JlbW92ZSsweDEwLzB4MjAgW2k5MTVdCj4g
WyAgMzE3LjQwMjM0MV0gIHBjaV9kZXZpY2VfcmVtb3ZlKzB4MzYvMHhiMAo+IFsgIDMxNy40MDIz
NTddICBkZXZpY2VfcmVsZWFzZV9kcml2ZXJfaW50ZXJuYWwrMHgxODUvMHgyNTAKPiBbICAzMTcu
NDAyMzc0XSAgZHJpdmVyX2RldGFjaCsweDM1LzB4NzAKPiBbICAzMTcuNDAyMzkwXSAgYnVzX3Jl
bW92ZV9kcml2ZXIrMHg1My8weGQwCj4gWyAgMzE3LjQwMjQwNF0gIHBjaV91bnJlZ2lzdGVyX2Ry
aXZlcisweDI1LzB4YTAKPiBbICAzMTcuNDAyNDIzXSAgX19zZV9zeXNfZGVsZXRlX21vZHVsZSsw
eDE2Mi8weDIxMAo+IFsgIDMxNy40MDI0MzldICA/IGRvX3N5c2NhbGxfNjQrMHhkLzB4MTkwCj4g
WyAgMzE3LjQwMjQ1NF0gIGRvX3N5c2NhbGxfNjQrMHg1NS8weDE5MAo+IFsgIDMxNy40MDI0NzBd
ICBlbnRyeV9TWVNDQUxMXzY0X2FmdGVyX2h3ZnJhbWUrMHg0OS8weGJlCj4gWyAgMzE3LjQwMjQ4
NV0gUklQOiAwMDMzOjB4N2ZlYmY2ZTVkMWI3Cj4gWyAgMzE3LjQwMjQ5Nl0gQ29kZTogNzMgMDEg
YzMgNDggOGIgMGQgZDEgOGMgMmMgMDAgZjcgZDggNjQgODkgMDEgNDggODMgYzggZmYgYzMgNjYg
MmUgMGYgMWYgODQgMDAgMDAgMDAgMDAgMDAgMGYgMWYgNDQgMDAgMDAgYjggYjAgMDAgMDAgMDAg
MGYgMDUgPDQ4PiAzZCAwMSBmMCBmZiBmZiA3MyAwMSBjMyA0OCA4YiAwZCBhMSA4YyAyYyAwMCBm
NyBkOCA2NCA4OSAwMSA0OAo+IFsgIDMxNy40MDI2NDZdIFJTUDogMDAyYjowMDAwN2ZmZmI1ZTcy
Nzk4IEVGTEFHUzogMDAwMDAyMDYgT1JJR19SQVg6IDAwMDAwMDAwMDAwMDAwYjAKPiBbICAzMTcu
NDAyNjY3XSBSQVg6IGZmZmZmZmZmZmZmZmZmZGEgUkJYOiAwMDAwMDAwMDAwMDAwMDAwIFJDWDog
MDAwMDdmZWJmNmU1ZDFiNwo+IFsgIDMxNy40MDI2ODZdIFJEWDogMDAwMDAwMDAwMDAwMDAwMCBS
U0k6IDAwMDAwMDAwMDAwMDA4MDAgUkRJOiAwMDAwNTYyZGExYWRkZDk4Cj4gWyAgMzE3LjQwMjcw
M10gUkJQOiAwMDAwNTYyZGExYWRkZDMwIFIwODogMDAwMDU2MmRhMWFkZGQ5YyBSMDk6IDAwMDA3
ZmZmYjVlNzI3ZDgKPiBbICAzMTcuNDAyNzIxXSBSMTA6IDAwMDA3ZmZmYjVlNzE3OTQgUjExOiAw
MDAwMDAwMDAwMDAwMjA2IFIxMjogMDAwMDU2MmRhMGZmNjQ3MAo+IAo+IFRlc3RjYXNlOiBpZ3Qv
ZHJ2X21vZHVsZV9yZWxvYWQvYmFzaWMtcmVsb2FkLWluamVjdAo+IFNpZ25lZC1vZmYtYnk6IENo
cmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBNaWNoYcWCIFdpbmlh
cnNraSA8bWljaGFsLndpbmlhcnNraUBpbnRlbC5jb20+Cj4gQ2M6IE1pY2hhbCBXYWpkZWN6a28g
PG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IFJvZHJpZ28gVml2aSA8
cm9kcmlnby52aXZpQGludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu
dGVsX2d1Y19zdWJtaXNzaW9uLmMgfCAzICsrLQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRp
b25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2d1Y19zdWJtaXNzaW9uLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9n
dWNfc3VibWlzc2lvbi5jCj4gaW5kZXggY2Q1MWJlOGZmMDI1Li4yMjM2NzEzMWQ2YTEgMTAwNjQ0
Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX3N1Ym1pc3Npb24uYwo+ICsr
KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19zdWJtaXNzaW9uLmMKPiBAQCAtMTEy
OCw3ICsxMTI4LDggQEAgc3RhdGljIHZvaWQgZ3VjX2NsaWVudHNfZGVzdHJveShzdHJ1Y3QgaW50
ZWxfZ3VjICpndWMpCj4gIAkJZ3VjX2NsaWVudF9mcmVlKGNsaWVudCk7Cj4gIAo+ICAJY2xpZW50
ID0gZmV0Y2hfYW5kX3plcm8oJmd1Yy0+ZXhlY2J1Zl9jbGllbnQpOwo+IC0JZ3VjX2NsaWVudF9m
cmVlKGNsaWVudCk7Cj4gKwlpZiAoY2xpZW50KQo+ICsJCWd1Y19jbGllbnRfZnJlZShjbGllbnQp
Owo+ICB9Cj4gIAo+ICAvKgo+IC0tIAo+IDIuMTguMAo+IAo+IF9fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IElu
dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w
Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs
aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h
bi9saXN0aW5mby9pbnRlbC1nZngK