[PATCH] drm/i915/psr: Remove useless function calls.

[PATCH] drm/i915/psr: Remove useless function calls.

[Rodrigo Vivi]

PSR is no longer supported on VLV/CHV so this is just dead code.

Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 5be07e1d816d..7d40bfcb1bbb 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -2830,10 +2830,6 @@ static void vlv_disable_dp(struct intel_encoder *encoder,
 			   const struct intel_crtc_state *old_crtc_state,
 			   const struct drm_connector_state *old_conn_state)
 {
-	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
-
-	intel_psr_disable(intel_dp, old_crtc_state);
-
 	intel_disable_dp(encoder, old_crtc_state, old_conn_state);
 }
 
@@ -3046,10 +3042,7 @@ static void vlv_enable_dp(struct intel_encoder *encoder,
 			  const struct intel_crtc_state *pipe_config,
 			  const struct drm_connector_state *conn_state)
 {
-	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
-
 	intel_edp_backlight_on(pipe_config, conn_state);
-	intel_psr_enable(intel_dp, pipe_config);
 }
 
 static void g4x_pre_enable_dp(struct intel_encoder *encoder,
-- 
2.17.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Remove useless function calls.

[Souza, Jose]

On Wed, 2018-07-11 at 15:00 -0700, Rodrigo Vivi wrote:
> PSR is no longer supported on VLV/CHV so this is just dead code.
> 

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c
> b/drivers/gpu/drm/i915/intel_dp.c
> index 5be07e1d816d..7d40bfcb1bbb 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -2830,10 +2830,6 @@ static void vlv_disable_dp(struct
> intel_encoder *encoder,
>  			   const struct intel_crtc_state
> *old_crtc_state,
>  			   const struct drm_connector_state
> *old_conn_state)
>  {
> -	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
> -
> -	intel_psr_disable(intel_dp, old_crtc_state);
> -
>  	intel_disable_dp(encoder, old_crtc_state, old_conn_state);
>  }
>  
> @@ -3046,10 +3042,7 @@ static void vlv_enable_dp(struct intel_encoder
> *encoder,
>  			  const struct intel_crtc_state
> *pipe_config,
>  			  const struct drm_connector_state
> *conn_state)
>  {
> -	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
> -
>  	intel_edp_backlight_on(pipe_config, conn_state);
> -	intel_psr_enable(intel_dp, pipe_config);
>  }
>  
>  static void g4x_pre_enable_dp(struct intel_encoder *encoder,
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/psr: Remove useless function calls.

[Rodrigo Vivi]

On Wed, Jul 11, 2018 at 10:04:00PM +0000, Souza, Jose wrote:
> On Wed, 2018-07-11 at 15:00 -0700, Rodrigo Vivi wrote:
> > PSR is no longer supported on VLV/CHV so this is just dead code.
> > 
> 
> Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

pushed to dinq, thanks

> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_dp.c | 7 -------
> >  1 file changed, 7 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_dp.c
> > b/drivers/gpu/drm/i915/intel_dp.c
> > index 5be07e1d816d..7d40bfcb1bbb 100644
> > --- a/drivers/gpu/drm/i915/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > @@ -2830,10 +2830,6 @@ static void vlv_disable_dp(struct
> > intel_encoder *encoder,
> >  			   const struct intel_crtc_state
> > *old_crtc_state,
> >  			   const struct drm_connector_state
> > *old_conn_state)
> >  {
> > -	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
> > -
> > -	intel_psr_disable(intel_dp, old_crtc_state);
> > -
> >  	intel_disable_dp(encoder, old_crtc_state, old_conn_state);
> >  }
> >  
> > @@ -3046,10 +3042,7 @@ static void vlv_enable_dp(struct intel_encoder
> > *encoder,
> >  			  const struct intel_crtc_state
> > *pipe_config,
> >  			  const struct drm_connector_state
> > *conn_state)
> >  {
> > -	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
> > -
> >  	intel_edp_backlight_on(pipe_config, conn_state);
> > -	intel_psr_enable(intel_dp, pipe_config);
> >  }
> >  
> >  static void g4x_pre_enable_dp(struct intel_encoder *encoder,
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915/psr: Remove useless function calls.

[Patchwork]

== Series Details ==

Series: drm/i915/psr: Remove useless function calls.
URL   : https://patchwork.freedesktop.org/series/46339/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4473 -> Patchwork_9619 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46339/revisions/1/mbox/

== Known issues ==

  Here are the changes found in Patchwork_9619 that come from known issues:

  === IGT changes ===

    ==== Possible fixes ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-skl-6700k2:      FAIL (fdo#103191) -> PASS

    
    ==== Warnings ====

    igt@gem_exec_suspend@basic-s4-devices:
      {fi-kbl-8809g}:     INCOMPLETE (fdo#107139) -> DMESG-WARN (fdo#107139)

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139


== Participating hosts (46 -> 42) ==

  Additional (1): fi-skl-guc 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * Linux: CI_DRM_4473 -> Patchwork_9619

  CI_DRM_4473: 17c95b123220c6896ac9cf99c78be4709da704d4 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4549: e19fd5549e9cf603251704117fc64f4068be5016 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9619: ed4d3ec314fce5f057ee3af26a55bbd2d52dd8c0 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

ed4d3ec314fc drm/i915/psr: Remove useless function calls.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9619/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx