From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v2 2/2] drm/i915/mst: Continue state updates even if AUX writes fail. Date: Wed, 18 Jul 2018 22:43:16 -0700 Message-ID: <20180719054316.GN2146@intel.com> References: <20180718171943.3246-1-dhinakaran.pandiyan@intel.com> <20180718171943.3246-2-dhinakaran.pandiyan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id A175B6EC35 for ; Thu, 19 Jul 2018 05:43:28 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180718171943.3246-2-dhinakaran.pandiyan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKdWwgMTgsIDIwMTggYXQgMTA6MTk6NDNBTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiBXZSBhcmUgdG9vIGxhdGUgaW4gdGhlIGVuYWJsaW5nIHNlcXVlbmNlIHRv IGJhY2sgb3V0IGNsZWFubHksIG5vdCB1cGRhdGluZwo+IHN0YXRlIHRyYWNraW5nIHZhcmlhYmxl cywgbGlrZSBpbnRlbF9kcC0+YWN0aXZlX21zdF9saW5rcyBpbiB0aGlzCj4gaW5zdGFuY2UsIHJl c3VsdHMgaW4gaW5jb3JyZWN0IGJlaGF2aW91ciBmdXJ0aGVyIGFsb25nLgoKSSBhZ3JlZSB3aXRo IHlvdSwgYWx0aG91Z2ggSSdtIG5vdCBmdWxseSBjb252aW5jZWQgdGhhdCB3ZSBuZWVkIHRvIGNh bGwgdGhlCnVwZGF0ZSBwYXlsb2FkIGlmIHZjcGkgYWxsb2NhdGlvbiBmYWlsZWQuLi4KCnNvIGlt aG8gdGhpcyBlbnRpcmUgZnVuY3Rpb24gc2hvdWxkIGJlIHJld29ya2VkIHRvIGJlIGxpa2UgdGhp czoKCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21zdC5jCkBAIC0yMTcsNyAr MjE3LDYgQEAgc3RhdGljIHZvaWQgaW50ZWxfbXN0X3ByZV9lbmFibGVfZHAoc3RydWN0IGludGVs X2VuY29kZXIgKmVuY29kZXIsCiAgICAgICAgZW51bSBwb3J0IHBvcnQgPSBpbnRlbF9kaWdfcG9y dC0+YmFzZS5wb3J0OwogICAgICAgIHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvciA9 CiAgICAgICAgICAgICAgICB0b19pbnRlbF9jb25uZWN0b3IoY29ubl9zdGF0ZS0+Y29ubmVjdG9y KTsKLSAgICAgICBpbnQgcmV0OwogICAgICAgIHVpbnQzMl90IHRlbXA7CiAKICAgICAgICAvKiBN U1QgZW5jb2RlcnMgYXJlIGJvdW5kIHRvIGEgY3J0Yywgbm90IHRvIGEgY29ubmVjdG9yLApAQCAt MjMzLDI1ICsyMzIsMTUgQEAgc3RhdGljIHZvaWQgaW50ZWxfbXN0X3ByZV9lbmFibGVfZHAoc3Ry dWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCiAKICAgICAgICBkcm1fZHBfc2VuZF9wb3dlcl91 cGRvd25fcGh5KCZpbnRlbF9kcC0+bXN0X21nciwgY29ubmVjdG9yLT5wb3J0LCB0cnVlKTsKIAot ICAgICAgIGlmIChpbnRlbF9kcC0+YWN0aXZlX21zdF9saW5rcyA9PSAwKQorICAgICAgIGlmIChp bnRlbF9kcC0+YWN0aXZlX21zdF9saW5rcysrID09IDApCiAgICAgICAgICAgICAgICBpbnRlbF9k aWdfcG9ydC0+YmFzZS5wcmVfZW5hYmxlKCZpbnRlbF9kaWdfcG9ydC0+YmFzZSwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGlwZV9jb25maWcsIE5VTEwp OwogCi0gICAgICAgcmV0ID0gZHJtX2RwX21zdF9hbGxvY2F0ZV92Y3BpKCZpbnRlbF9kcC0+bXN0 X21nciwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29ubmVjdG9yLT5w b3J0LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwaXBlX2NvbmZpZy0+ cGJuLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwaXBlX2NvbmZpZy0+ ZHBfbV9uLnR1KTsKLSAgICAgICBpZiAocmV0ID09IGZhbHNlKSB7CisgICAgICAgaWYgKGRybV9k cF9tc3RfYWxsb2NhdGVfdmNwaSgmaW50ZWxfZHAtPm1zdF9tZ3IsIGNvbm5lY3Rvci0+cG9ydCwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBpcGVfY29uZmlnLT5wYm4sIHBp cGVfY29uZmlnLT5kcF9tX24udHUpKQorICAgICAgICAgICAgICAgZHJtX2RwX3VwZGF0ZV9wYXls b2FkX3BhcnQxKCZpbnRlbF9kcC0+bXN0X21ncik7CisgICAgICAgZWxzZQogICAgICAgICAgICAg ICAgRFJNX0VSUk9SKCJmYWlsZWQgdG8gYWxsb2NhdGUgdmNwaVxuIik7Ci0gICAgICAgICAgICAg ICByZXR1cm47Ci0gICAgICAgfQotCi0KLSAgICAgICBpbnRlbF9kcC0+YWN0aXZlX21zdF9saW5r cysrOwotICAgICAgIHRlbXAgPSBJOTE1X1JFQUQoRFBfVFBfU1RBVFVTKHBvcnQpKTsKLSAgICAg ICBJOTE1X1dSSVRFKERQX1RQX1NUQVRVUyhwb3J0KSwgdGVtcCk7Ci0KLSAgICAgICByZXQgPSBk cm1fZHBfdXBkYXRlX3BheWxvYWRfcGFydDEoJmludGVsX2RwLT5tc3RfbWdyKTsKCgpwcm9iYWJs eSB3aXRoCi0gICAgICAgdGVtcCA9IEk5MTVfUkVBRChEUF9UUF9TVEFUVVMocG9ydCkpOwotICAg ICAgIEk5MTVfV1JJVEUoRFBfVFBfU1RBVFVTKHBvcnQpLCB0ZW1wKTsKCmluIGEgc2VwYXJhdGVk IHBhdGNoLiBObyBpZGVhIHdoeSB3ZSByZWFkIHRoaXMgc3RhdXMgcmVnIGFuZCB3cml0ZSBiYWNr LgpJIGRpZG4ndCBzZWUgb24gc3BlYyBhbnkgaW5kaWNhdGlvbiB0aGF0IHRoaXMgY2xlYW5zIGl0 IG9yIHRoYXQgd2UgbmVlZCB0aGF0CmZvciBjbGVhbmluZyBvciBhbnl0aGluZyBlbHNlLgoKPiAK PiB2MjogRml4ZWQgaW50IHYvcyBib29sIGNvbXBhcmlzb24KPiAKPiBDYzogVmlsbGUgU3lyasOk bMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzogUm9kcmlnbyBWaXZpIDxy b2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+IENjOiBOYXRoYW4gQ2lvYmFudSA8bmF0aGFuLmQuY2lv YmFudUBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogRGhpbmFrYXJhbiBQYW5kaXlh biA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RwX21zdC5jIHwgNSArLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNl cnRpb24oKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RwX21zdC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbXN0 LmMKPiBpbmRleCA3ZTNlMDE2MDc2NDMuLjExMGU3ZmYyMmVmNyAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9tc3QuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RwX21zdC5jCj4gQEAgLTI0MSwxMSArMjQxLDggQEAgc3RhdGljIHZvaWQgaW50 ZWxfbXN0X3ByZV9lbmFibGVfZHAoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAkJ CQkgICAgICAgY29ubmVjdG9yLT5wb3J0LAo+ICAJCQkJICAgICAgIHBpcGVfY29uZmlnLT5wYm4s Cj4gIAkJCQkgICAgICAgcGlwZV9jb25maWctPmRwX21fbi50dSk7Cj4gLQlpZiAocmV0ID09IGZh bHNlKSB7Cj4gKwlpZiAoIXJldCkKPiAgCQlEUk1fRVJST1IoImZhaWxlZCB0byBhbGxvY2F0ZSB2 Y3BpXG4iKTsKPiAtCQlyZXR1cm47Cj4gLQl9Cj4gLQo+ICAKPiAgCWludGVsX2RwLT5hY3RpdmVf bXN0X2xpbmtzKys7Cj4gIAl0ZW1wID0gSTkxNV9SRUFEKERQX1RQX1NUQVRVUyhwb3J0KSk7Cj4g LS0gCj4gMi4xNy4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=