intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Nathan Ciobanu <nathan.d.ciobanu@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org,
	Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Subject: Re: [PATCH] drm/i915: Remove unused "ret" variable.
Date: Fri, 20 Jul 2018 10:41:46 -0700	[thread overview]
Message-ID: <20180720174146.GD16907@intel.com> (raw)
In-Reply-To: <20180720005633.GA13259@nc-new>

On Thu, Jul 19, 2018 at 05:56:33PM -0700, Nathan Ciobanu wrote:
> On Thu, Jul 19, 2018 at 05:16:03PM -0700, Nathan Ciobanu wrote:
> > On Thu, Jul 19, 2018 at 04:42:17PM -0700, Rodrigo Vivi wrote:
> > > Just a small clean-up with no functional change, only
> > > removing a variable that is never actually used.
> > > 
> > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Nice one :)
> > Reviewed-by: <nathan.d.ciobanu@linux.intel.com>
> Reviewed-by: Nathan Ciobanu <nathan.d.ciobanu@linux.intel.com>

Thanks, pushed.

> > > ---
> > >  drivers/gpu/drm/i915/intel_dp_mst.c | 5 ++---
> > >  1 file changed, 2 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c
> > > index 7e3e01607643..18c65f8e4fe8 100644
> > > --- a/drivers/gpu/drm/i915/intel_dp_mst.c
> > > +++ b/drivers/gpu/drm/i915/intel_dp_mst.c
> > > @@ -263,7 +263,6 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder,
> > >  	struct intel_dp *intel_dp = &intel_dig_port->dp;
> > >  	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> > >  	enum port port = intel_dig_port->base.port;
> > > -	int ret;
> > >  
> > >  	DRM_DEBUG_KMS("active links %d\n", intel_dp->active_mst_links);
> > >  
> > > @@ -274,9 +273,9 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder,
> > >  				    1))
> > >  		DRM_ERROR("Timed out waiting for ACT sent\n");
> > >  
> > > -	ret = drm_dp_check_act_status(&intel_dp->mst_mgr);
> > > +	drm_dp_check_act_status(&intel_dp->mst_mgr);
> > >  
> > > -	ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr);
> > > +	drm_dp_update_payload_part2(&intel_dp->mst_mgr);
> > >  	if (pipe_config->has_audio)
> > >  		intel_audio_codec_enable(encoder, pipe_config, conn_state);
> > >  }
> > > -- 
> > > 2.17.1
> > > 
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-07-20 17:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19 23:42 [PATCH] drm/i915: Remove unused "ret" variable Rodrigo Vivi
2018-07-20  0:15 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-07-20  0:16 ` [PATCH] " Nathan Ciobanu
2018-07-20  0:56   ` Nathan Ciobanu
2018-07-20 17:41     ` Rodrigo Vivi [this message]
2018-07-20  6:21 ` ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180720174146.GD16907@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=nathan.d.ciobanu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).