* [PATCH] drm/i915: Remove unused "ret" variable.
@ 2018-07-19 23:42 Rodrigo Vivi
2018-07-20 0:15 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Rodrigo Vivi @ 2018-07-19 23:42 UTC (permalink / raw)
To: intel-gfx; +Cc: Dhinakaran Pandiyan, Rodrigo Vivi
Just a small clean-up with no functional change, only
removing a variable that is never actually used.
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/i915/intel_dp_mst.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c
index 7e3e01607643..18c65f8e4fe8 100644
--- a/drivers/gpu/drm/i915/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/intel_dp_mst.c
@@ -263,7 +263,6 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder,
struct intel_dp *intel_dp = &intel_dig_port->dp;
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
enum port port = intel_dig_port->base.port;
- int ret;
DRM_DEBUG_KMS("active links %d\n", intel_dp->active_mst_links);
@@ -274,9 +273,9 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder,
1))
DRM_ERROR("Timed out waiting for ACT sent\n");
- ret = drm_dp_check_act_status(&intel_dp->mst_mgr);
+ drm_dp_check_act_status(&intel_dp->mst_mgr);
- ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr);
+ drm_dp_update_payload_part2(&intel_dp->mst_mgr);
if (pipe_config->has_audio)
intel_audio_codec_enable(encoder, pipe_config, conn_state);
}
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Remove unused "ret" variable.
2018-07-19 23:42 [PATCH] drm/i915: Remove unused "ret" variable Rodrigo Vivi
@ 2018-07-20 0:15 ` Patchwork
2018-07-20 0:16 ` [PATCH] " Nathan Ciobanu
2018-07-20 6:21 ` ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-07-20 0:15 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Remove unused "ret" variable.
URL : https://patchwork.freedesktop.org/series/46904/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4517 -> Patchwork_9724 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/46904/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_9724 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-reload:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106248, fdo#106725)
igt@drv_selftest@live_hangcheck:
fi-kbl-7560u: PASS -> DMESG-FAIL (fdo#106560, fdo#106947)
igt@drv_selftest@live_workarounds:
{fi-cfl-8109u}: PASS -> DMESG-FAIL (fdo#107292)
igt@prime_vgem@basic-fence-flip:
fi-cfl-8700k: PASS -> FAIL (fdo#104008)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
== Participating hosts (47 -> 42) ==
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4517 -> Patchwork_9724
CI_DRM_4517: 2a25e5014e7b215f4261b6479ac29dabc2633484 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4568: 86f7b724ef18986bc58d35558d22e1ed3f8df4f9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9724: bce0d6bfd4ecb9f51511f73330253159a967f023 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
bce0d6bfd4ec drm/i915: Remove unused "ret" variable.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9724/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: Remove unused "ret" variable.
2018-07-19 23:42 [PATCH] drm/i915: Remove unused "ret" variable Rodrigo Vivi
2018-07-20 0:15 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-07-20 0:16 ` Nathan Ciobanu
2018-07-20 0:56 ` Nathan Ciobanu
2018-07-20 6:21 ` ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Nathan Ciobanu @ 2018-07-20 0:16 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx, Dhinakaran Pandiyan
On Thu, Jul 19, 2018 at 04:42:17PM -0700, Rodrigo Vivi wrote:
> Just a small clean-up with no functional change, only
> removing a variable that is never actually used.
>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Nice one :)
Reviewed-by: <nathan.d.ciobanu@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp_mst.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c
> index 7e3e01607643..18c65f8e4fe8 100644
> --- a/drivers/gpu/drm/i915/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/intel_dp_mst.c
> @@ -263,7 +263,6 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder,
> struct intel_dp *intel_dp = &intel_dig_port->dp;
> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> enum port port = intel_dig_port->base.port;
> - int ret;
>
> DRM_DEBUG_KMS("active links %d\n", intel_dp->active_mst_links);
>
> @@ -274,9 +273,9 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder,
> 1))
> DRM_ERROR("Timed out waiting for ACT sent\n");
>
> - ret = drm_dp_check_act_status(&intel_dp->mst_mgr);
> + drm_dp_check_act_status(&intel_dp->mst_mgr);
>
> - ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr);
> + drm_dp_update_payload_part2(&intel_dp->mst_mgr);
> if (pipe_config->has_audio)
> intel_audio_codec_enable(encoder, pipe_config, conn_state);
> }
> --
> 2.17.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: Remove unused "ret" variable.
2018-07-20 0:16 ` [PATCH] " Nathan Ciobanu
@ 2018-07-20 0:56 ` Nathan Ciobanu
2018-07-20 17:41 ` Rodrigo Vivi
0 siblings, 1 reply; 6+ messages in thread
From: Nathan Ciobanu @ 2018-07-20 0:56 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx, Dhinakaran Pandiyan
On Thu, Jul 19, 2018 at 05:16:03PM -0700, Nathan Ciobanu wrote:
> On Thu, Jul 19, 2018 at 04:42:17PM -0700, Rodrigo Vivi wrote:
> > Just a small clean-up with no functional change, only
> > removing a variable that is never actually used.
> >
> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Nice one :)
> Reviewed-by: <nathan.d.ciobanu@linux.intel.com>
Reviewed-by: Nathan Ciobanu <nathan.d.ciobanu@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_dp_mst.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c
> > index 7e3e01607643..18c65f8e4fe8 100644
> > --- a/drivers/gpu/drm/i915/intel_dp_mst.c
> > +++ b/drivers/gpu/drm/i915/intel_dp_mst.c
> > @@ -263,7 +263,6 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder,
> > struct intel_dp *intel_dp = &intel_dig_port->dp;
> > struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> > enum port port = intel_dig_port->base.port;
> > - int ret;
> >
> > DRM_DEBUG_KMS("active links %d\n", intel_dp->active_mst_links);
> >
> > @@ -274,9 +273,9 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder,
> > 1))
> > DRM_ERROR("Timed out waiting for ACT sent\n");
> >
> > - ret = drm_dp_check_act_status(&intel_dp->mst_mgr);
> > + drm_dp_check_act_status(&intel_dp->mst_mgr);
> >
> > - ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr);
> > + drm_dp_update_payload_part2(&intel_dp->mst_mgr);
> > if (pipe_config->has_audio)
> > intel_audio_codec_enable(encoder, pipe_config, conn_state);
> > }
> > --
> > 2.17.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: Remove unused "ret" variable.
2018-07-20 0:56 ` Nathan Ciobanu
@ 2018-07-20 17:41 ` Rodrigo Vivi
0 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Vivi @ 2018-07-20 17:41 UTC (permalink / raw)
To: Nathan Ciobanu; +Cc: intel-gfx, Dhinakaran Pandiyan
On Thu, Jul 19, 2018 at 05:56:33PM -0700, Nathan Ciobanu wrote:
> On Thu, Jul 19, 2018 at 05:16:03PM -0700, Nathan Ciobanu wrote:
> > On Thu, Jul 19, 2018 at 04:42:17PM -0700, Rodrigo Vivi wrote:
> > > Just a small clean-up with no functional change, only
> > > removing a variable that is never actually used.
> > >
> > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Nice one :)
> > Reviewed-by: <nathan.d.ciobanu@linux.intel.com>
> Reviewed-by: Nathan Ciobanu <nathan.d.ciobanu@linux.intel.com>
Thanks, pushed.
> > > ---
> > > drivers/gpu/drm/i915/intel_dp_mst.c | 5 ++---
> > > 1 file changed, 2 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c
> > > index 7e3e01607643..18c65f8e4fe8 100644
> > > --- a/drivers/gpu/drm/i915/intel_dp_mst.c
> > > +++ b/drivers/gpu/drm/i915/intel_dp_mst.c
> > > @@ -263,7 +263,6 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder,
> > > struct intel_dp *intel_dp = &intel_dig_port->dp;
> > > struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> > > enum port port = intel_dig_port->base.port;
> > > - int ret;
> > >
> > > DRM_DEBUG_KMS("active links %d\n", intel_dp->active_mst_links);
> > >
> > > @@ -274,9 +273,9 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder,
> > > 1))
> > > DRM_ERROR("Timed out waiting for ACT sent\n");
> > >
> > > - ret = drm_dp_check_act_status(&intel_dp->mst_mgr);
> > > + drm_dp_check_act_status(&intel_dp->mst_mgr);
> > >
> > > - ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr);
> > > + drm_dp_update_payload_part2(&intel_dp->mst_mgr);
> > > if (pipe_config->has_audio)
> > > intel_audio_codec_enable(encoder, pipe_config, conn_state);
> > > }
> > > --
> > > 2.17.1
> > >
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Remove unused "ret" variable.
2018-07-19 23:42 [PATCH] drm/i915: Remove unused "ret" variable Rodrigo Vivi
2018-07-20 0:15 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-07-20 0:16 ` [PATCH] " Nathan Ciobanu
@ 2018-07-20 6:21 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-07-20 6:21 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Remove unused "ret" variable.
URL : https://patchwork.freedesktop.org/series/46904/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4517_full -> Patchwork_9724_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9724_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9724_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9724_full:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_schedule@deep-vebox:
shard-kbl: PASS -> SKIP +1
igt@pm_rc6_residency@rc6-accuracy:
shard-snb: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_9724_full that come from known issues:
=== IGT changes ===
==== Possible fixes ====
igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible:
shard-glk: FAIL (fdo#100368) -> PASS +1
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4517 -> Patchwork_9724
CI_DRM_4517: 2a25e5014e7b215f4261b6479ac29dabc2633484 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4568: 86f7b724ef18986bc58d35558d22e1ed3f8df4f9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9724: bce0d6bfd4ecb9f51511f73330253159a967f023 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9724/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-20 17:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-19 23:42 [PATCH] drm/i915: Remove unused "ret" variable Rodrigo Vivi
2018-07-20 0:15 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-07-20 0:16 ` [PATCH] " Nathan Ciobanu
2018-07-20 0:56 ` Nathan Ciobanu
2018-07-20 17:41 ` Rodrigo Vivi
2018-07-20 6:21 ` ✓ Fi.CI.IGT: success for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).