* [PATCH] drm/i915: Avoid computing tile_row_size() for untiled objects
@ 2018-07-26 10:47 Chris Wilson
2018-07-26 11:21 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-07-26 11:22 ` [PATCH] " Matthew Auld
0 siblings, 2 replies; 4+ messages in thread
From: Chris Wilson @ 2018-07-26 10:47 UTC (permalink / raw)
To: intel-gfx
i915_gem_tile_height() asserts that the object is tiled, but inside the
error printer for the selftest we computed the row size regardless of
tiling, tripping over the assert.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/selftests/i915_gem_object.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_object.c b/drivers/gpu/drm/i915/selftests/i915_gem_object.c
index c69cbd5aed52..d9eca1b02aee 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_object.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_object.c
@@ -282,7 +282,7 @@ static int check_partial_mapping(struct drm_i915_gem_object *obj,
view.partial.offset,
view.partial.size,
vma->size >> PAGE_SHIFT,
- tile_row_pages(obj),
+ tile->tiling ? tile_row_pages(obj) : 0,
vma->fence ? vma->fence->id : -1, tile->tiling, tile->stride,
offset >> PAGE_SHIFT,
(unsigned int)offset_in_page(offset),
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Avoid computing tile_row_size() for untiled objects
2018-07-26 10:47 [PATCH] drm/i915: Avoid computing tile_row_size() for untiled objects Chris Wilson
@ 2018-07-26 11:21 ` Patchwork
2018-07-26 11:22 ` [PATCH] " Matthew Auld
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-07-26 11:21 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Avoid computing tile_row_size() for untiled objects
URL : https://patchwork.freedesktop.org/series/47279/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4548 -> Patchwork_9780 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_9780 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9780, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47279/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9780:
=== IGT changes ===
==== Possible regressions ====
igt@drv_selftest@live_evict:
fi-cnl-psr: SKIP -> DMESG-WARN +8
== Known issues ==
Here are the changes found in Patchwork_9780 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
fi-skl-6260u: PASS -> DMESG-FAIL (fdo#107174, fdo#106560)
fi-kbl-7567u: PASS -> DMESG-FAIL (fdo#106947, fdo#106560)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-bxt-dsi: PASS -> INCOMPLETE (fdo#103927)
==== Warnings ====
igt@drv_selftest@live_workarounds:
fi-cnl-psr: DMESG-WARN (fdo#105395) -> DMESG-FAIL (fdo#107292)
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105395 https://bugs.freedesktop.org/show_bug.cgi?id=105395
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
== Participating hosts (51 -> 40) ==
Missing (11): fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-hsw-4770 fi-skl-iommu fi-icl-u fi-byt-clapper fi-bdw-samus
== Build changes ==
* Linux: CI_DRM_4548 -> Patchwork_9780
CI_DRM_4548: 1ccdb8d0bf55621006a4ac04e8e5e964480382ef @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4576: bcb37a9b20eeec97f15fac2222408cc2e0b77631 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9780: dca35f46500a7a440bdcb95da46495192ff9e5d3 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
dca35f46500a drm/i915: Avoid computing tile_row_size() for untiled objects
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9780/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915: Avoid computing tile_row_size() for untiled objects
2018-07-26 10:47 [PATCH] drm/i915: Avoid computing tile_row_size() for untiled objects Chris Wilson
2018-07-26 11:21 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-07-26 11:22 ` Matthew Auld
2018-07-26 11:31 ` Chris Wilson
1 sibling, 1 reply; 4+ messages in thread
From: Matthew Auld @ 2018-07-26 11:22 UTC (permalink / raw)
To: Chris Wilson; +Cc: Intel Graphics Development
On 26 July 2018 at 11:47, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> i915_gem_tile_height() asserts that the object is tiled, but inside the
> error printer for the selftest we computed the row size regardless of
> tiling, tripping over the assert.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: Avoid computing tile_row_size() for untiled objects
2018-07-26 11:22 ` [PATCH] " Matthew Auld
@ 2018-07-26 11:31 ` Chris Wilson
0 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2018-07-26 11:31 UTC (permalink / raw)
To: Matthew Auld; +Cc: Intel Graphics Development
Quoting Matthew Auld (2018-07-26 12:22:52)
> On 26 July 2018 at 11:47, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > i915_gem_tile_height() asserts that the object is tiled, but inside the
> > error printer for the selftest we computed the row size regardless of
> > tiling, tripping over the assert.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Ta, onto the real problem that the GTT write didn't land. :|
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-26 11:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-26 10:47 [PATCH] drm/i915: Avoid computing tile_row_size() for untiled objects Chris Wilson
2018-07-26 11:21 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-07-26 11:22 ` [PATCH] " Matthew Auld
2018-07-26 11:31 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).