From: "Jakub Bartmiński" <jakub.bartminski@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v6 2/6] drm/i915/guc: Do not partition WOPCM if GuC is not used.
Date: Fri, 27 Jul 2018 10:53:46 +0200 [thread overview]
Message-ID: <20180727085350.321-2-jakub.bartminski@intel.com> (raw)
In-Reply-To: <20180727085350.321-1-jakub.bartminski@intel.com>
There seems to be no reason for doing extra work on WOPCM partitioning
in the case GuC is not used, as the partitioning will not be used by the
intel_wopcm_init_hw function anyway.
Signed-off-by: Jakub Bartmiński <jakub.bartminski@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Michał Winiarski <michal.winiarski@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
drivers/gpu/drm/i915/intel_wopcm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_wopcm.c b/drivers/gpu/drm/i915/intel_wopcm.c
index 74bf76f3fddc..09cc62b0d7ca 100644
--- a/drivers/gpu/drm/i915/intel_wopcm.c
+++ b/drivers/gpu/drm/i915/intel_wopcm.c
@@ -163,6 +163,9 @@ int intel_wopcm_init(struct intel_wopcm *wopcm)
u32 guc_wopcm_rsvd;
int err;
+ if (!USES_GUC(dev_priv))
+ return 0;
+
GEM_BUG_ON(!wopcm->size);
if (guc_fw_size >= wopcm->size) {
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-07-27 8:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 8:53 [PATCH v6 1/6] drm/i915/guc: Avoid wasting memory on incorrect GuC pin bias Jakub Bartmiński
2018-07-27 8:53 ` Jakub Bartmiński [this message]
2018-07-27 10:20 ` [PATCH v6 2/6] drm/i915/guc: Do not partition WOPCM if GuC is not used Chris Wilson
2018-07-27 12:04 ` Michal Wajdeczko
2018-07-27 8:53 ` [PATCH v6 3/6] drm/i915/guc: Move the pin bias value from GuC to GGTT Jakub Bartmiński
2018-07-27 10:29 ` Chris Wilson
2018-07-27 12:03 ` Michal Wajdeczko
2018-07-27 12:07 ` Chris Wilson
2018-07-27 8:53 ` [PATCH v6 4/6] drm/i915: Remove unnecessary ggtt_offset_bias from i915_gem_context Jakub Bartmiński
2018-07-27 10:30 ` Chris Wilson
2018-07-27 8:53 ` [PATCH v6 5/6] drm/i915: Add a fault injection point to WOPCM init Jakub Bartmiński
2018-07-27 12:06 ` Michal Wajdeczko
2018-07-27 8:53 ` [PATCH v6 6/6] HAX enable GuC for CI Jakub Bartmiński
2018-07-27 9:16 ` ✗ Fi.CI.SPARSE: warning for series starting with [v6,1/6] drm/i915/guc: Avoid wasting memory on incorrect GuC pin bias Patchwork
2018-07-27 9:35 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-07-27 9:51 ` Chris Wilson
2018-07-27 10:32 ` Bartminski, Jakub
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727085350.321-2-jakub.bartminski@intel.com \
--to=jakub.bartminski@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).