* [PATCH] drm/i915: Kick waiters on resetting legacy rings
@ 2018-07-27 18:08 Chris Wilson
2018-07-27 19:06 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2018-07-27 18:08 UTC (permalink / raw)
To: intel-gfx
For reasons unknown, interrupts following a reset do not arrive, but
this can be papered over by kicking any waiter and peeking at the
breadcrumbs following the reset.
Testcase: igt/gem_eio/reset-stress
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index d1e03b7fbffa..c03f4fa4f350 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -527,6 +527,7 @@ static int init_ring_common(struct intel_engine_cs *engine)
if (INTEL_GEN(dev_priv) > 2)
I915_WRITE_MODE(engine, _MASKED_BIT_DISABLE(STOP_RING));
+ intel_engine_wakeup(engine);
out:
intel_uncore_forcewake_put(dev_priv, FORCEWAKE_ALL);
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Kick waiters on resetting legacy rings
2018-07-27 18:08 [PATCH] drm/i915: Kick waiters on resetting legacy rings Chris Wilson
@ 2018-07-27 19:06 ` Patchwork
2018-07-27 22:37 ` ✓ Fi.CI.IGT: " Patchwork
2018-07-29 5:31 ` [PATCH] " Chris Wilson
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-07-27 19:06 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Kick waiters on resetting legacy rings
URL : https://patchwork.freedesktop.org/series/47362/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4565 -> Patchwork_9794 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47362/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_9794 that come from known issues:
=== IGT changes ===
==== Possible fixes ====
igt@drv_selftest@live_coherency:
{fi-icl-u}: DMESG-FAIL (fdo#107400) -> PASS
igt@gem_exec_suspend@basic-s4-devices:
fi-kbl-7500u: DMESG-WARN (fdo#107139, fdo#105128) -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: DMESG-FAIL (fdo#106103, fdo#102614) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
{fi-cfl-8109u}: INCOMPLETE (fdo#106070) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-bxt-dsi: INCOMPLETE (fdo#103927) -> PASS
{igt@kms_psr@primary_mmap_gtt}:
fi-cnl-psr: DMESG-WARN (fdo#107372) -> PASS
==== Warnings ====
igt@drv_selftest@live_workarounds:
fi-cnl-psr: DMESG-FAIL (fdo#107292) -> DMESG-WARN (fdo#105395)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#105395 https://bugs.freedesktop.org/show_bug.cgi?id=105395
fdo#106070 https://bugs.freedesktop.org/show_bug.cgi?id=106070
fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
fdo#107400 https://bugs.freedesktop.org/show_bug.cgi?id=107400
== Participating hosts (53 -> 46) ==
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-glk-j4005 fi-byt-clapper
== Build changes ==
* Linux: CI_DRM_4565 -> Patchwork_9794
CI_DRM_4565: 37c9f83ad5b98201ea74a38b0efc096bc29f1956 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4580: f1c868dae24056ebc27e4f3c197724ce9b956a8a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9794: ebda88d2d40f36cab9b0367ea3a05a797090aa31 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
ebda88d2d40f drm/i915: Kick waiters on resetting legacy rings
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9794/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Kick waiters on resetting legacy rings
2018-07-27 18:08 [PATCH] drm/i915: Kick waiters on resetting legacy rings Chris Wilson
2018-07-27 19:06 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-07-27 22:37 ` Patchwork
2018-07-29 5:31 ` [PATCH] " Chris Wilson
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-07-27 22:37 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Kick waiters on resetting legacy rings
URL : https://patchwork.freedesktop.org/series/47362/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4565_full -> Patchwork_9794_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_9794_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_flip@plain-flip-fb-recreate-interruptible:
shard-glk: PASS -> FAIL (fdo#100368)
==== Possible fixes ====
igt@kms_flip@2x-plain-flip-fb-recreate:
shard-glk: FAIL (fdo#100368) -> PASS
igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
shard-hsw: FAIL (fdo#100368) -> PASS
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#102887, fdo#105363) -> PASS
igt@kms_setmode@basic:
shard-kbl: FAIL (fdo#99912) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4565 -> Patchwork_9794
CI_DRM_4565: 37c9f83ad5b98201ea74a38b0efc096bc29f1956 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4580: f1c868dae24056ebc27e4f3c197724ce9b956a8a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9794: ebda88d2d40f36cab9b0367ea3a05a797090aa31 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9794/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: Kick waiters on resetting legacy rings
2018-07-27 18:08 [PATCH] drm/i915: Kick waiters on resetting legacy rings Chris Wilson
2018-07-27 19:06 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-07-27 22:37 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-07-29 5:31 ` Chris Wilson
2 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2018-07-29 5:31 UTC (permalink / raw)
To: intel-gfx
Quoting Chris Wilson (2018-07-27 19:08:41)
> For reasons unknown, interrupts following a reset do not arrive, but
> this can be papered over by kicking any waiter and peeking at the
> breadcrumbs following the reset.
>
> Testcase: igt/gem_eio/reset-stress
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Hmm, it probably explains
References: https://bugs.freedesktop.org/show_bug.cgi?id=105957
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-29 5:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-27 18:08 [PATCH] drm/i915: Kick waiters on resetting legacy rings Chris Wilson
2018-07-27 19:06 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-07-27 22:37 ` ✓ Fi.CI.IGT: " Patchwork
2018-07-29 5:31 ` [PATCH] " Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).