intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Introduce intel_runtime_pm_disable to pair intel_runtime_pm_enable
Date: Thu, 09 Aug 2018 09:50:18 -0000	[thread overview]
Message-ID: <20180809095018.3701.23037@emeril.freedesktop.org> (raw)
In-Reply-To: <20180809091635.14976-1-chris@chris-wilson.co.uk>

== Series Details ==

Series: series starting with [1/2] drm/i915: Introduce intel_runtime_pm_disable to pair intel_runtime_pm_enable
URL   : https://patchwork.freedesktop.org/series/47934/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
1787a18142d6 drm/i915: Introduce intel_runtime_pm_disable to pair intel_runtime_pm_enable
5d4072eab971 drm/i915: Track all held rpm wakerefs
-:76: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#76: FILE: drivers/gpu/drm/i915/i915_drv.h:1284:
+	spinlock_t debug_lock;

-:158: ERROR:CODE_INDENT: code indent should use tabs where possible
#158: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:107:
+        const depot_stack_handle_t * const a = _a, * const b = _b;$

-:158: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#158: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:107:
+        const depot_stack_handle_t * const a = _a, * const b = _b;$

-:160: ERROR:CODE_INDENT: code indent should use tabs where possible
#160: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:109:
+        if (*a < *b)$

-:160: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#160: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:109:
+        if (*a < *b)$

-:161: ERROR:CODE_INDENT: code indent should use tabs where possible
#161: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:110:
+                return -1;$

-:161: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#161: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:110:
+                return -1;$

-:162: ERROR:CODE_INDENT: code indent should use tabs where possible
#162: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:111:
+        else if (*a > *b)$

-:162: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#162: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:111:
+        else if (*a > *b)$

-:163: ERROR:CODE_INDENT: code indent should use tabs where possible
#163: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:112:
+                return 1;$

-:163: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#163: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:112:
+                return 1;$

-:164: ERROR:CODE_INDENT: code indent should use tabs where possible
#164: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:113:
+        else$

-:164: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#164: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:113:
+        else$

-:165: ERROR:CODE_INDENT: code indent should use tabs where possible
#165: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:114:
+                return 0;$

-:165: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#165: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:114:
+                return 0;$

total: 7 errors, 7 warnings, 1 checks, 236 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-08-09  9:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09  9:16 [PATCH 1/2] drm/i915: Introduce intel_runtime_pm_disable to pair intel_runtime_pm_enable Chris Wilson
2018-08-09  9:16 ` [PATCH 2/2] drm/i915: Track all held rpm wakerefs Chris Wilson
2018-08-09  9:50 ` Patchwork [this message]
2018-08-09  9:51 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Introduce intel_runtime_pm_disable to pair intel_runtime_pm_enable Patchwork
2018-08-09 10:09 ` ✗ Fi.CI.BAT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2018-08-16 12:37 [PATCH 1/2] " Imre Deak
2018-08-16 13:22 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180809095018.3701.23037@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).