✗ Fi.CI.CHECKPATCH: warning for series starting with [01/14] drm/i915: Cleanup gt powerstate from gem

[Patchwork <patchwork@emeril.freedesktop.org>]

== Series Details ==

Series: series starting with [01/14] drm/i915: Cleanup gt powerstate from gem
URL   : https://patchwork.freedesktop.org/series/48093/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
9997a35e7674 drm/i915: Cleanup gt powerstate from gem
acc6293cb5d5 drm/i915: Restrict gen6_reset_rps_interrupts to gen6+
1d2fa57b3ec5 drm/i915: Disable runtime-pm using lowlevel functions if !HAS_RC6
6b20ec96218e drm/i915: Only skip connector output for disable_display
bfdceb7f54df drm/i915: Explicitly take the init-power domain
3d00e01e5d4c drm/i915: Attach the pci match data to the device upon creation
-:83: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#83: FILE: drivers/gpu/drm/i915/i915_drv.c:1348:
+	BUG_ON(device_info->gen > sizeof(device_info->gen_mask) * BITS_PER_BYTE);

total: 0 errors, 1 warnings, 0 checks, 113 lines checked
d2118bcd8b3b drm/i915: Introduce intel_runtime_pm_disable to pair intel_runtime_pm_enable
e3aa0f6d1e45 drm/i915: Track all held rpm wakerefs
-:104: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#104: FILE: drivers/gpu/drm/i915/i915_drv.h:1293:
+	spinlock_t debug_lock;

total: 0 errors, 0 warnings, 1 checks, 502 lines checked
b202a395ff99 drm/i915: Markup paired operations on wakerefs
-:757: WARNING:NEW_TYPEDEFS: do not add new typedefs
#757: FILE: drivers/gpu/drm/i915/i915_drv.h:130:
+typedef depot_stack_handle_t intel_wakeref_t;

total: 0 errors, 1 warnings, 0 checks, 1922 lines checked
937a00ac7a78 drm/i915: Syntatic sugar for using intel_runtime_pm
-:491: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#491: FILE: drivers/gpu/drm/i915/intel_drv.h:2042:
+#define with_intel_runtime_pm(i915, wf) \
+	for (wf = intel_runtime_pm_get(i915); wf; \
+	     intel_runtime_pm_put(i915, wf), wf = 0)

-:491: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects?
#491: FILE: drivers/gpu/drm/i915/intel_drv.h:2042:
+#define with_intel_runtime_pm(i915, wf) \
+	for (wf = intel_runtime_pm_get(i915); wf; \
+	     intel_runtime_pm_put(i915, wf), wf = 0)

-:495: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#495: FILE: drivers/gpu/drm/i915/intel_drv.h:2046:
+#define with_intel_runtime_pm_if_in_use(i915, wf) \
+	for (wf = intel_runtime_pm_get_if_in_use(i915); wf; \
+	     intel_runtime_pm_put(i915, wf), wf = 0)

-:495: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects?
#495: FILE: drivers/gpu/drm/i915/intel_drv.h:2046:
+#define with_intel_runtime_pm_if_in_use(i915, wf) \
+	for (wf = intel_runtime_pm_get_if_in_use(i915); wf; \
+	     intel_runtime_pm_put(i915, wf), wf = 0)

total: 0 errors, 0 warnings, 4 checks, 569 lines checked
9c0468e4672a drm/i915: Markup paired operations on display power domains
-:31: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#31: FILE: drivers/gpu/drm/i915/i915_debugfs.c:663:
+		wakeref = intel_display_power_get_if_enabled(dev_priv,
+							power_domain);

total: 0 errors, 0 warnings, 1 checks, 1415 lines checked
bc516106cbbb drm/i915/dp: Markup pps lock power well
-:49: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dp' - possible side-effects?
#49: FILE: drivers/gpu/drm/i915/intel_dp.c:687:
+#define with_pps_lock(dp, wf) \
+	for (wf = pps_lock(dp); wf; pps_unlock(dp, wf), wf = 0)

-:49: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects?
#49: FILE: drivers/gpu/drm/i915/intel_dp.c:687:
+#define with_pps_lock(dp, wf) \
+	for (wf = pps_lock(dp); wf; pps_unlock(dp, wf), wf = 0)

total: 0 errors, 0 warnings, 2 checks, 427 lines checked
affe81034653 drm/i915: Complain if hsw_get_pipe_config acquires the same power well twice
bf82fed0ccf0 drm/i915: Enable runtime-pm debugging by default for CI

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx